str:\n@@ -93,8 +96,8 @@ def get_gpu_name(family: str) -> str:\n 'standardNCSv3Family': 'V100',\n 'standardNCPromoFamily': 'K80',\n 'StandardNCASv3_T4Family': 'T4',\n- 'standardNDSv2Family': 'P40',\n- 'standardNDAMSv4_A100Family': 'A100',\n+ 'standardNDSv2Family': 'V100-32GB',\n+ 'standardNDAMSv4_A100Family': 'A100-80GB',\n 'StandardNDASv4_A100Family': 'A100',\n 'standardNVFamily': 'M60',\n 'standardNVSv2Family': 'M60',\n@@ -169,6 +172,8 @@ def get_additional_columns(row):\n [df_sku, df_sku.apply(get_additional_columns, axis='columns')],\n axis='columns',\n ).rename(columns={'name': 'InstanceType'})\n+ # Filter out deprecated families\n+ df_ret = df_ret.loc[~df_ret['family'].isin(DEPRECATED_FAMILIES)]\n return df_ret\n \n \ndiff --git a/sky/optimizer.py b/sky/optimizer.py\nindex 57d5ca0a8da..9c126f7c610 100644\n--- a/sky/optimizer.py\n+++ b/sky/optimizer.py\n@@ -208,7 +208,9 @@ def _optimize_cost(\n if not launchable_list:\n raise exceptions.ResourcesUnavailableError(\n f'No launchable resource found for task {node}. '\n- 'To fix: relax its resource requirements.')\n+ 'To fix: relax its resource requirements.\\n'\n+ 'Hint: \\'sky show-gpus --all\\' '\n+ 'to list available accelerators.')\n if num_resources == 1 and node.time_estimator_func is None:\n logger.info('Defaulting estimated time to 1 hr. '\n 'Call Task.set_time_estimator() to override.')\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 3,\n \"problem_domain\": \"Bug Fixes\"\n}"}}},{"rowIdx":7074,"cells":{"instance_id":{"kind":"string","value":"skypilot-org__skypilot-235@0bb5938"},"repo":{"kind":"string","value":"skypilot-org/skypilot"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":235,"string":"235"},"title":{"kind":"string","value":"Fix defunct job after cancelling"},"body":{"kind":"string","value":"We are currently using `subprocess` to run the command line. The child process may be defunct when the python program is killed. Fixed by creating a subprocess to kill the defuncted child process with `try ... finally`. Fixed #233 \r\n\r\nTested:\r\n1. Launch a cluster with `sky launch -c test ./examples/job_queue/cluster.yaml`\r\n2. Run a GPU program `sky exec -c test ./examples/job_queue/job_gpu.yaml`\r\n3. Check the gpustat `sky exec -c test gpustat`\r\n3. Cancel the job `sky cancel -c test 1`\r\n4. Check the gpustat again `sky exec -c test gpustat -cpu -i 1`\r\n\r\nBefore the fix, the gpu will remain occupied after canceling. After the fix, the problem is solved."},"created_at":{"kind":"string","value":"2022-01-22T23:04:46Z"},"problem_statement":{"kind":"string","value":"Failed to kill a sky job with sky cancel\nI failed to cancel my job with `sky cancel`. I had to manually ssh in and kill it.\r\n@Michaelvll have you met this issue before?\r\n```\r\n(sky) weichiang@blaze:~/repos/bert-sign/sky-experiments/prototype/examples$ sky cancel -c sky-2920-weichiang 9\r\nCancelling jobs (9) on cluster sky-2920-weichiang...\r\n(sky) weichiang@blaze:~/repos/bert-sign/sky-experiments/prototype/examples$ sky queue sky-2920-weichiang\r\nFetching and parsing job queue...\r\n\r\nSky Job Queue of Cluster sky-2920-weichiang\r\nID NAME USER SUBMITTED STATUS LOG\r\n9 bert_sign weichiang 9 mins ago CANCELLED sky_logs/sky-2022-01-22-00-35-33-025250\r\n8 bert_sign weichiang 4 hrs ago FAILED sky_logs/sky-2022-01-21-20-18-28-505572\r\n7 bert_sign weichiang 8 hrs ago FAILED sky_logs/sky-2022-01-21-16-21-57-228872\r\n6 <cmd> weichiang 8 hrs ago FAILED sky_logs/sky-2022-01-21-16-01-15-015994\r\n5 bert_sign weichiang 8 hrs ago FAILED sky_logs/sky-2022-01-21-15-51-10-260086\r\n4 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-42-01-661227\r\n3 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-40-42-390030\r\n2 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-37-32-004498\r\n1 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-32-41-239102\r\n```\r\nOn the VM. the job on GPU-1 (submitted by Sky) is still running.\r\n```\r\n(flax) ubuntu@ip-172-31-14-71:~/tensorflow_datasets/lm1b$ gpustat\r\nip-172-31-14-71 Sat Jan 22 08:51:30 2022 450.142.00\r\n[0] Tesla V100-SXM2-16GB | 49°C, 3 % | 15180 / 16160 MB | ubuntu(15177M)\r\n[1] Tesla V100-SXM2-16GB | 63°C, 100 % | 16022 / 16160 MB | ubuntu(16011M)\r\n[2] Tesla V100-SXM2-16GB | 39°C, 0 % | 0 / 16160 MB |\r\n[3] Tesla V100-SXM2-16GB | 42°C, 0 % | 0 / 16160 MB |\r\n[4] Tesla V100-SXM2-16GB | 41°C, 0 % | 0 / 16160 MB |\r\n[5] Tesla V100-SXM2-16GB | 42°C, 0 % | 0 / 16160 MB |\r\n[6] Tesla V100-SXM2-16GB | 40°C, 0 % | 0 / 16160 MB |\r\n[7] Tesla V100-SXM2-16GB | 41°C, 0 % | 0 / 16160 MB |\r\n```\r\n```\r\n106906 ubuntu 20 0 4648 836 760 S 0.0 0.0 0:00.00 ├─ /bin/sh -c /bin/bash /tmp/sky_app_kabqgmyi\r\n106913 ubuntu 20 0 13444 3532 3104 S 0.0 0.0 0:00.00 │ └─ /bin/bash /tmp/sky_app_kabqgmyi \r\n106935 ubuntu 20 0 66.4G 40.6G 5192M S 0.0 8.4 13:10.59 │ └─ python main.py --configs configs/products/bert-finetune/sbert-large-tmp2-mixup-deep.yml --data_root /home/ubuntu/dataset/\r\n```"},"hints_text":{"kind":"string","value":"Yeah, that happens to me sometimes. Is it possible to create a small reproduction code? I suspect it is caused by the ray's stale actors."},"resolved_issues":{"kind":"list like","value":[{"body":"I failed to cancel my job with `sky cancel`. I had to manually ssh in and kill it.\r\n@Michaelvll have you met this issue before?\r\n```\r\n(sky) weichiang@blaze:~/repos/bert-sign/sky-experiments/prototype/examples$ sky cancel -c sky-2920-weichiang 9\r\nCancelling jobs (9) on cluster sky-2920-weichiang...\r\n(sky) weichiang@blaze:~/repos/bert-sign/sky-experiments/prototype/examples$ sky queue sky-2920-weichiang\r\nFetching and parsing job queue...\r\n\r\nSky Job Queue of Cluster sky-2920-weichiang\r\nID NAME USER SUBMITTED STATUS LOG\r\n9 bert_sign weichiang 9 mins ago CANCELLED sky_logs/sky-2022-01-22-00-35-33-025250\r\n8 bert_sign weichiang 4 hrs ago FAILED sky_logs/sky-2022-01-21-20-18-28-505572\r\n7 bert_sign weichiang 8 hrs ago FAILED sky_logs/sky-2022-01-21-16-21-57-228872\r\n6 <cmd> weichiang 8 hrs ago FAILED sky_logs/sky-2022-01-21-16-01-15-015994\r\n5 bert_sign weichiang 8 hrs ago FAILED sky_logs/sky-2022-01-21-15-51-10-260086\r\n4 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-42-01-661227\r\n3 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-40-42-390030\r\n2 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-37-32-004498\r\n1 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-32-41-239102\r\n```\r\nOn the VM. the job on GPU-1 (submitted by Sky) is still running.\r\n```\r\n(flax) ubuntu@ip-172-31-14-71:~/tensorflow_datasets/lm1b$ gpustat\r\nip-172-31-14-71 Sat Jan 22 08:51:30 2022 450.142.00\r\n[0] Tesla V100-SXM2-16GB | 49°C, 3 % | 15180 / 16160 MB | ubuntu(15177M)\r\n[1] Tesla V100-SXM2-16GB | 63°C, 100 % | 16022 / 16160 MB | ubuntu(16011M)\r\n[2] Tesla V100-SXM2-16GB | 39°C, 0 % | 0 / 16160 MB |\r\n[3] Tesla V100-SXM2-16GB | 42°C, 0 % | 0 / 16160 MB |\r\n[4] Tesla V100-SXM2-16GB | 41°C, 0 % | 0 / 16160 MB |\r\n[5] Tesla V100-SXM2-16GB | 42°C, 0 % | 0 / 16160 MB |\r\n[6] Tesla V100-SXM2-16GB | 40°C, 0 % | 0 / 16160 MB |\r\n[7] Tesla V100-SXM2-16GB | 41°C, 0 % | 0 / 16160 MB |\r\n```\r\n```\r\n106906 ubuntu 20 0 4648 836 760 S 0.0 0.0 0:00.00 ├─ /bin/sh -c /bin/bash /tmp/sky_app_kabqgmyi\r\n106913 ubuntu 20 0 13444 3532 3104 S 0.0 0.0 0:00.00 │ └─ /bin/bash /tmp/sky_app_kabqgmyi \r\n106935 ubuntu 20 0 66.4G 40.6G 5192M S 0.0 8.4 13:10.59 │ └─ python main.py --configs configs/products/bert-finetune/sbert-large-tmp2-mixup-deep.yml --data_root /home/ubuntu/dataset/\r\n```","number":233,"title":"Failed to kill a sky job with sky cancel"}],"string":"[\n {\n \"body\": \"I failed to cancel my job with `sky cancel`. I had to manually ssh in and kill it.\\r\\n@Michaelvll have you met this issue before?\\r\\n```\\r\\n(sky) weichiang@blaze:~/repos/bert-sign/sky-experiments/prototype/examples$ sky cancel -c sky-2920-weichiang 9\\r\\nCancelling jobs (9) on cluster sky-2920-weichiang...\\r\\n(sky) weichiang@blaze:~/repos/bert-sign/sky-experiments/prototype/examples$ sky queue sky-2920-weichiang\\r\\nFetching and parsing job queue...\\r\\n\\r\\nSky Job Queue of Cluster sky-2920-weichiang\\r\\nID NAME USER SUBMITTED STATUS LOG\\r\\n9 bert_sign weichiang 9 mins ago CANCELLED sky_logs/sky-2022-01-22-00-35-33-025250\\r\\n8 bert_sign weichiang 4 hrs ago FAILED sky_logs/sky-2022-01-21-20-18-28-505572\\r\\n7 bert_sign weichiang 8 hrs ago FAILED sky_logs/sky-2022-01-21-16-21-57-228872\\r\\n6 <cmd> weichiang 8 hrs ago FAILED sky_logs/sky-2022-01-21-16-01-15-015994\\r\\n5 bert_sign weichiang 8 hrs ago FAILED sky_logs/sky-2022-01-21-15-51-10-260086\\r\\n4 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-42-01-661227\\r\\n3 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-40-42-390030\\r\\n2 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-37-32-004498\\r\\n1 bert_sign weichiang 9 hrs ago FAILED sky_logs/sky-2022-01-21-15-32-41-239102\\r\\n```\\r\\nOn the VM. the job on GPU-1 (submitted by Sky) is still running.\\r\\n```\\r\\n(flax) ubuntu@ip-172-31-14-71:~/tensorflow_datasets/lm1b$ gpustat\\r\\nip-172-31-14-71 Sat Jan 22 08:51:30 2022 450.142.00\\r\\n[0] Tesla V100-SXM2-16GB | 49°C, 3 % | 15180 / 16160 MB | ubuntu(15177M)\\r\\n[1] Tesla V100-SXM2-16GB | 63°C, 100 % | 16022 / 16160 MB | ubuntu(16011M)\\r\\n[2] Tesla V100-SXM2-16GB | 39°C, 0 % | 0 / 16160 MB |\\r\\n[3] Tesla V100-SXM2-16GB | 42°C, 0 % | 0 / 16160 MB |\\r\\n[4] Tesla V100-SXM2-16GB | 41°C, 0 % | 0 / 16160 MB |\\r\\n[5] Tesla V100-SXM2-16GB | 42°C, 0 % | 0 / 16160 MB |\\r\\n[6] Tesla V100-SXM2-16GB | 40°C, 0 % | 0 / 16160 MB |\\r\\n[7] Tesla V100-SXM2-16GB | 41°C, 0 % | 0 / 16160 MB |\\r\\n```\\r\\n```\\r\\n106906 ubuntu 20 0 4648 836 760 S 0.0 0.0 0:00.00 ├─ /bin/sh -c /bin/bash /tmp/sky_app_kabqgmyi\\r\\n106913 ubuntu 20 0 13444 3532 3104 S 0.0 0.0 0:00.00 │ └─ /bin/bash /tmp/sky_app_kabqgmyi \\r\\n106935 ubuntu 20 0 66.4G 40.6G 5192M S 0.0 8.4 13:10.59 │ └─ python main.py --configs configs/products/bert-finetune/sbert-large-tmp2-mixup-deep.yml --data_root /home/ubuntu/dataset/\\r\\n```\",\n \"number\": 233,\n \"title\": \"Failed to kill a sky job with sky cancel\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"95a90955f9c8bf6deae1520e208a350caa1f2b0f"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"0bb5938b22cfcfee6cbe904519ccf1aa8f1a6a07\",\n \"head_commit_message\": \"Change comment\",\n \"patch_to_review\": \"diff --git a/prototype/examples/job_queue/job_gpu.yaml b/prototype/examples/job_queue/job_gpu.yaml\\nnew file mode 100644\\nindex 00000000000..985847b68cd\\n--- /dev/null\\n+++ b/prototype/examples/job_queue/job_gpu.yaml\\n@@ -0,0 +1,28 @@\\n+# A task submitted to an existing cluster.\\n+#\\n+# Runs a task on a existing cluster.\\n+#\\n+# Usage:\\n+# sky launch -c jq cluster.yaml\\n+# sky exec -c jq job.yaml\\n+\\n+name: job\\n+\\n+resources:\\n+ accelerators:\\n+ K80: 0.5\\n+\\n+# setup: |\\n+# conda create -n test python=3.7 -y\\n+# conda activate test\\n+# conda install pytorch torchvision torchaudio cudatoolkit=10.2 -c pytorch\\n+\\n+\\n+\\n+run: |\\n+ timestamp=$(date +%s)\\n+ conda activate test\\n+ echo \\\"started\\\"\\n+ python -u -c \\\"import torch; a = torch.randn(10000, 10000).cuda(); b = torch.randn(10000, 10000).cuda(); [print((a @ b).sum()) for _ in range(10000000000)]\\\"\\n+ echo \\\"ended\\\"\\n+\\ndiff --git a/prototype/sky/skylet/log_lib.py b/prototype/sky/skylet/log_lib.py\\nindex 1ec60227673..2de096b5761 100644\\n--- a/prototype/sky/skylet/log_lib.py\\n+++ b/prototype/sky/skylet/log_lib.py\\n@@ -76,18 +76,35 @@ def run_with_log(\\n Retruns the process, stdout and stderr of the command.\\n Note that the stdout and stderr is already decoded.\\n \\\"\\\"\\\"\\n- with subprocess.Popen(cmd,\\n- stdout=subprocess.PIPE,\\n- stderr=subprocess.PIPE,\\n- **kwargs) as proc:\\n- stdout, stderr = redirect_process_output(\\n- proc, log_path, stream_logs, start_streaming_at=start_streaming_at)\\n- proc.wait()\\n- if proc.returncode != 0 and check:\\n- raise RuntimeError('Command failed, please check the logs.')\\n- if return_none:\\n- return None\\n- return proc, stdout, stderr\\n+ try:\\n+ with subprocess.Popen(cmd,\\n+ stdout=subprocess.PIPE,\\n+ stderr=subprocess.PIPE,\\n+ start_new_session=True,\\n+ **kwargs) as proc:\\n+ proc_pid = os.getpgid(proc.pid)\\n+ stdout, stderr = redirect_process_output(\\n+ proc,\\n+ log_path,\\n+ stream_logs,\\n+ start_streaming_at=start_streaming_at)\\n+ proc.wait()\\n+ if proc.returncode != 0 and check:\\n+ raise RuntimeError('Command failed, please check the logs.')\\n+ if return_none:\\n+ return None\\n+ return proc, stdout, stderr\\n+ finally:\\n+ # The proc can be defunct if the python program is killed. Here we\\n+ # open a new subprocess to kill the process, SIGKILL the process group.\\n+ # Adapted from ray/dashboard/modules/job/job_manager.py#L154\\n+ subprocess.Popen(\\n+ f'kill -9 -{proc_pid}',\\n+ shell=True,\\n+ # Suppress output\\n+ stdout=subprocess.DEVNULL,\\n+ stderr=subprocess.DEVNULL,\\n+ )\\n \\n \\n def run_bash_command_with_log(bash_command: str,\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -76,18 +76,35 @@ def run_with_log(\n Retruns the process, stdout and stderr of the command.\n Note that the stdout and stderr is already decoded.\n \"\"\"\n- with subprocess.Popen(cmd,\n- stdout=subprocess.PIPE,\n- stderr=subprocess.PIPE,\n- **kwargs) as proc:\n- stdout, stderr = redirect_process_output(\n- proc, log_path, stream_logs, start_streaming_at=start_streaming_at)\n- proc.wait()\n- if proc.returncode != 0 and check:\n- raise RuntimeError('Command failed, please check the logs.')\n- if return_none:\n- return None\n- return proc, stdout, stderr\n+ try:\n+ with subprocess.Popen(cmd,\n+ stdout=subprocess.PIPE,\n+ stderr=subprocess.PIPE,\n+ start_new_session=True,\n+ **kwargs) as proc:\n+ proc_pid = os.getpgid(proc.pid)","line":null,"original_line":85,"original_start_line":null,"path":"prototype/sky/skylet/log_lib.py","start_line":null,"text":"@user1:\nnit: pid = process id, here I think you mean `proc_pgid`?"}],"string":"[\n {\n \"diff_hunk\": \"@@ -76,18 +76,35 @@ def run_with_log(\\n Retruns the process, stdout and stderr of the command.\\n Note that the stdout and stderr is already decoded.\\n \\\"\\\"\\\"\\n- with subprocess.Popen(cmd,\\n- stdout=subprocess.PIPE,\\n- stderr=subprocess.PIPE,\\n- **kwargs) as proc:\\n- stdout, stderr = redirect_process_output(\\n- proc, log_path, stream_logs, start_streaming_at=start_streaming_at)\\n- proc.wait()\\n- if proc.returncode != 0 and check:\\n- raise RuntimeError('Command failed, please check the logs.')\\n- if return_none:\\n- return None\\n- return proc, stdout, stderr\\n+ try:\\n+ with subprocess.Popen(cmd,\\n+ stdout=subprocess.PIPE,\\n+ stderr=subprocess.PIPE,\\n+ start_new_session=True,\\n+ **kwargs) as proc:\\n+ proc_pid = os.getpgid(proc.pid)\",\n \"line\": null,\n \"original_line\": 85,\n \"original_start_line\": null,\n \"path\": \"prototype/sky/skylet/log_lib.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nnit: pid = process id, here I think you mean `proc_pgid`?\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"754b78fffde75ee59e97ddfb46e937256579c20b"},"merged_patch":{"kind":"string","value":"diff --git a/prototype/examples/job_queue/job_gpu.yaml b/prototype/examples/job_queue/job_gpu.yaml\nnew file mode 100644\nindex 00000000000..985847b68cd\n--- /dev/null\n+++ b/prototype/examples/job_queue/job_gpu.yaml\n@@ -0,0 +1,28 @@\n+# A task submitted to an existing cluster.\n+#\n+# Runs a task on a existing cluster.\n+#\n+# Usage:\n+# sky launch -c jq cluster.yaml\n+# sky exec -c jq job.yaml\n+\n+name: job\n+\n+resources:\n+ accelerators:\n+ K80: 0.5\n+\n+# setup: |\n+# conda create -n test python=3.7 -y\n+# conda activate test\n+# conda install pytorch torchvision torchaudio cudatoolkit=10.2 -c pytorch\n+\n+\n+\n+run: |\n+ timestamp=$(date +%s)\n+ conda activate test\n+ echo \"started\"\n+ python -u -c \"import torch; a = torch.randn(10000, 10000).cuda(); b = torch.randn(10000, 10000).cuda(); [print((a @ b).sum()) for _ in range(10000000000)]\"\n+ echo \"ended\"\n+\ndiff --git a/prototype/sky/skylet/log_lib.py b/prototype/sky/skylet/log_lib.py\nindex 1ec60227673..ee0e8ed57e0 100644\n--- a/prototype/sky/skylet/log_lib.py\n+++ b/prototype/sky/skylet/log_lib.py\n@@ -76,18 +76,35 @@ def run_with_log(\n Retruns the process, stdout and stderr of the command.\n Note that the stdout and stderr is already decoded.\n \"\"\"\n- with subprocess.Popen(cmd,\n- stdout=subprocess.PIPE,\n- stderr=subprocess.PIPE,\n- **kwargs) as proc:\n- stdout, stderr = redirect_process_output(\n- proc, log_path, stream_logs, start_streaming_at=start_streaming_at)\n- proc.wait()\n- if proc.returncode != 0 and check:\n- raise RuntimeError('Command failed, please check the logs.')\n- if return_none:\n- return None\n- return proc, stdout, stderr\n+ try:\n+ with subprocess.Popen(cmd,\n+ stdout=subprocess.PIPE,\n+ stderr=subprocess.PIPE,\n+ start_new_session=True,\n+ **kwargs) as proc:\n+ proc_pgid = os.getpgid(proc.pid)\n+ stdout, stderr = redirect_process_output(\n+ proc,\n+ log_path,\n+ stream_logs,\n+ start_streaming_at=start_streaming_at)\n+ proc.wait()\n+ if proc.returncode != 0 and check:\n+ raise RuntimeError('Command failed, please check the logs.')\n+ if return_none:\n+ return None\n+ return proc, stdout, stderr\n+ finally:\n+ # The proc can be defunct if the python program is killed. Here we\n+ # open a new subprocess to kill the process, SIGKILL the process group.\n+ # Adapted from ray/dashboard/modules/job/job_manager.py#L154\n+ subprocess.Popen(\n+ f'kill -9 -{proc_pgid}',\n+ shell=True,\n+ # Suppress output\n+ stdout=subprocess.DEVNULL,\n+ stderr=subprocess.DEVNULL,\n+ )\n \n \n def run_bash_command_with_log(bash_command: str,\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 4,\n \"problem_domain\": \"Bug Fixes\"\n}"}}},{"rowIdx":7075,"cells":{"instance_id":{"kind":"string","value":"skypilot-org__skypilot-211@8413579"},"repo":{"kind":"string","value":"skypilot-org/skypilot"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":211,"string":"211"},"title":{"kind":"string","value":"Fix git SSH agent forwarding issues"},"body":{"kind":"string","value":"Polishing SSH and git functionality.\r\n\r\n### Tests\r\n```\r\nclass c1:\r\n name = 'cluster1'\r\n ip = '127.0.0.1'\r\n auth_config = {'ssh_user': 'ubuntu', 'ssh_private_key': '~/.ssh/id_rsa'}\r\n\r\nclass c2:\r\n name = 'cluster2'\r\n ip = '127.0.0.2'\r\n auth_config = {'ssh_user': 'ubuntu', 'ssh_private_key': '~/.ssh/id_rsa'}\r\n\r\nclass c3:\r\n name = 'cluster3'\r\n ip = '127.0.0.3'\r\n auth_config = {'ssh_user': 'ubuntu', 'ssh_private_key': '~/.ssh/id_rsa'}\r\n\r\nclass c2_overwrite:\r\n name = 'cluster2'\r\n ip = 'overwrite'\r\n auth_config = {'ssh_user': 'ubuntu', 'ssh_private_key': '~/.ssh/id_rsa'}\r\n\r\n# add some clusters\r\nbackend_utils.SSHConfigHelper.add_cluster(c1.name, c1.ip, c1.auth_config)\r\nbackend_utils.SSHConfigHelper.add_cluster(c2.name, c2.ip, c2.auth_config)\r\nbackend_utils.SSHConfigHelper.add_cluster(c3.name, c3.ip, c3.auth_config)\r\nimport pdb; pdb.set_trace()\r\n\r\n# overwrite\r\nbackend_utils.SSHConfigHelper.add_cluster(c2_overwrite.name, c2_overwrite.ip, c2_overwrite.auth_config)\r\n\r\n# delete middle config\r\nbackend_utils.SSHConfigHelper.remove_cluster(c2_overwrite.ip, c2_overwrite.auth_config)\r\n\r\n# remove everything\r\nbackend_utils.SSHConfigHelper.remove_cluster(c1.ip, c1.auth_config)\r\nbackend_utils.SSHConfigHelper.remove_cluster(c2.ip, c2.auth_config)\r\nbackend_utils.SSHConfigHelper.remove_cluster(c2_overwrite.ip, c2_overwrite.auth_config)\r\nbackend_utils.SSHConfigHelper.remove_cluster(c3.ip, c3.auth_config)\r\n```\r\n\r\n- [x] Verified that SSH config no longer has a ton of trailing lines. \r\n- [x] git key path exists in `ssh-add -L` locally and on server\r\n- [x] git forward works on server"},"created_at":{"kind":"string","value":"2022-01-18T09:15:05Z"},"problem_statement":{"kind":"string","value":"git credential forwarding doesn't work for https auth\nMany users use `gh auth login` to authenticate with github and cache their git credentials locally. This uses https instead of ssh for git authentication. \r\n\r\nCurrent git credential forwarding in sky supports forwarding only ssh credentials. Is there some way we can add support for forwarding https credentials (access tokens?)? @gmittal \n\nssh config unexpected newlines and known_host check\nThe ssh config helper is very useful. I found two small problems:\r\n1. After creating and tearing down clusters, there will be multiple unexpected newlines in the `~/.ssh/config` at the beginning and the end of the file.\r\n2. We need to add `StrictHostKeyChecking no` after each entry we add, so as to avoid the host key conflict with the known_hosts, when the user creates, tears down, and creates again with the same cluster name."},"hints_text":{"kind":"string","value":"HTTPS host forwarding doesn't seem to be documented anywhere by GitHub, so for now we'll have to require that if users want git to magically work on their remote VMs they're going to need to have an SSH key set up locally. `gh auth login` supports SSH setup quite easily in their login flow, including creating a new key and registering it with a GitHub account."},"resolved_issues":{"kind":"list like","value":[{"body":"Many users use `gh auth login` to authenticate with github and cache their git credentials locally. This uses https instead of ssh for git authentication. \r\n\r\nCurrent git credential forwarding in sky supports forwarding only ssh credentials. Is there some way we can add support for forwarding https credentials (access tokens?)? @gmittal ","number":165,"title":"git credential forwarding doesn't work for https auth"},{"body":"The ssh config helper is very useful. I found two small problems:\r\n1. After creating and tearing down clusters, there will be multiple unexpected newlines in the `~/.ssh/config` at the beginning and the end of the file.\r\n2. We need to add `StrictHostKeyChecking no` after each entry we add, so as to avoid the host key conflict with the known_hosts, when the user creates, tears down, and creates again with the same cluster name.","number":173,"title":"ssh config unexpected newlines and known_host check"}],"string":"[\n {\n \"body\": \"Many users use `gh auth login` to authenticate with github and cache their git credentials locally. This uses https instead of ssh for git authentication. \\r\\n\\r\\nCurrent git credential forwarding in sky supports forwarding only ssh credentials. Is there some way we can add support for forwarding https credentials (access tokens?)? @gmittal \",\n \"number\": 165,\n \"title\": \"git credential forwarding doesn't work for https auth\"\n },\n {\n \"body\": \"The ssh config helper is very useful. I found two small problems:\\r\\n1. After creating and tearing down clusters, there will be multiple unexpected newlines in the `~/.ssh/config` at the beginning and the end of the file.\\r\\n2. We need to add `StrictHostKeyChecking no` after each entry we add, so as to avoid the host key conflict with the known_hosts, when the user creates, tears down, and creates again with the same cluster name.\",\n \"number\": 173,\n \"title\": \"ssh config unexpected newlines and known_host check\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"df228f88146aef3aff343f306501b1304a20794b"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"8413579bbfe539a3b6170f32e3f2c277c2cd037f\",\n \"head_commit_message\": \"Fix remove lines\",\n \"patch_to_review\": \"diff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\\nindex 3be7672af58..eba2634e082 100644\\n--- a/prototype/sky/backends/backend_utils.py\\n+++ b/prototype/sky/backends/backend_utils.py\\n@@ -178,8 +178,8 @@ def _get_generated_config(cls, autogen_comment: str, host_name: str,\\n IdentityFile {ssh_key_path}\\n IdentitiesOnly yes\\n ForwardAgent yes\\n- Port 22\\n- \\\"\\\"\\\")\\n+ StrictHostKeyChecking no\\n+ Port 22\\\"\\\"\\\")\\n return codegen\\n \\n @classmethod\\n@@ -237,18 +237,19 @@ def add_cluster(\\n # Add (or overwrite) the new config.\\n if overwrite:\\n assert overwrite_begin_idx is not None\\n- updated_lines = codegen.splitlines(keepends=True)\\n+ updated_lines = codegen.splitlines(keepends=True) + ['\\\\n\\\\n']\\n config[overwrite_begin_idx:overwrite_begin_idx +\\n len(updated_lines)] = updated_lines\\n with open(config_path, 'w') as f:\\n- f.write('\\\\n')\\n- f.writelines(config)\\n- f.write('\\\\n')\\n+ f.write(''.join(config).strip())\\n else:\\n with open(config_path, 'a') as f:\\n- f.write('\\\\n')\\n+ f.write('\\\\n\\\\n')\\n f.write(codegen)\\n \\n+ # Add git credential forwarding\\n+ GitCredentialsHelper.start_agent()\\n+\\n @classmethod\\n def remove_cluster(cls, ip: str, auth_config: Dict[str, str]):\\n \\\"\\\"\\\"Remove authentication information for cluster from local SSH config.\\n@@ -281,6 +282,12 @@ def remove_cluster(cls, ip: str, auth_config: Dict[str, str]):\\n if start_line_idx is None: # No config to remove.\\n return\\n \\n+ # Scan for end of previous config.\\n+ cursor = start_line_idx\\n+ while cursor > 0 and len(config[cursor].strip()) > 0:\\n+ cursor -= 1\\n+ prev_end_line_idx = cursor\\n+\\n # Scan for end of the cluster config.\\n end_line_idx = None\\n cursor = start_line_idx + 1\\n@@ -293,9 +300,52 @@ def remove_cluster(cls, ip: str, auth_config: Dict[str, str]):\\n cursor += 1\\n \\n # Remove sky-generated config and update the file.\\n- config[start_line_idx:end_line_idx] = []\\n+ config[prev_end_line_idx:end_line_idx] = [\\n+ '\\\\n'\\n+ ] if end_line_idx is not None else []\\n with open(config_path, 'w') as f:\\n- f.writelines(config)\\n+ f.write(''.join(config).strip())\\n+\\n+\\n+class GitCredentialsHelper(object):\\n+ \\\"\\\"\\\"Helper for handling local git SSH credentials.\\\"\\\"\\\"\\n+\\n+ # TODO: Add support for other remotes (e.g. Bitbucket)\\n+ git_remote_url = 'git@github.com'\\n+\\n+ @classmethod\\n+ def _get_ssh_key(cls) -> Optional[str]:\\n+ \\\"\\\"\\\"Find SSH key used for git authentication.\\\"\\\"\\\"\\n+ out = run(f'ssh -T {cls.git_remote_url} -v',\\n+ check=False,\\n+ capture_output=True)\\n+ ssh_log = out.stderr.decode('utf-8').splitlines()\\n+\\n+ # scan for the key\\n+ key_path = None\\n+ cursor = 0\\n+ while cursor < len(ssh_log):\\n+ line = ssh_log[cursor]\\n+ if 'Server accepts key' in line:\\n+ key_path = [e for e in line.split() if '.ssh' in e][0]\\n+ logger.info(f'Found git key: {key_path}')\\n+ break\\n+ if 'Permission denied (publickey)' in line:\\n+ logger.info('Git SSH key not configured.'\\n+ 'Git credential forwarding will not work over SSH.')\\n+ break\\n+ cursor += 1\\n+\\n+ return key_path\\n+\\n+ @classmethod\\n+ def start_agent(cls) -> None:\\n+ \\\"\\\"\\\"Start SSH agent for credential forwarding.\\\"\\\"\\\"\\n+ key_path = cls._get_ssh_key()\\n+ if key_path is not None:\\n+ logger.info('Starting local SSH agent and adding GitHub SSH key.')\\n+ run('eval \\\"$(ssh-agent -s)\\\" && '\\n+ f'ssh-add -K {key_path} || ssh-add {key_path}')\\n \\n \\n # TODO(suquark): once we have sky on PYPI, we should directly install sky\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -293,9 +300,52 @@ def remove_cluster(cls, ip: str, auth_config: Dict[str, str]):\n cursor += 1\n \n # Remove sky-generated config and update the file.\n- config[start_line_idx:end_line_idx] = []\n+ config[prev_end_line_idx:end_line_idx] = [\n+ '\\n'\n+ ] if end_line_idx is not None else []\n with open(config_path, 'w') as f:\n- f.writelines(config)\n+ f.write(''.join(config).strip())\n+\n+\n+class GitCredentialsHelper(object):\n+ \"\"\"Helper for handling local git SSH credentials.\"\"\"\n+\n+ # TODO: Add support for other remotes (e.g. Bitbucket)\n+ git_remote_url = 'git@github.com'\n+\n+ @classmethod\n+ def _get_ssh_key(cls) -> Optional[str]:\n+ \"\"\"Find SSH key used for git authentication.\"\"\"\n+ out = run(f'ssh -T {cls.git_remote_url} -v',\n+ check=False,\n+ capture_output=True)","line":null,"original_line":321,"original_start_line":null,"path":"prototype/sky/backends/backend_utils.py","start_line":null,"text":"@user1:\nnit: How about using `stderr=subprocess.PIPE` instead, if we still want to support python 3.6? The `capture_output` is added in python 3.7.\n\n@author:\nFixed"}],"string":"[\n {\n \"diff_hunk\": \"@@ -293,9 +300,52 @@ def remove_cluster(cls, ip: str, auth_config: Dict[str, str]):\\n cursor += 1\\n \\n # Remove sky-generated config and update the file.\\n- config[start_line_idx:end_line_idx] = []\\n+ config[prev_end_line_idx:end_line_idx] = [\\n+ '\\\\n'\\n+ ] if end_line_idx is not None else []\\n with open(config_path, 'w') as f:\\n- f.writelines(config)\\n+ f.write(''.join(config).strip())\\n+\\n+\\n+class GitCredentialsHelper(object):\\n+ \\\"\\\"\\\"Helper for handling local git SSH credentials.\\\"\\\"\\\"\\n+\\n+ # TODO: Add support for other remotes (e.g. Bitbucket)\\n+ git_remote_url = 'git@github.com'\\n+\\n+ @classmethod\\n+ def _get_ssh_key(cls) -> Optional[str]:\\n+ \\\"\\\"\\\"Find SSH key used for git authentication.\\\"\\\"\\\"\\n+ out = run(f'ssh -T {cls.git_remote_url} -v',\\n+ check=False,\\n+ capture_output=True)\",\n \"line\": null,\n \"original_line\": 321,\n \"original_start_line\": null,\n \"path\": \"prototype/sky/backends/backend_utils.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nnit: How about using `stderr=subprocess.PIPE` instead, if we still want to support python 3.6? The `capture_output` is added in python 3.7.\\n\\n@author:\\nFixed\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"86e1dbbe2c0e1f48b6ce1ca2a67f3d989d010252"},"merged_patch":{"kind":"string","value":"diff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\nindex 3be7672af58..bcf7bd3971c 100644\n--- a/prototype/sky/backends/backend_utils.py\n+++ b/prototype/sky/backends/backend_utils.py\n@@ -178,8 +178,9 @@ def _get_generated_config(cls, autogen_comment: str, host_name: str,\n IdentityFile {ssh_key_path}\n IdentitiesOnly yes\n ForwardAgent yes\n+ StrictHostKeyChecking no\n Port 22\n- \"\"\")\n+ \"\"\")\n return codegen\n \n @classmethod\n@@ -237,18 +238,23 @@ def add_cluster(\n # Add (or overwrite) the new config.\n if overwrite:\n assert overwrite_begin_idx is not None\n- updated_lines = codegen.splitlines(keepends=True)\n+ updated_lines = codegen.splitlines(keepends=True) + ['\\n']\n config[overwrite_begin_idx:overwrite_begin_idx +\n len(updated_lines)] = updated_lines\n with open(config_path, 'w') as f:\n- f.write('\\n')\n- f.writelines(config)\n+ f.write(''.join(config).strip())\n f.write('\\n')\n else:\n with open(config_path, 'a') as f:\n+ if not config[-1].endswith('\\n'):\n+ # Add trailing newline if it doesn't exist.\n+ f.write('\\n')\n f.write('\\n')\n f.write(codegen)\n \n+ # Add git credential forwarding\n+ GitCredentialsHelper.start_agent()\n+\n @classmethod\n def remove_cluster(cls, ip: str, auth_config: Dict[str, str]):\n \"\"\"Remove authentication information for cluster from local SSH config.\n@@ -281,6 +287,12 @@ def remove_cluster(cls, ip: str, auth_config: Dict[str, str]):\n if start_line_idx is None: # No config to remove.\n return\n \n+ # Scan for end of previous config.\n+ cursor = start_line_idx\n+ while cursor > 0 and len(config[cursor].strip()) > 0:\n+ cursor -= 1\n+ prev_end_line_idx = cursor\n+\n # Scan for end of the cluster config.\n end_line_idx = None\n cursor = start_line_idx + 1\n@@ -293,9 +305,54 @@ def remove_cluster(cls, ip: str, auth_config: Dict[str, str]):\n cursor += 1\n \n # Remove sky-generated config and update the file.\n- config[start_line_idx:end_line_idx] = []\n+ config[prev_end_line_idx:end_line_idx] = [\n+ '\\n'\n+ ] if end_line_idx is not None else []\n with open(config_path, 'w') as f:\n- f.writelines(config)\n+ f.write(''.join(config).strip())\n+ f.write('\\n')\n+\n+\n+class GitCredentialsHelper(object):\n+ \"\"\"Helper for handling local git SSH credentials.\"\"\"\n+\n+ # TODO: Add support for other remotes (e.g. Bitbucket)\n+ git_remote_url = 'git@github.com'\n+\n+ @classmethod\n+ def _get_ssh_key(cls) -> Optional[str]:\n+ \"\"\"Find SSH key used for git authentication.\"\"\"\n+ out = run(f'ssh -T {cls.git_remote_url} -v',\n+ check=False,\n+ stderr=subprocess.PIPE,\n+ stdout=subprocess.PIPE)\n+ ssh_log = out.stderr.decode('utf-8').splitlines()\n+\n+ # scan for the key\n+ key_path = None\n+ cursor = 0\n+ while cursor < len(ssh_log):\n+ line = ssh_log[cursor]\n+ if 'Server accepts key' in line:\n+ key_path = [e for e in line.split() if '.ssh' in e][0]\n+ logger.info(f'Found git key: {key_path}')\n+ break\n+ if 'Permission denied (publickey)' in line:\n+ logger.info('Git SSH key not configured.'\n+ 'Git credential forwarding will not work over SSH.')\n+ break\n+ cursor += 1\n+\n+ return key_path\n+\n+ @classmethod\n+ def start_agent(cls) -> None:\n+ \"\"\"Start SSH agent for credential forwarding.\"\"\"\n+ key_path = cls._get_ssh_key()\n+ if key_path is not None:\n+ logger.info('Starting local SSH agent and adding GitHub SSH key.')\n+ run('eval \"$(ssh-agent -s)\" && '\n+ f'ssh-add -K {key_path} || ssh-add {key_path}')\n \n \n # TODO(suquark): once we have sky on PYPI, we should directly install sky\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 4,\n \"problem_domain\": \"Bug Fixes\"\n}"}}},{"rowIdx":7076,"cells":{"instance_id":{"kind":"string","value":"skypilot-org__skypilot-163@b791373"},"repo":{"kind":"string","value":"skypilot-org/skypilot"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":163,"string":"163"},"title":{"kind":"string","value":"Catch resource demands (accelerators) inconsistent with instance type."},"body":{"kind":"string","value":"Fixes #154.\r\n\r\nTested\r\n- new unit tests\r\n- `sky gpunode -t p3.2xlarge --gpus=K80 --cloud aws` correctly fails with the new error\r\n- `sky gpunode -t p3.2xlarge --gpus=V100 --cloud aws` works\r\n- `sky gpunode -t p3dn.24xlarge --cloud aws` works"},"created_at":{"kind":"string","value":"2022-01-11T02:31:56Z"},"problem_statement":{"kind":"string","value":"accelerators_to_hourly_cost prevents gpunode with user-specified instance type\n```\r\n❯ sky gpunode -t p3dn.24xlarge --cloud aws\r\nI 01-08 14:18:15 optimizer.py:206] Defaulting estimated time to 1 hr. Call Task.set_time_estimator() to override.\r\nTraceback (most recent call last):\r\n File \"/Users/gautam/miniconda3/envs/sky/bin/sky\", line 33, in <module>\r\n sys.exit(load_entry_point('sky', 'console_scripts', 'sky')())\r\n File \"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\", line 1128, in __call__\r\n return self.main(*args, **kwargs)\r\n File \"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\", line 1053, in main\r\n rv = self.invoke(ctx)\r\n File \"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\", line 1659, in invoke\r\n return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n File \"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\", line 1395, in invoke\r\n return ctx.invoke(self.callback, **ctx.params)\r\n File \"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\", line 754, in invoke\r\n return __callback(*args, **kwargs)\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/cli.py\", line 669, in gpunode\r\n _create_and_ssh_into_node(\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/cli.py\", line 211, in _create_and_ssh_into_node\r\n dag = sky.optimize(dag)\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/optimizer.py\", line 76, in optimize\r\n optimized_dag, unused_best_plan = Optimizer._optimize_cost(\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/optimizer.py\", line 229, in _optimize_cost\r\n estimated_cost = resources.get_cost(estimated_runtime)\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/resources.py\", line 102, in get_cost\r\n hourly_cost += self.cloud.accelerators_to_hourly_cost(\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/clouds/cloud.py\", line 77, in accelerators_to_hourly_cost\r\n raise NotImplementedError\r\nNotImplementedError\r\n```"},"hints_text":{"kind":"string","value":""},"resolved_issues":{"kind":"list like","value":[{"body":"```\r\n❯ sky gpunode -t p3dn.24xlarge --cloud aws\r\nI 01-08 14:18:15 optimizer.py:206] Defaulting estimated time to 1 hr. Call Task.set_time_estimator() to override.\r\nTraceback (most recent call last):\r\n File \"/Users/gautam/miniconda3/envs/sky/bin/sky\", line 33, in <module>\r\n sys.exit(load_entry_point('sky', 'console_scripts', 'sky')())\r\n File \"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\", line 1128, in __call__\r\n return self.main(*args, **kwargs)\r\n File \"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\", line 1053, in main\r\n rv = self.invoke(ctx)\r\n File \"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\", line 1659, in invoke\r\n return _process_result(sub_ctx.command.invoke(sub_ctx))\r\n File \"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\", line 1395, in invoke\r\n return ctx.invoke(self.callback, **ctx.params)\r\n File \"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\", line 754, in invoke\r\n return __callback(*args, **kwargs)\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/cli.py\", line 669, in gpunode\r\n _create_and_ssh_into_node(\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/cli.py\", line 211, in _create_and_ssh_into_node\r\n dag = sky.optimize(dag)\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/optimizer.py\", line 76, in optimize\r\n optimized_dag, unused_best_plan = Optimizer._optimize_cost(\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/optimizer.py\", line 229, in _optimize_cost\r\n estimated_cost = resources.get_cost(estimated_runtime)\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/resources.py\", line 102, in get_cost\r\n hourly_cost += self.cloud.accelerators_to_hourly_cost(\r\n File \"/Users/gautam/Desktop/workbench/sky/prototype/sky/clouds/cloud.py\", line 77, in accelerators_to_hourly_cost\r\n raise NotImplementedError\r\nNotImplementedError\r\n```","number":154,"title":"accelerators_to_hourly_cost prevents gpunode with user-specified instance type"}],"string":"[\n {\n \"body\": \"```\\r\\n❯ sky gpunode -t p3dn.24xlarge --cloud aws\\r\\nI 01-08 14:18:15 optimizer.py:206] Defaulting estimated time to 1 hr. Call Task.set_time_estimator() to override.\\r\\nTraceback (most recent call last):\\r\\n File \\\"/Users/gautam/miniconda3/envs/sky/bin/sky\\\", line 33, in <module>\\r\\n sys.exit(load_entry_point('sky', 'console_scripts', 'sky')())\\r\\n File \\\"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\\\", line 1128, in __call__\\r\\n return self.main(*args, **kwargs)\\r\\n File \\\"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\\\", line 1053, in main\\r\\n rv = self.invoke(ctx)\\r\\n File \\\"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\\\", line 1659, in invoke\\r\\n return _process_result(sub_ctx.command.invoke(sub_ctx))\\r\\n File \\\"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\\\", line 1395, in invoke\\r\\n return ctx.invoke(self.callback, **ctx.params)\\r\\n File \\\"/Users/gautam/miniconda3/envs/sky/lib/python3.8/site-packages/click/core.py\\\", line 754, in invoke\\r\\n return __callback(*args, **kwargs)\\r\\n File \\\"/Users/gautam/Desktop/workbench/sky/prototype/sky/cli.py\\\", line 669, in gpunode\\r\\n _create_and_ssh_into_node(\\r\\n File \\\"/Users/gautam/Desktop/workbench/sky/prototype/sky/cli.py\\\", line 211, in _create_and_ssh_into_node\\r\\n dag = sky.optimize(dag)\\r\\n File \\\"/Users/gautam/Desktop/workbench/sky/prototype/sky/optimizer.py\\\", line 76, in optimize\\r\\n optimized_dag, unused_best_plan = Optimizer._optimize_cost(\\r\\n File \\\"/Users/gautam/Desktop/workbench/sky/prototype/sky/optimizer.py\\\", line 229, in _optimize_cost\\r\\n estimated_cost = resources.get_cost(estimated_runtime)\\r\\n File \\\"/Users/gautam/Desktop/workbench/sky/prototype/sky/resources.py\\\", line 102, in get_cost\\r\\n hourly_cost += self.cloud.accelerators_to_hourly_cost(\\r\\n File \\\"/Users/gautam/Desktop/workbench/sky/prototype/sky/clouds/cloud.py\\\", line 77, in accelerators_to_hourly_cost\\r\\n raise NotImplementedError\\r\\nNotImplementedError\\r\\n```\",\n \"number\": 154,\n \"title\": \"accelerators_to_hourly_cost prevents gpunode with user-specified instance type\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"d9cbd6c2dbe447cf6f865449170ef9096c8cdf50"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"b791373260c1ff5562c533565d57a40086216060\",\n \"head_commit_message\": \"Fine tune a few things\",\n \"patch_to_review\": \"diff --git a/prototype/examples/huggingface_glue_imdb_app.yaml b/prototype/examples/huggingface_glue_imdb_app.yaml\\nindex 1e1ff257e9e..1d32d77c4d9 100644\\n--- a/prototype/examples/huggingface_glue_imdb_app.yaml\\n+++ b/prototype/examples/huggingface_glue_imdb_app.yaml\\n@@ -25,5 +25,5 @@ run: |\\n --per_device_train_batch_size 32 \\\\\\n --learning_rate 2e-5 \\\\\\n --max_steps 50 \\\\\\n- --output_dir /tmp/imdb/ \\\\\\n+ --output_dir /tmp/imdb/ --overwrite_output_dir \\\\\\n --fp16\\ndiff --git a/prototype/examples/multi_echo.py b/prototype/examples/multi_echo.py\\nindex d1343c221c5..223956795eb 100644\\n--- a/prototype/examples/multi_echo.py\\n+++ b/prototype/examples/multi_echo.py\\n@@ -6,7 +6,7 @@\\n task = sky.Task().set_resources(cluster_resources)\\n # `detach_run` will only detach the `run` command. The provision and `setup` are\\n # still blocking.\\n-sky.launch(dag, cluster_name='multi_echo', detach_run=True)\\n+sky.launch(dag, cluster_name='multi-echo', detach_run=True)\\n \\n # Run the multiple tasks.\\n for i in range(16):\\n@@ -14,4 +14,4 @@\\n task = sky.Task(run=f'echo {i}; sleep 15')\\n resources = sky.Resources(accelerators={'K80': 0.1})\\n task.set_resources(resources)\\n- sky.exec(dag, cluster_name='multi_echo', detach_run=True)\\n+ sky.exec(dag, cluster_name='multi-echo', detach_run=True)\\ndiff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py\\nindex 3925de9f828..0761961e952 100644\\n--- a/prototype/sky/backends/cloud_vm_ray_backend.py\\n+++ b/prototype/sky/backends/cloud_vm_ray_backend.py\\n@@ -1233,7 +1233,7 @@ def _exec_code_on_head(\\n f'{backend_utils.BOLD}sky logs -c {name} {job_id}'\\n f'{backend_utils.RESET_BOLD}'\\n '\\\\nTo view the job queue:\\\\t'\\n- f'{backend_utils.BOLD}sky queue -c {name}'\\n+ f'{backend_utils.BOLD}sky queue {name}'\\n f'{backend_utils.RESET_BOLD}')\\n \\n def _add_job(self, handle: ResourceHandle) -> int:\\n@@ -1384,11 +1384,11 @@ def post_execute(self, handle: ResourceHandle, teardown: bool) -> None:\\n '\\\\nTo submit a job:'\\n f'\\\\t\\\\t{backend_utils.BOLD}sky exec -c {name} yaml_file'\\n f'{backend_utils.RESET_BOLD}'\\n- '\\\\nTo teardown the cluster:'\\n- f'\\\\t{backend_utils.BOLD}sky down {name}'\\n- f'{backend_utils.RESET_BOLD}'\\n '\\\\nTo stop the cluster:'\\n f'\\\\t{backend_utils.BOLD}sky stop {name}'\\n+ f'{backend_utils.RESET_BOLD}'\\n+ '\\\\nTo teardown the cluster:'\\n+ f'\\\\t{backend_utils.BOLD}sky down {name}'\\n f'{backend_utils.RESET_BOLD}')\\n if handle.tpu_delete_script is not None:\\n logger.info('Tip: `sky down` will delete launched TPU(s) too.')\\ndiff --git a/prototype/sky/cli.py b/prototype/sky/cli.py\\nindex 81f3822c0b6..057fdf23d80 100644\\n--- a/prototype/sky/cli.py\\n+++ b/prototype/sky/cli.py\\n@@ -217,6 +217,10 @@ def _create_and_ssh_into_node(\\n task = dag.tasks[0]\\n backend.register_info(dag=dag)\\n \\n+ # FIXME(gautam): typing the following seq of cmds:\\n+ # sky gpunode -t p3.2xlarge --gpus=V100 --cloud aws\\n+ # sky gpunode -t n1-standard-8 --gpus=V100 --cloud gcp\\n+ # makes the second cmd log into the first VM. It should error out.\\n handle = global_user_state.get_handle_from_cluster_name(cluster_name)\\n if handle is None or handle.head_ip is None:\\n # head_ip would be None if previous provisioning failed.\\n@@ -246,10 +250,10 @@ def _create_and_ssh_into_node(\\n else:\\n option = f' -c {cluster_name}'\\n click.secho(f'sky {node_type}{option}', bold=True)\\n- click.echo('To tear down the node:\\\\t', nl=False)\\n- click.secho(f'sky down {cluster_name}', bold=True)\\n click.echo('To stop the node:\\\\t', nl=False)\\n click.secho(f'sky stop {cluster_name}', bold=True)\\n+ click.echo('To tear down the node:\\\\t', nl=False)\\n+ click.secho(f'sky down {cluster_name}', bold=True)\\n \\n \\n class _NaturalOrderGroup(click.Group):\\n@@ -463,7 +467,7 @@ def queue(cluster: Optional[str], skip_finished: bool, all_users: bool):\\n help='Name of the existing cluster to find the job.')\\n @click.argument('job_id', required=True, type=str)\\n def logs(cluster: str, job_id: str):\\n- \\\"\\\"\\\"Tailing the log of a job.\\\"\\\"\\\"\\n+ \\\"\\\"\\\"Tail the log of a job.\\\"\\\"\\\"\\n # TODO: Add an option for downloading logs.\\n cluster_name = cluster\\n backend = backends.CloudVmRayBackend()\\n@@ -494,7 +498,8 @@ def logs(cluster: str, job_id: str):\\n help='Cancel all jobs.')\\n @click.argument('jobs', required=False, type=int, nargs=-1)\\n def cancel(cluster: str, all: bool, jobs: List[int]): # pylint: disable=redefined-builtin\\n- \\\"\\\"\\\"Cancel the jobs on a cluster.\\\"\\\"\\\"\\n+ \\\"\\\"\\\"Cancel job(s).\\\"\\\"\\\"\\n+ # FIXME(zhwu): should not allow SUCCEEDED jobs to be turned into CANCELLED.\\n if len(jobs) == 0 and not all:\\n raise click.UsageError(\\n 'sky cancel requires either a job id '\\n@@ -510,7 +515,8 @@ def cancel(cluster: str, all: bool, jobs: List[int]): # pylint: disable=redefin\\n fg='yellow')\\n jobs = None\\n else:\\n- click.secho(f'Cancelling jobs {jobs} on cluster {cluster} ...',\\n+ jobs_str = ', '.join(map(str, jobs))\\n+ click.secho(f'Cancelling jobs ({jobs_str}) on cluster {cluster} ...',\\n fg='yellow')\\n \\n codegen = backend_utils.JobLibCodeGen()\\n@@ -522,41 +528,6 @@ def cancel(cluster: str, all: bool, jobs: List[int]): # pylint: disable=redefin\\n backend.run_on_head(handle, code, stream_logs=False)\\n \\n \\n-@cli.command()\\n-@click.argument('clusters', nargs=-1, required=False)\\n-@click.option('--all',\\n- '-a',\\n- default=None,\\n- is_flag=True,\\n- help='Tear down all existing clusters.')\\n-def down(\\n- clusters: Tuple[str],\\n- all: Optional[bool], # pylint: disable=redefined-builtin\\n-):\\n- \\\"\\\"\\\"Tear down cluster(s).\\n-\\n- CLUSTER is the name of the cluster to tear down. If both CLUSTER and --all\\n- are supplied, the latter takes precedence.\\n-\\n- Accelerators (e.g., TPU) that are part of the cluster will be deleted too.\\n-\\n- Examples:\\n-\\n- \\\\b\\n- # Tear down a specific cluster.\\n- sky down cluster_name\\n-\\n- \\\\b\\n- # Tear down multiple clusters.\\n- sky down cluster1 cluster2\\n-\\n- \\\\b\\n- # Tear down all existing clusters.\\n- sky down -a\\n- \\\"\\\"\\\"\\n- _terminate_or_stop_clusters(clusters, apply_to_all=all, terminate=True)\\n-\\n-\\n @cli.command()\\n @click.argument('clusters', nargs=-1, required=False)\\n @click.option('--all',\\n@@ -687,6 +658,41 @@ def _filter(name, all_clusters):\\n click.secho(f'Cluster {name} started.', fg='green')\\n \\n \\n+@cli.command()\\n+@click.argument('clusters', nargs=-1, required=False)\\n+@click.option('--all',\\n+ '-a',\\n+ default=None,\\n+ is_flag=True,\\n+ help='Tear down all existing clusters.')\\n+def down(\\n+ clusters: Tuple[str],\\n+ all: Optional[bool], # pylint: disable=redefined-builtin\\n+):\\n+ \\\"\\\"\\\"Tear down cluster(s).\\n+\\n+ CLUSTER is the name of the cluster to tear down. If both CLUSTER and --all\\n+ are supplied, the latter takes precedence.\\n+\\n+ Accelerators (e.g., TPU) that are part of the cluster will be deleted too.\\n+\\n+ Examples:\\n+\\n+ \\\\b\\n+ # Tear down a specific cluster.\\n+ sky down cluster_name\\n+\\n+ \\\\b\\n+ # Tear down multiple clusters.\\n+ sky down cluster1 cluster2\\n+\\n+ \\\\b\\n+ # Tear down all existing clusters.\\n+ sky down -a\\n+ \\\"\\\"\\\"\\n+ _terminate_or_stop_clusters(clusters, apply_to_all=all, terminate=True)\\n+\\n+\\n def _terminate_or_stop_clusters(names: Tuple[str], apply_to_all: Optional[bool],\\n terminate: bool) -> None:\\n \\\"\\\"\\\"Terminates or stops a cluster (or all clusters).\\\"\\\"\\\"\\n@@ -780,10 +786,12 @@ def gpunode(cluster: str, port_forward: Optional[List[int]],\\n f'Cloud \\\\'{cloud}\\\\' is not supported. ' + \\\\\\n f'Supported clouds: {list(task_lib.CLOUD_REGISTRY.keys())}'\\n )\\n- if gpus is None:\\n- gpus = {'K80': 1}\\n- else:\\n+ if gpus is not None:\\n gpus = _parse_accelerator_options(gpus)\\n+ elif instance_type is None:\\n+ # Use this request if both gpus and instance_type are not specified.\\n+ gpus = {'K80': 1}\\n+\\n resources = sky.Resources(cloud=cloud_provider,\\n instance_type=instance_type,\\n accelerators=gpus,\\ndiff --git a/prototype/sky/resources.py b/prototype/sky/resources.py\\nindex d6bff4d23b9..3798594807d 100644\\n--- a/prototype/sky/resources.py\\n+++ b/prototype/sky/resources.py\\n@@ -61,6 +61,8 @@ def __init__(\\n self.accelerator_args = accelerator_args\\n self.use_spot = use_spot\\n \\n+ self._clear_redundant_accelerators_field()\\n+\\n def __repr__(self) -> str:\\n accelerators = ''\\n accelerator_args = ''\\n@@ -77,6 +79,29 @@ def __repr__(self) -> str:\\n def is_launchable(self) -> bool:\\n return self.cloud is not None and self.instance_type is not None\\n \\n+ def _clear_redundant_accelerators_field(self) -> None:\\n+ \\\"\\\"\\\"Try-clears any specified accelerators field for non-GCP.\\\"\\\"\\\"\\n+ # GCP must have 'self.accelerators' because it attaches accelerators to\\n+ # regular VMs. For other clouds, this field may be\\n+ # reduandant/inconsistent with the specified instance_type.\\n+ if self.is_launchable() and not isinstance(self.cloud, clouds.GCP):\\n+ acc_requested = self.accelerators\\n+ if acc_requested is None:\\n+ return\\n+ acc_from_instance_type = (\\n+ self.cloud.get_accelerators_from_instance_type(\\n+ self.instance_type))\\n+ if acc_from_instance_type != acc_requested:\\n+ raise ValueError(\\n+ 'Infeasible resource demands found:\\\\n'\\n+ f' Instance type requested: {self.instance_type}\\\\n'\\n+ f' Accelerators for {self.instance_type}: '\\n+ f'{acc_from_instance_type}\\\\n'\\n+ f' Accelerators requested: {acc_requested}\\\\n'\\n+ f'To fix: either only specify instance_type, or change '\\n+ 'the accelerators field to be consistent.')\\n+ self.accelerators = None\\n+\\n def get_accelerators(self) -> Optional[Dict[str, int]]:\\n \\\"\\\"\\\"Returns the accelerators field directly or by inferring.\\n \\ndiff --git a/prototype/tests/test_optimizer_dryruns.py b/prototype/tests/test_optimizer_dryruns.py\\nindex 10bc6082848..83e08e3088a 100644\\n--- a/prototype/tests/test_optimizer_dryruns.py\\n+++ b/prototype/tests/test_optimizer_dryruns.py\\n@@ -9,7 +9,6 @@ def _test_resources(resources):\\n train = sky.Task('train')\\n train.set_resources({resources})\\n sky.launch(dag, dryrun=True)\\n- assert True\\n \\n \\n def test_resources_aws():\\n@@ -50,3 +49,30 @@ def test_partial_v100():\\n _test_resources(\\n sky.Resources(clouds.AWS(), accelerators='V100', use_spot=True))\\n _test_resources(sky.Resources(clouds.AWS(), accelerators={'V100': 8}))\\n+\\n+\\n+def test_instance_type_mistmatches_accelerators():\\n+ bad_instance_and_accs = [\\n+ # Actual: V100\\n+ ('p3.2xlarge', 'K80'),\\n+ # Actual: None\\n+ ('m4.2xlarge', 'V100'),\\n+ ]\\n+ for instance, acc in bad_instance_and_accs:\\n+ with pytest.raises(ValueError) as e:\\n+ _test_resources(\\n+ sky.Resources(clouds.AWS(),\\n+ instance_type=instance,\\n+ accelerators=acc))\\n+ assert 'Infeasible resource demands found' in str(e.value)\\n+\\n+\\n+def test_instance_type_matches_accelerators():\\n+ _test_resources(\\n+ sky.Resources(clouds.AWS(),\\n+ instance_type='p3.2xlarge',\\n+ accelerators='V100'))\\n+ _test_resources(\\n+ sky.Resources(clouds.GCP(),\\n+ instance_type='n1-standard-2',\\n+ accelerators='V100'))\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -77,6 +79,29 @@ def __repr__(self) -> str:\n def is_launchable(self) -> bool:\n return self.cloud is not None and self.instance_type is not None\n \n+ def _clear_redundant_accelerators_field(self) -> None:\n+ \"\"\"Try-clears any specified accelerators field for non-GCP.\"\"\"\n+ # GCP must have 'self.accelerators' because it attaches accelerators to\n+ # regular VMs. For other clouds, this field may be\n+ # reduandant/inconsistent with the specified instance_type.\n+ if self.is_launchable() and not isinstance(self.cloud, clouds.GCP):\n+ acc_requested = self.accelerators\n+ if acc_requested is None:\n+ return\n+ acc_from_instance_type = (\n+ self.cloud.get_accelerators_from_instance_type(\n+ self.instance_type))\n+ if acc_from_instance_type != acc_requested:","line":null,"original_line":94,"original_start_line":null,"path":"prototype/sky/resources.py","start_line":null,"text":"@user1:\nHere is a case where the user needs to set different accelerators to instance_type. The task (as shown below) must be run on `p2.16xlarge` due to the peak memory limitation, but the user does not want to reserve all the GPUs, so that she can submit other small jobs to that cluster as well. \r\n```yaml\r\n# task.yaml\r\nresources:\r\n cloud: aws\r\n instance_type: p3.16xlarge\r\n accelerators:\r\n V100: 1\r\nsetup: ...\r\nrun: ...\r\n```\r\n\r\nOne way is to force the user to have an additional `cluster.yaml` to have the correct instance_type vs accelerators, but an additional file may be bothering? Or we can only check the `acc_requested.keys()[0] == self.accelerators.keys()[0]` and `acc_requested.values()[0] <= self.accelerators.values()[0]`.\n\n@author:\nGreat catch! I think part of why this is hard to spot is because the same `resources:` field is used for both the cluster shape, and the task demand. \r\n\r\nPushed the second fix that you proposed and verified this yaml can launch (and that the codegen'd Ray program has the correct `{V100:1}` demand)."}],"string":"[\n {\n \"diff_hunk\": \"@@ -77,6 +79,29 @@ def __repr__(self) -> str:\\n def is_launchable(self) -> bool:\\n return self.cloud is not None and self.instance_type is not None\\n \\n+ def _clear_redundant_accelerators_field(self) -> None:\\n+ \\\"\\\"\\\"Try-clears any specified accelerators field for non-GCP.\\\"\\\"\\\"\\n+ # GCP must have 'self.accelerators' because it attaches accelerators to\\n+ # regular VMs. For other clouds, this field may be\\n+ # reduandant/inconsistent with the specified instance_type.\\n+ if self.is_launchable() and not isinstance(self.cloud, clouds.GCP):\\n+ acc_requested = self.accelerators\\n+ if acc_requested is None:\\n+ return\\n+ acc_from_instance_type = (\\n+ self.cloud.get_accelerators_from_instance_type(\\n+ self.instance_type))\\n+ if acc_from_instance_type != acc_requested:\",\n \"line\": null,\n \"original_line\": 94,\n \"original_start_line\": null,\n \"path\": \"prototype/sky/resources.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nHere is a case where the user needs to set different accelerators to instance_type. The task (as shown below) must be run on `p2.16xlarge` due to the peak memory limitation, but the user does not want to reserve all the GPUs, so that she can submit other small jobs to that cluster as well. \\r\\n```yaml\\r\\n# task.yaml\\r\\nresources:\\r\\n cloud: aws\\r\\n instance_type: p3.16xlarge\\r\\n accelerators:\\r\\n V100: 1\\r\\nsetup: ...\\r\\nrun: ...\\r\\n```\\r\\n\\r\\nOne way is to force the user to have an additional `cluster.yaml` to have the correct instance_type vs accelerators, but an additional file may be bothering? Or we can only check the `acc_requested.keys()[0] == self.accelerators.keys()[0]` and `acc_requested.values()[0] <= self.accelerators.values()[0]`.\\n\\n@author:\\nGreat catch! I think part of why this is hard to spot is because the same `resources:` field is used for both the cluster shape, and the task demand. \\r\\n\\r\\nPushed the second fix that you proposed and verified this yaml can launch (and that the codegen'd Ray program has the correct `{V100:1}` demand).\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"dcd6dca0b1d96b37118cd32608c629c901ca0898"},"merged_patch":{"kind":"string","value":"diff --git a/prototype/examples/huggingface_glue_imdb_app.yaml b/prototype/examples/huggingface_glue_imdb_app.yaml\nindex 1e1ff257e9e..1d32d77c4d9 100644\n--- a/prototype/examples/huggingface_glue_imdb_app.yaml\n+++ b/prototype/examples/huggingface_glue_imdb_app.yaml\n@@ -25,5 +25,5 @@ run: |\n --per_device_train_batch_size 32 \\\n --learning_rate 2e-5 \\\n --max_steps 50 \\\n- --output_dir /tmp/imdb/ \\\n+ --output_dir /tmp/imdb/ --overwrite_output_dir \\\n --fp16\ndiff --git a/prototype/examples/multi_echo.py b/prototype/examples/multi_echo.py\nindex d1343c221c5..223956795eb 100644\n--- a/prototype/examples/multi_echo.py\n+++ b/prototype/examples/multi_echo.py\n@@ -6,7 +6,7 @@\n task = sky.Task().set_resources(cluster_resources)\n # `detach_run` will only detach the `run` command. The provision and `setup` are\n # still blocking.\n-sky.launch(dag, cluster_name='multi_echo', detach_run=True)\n+sky.launch(dag, cluster_name='multi-echo', detach_run=True)\n \n # Run the multiple tasks.\n for i in range(16):\n@@ -14,4 +14,4 @@\n task = sky.Task(run=f'echo {i}; sleep 15')\n resources = sky.Resources(accelerators={'K80': 0.1})\n task.set_resources(resources)\n- sky.exec(dag, cluster_name='multi_echo', detach_run=True)\n+ sky.exec(dag, cluster_name='multi-echo', detach_run=True)\ndiff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py\nindex 80cb893c438..6fa591842ab 100644\n--- a/prototype/sky/backends/cloud_vm_ray_backend.py\n+++ b/prototype/sky/backends/cloud_vm_ray_backend.py\n@@ -991,7 +991,7 @@ def _check_task_resources_smaller_than_cluster(self, handle: ResourceHandle,\n f' Existing: {handle.launched_nodes}x '\n f'{handle.launched_resources}\\n'\n f'To fix: specify a new cluster name, or down the '\n- f'existing cluster first: `sky down {cluster_name}`.')\n+ f'existing cluster first: sky down {cluster_name}')\n \n def _check_existing_cluster(self, task: Task, to_provision: Resources,\n cluster_name: str) -> Tuple[str, Resources]:\n@@ -1249,7 +1249,7 @@ def _exec_code_on_head(\n f'{backend_utils.BOLD}sky logs -c {name} {job_id}'\n f'{backend_utils.RESET_BOLD}'\n '\\nTo view the job queue:\\t'\n- f'{backend_utils.BOLD}sky queue -c {name}'\n+ f'{backend_utils.BOLD}sky queue {name}'\n f'{backend_utils.RESET_BOLD}')\n \n def _add_job(self, handle: ResourceHandle) -> int:\n@@ -1400,11 +1400,11 @@ def post_execute(self, handle: ResourceHandle, teardown: bool) -> None:\n '\\nTo submit a job:'\n f'\\t\\t{backend_utils.BOLD}sky exec -c {name} yaml_file'\n f'{backend_utils.RESET_BOLD}'\n- '\\nTo teardown the cluster:'\n- f'\\t{backend_utils.BOLD}sky down {name}'\n- f'{backend_utils.RESET_BOLD}'\n '\\nTo stop the cluster:'\n f'\\t{backend_utils.BOLD}sky stop {name}'\n+ f'{backend_utils.RESET_BOLD}'\n+ '\\nTo teardown the cluster:'\n+ f'\\t{backend_utils.BOLD}sky down {name}'\n f'{backend_utils.RESET_BOLD}')\n if handle.tpu_delete_script is not None:\n logger.info('Tip: `sky down` will delete launched TPU(s) too.')\ndiff --git a/prototype/sky/cli.py b/prototype/sky/cli.py\nindex 0c3c6da9686..28b63943e33 100644\n--- a/prototype/sky/cli.py\n+++ b/prototype/sky/cli.py\n@@ -217,6 +217,10 @@ def _create_and_ssh_into_node(\n task = dag.tasks[0]\n backend.register_info(dag=dag)\n \n+ # FIXME(gautam): typing the following seq of cmds:\n+ # sky gpunode -t p3.2xlarge --gpus=V100 --cloud aws\n+ # sky gpunode -t n1-standard-8 --gpus=V100 --cloud gcp\n+ # makes the second cmd log into the first VM. It should error out.\n handle = global_user_state.get_handle_from_cluster_name(cluster_name)\n if handle is None or handle.head_ip is None:\n # head_ip would be None if previous provisioning failed.\n@@ -246,10 +250,10 @@ def _create_and_ssh_into_node(\n else:\n option = f' -c {cluster_name}'\n click.secho(f'sky {node_type}{option}', bold=True)\n- click.echo('To tear down the node:\\t', nl=False)\n- click.secho(f'sky down {cluster_name}', bold=True)\n click.echo('To stop the node:\\t', nl=False)\n click.secho(f'sky stop {cluster_name}', bold=True)\n+ click.echo('To tear down the node:\\t', nl=False)\n+ click.secho(f'sky down {cluster_name}', bold=True)\n \n \n class _NaturalOrderGroup(click.Group):\n@@ -475,7 +479,7 @@ def _show_job_queue_on_cluster(cluster: str, handle: Optional[Any],\n help='Name of the existing cluster to find the job.')\n @click.argument('job_id', required=True, type=str)\n def logs(cluster: str, job_id: str):\n- \"\"\"Tailing the log of a job.\"\"\"\n+ \"\"\"Tail the log of a job.\"\"\"\n # TODO: Add an option for downloading logs.\n cluster_name = cluster\n backend = backends.CloudVmRayBackend()\n@@ -506,7 +510,7 @@ def logs(cluster: str, job_id: str):\n help='Cancel all jobs.')\n @click.argument('jobs', required=False, type=int, nargs=-1)\n def cancel(cluster: str, all: bool, jobs: List[int]): # pylint: disable=redefined-builtin\n- \"\"\"Cancel the jobs on a cluster.\"\"\"\n+ \"\"\"Cancel job(s).\"\"\"\n if len(jobs) == 0 and not all:\n raise click.UsageError(\n 'sky cancel requires either a job id '\n@@ -522,7 +526,8 @@ def cancel(cluster: str, all: bool, jobs: List[int]): # pylint: disable=redefin\n fg='yellow')\n jobs = None\n else:\n- click.secho(f'Cancelling jobs {jobs} on cluster {cluster} ...',\n+ jobs_str = ', '.join(map(str, jobs))\n+ click.secho(f'Cancelling jobs ({jobs_str}) on cluster {cluster} ...',\n fg='yellow')\n \n codegen = backend_utils.JobLibCodeGen()\n@@ -534,41 +539,6 @@ def cancel(cluster: str, all: bool, jobs: List[int]): # pylint: disable=redefin\n backend.run_on_head(handle, code, stream_logs=False)\n \n \n-@cli.command()\n-@click.argument('clusters', nargs=-1, required=False)\n-@click.option('--all',\n- '-a',\n- default=None,\n- is_flag=True,\n- help='Tear down all existing clusters.')\n-def down(\n- clusters: Tuple[str],\n- all: Optional[bool], # pylint: disable=redefined-builtin\n-):\n- \"\"\"Tear down cluster(s).\n-\n- CLUSTER is the name of the cluster to tear down. If both CLUSTER and --all\n- are supplied, the latter takes precedence.\n-\n- Accelerators (e.g., TPU) that are part of the cluster will be deleted too.\n-\n- Examples:\n-\n- \\b\n- # Tear down a specific cluster.\n- sky down cluster_name\n-\n- \\b\n- # Tear down multiple clusters.\n- sky down cluster1 cluster2\n-\n- \\b\n- # Tear down all existing clusters.\n- sky down -a\n- \"\"\"\n- _terminate_or_stop_clusters(clusters, apply_to_all=all, terminate=True)\n-\n-\n @cli.command()\n @click.argument('clusters', nargs=-1, required=False)\n @click.option('--all',\n@@ -699,6 +669,41 @@ def _filter(name, all_clusters):\n click.secho(f'Cluster {name} started.', fg='green')\n \n \n+@cli.command()\n+@click.argument('clusters', nargs=-1, required=False)\n+@click.option('--all',\n+ '-a',\n+ default=None,\n+ is_flag=True,\n+ help='Tear down all existing clusters.')\n+def down(\n+ clusters: Tuple[str],\n+ all: Optional[bool], # pylint: disable=redefined-builtin\n+):\n+ \"\"\"Tear down cluster(s).\n+\n+ CLUSTER is the name of the cluster to tear down. If both CLUSTER and --all\n+ are supplied, the latter takes precedence.\n+\n+ Accelerators (e.g., TPU) that are part of the cluster will be deleted too.\n+\n+ Examples:\n+\n+ \\b\n+ # Tear down a specific cluster.\n+ sky down cluster_name\n+\n+ \\b\n+ # Tear down multiple clusters.\n+ sky down cluster1 cluster2\n+\n+ \\b\n+ # Tear down all existing clusters.\n+ sky down -a\n+ \"\"\"\n+ _terminate_or_stop_clusters(clusters, apply_to_all=all, terminate=True)\n+\n+\n def _terminate_or_stop_clusters(names: Tuple[str], apply_to_all: Optional[bool],\n terminate: bool) -> None:\n \"\"\"Terminates or stops a cluster (or all clusters).\"\"\"\n@@ -792,10 +797,12 @@ def gpunode(cluster: str, port_forward: Optional[List[int]],\n f'Cloud \\'{cloud}\\' is not supported. ' + \\\n f'Supported clouds: {list(task_lib.CLOUD_REGISTRY.keys())}'\n )\n- if gpus is None:\n- gpus = {'K80': 1}\n- else:\n+ if gpus is not None:\n gpus = _parse_accelerator_options(gpus)\n+ elif instance_type is None:\n+ # Use this request if both gpus and instance_type are not specified.\n+ gpus = {'K80': 1}\n+\n resources = sky.Resources(cloud=cloud_provider,\n instance_type=instance_type,\n accelerators=gpus,\ndiff --git a/prototype/sky/clouds/aws.py b/prototype/sky/clouds/aws.py\nindex 018d6bb9c86..e7222df1414 100644\n--- a/prototype/sky/clouds/aws.py\n+++ b/prototype/sky/clouds/aws.py\n@@ -93,6 +93,12 @@ def get_default_ami(cls, region_name: str) -> str:\n def instance_type_to_hourly_cost(self, instance_type: str, use_spot: bool):\n return aws_catalog.get_hourly_cost(instance_type, use_spot=use_spot)\n \n+ def accelerators_to_hourly_cost(self, accelerators):\n+ # AWS includes accelerators as part of the instance type. Implementing\n+ # this is also necessary for e.g., the instance may have 4 GPUs, while\n+ # the task specifies to use 1 GPU.\n+ return 0\n+\n def get_egress_cost(self, num_gigabytes: float):\n # In general, query this from the cloud:\n # https://aws.amazon.com/s3/pricing/\ndiff --git a/prototype/sky/clouds/azure.py b/prototype/sky/clouds/azure.py\nindex 3f74878f78f..464c505aa46 100644\n--- a/prototype/sky/clouds/azure.py\n+++ b/prototype/sky/clouds/azure.py\n@@ -16,6 +16,12 @@ class Azure(clouds.Cloud):\n def instance_type_to_hourly_cost(self, instance_type, use_spot):\n return azure_catalog.get_hourly_cost(instance_type, use_spot=use_spot)\n \n+ def accelerators_to_hourly_cost(self, accelerators):\n+ # Azure includes accelerators as part of the instance type.\n+ # Implementing this is also necessary for e.g., the instance may have 4\n+ # GPUs, while the task specifies to use 1 GPU.\n+ return 0\n+\n def get_egress_cost(self, num_gigabytes):\n # In general, query this from the cloud:\n # https://azure.microsoft.com/en-us/pricing/details/bandwidth/\ndiff --git a/prototype/sky/resources.py b/prototype/sky/resources.py\nindex 9e474a9aabb..962f8e1b1e9 100644\n--- a/prototype/sky/resources.py\n+++ b/prototype/sky/resources.py\n@@ -61,6 +61,8 @@ def __init__(\n self.accelerator_args = accelerator_args\n self.use_spot = use_spot\n \n+ self._try_validate_accelerators()\n+\n def __repr__(self) -> str:\n accelerators = ''\n accelerator_args = ''\n@@ -77,6 +79,30 @@ def __repr__(self) -> str:\n def is_launchable(self) -> bool:\n return self.cloud is not None and self.instance_type is not None\n \n+ def _try_validate_accelerators(self) -> None:\n+ \"\"\"Try-validates accelerators against the instance type.\"\"\"\n+ if self.is_launchable() and not isinstance(self.cloud, clouds.GCP):\n+ # GCP attaches accelerators to VMs, so no need for this check.\n+ acc_requested = self.accelerators\n+ if acc_requested is None:\n+ return\n+ acc_from_instance_type = (\n+ self.cloud.get_accelerators_from_instance_type(\n+ self.instance_type))\n+ if not Resources(accelerators=acc_requested).less_demanding_than(\n+ Resources(accelerators=acc_from_instance_type)):\n+ raise ValueError(\n+ 'Infeasible resource demands found:\\n'\n+ f' Instance type requested: {self.instance_type}\\n'\n+ f' Accelerators for {self.instance_type}: '\n+ f'{acc_from_instance_type}\\n'\n+ f' Accelerators requested: {acc_requested}\\n'\n+ f'To fix: either only specify instance_type, or change '\n+ 'the accelerators field to be consistent.')\n+ # NOTE: should not clear 'self.accelerators' even for AWS/Azure,\n+ # because e.g., the instance may have 4 GPUs, while the task\n+ # specifies to use 1 GPU.\n+\n def get_accelerators(self) -> Optional[Dict[str, int]]:\n \"\"\"Returns the accelerators field directly or by inferring.\n \n@@ -116,8 +142,8 @@ def is_same_resources(self, other: 'Resources') -> bool:\n return False\n # self.cloud == other.cloud\n \n- if self.instance_type is not None and \\\n- self.instance_type != other.instance_type:\n+ if (self.instance_type is not None and\n+ self.instance_type != other.instance_type):\n return False\n # self.instance_type == other.instance_type\n \n@@ -141,8 +167,8 @@ def less_demanding_than(self, other: 'Resources') -> bool:\n return False\n # self.cloud <= other.cloud\n \n- if self.instance_type is not None and \\\n- self.instance_type != other.instance_type:\n+ if (self.instance_type is not None and\n+ self.instance_type != other.instance_type):\n return False\n # self.instance_type <= other.instance_type\n \ndiff --git a/prototype/tests/test_optimizer_dryruns.py b/prototype/tests/test_optimizer_dryruns.py\nindex 10bc6082848..ef5c9702f71 100644\n--- a/prototype/tests/test_optimizer_dryruns.py\n+++ b/prototype/tests/test_optimizer_dryruns.py\n@@ -1,7 +1,6 @@\n import pytest\n \n import sky\n-from sky import clouds\n \n \n def _test_resources(resources):\n@@ -9,19 +8,18 @@ def _test_resources(resources):\n train = sky.Task('train')\n train.set_resources({resources})\n sky.launch(dag, dryrun=True)\n- assert True\n \n \n def test_resources_aws():\n- _test_resources(sky.Resources(clouds.AWS(), 'p3.2xlarge'))\n+ _test_resources(sky.Resources(sky.AWS(), 'p3.2xlarge'))\n \n \n def test_resources_azure():\n- _test_resources(sky.Resources(clouds.Azure(), 'Standard_NC24s_v3'))\n+ _test_resources(sky.Resources(sky.Azure(), 'Standard_NC24s_v3'))\n \n \n def test_resources_gcp():\n- _test_resources(sky.Resources(clouds.GCP(), 'n1-standard-16'))\n+ _test_resources(sky.Resources(sky.GCP(), 'n1-standard-16'))\n \n \n def test_partial_k80():\n@@ -46,7 +44,39 @@ def test_partial_tpu():\n \n \n def test_partial_v100():\n- _test_resources(sky.Resources(clouds.AWS(), accelerators='V100'))\n+ _test_resources(sky.Resources(sky.AWS(), accelerators='V100'))\n+ _test_resources(sky.Resources(sky.AWS(), accelerators='V100',\n+ use_spot=True))\n+ _test_resources(sky.Resources(sky.AWS(), accelerators={'V100': 8}))\n+\n+\n+def test_instance_type_mistmatches_accelerators():\n+ bad_instance_and_accs = [\n+ # Actual: V100\n+ ('p3.2xlarge', 'K80'),\n+ # Actual: None\n+ ('m4.2xlarge', 'V100'),\n+ ]\n+ for instance, acc in bad_instance_and_accs:\n+ with pytest.raises(ValueError) as e:\n+ _test_resources(\n+ sky.Resources(sky.AWS(),\n+ instance_type=instance,\n+ accelerators=acc))\n+ assert 'Infeasible resource demands found' in str(e.value)\n+\n+\n+def test_instance_type_matches_accelerators():\n _test_resources(\n- sky.Resources(clouds.AWS(), accelerators='V100', use_spot=True))\n- _test_resources(sky.Resources(clouds.AWS(), accelerators={'V100': 8}))\n+ sky.Resources(sky.AWS(),\n+ instance_type='p3.2xlarge',\n+ accelerators='V100'))\n+ _test_resources(\n+ sky.Resources(sky.GCP(),\n+ instance_type='n1-standard-2',\n+ accelerators='V100'))\n+ # Partial use: Instance has 8 V100s, while the task needs 1 of them.\n+ _test_resources(\n+ sky.Resources(sky.AWS(),\n+ instance_type='p3.16xlarge',\n+ accelerators={'V100': 1}))\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 4,\n \"problem_domain\": \"Bug Fixes\"\n}"}}},{"rowIdx":7077,"cells":{"instance_id":{"kind":"string","value":"espnet__espnet-2509@1a08dc0"},"repo":{"kind":"string","value":"espnet/espnet"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":2509,"string":"2,509"},"title":{"kind":"string","value":"Docker Updates"},"body":{"kind":"string","value":"Updates on docker to fit the installation of ESpnet.\r\nThis will also fix PR #2508."},"created_at":{"kind":"string","value":"2020-09-24T01:54:00Z"},"problem_statement":{"kind":"string","value":"Docker build error\n# error content\r\n I got the error while building docker image\r\nI run these commands.\r\n- command\r\n```\r\ncd docker\r\n./build.sh fully_local cpu\r\n```\r\nbut the error was occared.\r\n- the error sentence\r\n```\r\nStep 14/16 : RUN if [ -z \"$( nvcc -V )\" ]; then echo \"Build without CUDA\" && MY_OPTS=\"CUPY_VERSION=\"; else echo \"Build with CUDA\" && export CFLAGS=\"-I${CUDA_HOME}/include ${CFLAGS}\" && MY_OPTS=\"CUDA_VERSION=${CUDA_VER}\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \"${CUDA_VER}\" = \"10.1\" ]; then MY_OPTS=\"${MY_OPTS} TH_VERSION=1.3.1\"; fi; echo \"Make with options ${MY_OPTS}\"; make KALDI=/kaldi ${MY_OPTS}\r\n ---> Running in 59da3674b2df\r\n/bin/sh: 1: nvcc: not found\r\nBuild without CUDA\r\nMake with options CUPY_VERSION=\r\nexpr: syntax error\r\ntest -f kaldi/egs/wsj/s5/utils/parse_options.sh || { echo -e \"Error: Put Kaldi here!\\n $ ln -s <kaldi-root> kaldi\"; exit 1; }\r\n-e Error: Put Kaldi here!\r\n $ ln -s <kaldi-root> kaldi\r\nMakefile:65: recipe for target 'kaldi' failed\r\nmake: *** [kaldi] Error 1\r\nThe command '/bin/sh -c if [ -z \"$( nvcc -V )\" ]; then echo \"Build without CUDA\" && MY_OPTS=\"CUPY_VERSION=\"; else echo \"Build with CUDA\" && export CFLAGS=\"-I${CUDA_HOME}/include ${CFLAGS}\" && MY_OPTS=\"CUDA_VERSION=${CUDA_VER}\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \"${CUDA_VER}\" = \"10.1\" ]; then MY_OPTS=\"${MY_OPTS} TH_VERSION=1.3.1\"; fi; echo \"Make with options ${MY_OPTS}\"; make KALDI=/kaldi ${MY_OPTS}' returned a non-zero code: 2\r\n```\r\n\r\n# My environment:\r\nOS: macOS Catalina. (I also tried on Ubuntu18.04, but the error was also happend.)\r\n\r\n# I followed the error message, but other error occared.\r\nI tried to add the command to Dokcerfile, but other error occard.\r\n- added the command to `docker/prebuilt/local/Dockerfile`\r\n```\r\nRUN ln -s /kaldi kaldi\r\n```\r\n\r\n- another error\r\n```\r\nStep 15/17 : RUN if [ -z \"$( nvcc -V )\" ]; then echo \"Build without CUDA\" && MY_OPTS=\"CUPY_VERSION=\"; else echo \"Build with CUDA\" && export CFLAGS=\"-I${CUDA_HOME}/include ${CFLAGS}\" && MY_OPTS=\"CUDA_VERSION=${CUDA_VER}\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \"${CUDA_VER}\" = \"10.1\" ]; then MY_OPTS=\"${MY_OPTS} TH_VERSION=1.3.1\"; fi; echo \"Make with options ${MY_OPTS}\"; make KALDI=/kaldi ${MY_OPTS}\r\n ---> Running in fabc99f97da5\r\nBuild without CUDA\r\nMake with options CUPY_VERSION=\r\n/bin/sh: 1: nvcc: not found\r\nexpr: syntax error\r\ntest -f activate_python.sh || { echo \"Error: Run ./setup_python.sh or ./setup_anaconda.sh\"; exit 1; }\r\nError: Run ./setup_python.sh or ./setup_anaconda.sh\r\nMakefile:68: recipe for target 'activate_python.sh' failed\r\nmake: *** [activate_python.sh] Error 1\r\nThe command '/bin/sh -c if [ -z \"$( nvcc -V )\" ]; then echo \"Build without CUDA\" && MY_OPTS=\"CUPY_VERSION=\"; else echo \"Build with CUDA\" && export CFLAGS=\"-I${CUDA_HOME}/include ${CFLAGS}\" && MY_OPTS=\"CUDA_VERSION=${CUDA_VER}\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \"${CUDA_VER}\" = \"10.1\" ]; then MY_OPTS=\"${MY_OPTS} TH_VERSION=1.3.1\"; fi; echo \"Make with options ${MY_OPTS}\"; make KALDI=/kaldi ${MY_OPTS}' returned a non-zero code: 2\r\n```\r\nAfter that, I tried to fix more following the error message, but error was still existed.\r\n\r\n- added the command to `docker/prebuilt/local/Dockerfile`\r\n```\r\nRUN ./setup_python.sh $(which python3)\r\n```\r\n\r\n- another error\r\n```\r\nStep 15/18 : RUN ./setup_python.sh $(which python3)\r\n ---> Running in 83f7d133da5d\r\n/usr/bin/pip3 doesn't exist.\r\nThe command '/bin/sh -c ./setup_python.sh $(which python3)' returned a non-zero code: 1\r\n```\r\n# I tried to fix and build was successed but installing ESPNet was imcomplete\r\n\r\n- added the command to `docker/prebuilt/local/Dockerfile`\r\n```\r\nRUN ./setup_anaconda.sh\r\n```\r\n\r\nAfter that, building images is sccessed with no error.\r\nbut there are not all of content in ESPNet\r\ne.g. espnet/espnet, espnet/utils and espnet/egs etc. are not existed.\r\n\r\n```\r\nls espnet\r\n```\r\n```\r\nCONTRIBUTING.md README.md doc espnet.egg-info setup.cfg test_utils\r\nLICENSE ci egs2 espnet2 setup.py tools\r\n```\r\n\r\n\r\n**If someone knows how to fix it, please advice me.**"},"hints_text":{"kind":"string","value":"@muramasa2 THe problem is that the docker was not updated for the new environment of ESPnet.\r\nIt has been new changes in the installation.\r\nI will upload the fixes for all docker containers.\n@Fhrozen I appreciate your support, thanks."},"resolved_issues":{"kind":"list like","value":[{"body":"# error content\r\n I got the error while building docker image\r\nI run these commands.\r\n- command\r\n```\r\ncd docker\r\n./build.sh fully_local cpu\r\n```\r\nbut the error was occared.\r\n- the error sentence\r\n```\r\nStep 14/16 : RUN if [ -z \"$( nvcc -V )\" ]; then echo \"Build without CUDA\" && MY_OPTS=\"CUPY_VERSION=\"; else echo \"Build with CUDA\" && export CFLAGS=\"-I${CUDA_HOME}/include ${CFLAGS}\" && MY_OPTS=\"CUDA_VERSION=${CUDA_VER}\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \"${CUDA_VER}\" = \"10.1\" ]; then MY_OPTS=\"${MY_OPTS} TH_VERSION=1.3.1\"; fi; echo \"Make with options ${MY_OPTS}\"; make KALDI=/kaldi ${MY_OPTS}\r\n ---> Running in 59da3674b2df\r\n/bin/sh: 1: nvcc: not found\r\nBuild without CUDA\r\nMake with options CUPY_VERSION=\r\nexpr: syntax error\r\ntest -f kaldi/egs/wsj/s5/utils/parse_options.sh || { echo -e \"Error: Put Kaldi here!\\n $ ln -s <kaldi-root> kaldi\"; exit 1; }\r\n-e Error: Put Kaldi here!\r\n $ ln -s <kaldi-root> kaldi\r\nMakefile:65: recipe for target 'kaldi' failed\r\nmake: *** [kaldi] Error 1\r\nThe command '/bin/sh -c if [ -z \"$( nvcc -V )\" ]; then echo \"Build without CUDA\" && MY_OPTS=\"CUPY_VERSION=\"; else echo \"Build with CUDA\" && export CFLAGS=\"-I${CUDA_HOME}/include ${CFLAGS}\" && MY_OPTS=\"CUDA_VERSION=${CUDA_VER}\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \"${CUDA_VER}\" = \"10.1\" ]; then MY_OPTS=\"${MY_OPTS} TH_VERSION=1.3.1\"; fi; echo \"Make with options ${MY_OPTS}\"; make KALDI=/kaldi ${MY_OPTS}' returned a non-zero code: 2\r\n```\r\n\r\n# My environment:\r\nOS: macOS Catalina. (I also tried on Ubuntu18.04, but the error was also happend.)\r\n\r\n# I followed the error message, but other error occared.\r\nI tried to add the command to Dokcerfile, but other error occard.\r\n- added the command to `docker/prebuilt/local/Dockerfile`\r\n```\r\nRUN ln -s /kaldi kaldi\r\n```\r\n\r\n- another error\r\n```\r\nStep 15/17 : RUN if [ -z \"$( nvcc -V )\" ]; then echo \"Build without CUDA\" && MY_OPTS=\"CUPY_VERSION=\"; else echo \"Build with CUDA\" && export CFLAGS=\"-I${CUDA_HOME}/include ${CFLAGS}\" && MY_OPTS=\"CUDA_VERSION=${CUDA_VER}\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \"${CUDA_VER}\" = \"10.1\" ]; then MY_OPTS=\"${MY_OPTS} TH_VERSION=1.3.1\"; fi; echo \"Make with options ${MY_OPTS}\"; make KALDI=/kaldi ${MY_OPTS}\r\n ---> Running in fabc99f97da5\r\nBuild without CUDA\r\nMake with options CUPY_VERSION=\r\n/bin/sh: 1: nvcc: not found\r\nexpr: syntax error\r\ntest -f activate_python.sh || { echo \"Error: Run ./setup_python.sh or ./setup_anaconda.sh\"; exit 1; }\r\nError: Run ./setup_python.sh or ./setup_anaconda.sh\r\nMakefile:68: recipe for target 'activate_python.sh' failed\r\nmake: *** [activate_python.sh] Error 1\r\nThe command '/bin/sh -c if [ -z \"$( nvcc -V )\" ]; then echo \"Build without CUDA\" && MY_OPTS=\"CUPY_VERSION=\"; else echo \"Build with CUDA\" && export CFLAGS=\"-I${CUDA_HOME}/include ${CFLAGS}\" && MY_OPTS=\"CUDA_VERSION=${CUDA_VER}\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \"${CUDA_VER}\" = \"10.1\" ]; then MY_OPTS=\"${MY_OPTS} TH_VERSION=1.3.1\"; fi; echo \"Make with options ${MY_OPTS}\"; make KALDI=/kaldi ${MY_OPTS}' returned a non-zero code: 2\r\n```\r\nAfter that, I tried to fix more following the error message, but error was still existed.\r\n\r\n- added the command to `docker/prebuilt/local/Dockerfile`\r\n```\r\nRUN ./setup_python.sh $(which python3)\r\n```\r\n\r\n- another error\r\n```\r\nStep 15/18 : RUN ./setup_python.sh $(which python3)\r\n ---> Running in 83f7d133da5d\r\n/usr/bin/pip3 doesn't exist.\r\nThe command '/bin/sh -c ./setup_python.sh $(which python3)' returned a non-zero code: 1\r\n```\r\n# I tried to fix and build was successed but installing ESPNet was imcomplete\r\n\r\n- added the command to `docker/prebuilt/local/Dockerfile`\r\n```\r\nRUN ./setup_anaconda.sh\r\n```\r\n\r\nAfter that, building images is sccessed with no error.\r\nbut there are not all of content in ESPNet\r\ne.g. espnet/espnet, espnet/utils and espnet/egs etc. are not existed.\r\n\r\n```\r\nls espnet\r\n```\r\n```\r\nCONTRIBUTING.md README.md doc espnet.egg-info setup.cfg test_utils\r\nLICENSE ci egs2 espnet2 setup.py tools\r\n```\r\n\r\n\r\n**If someone knows how to fix it, please advice me.**","number":2508,"title":"Docker build error"}],"string":"[\n {\n \"body\": \"# error content\\r\\n I got the error while building docker image\\r\\nI run these commands.\\r\\n- command\\r\\n```\\r\\ncd docker\\r\\n./build.sh fully_local cpu\\r\\n```\\r\\nbut the error was occared.\\r\\n- the error sentence\\r\\n```\\r\\nStep 14/16 : RUN if [ -z \\\"$( nvcc -V )\\\" ]; then echo \\\"Build without CUDA\\\" && MY_OPTS=\\\"CUPY_VERSION=\\\"; else echo \\\"Build with CUDA\\\" && export CFLAGS=\\\"-I${CUDA_HOME}/include ${CFLAGS}\\\" && MY_OPTS=\\\"CUDA_VERSION=${CUDA_VER}\\\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \\\"${CUDA_VER}\\\" = \\\"10.1\\\" ]; then MY_OPTS=\\\"${MY_OPTS} TH_VERSION=1.3.1\\\"; fi; echo \\\"Make with options ${MY_OPTS}\\\"; make KALDI=/kaldi ${MY_OPTS}\\r\\n ---> Running in 59da3674b2df\\r\\n/bin/sh: 1: nvcc: not found\\r\\nBuild without CUDA\\r\\nMake with options CUPY_VERSION=\\r\\nexpr: syntax error\\r\\ntest -f kaldi/egs/wsj/s5/utils/parse_options.sh || { echo -e \\\"Error: Put Kaldi here!\\\\n $ ln -s <kaldi-root> kaldi\\\"; exit 1; }\\r\\n-e Error: Put Kaldi here!\\r\\n $ ln -s <kaldi-root> kaldi\\r\\nMakefile:65: recipe for target 'kaldi' failed\\r\\nmake: *** [kaldi] Error 1\\r\\nThe command '/bin/sh -c if [ -z \\\"$( nvcc -V )\\\" ]; then echo \\\"Build without CUDA\\\" && MY_OPTS=\\\"CUPY_VERSION=\\\"; else echo \\\"Build with CUDA\\\" && export CFLAGS=\\\"-I${CUDA_HOME}/include ${CFLAGS}\\\" && MY_OPTS=\\\"CUDA_VERSION=${CUDA_VER}\\\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \\\"${CUDA_VER}\\\" = \\\"10.1\\\" ]; then MY_OPTS=\\\"${MY_OPTS} TH_VERSION=1.3.1\\\"; fi; echo \\\"Make with options ${MY_OPTS}\\\"; make KALDI=/kaldi ${MY_OPTS}' returned a non-zero code: 2\\r\\n```\\r\\n\\r\\n# My environment:\\r\\nOS: macOS Catalina. (I also tried on Ubuntu18.04, but the error was also happend.)\\r\\n\\r\\n# I followed the error message, but other error occared.\\r\\nI tried to add the command to Dokcerfile, but other error occard.\\r\\n- added the command to `docker/prebuilt/local/Dockerfile`\\r\\n```\\r\\nRUN ln -s /kaldi kaldi\\r\\n```\\r\\n\\r\\n- another error\\r\\n```\\r\\nStep 15/17 : RUN if [ -z \\\"$( nvcc -V )\\\" ]; then echo \\\"Build without CUDA\\\" && MY_OPTS=\\\"CUPY_VERSION=\\\"; else echo \\\"Build with CUDA\\\" && export CFLAGS=\\\"-I${CUDA_HOME}/include ${CFLAGS}\\\" && MY_OPTS=\\\"CUDA_VERSION=${CUDA_VER}\\\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \\\"${CUDA_VER}\\\" = \\\"10.1\\\" ]; then MY_OPTS=\\\"${MY_OPTS} TH_VERSION=1.3.1\\\"; fi; echo \\\"Make with options ${MY_OPTS}\\\"; make KALDI=/kaldi ${MY_OPTS}\\r\\n ---> Running in fabc99f97da5\\r\\nBuild without CUDA\\r\\nMake with options CUPY_VERSION=\\r\\n/bin/sh: 1: nvcc: not found\\r\\nexpr: syntax error\\r\\ntest -f activate_python.sh || { echo \\\"Error: Run ./setup_python.sh or ./setup_anaconda.sh\\\"; exit 1; }\\r\\nError: Run ./setup_python.sh or ./setup_anaconda.sh\\r\\nMakefile:68: recipe for target 'activate_python.sh' failed\\r\\nmake: *** [activate_python.sh] Error 1\\r\\nThe command '/bin/sh -c if [ -z \\\"$( nvcc -V )\\\" ]; then echo \\\"Build without CUDA\\\" && MY_OPTS=\\\"CUPY_VERSION=\\\"; else echo \\\"Build with CUDA\\\" && export CFLAGS=\\\"-I${CUDA_HOME}/include ${CFLAGS}\\\" && MY_OPTS=\\\"CUDA_VERSION=${CUDA_VER}\\\" && sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && sed -i 's|which nvidia-smi|which nvcc|g' Makefile; fi; if [ \\\"${CUDA_VER}\\\" = \\\"10.1\\\" ]; then MY_OPTS=\\\"${MY_OPTS} TH_VERSION=1.3.1\\\"; fi; echo \\\"Make with options ${MY_OPTS}\\\"; make KALDI=/kaldi ${MY_OPTS}' returned a non-zero code: 2\\r\\n```\\r\\nAfter that, I tried to fix more following the error message, but error was still existed.\\r\\n\\r\\n- added the command to `docker/prebuilt/local/Dockerfile`\\r\\n```\\r\\nRUN ./setup_python.sh $(which python3)\\r\\n```\\r\\n\\r\\n- another error\\r\\n```\\r\\nStep 15/18 : RUN ./setup_python.sh $(which python3)\\r\\n ---> Running in 83f7d133da5d\\r\\n/usr/bin/pip3 doesn't exist.\\r\\nThe command '/bin/sh -c ./setup_python.sh $(which python3)' returned a non-zero code: 1\\r\\n```\\r\\n# I tried to fix and build was successed but installing ESPNet was imcomplete\\r\\n\\r\\n- added the command to `docker/prebuilt/local/Dockerfile`\\r\\n```\\r\\nRUN ./setup_anaconda.sh\\r\\n```\\r\\n\\r\\nAfter that, building images is sccessed with no error.\\r\\nbut there are not all of content in ESPNet\\r\\ne.g. espnet/espnet, espnet/utils and espnet/egs etc. are not existed.\\r\\n\\r\\n```\\r\\nls espnet\\r\\n```\\r\\n```\\r\\nCONTRIBUTING.md README.md doc espnet.egg-info setup.cfg test_utils\\r\\nLICENSE ci egs2 espnet2 setup.py tools\\r\\n```\\r\\n\\r\\n\\r\\n**If someone knows how to fix it, please advice me.**\",\n \"number\": 2508,\n \"title\": \"Docker build error\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"180af1103997d4eb42ece85cdb92b049db5570c7"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"1a08dc0415ea255b6614119628a8aff1b8830469\",\n \"head_commit_message\": \"Update docker/prebuilt/devel/Dockerfile\",\n \"patch_to_review\": \"diff --git a/docker/prebuilt/devel/Dockerfile b/docker/prebuilt/devel/Dockerfile\\nindex 14d396ccd9b..55ddfdcdf90 100644\\n--- a/docker/prebuilt/devel/Dockerfile\\n+++ b/docker/prebuilt/devel/Dockerfile\\n@@ -18,21 +18,25 @@ WORKDIR /espnet/tools\\n # Disable cupy test\\n # Docker build does not load libcuda.so.1\\n # Replace nvidia-smi for nvcc because docker does not load nvidia-smi\\n-RUN if [ -z \\\"$( nvcc -V )\\\" ]; then \\\\\\n+RUN if [ -z \\\"$( which nvcc )\\\" ]; then \\\\\\n echo \\\"Build without CUDA\\\" && \\\\\\n- MY_OPTS=\\\"CUPY_VERSION=\\\"; \\\\\\n+ MY_OPTS='CUPY_VERSION=\\\"\\\" TH_VERSION=1.6.0'; \\\\\\n else \\\\\\n echo \\\"Build with CUDA\\\" && \\\\\\n+ # Docker containers cannot load cuda libs during build.\\n+ # So, their checks on cuda packages are disabled.\\n+ sed -i '200s|install.py|install.py --no-cuda --no-cupy |' Makefile && \\\\\\n export CFLAGS=\\\"-I${CUDA_HOME}/include ${CFLAGS}\\\" && \\\\\\n MY_OPTS=\\\"CUDA_VERSION=${CUDA_VER}\\\" && \\\\\\n- sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && \\\\\\n- sed -i 's|which nvidia-smi|which nvcc|g' Makefile; \\\\\\n+ . ./setup_cuda_env.sh /usr/local/cuda; \\\\\\n fi; \\\\ \\n if [ \\\"${CUDA_VER}\\\" = \\\"10.1\\\" ]; then \\\\\\n- # Pytorch 1.3.1 is not supported by warpctc\\n- MY_OPTS=\\\"${MY_OPTS} TH_VERSION=1.3.1\\\"; \\\\\\n+ # warpctc is not supported from Pytorch 1.3.1\\n+ MY_OPTS=\\\"${MY_OPTS} TH_VERSION=1.6.0\\\"; \\\\\\n fi; \\\\\\n- echo \\\"Make with options ${MY_OPTS}\\\"; \\\\\\n+ echo \\\"Make with options ${MY_OPTS}\\\" && \\\\\\n+ ln -s /kaldi ./ && \\\\\\n+ ./setup_anaconda.sh /miniconda espnet 3.7.4 && \\\\\\n make KALDI=/kaldi ${MY_OPTS}\\n \\n RUN rm -rf ../espnet\\ndiff --git a/docker/prebuilt/devel/gpu/10.1/cudnn7/Dockerfile b/docker/prebuilt/devel/gpu/10.1/cudnn7/Dockerfile\\nindex b0adc4c02e2..adcdace6628 100644\\n--- a/docker/prebuilt/devel/gpu/10.1/cudnn7/Dockerfile\\n+++ b/docker/prebuilt/devel/gpu/10.1/cudnn7/Dockerfile\\n@@ -37,7 +37,7 @@ ENV CUDA_HOME /usr/local/cuda\\n \\n ## FROM CUDA 10.1 runtime [https://gitlab.com/nvidia/cuda/blob/ubuntu18.04/10.1/runtime/Dockerfile]\\n \\n-ENV NCCL_VERSION 2.4.2\\n+ENV NCCL_VERSION 2.7.8\\n \\n RUN apt-get update && apt-get install -y --no-install-recommends \\\\\\n cuda-libraries-$CUDA_PKG_VERSION \\\\\\n@@ -49,13 +49,21 @@ RUN apt-get update && apt-get install -y --no-install-recommends \\\\\\n ## FROM CUDA 10.1 devel [https://gitlab.com/nvidia/cuda/blob/ubuntu18.04/10.1/devel/Dockerfile]\\n \\n RUN apt-get update && apt-get install -y --no-install-recommends \\\\\\n- cuda-libraries-dev-$CUDA_PKG_VERSION \\\\\\n cuda-nvml-dev-$CUDA_PKG_VERSION \\\\\\n- cuda-minimal-build-$CUDA_PKG_VERSION \\\\\\n cuda-command-line-tools-$CUDA_PKG_VERSION \\\\\\n- libnccl-dev=$NCCL_VERSION-1+cuda10.1 && \\\\\\n+ cuda-nvprof-$CUDA_PKG_VERSION \\\\\\n+ cuda-npp-dev-$CUDA_PKG_VERSION \\\\\\n+ cuda-libraries-dev-$CUDA_PKG_VERSION \\\\\\n+ cuda-minimal-build-$CUDA_PKG_VERSION \\\\\\n+ libcublas-dev=10.2.1.243-1 \\\\\\n+ libnccl-dev=2.7.8-1+cuda10.1 && \\\\\\n+ apt-mark hold libnccl-dev && \\\\\\n rm -rf /var/lib/apt/lists/*\\n \\n+# apt from auto upgrading the cublas package. See https://gitlab.com/nvidia/container-images/cuda/-/issues/88\\n+RUN apt-mark hold libcublas-dev\\n+\\n+\\n ENV LIBRARY_PATH /usr/local/cuda/lib64/stubs\\n \\n ## FROM CUDA 10.1-CUDNN 7 devel\\ndiff --git a/docker/prebuilt/local/Dockerfile b/docker/prebuilt/local/Dockerfile\\nindex 07cf5aa9e3a..23c3d3e5ee9 100644\\n--- a/docker/prebuilt/local/Dockerfile\\n+++ b/docker/prebuilt/local/Dockerfile\\n@@ -22,24 +22,27 @@ RUN cd espnet && \\\\\\n # Install espnet\\n WORKDIR /espnet/tools\\n \\n-# Disable cupy test\\n-# Docker build does not load libcuda.so.1\\n # Replace nvidia-smi for nvcc because docker does not load nvidia-smi\\n-RUN if [ -z \\\"$( nvcc -V )\\\" ]; then \\\\\\n+RUN if [ -z \\\"$( which nvcc )\\\" ]; then \\\\\\n echo \\\"Build without CUDA\\\" && \\\\\\n- MY_OPTS=\\\"CUPY_VERSION=\\\"; \\\\\\n+ MY_OPTS='CUPY_VERSION=\\\"\\\" TH_VERSION=1.6.0'; \\\\\\n else \\\\\\n echo \\\"Build with CUDA\\\" && \\\\\\n+ # Disable cupy test\\n+ # Docker build does not load libcuda.so.1\\n+ # So, they checks on cuda package are disable.\\n+ sed -i '200s|install.py|install.py --no-cuda --no-cupy |' Makefile && \\\\\\n export CFLAGS=\\\"-I${CUDA_HOME}/include ${CFLAGS}\\\" && \\\\\\n MY_OPTS=\\\"CUDA_VERSION=${CUDA_VER}\\\" && \\\\\\n- sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && \\\\\\n- sed -i 's|which nvidia-smi|which nvcc|g' Makefile; \\\\\\n+ . ./setup_cuda_env.sh /usr/local/cuda; \\\\\\n fi; \\\\ \\n if [ \\\"${CUDA_VER}\\\" = \\\"10.1\\\" ]; then \\\\\\n- # Pytorch 1.3.1 is not supported by warpctc\\n- MY_OPTS=\\\"${MY_OPTS} TH_VERSION=1.3.1\\\"; \\\\\\n+ # warpctc is not supported from Pytorch 1.3.1\\n+ MY_OPTS=\\\"${MY_OPTS} TH_VERSION=1.6.0\\\"; \\\\\\n fi; \\\\\\n- echo \\\"Make with options ${MY_OPTS}\\\"; \\\\\\n+ echo \\\"Make with options ${MY_OPTS}\\\" && \\\\\\n+ ln -s /kaldi ./ && \\\\\\n+ ./setup_anaconda.sh /miniconda espnet 3.7.4 && \\\\\\n make KALDI=/kaldi ${MY_OPTS}\\n \\n RUN rm -rf ../espnet\\ndiff --git a/docker/prebuilt/runtime/Dockerfile b/docker/prebuilt/runtime/Dockerfile\\nindex b8dc7cb5409..1e1bc66a12c 100644\\n--- a/docker/prebuilt/runtime/Dockerfile\\n+++ b/docker/prebuilt/runtime/Dockerfile\\n@@ -17,10 +17,12 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get -y install --no-ins\\n cmake \\\\\\n curl \\\\\\n flac \\\\\\n+ ffmpeg \\\\\\n gawk \\\\\\n gfortran \\\\\\n git \\\\\\n libtool \\\\\\n+ libsndfile1-dev \\\\\\n python2.7 \\\\\\n python3 \\\\\\n sox \\\\\\n@@ -49,6 +51,10 @@ RUN cd /kaldi/tools && \\\\\\n make depend -j${NUM_BUILD_CORES} && \\\\\\n make -j${NUM_BUILD_CORES} && \\\\\\n find /kaldi/src -name \\\"*.o\\\" -exec rm -f {} \\\\; && \\\\\\n- find /kaldi/src -name \\\"*.o\\\" -exec rm -f {} \\\\; \\n+ find /kaldi/src -name \\\"*.o\\\" -exec rm -f {} \\\\;\\n+\\n+RUN wget --tries=3 \\\"https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh\\\" -O miniconda.sh && \\\\\\n+ bash miniconda.sh -b -p /miniconda && \\\\\\n+ rm miniconda.sh\\n \\n WORKDIR /\\n\\\\ No newline at end of file\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -22,24 +22,27 @@ RUN cd espnet && \\\n # Install espnet\n WORKDIR /espnet/tools\n \n-# Disable cupy test\n-# Docker build does not load libcuda.so.1\n # Replace nvidia-smi for nvcc because docker does not load nvidia-smi\n-RUN if [ -z \"$( nvcc -V )\" ]; then \\\n+RUN if [ -z \"$( which nvcc )\" ]; then \\\n echo \"Build without CUDA\" && \\\n- MY_OPTS=\"CUPY_VERSION=\"; \\\n+ MY_OPTS='CUPY_VERSION=\"\" TH_VERSION=1.6.0'; \\\n else \\\n echo \"Build with CUDA\" && \\\n+ # Disable cupy test\n+ # Docker build does not load libcuda.so.1\n+ # So, they checks on cuda package are disable.","line":null,"original_line":33,"original_start_line":null,"path":"docker/prebuilt/local/Dockerfile","start_line":null,"text":"@user1:\n```suggestion\r\n # So, their checks on cuda packages are disabled.\r\n```"}],"string":"[\n {\n \"diff_hunk\": \"@@ -22,24 +22,27 @@ RUN cd espnet && \\\\\\n # Install espnet\\n WORKDIR /espnet/tools\\n \\n-# Disable cupy test\\n-# Docker build does not load libcuda.so.1\\n # Replace nvidia-smi for nvcc because docker does not load nvidia-smi\\n-RUN if [ -z \\\"$( nvcc -V )\\\" ]; then \\\\\\n+RUN if [ -z \\\"$( which nvcc )\\\" ]; then \\\\\\n echo \\\"Build without CUDA\\\" && \\\\\\n- MY_OPTS=\\\"CUPY_VERSION=\\\"; \\\\\\n+ MY_OPTS='CUPY_VERSION=\\\"\\\" TH_VERSION=1.6.0'; \\\\\\n else \\\\\\n echo \\\"Build with CUDA\\\" && \\\\\\n+ # Disable cupy test\\n+ # Docker build does not load libcuda.so.1\\n+ # So, they checks on cuda package are disable.\",\n \"line\": null,\n \"original_line\": 33,\n \"original_start_line\": null,\n \"path\": \"docker/prebuilt/local/Dockerfile\",\n \"start_line\": null,\n \"text\": \"@user1:\\n```suggestion\\r\\n # So, their checks on cuda packages are disabled.\\r\\n```\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"9b4da4b8fe6ed95e5c07a55b9e69eb75dc953f5e"},"merged_patch":{"kind":"string","value":"diff --git a/docker/prebuilt/devel/Dockerfile b/docker/prebuilt/devel/Dockerfile\nindex 14d396ccd9b..55ddfdcdf90 100644\n--- a/docker/prebuilt/devel/Dockerfile\n+++ b/docker/prebuilt/devel/Dockerfile\n@@ -18,21 +18,25 @@ WORKDIR /espnet/tools\n # Disable cupy test\n # Docker build does not load libcuda.so.1\n # Replace nvidia-smi for nvcc because docker does not load nvidia-smi\n-RUN if [ -z \"$( nvcc -V )\" ]; then \\\n+RUN if [ -z \"$( which nvcc )\" ]; then \\\n echo \"Build without CUDA\" && \\\n- MY_OPTS=\"CUPY_VERSION=\"; \\\n+ MY_OPTS='CUPY_VERSION=\"\" TH_VERSION=1.6.0'; \\\n else \\\n echo \"Build with CUDA\" && \\\n+ # Docker containers cannot load cuda libs during build.\n+ # So, their checks on cuda packages are disabled.\n+ sed -i '200s|install.py|install.py --no-cuda --no-cupy |' Makefile && \\\n export CFLAGS=\"-I${CUDA_HOME}/include ${CFLAGS}\" && \\\n MY_OPTS=\"CUDA_VERSION=${CUDA_VER}\" && \\\n- sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && \\\n- sed -i 's|which nvidia-smi|which nvcc|g' Makefile; \\\n+ . ./setup_cuda_env.sh /usr/local/cuda; \\\n fi; \\ \n if [ \"${CUDA_VER}\" = \"10.1\" ]; then \\\n- # Pytorch 1.3.1 is not supported by warpctc\n- MY_OPTS=\"${MY_OPTS} TH_VERSION=1.3.1\"; \\\n+ # warpctc is not supported from Pytorch 1.3.1\n+ MY_OPTS=\"${MY_OPTS} TH_VERSION=1.6.0\"; \\\n fi; \\\n- echo \"Make with options ${MY_OPTS}\"; \\\n+ echo \"Make with options ${MY_OPTS}\" && \\\n+ ln -s /kaldi ./ && \\\n+ ./setup_anaconda.sh /miniconda espnet 3.7.4 && \\\n make KALDI=/kaldi ${MY_OPTS}\n \n RUN rm -rf ../espnet\ndiff --git a/docker/prebuilt/devel/gpu/10.1/cudnn7/Dockerfile b/docker/prebuilt/devel/gpu/10.1/cudnn7/Dockerfile\nindex b0adc4c02e2..adcdace6628 100644\n--- a/docker/prebuilt/devel/gpu/10.1/cudnn7/Dockerfile\n+++ b/docker/prebuilt/devel/gpu/10.1/cudnn7/Dockerfile\n@@ -37,7 +37,7 @@ ENV CUDA_HOME /usr/local/cuda\n \n ## FROM CUDA 10.1 runtime [https://gitlab.com/nvidia/cuda/blob/ubuntu18.04/10.1/runtime/Dockerfile]\n \n-ENV NCCL_VERSION 2.4.2\n+ENV NCCL_VERSION 2.7.8\n \n RUN apt-get update && apt-get install -y --no-install-recommends \\\n cuda-libraries-$CUDA_PKG_VERSION \\\n@@ -49,13 +49,21 @@ RUN apt-get update && apt-get install -y --no-install-recommends \\\n ## FROM CUDA 10.1 devel [https://gitlab.com/nvidia/cuda/blob/ubuntu18.04/10.1/devel/Dockerfile]\n \n RUN apt-get update && apt-get install -y --no-install-recommends \\\n- cuda-libraries-dev-$CUDA_PKG_VERSION \\\n cuda-nvml-dev-$CUDA_PKG_VERSION \\\n- cuda-minimal-build-$CUDA_PKG_VERSION \\\n cuda-command-line-tools-$CUDA_PKG_VERSION \\\n- libnccl-dev=$NCCL_VERSION-1+cuda10.1 && \\\n+ cuda-nvprof-$CUDA_PKG_VERSION \\\n+ cuda-npp-dev-$CUDA_PKG_VERSION \\\n+ cuda-libraries-dev-$CUDA_PKG_VERSION \\\n+ cuda-minimal-build-$CUDA_PKG_VERSION \\\n+ libcublas-dev=10.2.1.243-1 \\\n+ libnccl-dev=2.7.8-1+cuda10.1 && \\\n+ apt-mark hold libnccl-dev && \\\n rm -rf /var/lib/apt/lists/*\n \n+# apt from auto upgrading the cublas package. See https://gitlab.com/nvidia/container-images/cuda/-/issues/88\n+RUN apt-mark hold libcublas-dev\n+\n+\n ENV LIBRARY_PATH /usr/local/cuda/lib64/stubs\n \n ## FROM CUDA 10.1-CUDNN 7 devel\ndiff --git a/docker/prebuilt/local/Dockerfile b/docker/prebuilt/local/Dockerfile\nindex 07cf5aa9e3a..15939185aff 100644\n--- a/docker/prebuilt/local/Dockerfile\n+++ b/docker/prebuilt/local/Dockerfile\n@@ -22,24 +22,27 @@ RUN cd espnet && \\\n # Install espnet\n WORKDIR /espnet/tools\n \n-# Disable cupy test\n-# Docker build does not load libcuda.so.1\n # Replace nvidia-smi for nvcc because docker does not load nvidia-smi\n-RUN if [ -z \"$( nvcc -V )\" ]; then \\\n+RUN if [ -z \"$( which nvcc )\" ]; then \\\n echo \"Build without CUDA\" && \\\n- MY_OPTS=\"CUPY_VERSION=\"; \\\n+ MY_OPTS='CUPY_VERSION=\"\" TH_VERSION=1.6.0'; \\\n else \\\n echo \"Build with CUDA\" && \\\n+ # Disable cupy test\n+ # Docker build does not load libcuda.so.1\n+ # So, their checks on cuda packages are disabled.\n+ sed -i '200s|install.py|install.py --no-cuda --no-cupy |' Makefile && \\\n export CFLAGS=\"-I${CUDA_HOME}/include ${CFLAGS}\" && \\\n MY_OPTS=\"CUDA_VERSION=${CUDA_VER}\" && \\\n- sed -i 's|_install.py|_install.py --no-cuda|g' Makefile && \\\n- sed -i 's|which nvidia-smi|which nvcc|g' Makefile; \\\n+ . ./setup_cuda_env.sh /usr/local/cuda; \\\n fi; \\ \n if [ \"${CUDA_VER}\" = \"10.1\" ]; then \\\n- # Pytorch 1.3.1 is not supported by warpctc\n- MY_OPTS=\"${MY_OPTS} TH_VERSION=1.3.1\"; \\\n+ # warpctc is not supported from Pytorch 1.3.1\n+ MY_OPTS=\"${MY_OPTS} TH_VERSION=1.6.0\"; \\\n fi; \\\n- echo \"Make with options ${MY_OPTS}\"; \\\n+ echo \"Make with options ${MY_OPTS}\" && \\\n+ ln -s /kaldi ./ && \\\n+ ./setup_anaconda.sh /miniconda espnet 3.7.4 && \\\n make KALDI=/kaldi ${MY_OPTS}\n \n RUN rm -rf ../espnet\ndiff --git a/docker/prebuilt/runtime/Dockerfile b/docker/prebuilt/runtime/Dockerfile\nindex b8dc7cb5409..1e1bc66a12c 100644\n--- a/docker/prebuilt/runtime/Dockerfile\n+++ b/docker/prebuilt/runtime/Dockerfile\n@@ -17,10 +17,12 @@ RUN DEBIAN_FRONTEND=noninteractive apt-get update && apt-get -y install --no-ins\n cmake \\\n curl \\\n flac \\\n+ ffmpeg \\\n gawk \\\n gfortran \\\n git \\\n libtool \\\n+ libsndfile1-dev \\\n python2.7 \\\n python3 \\\n sox \\\n@@ -49,6 +51,10 @@ RUN cd /kaldi/tools && \\\n make depend -j${NUM_BUILD_CORES} && \\\n make -j${NUM_BUILD_CORES} && \\\n find /kaldi/src -name \"*.o\" -exec rm -f {} \\; && \\\n- find /kaldi/src -name \"*.o\" -exec rm -f {} \\; \n+ find /kaldi/src -name \"*.o\" -exec rm -f {} \\;\n+\n+RUN wget --tries=3 \"https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh\" -O miniconda.sh && \\\n+ bash miniconda.sh -b -p /miniconda && \\\n+ rm miniconda.sh\n \n WORKDIR /\n\\ No newline at end of file\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 3,\n \"problem_domain\": \"Dependency Updates & Env Compatibility\"\n}"}}},{"rowIdx":7078,"cells":{"instance_id":{"kind":"string","value":"skypilot-org__skypilot-49@1fa7fec"},"repo":{"kind":"string","value":"skypilot-org/skypilot"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":49,"string":"49"},"title":{"kind":"string","value":"Add logging for execution_v2"},"body":{"kind":"string","value":"Added the logging for the execution_v2 (as in #25 ). The behavior would be as follows:\r\n1. All the provision information/task output will be written to files so that users can tail the files for the output.\r\n2. If the `stream_logs` is set to true, the output provision logs will be streamed to the console if the `Shared connection to` appears in the output, so that only the succeeded `ray up`'s output will be shown in the console."},"created_at":{"kind":"string","value":"2021-11-20T09:46:02Z"},"problem_statement":{"kind":"string","value":"Stream logs to files during VM provisioning and setup\nIs it expected behavior that there is no output for VM setup during provisioning? I think it might be hard for the user to debug for the setup commends. Also, I failed to find the output anywhere as a file.\r\n\r\nI am running `python ./examples/resnet_app.py`, and the output is as below.\r\n```\r\nI 11-12 10:57:38 cloud_vm_ray_backend.py:213] If this takes longer than ~30 seconds, provisioning is likely successful. Setting up may take a few minutes.\r\nI 11-12 10:57:38 backend_utils.py:38] Created or updated file config/aws-ray.yml\r\nI 11-12 11:02:52 cloud_vm_ray_backend.py:238] Successfully provisioned or found existing VM(s). Setup completed.\r\n```"},"hints_text":{"kind":"string","value":"Yes, expected to not show, although we can change. The rationale is if you print ray up's stdout/stderr, and if you have retries, that will be very crowded. Give it a try by setting a p3.16x requirement.\r\n\r\nWe could try to write the stdout/stderr (captured in variables) to files. This is similar to V1's logging.\nWe should at least stream the logs to files and tell user to `tail -F path/to/logfile` if they're curious about progress. When I try it now I have to stare at a blank screen for 10 minutes with no progress:\r\n\r\n```\r\nI 11-16 19:37:15 cloud_vm_ray_backend.py:210] Launching on AWS us-west-2 (us-west-2a,us-west-2b,us-west-2c,us-west-2d).\r\nI 11-16 19:37:15 cloud_vm_ray_backend.py:213] If this takes longer than ~30 seconds, provisioning is likely successful. Setting up may take a few minutes.\r\nI 11-16 19:37:15 backend_utils.py:38] Created or updated file config/aws-ray.yml\r\n\r\n```\n+1 to stream to a file and hint on tail -f."},"resolved_issues":{"kind":"list like","value":[{"body":"Is it expected behavior that there is no output for VM setup during provisioning? I think it might be hard for the user to debug for the setup commends. Also, I failed to find the output anywhere as a file.\r\n\r\nI am running `python ./examples/resnet_app.py`, and the output is as below.\r\n```\r\nI 11-12 10:57:38 cloud_vm_ray_backend.py:213] If this takes longer than ~30 seconds, provisioning is likely successful. Setting up may take a few minutes.\r\nI 11-12 10:57:38 backend_utils.py:38] Created or updated file config/aws-ray.yml\r\nI 11-12 11:02:52 cloud_vm_ray_backend.py:238] Successfully provisioned or found existing VM(s). Setup completed.\r\n```","number":25,"title":"Stream logs to files during VM provisioning and setup"}],"string":"[\n {\n \"body\": \"Is it expected behavior that there is no output for VM setup during provisioning? I think it might be hard for the user to debug for the setup commends. Also, I failed to find the output anywhere as a file.\\r\\n\\r\\nI am running `python ./examples/resnet_app.py`, and the output is as below.\\r\\n```\\r\\nI 11-12 10:57:38 cloud_vm_ray_backend.py:213] If this takes longer than ~30 seconds, provisioning is likely successful. Setting up may take a few minutes.\\r\\nI 11-12 10:57:38 backend_utils.py:38] Created or updated file config/aws-ray.yml\\r\\nI 11-12 11:02:52 cloud_vm_ray_backend.py:238] Successfully provisioned or found existing VM(s). Setup completed.\\r\\n```\",\n \"number\": 25,\n \"title\": \"Stream logs to files during VM provisioning and setup\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"e6af21aa3a5a338a08a1eb6c0c199675ada014e2"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"1fa7fec10fe18aeee823e959fa2a58ca3b3423f5\",\n \"head_commit_message\": \"Fix tail -f information for provision\",\n \"patch_to_review\": \"diff --git a/prototype/sky/backends/backend.py b/prototype/sky/backends/backend.py\\nindex 4a37b0ec685..0ec810d27dd 100644\\n--- a/prototype/sky/backends/backend.py\\n+++ b/prototype/sky/backends/backend.py\\n@@ -17,8 +17,8 @@ class Backend(object):\\n # Examples: 'cluster.yaml'; 'ray://...', 'k8s://...'.\\n ResourceHandle = Any\\n \\n- def provision(self, task: App, to_provision: Resources,\\n- dryrun: bool) -> ResourceHandle:\\n+ def provision(self, task: App, to_provision: Resources, dryrun: bool,\\n+ stream_logs: bool) -> ResourceHandle:\\n raise NotImplementedError\\n \\n def sync_workdir(self, handle: ResourceHandle, workdir: Path) -> None:\\ndiff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\\nindex 6f9105c0145..7a0e6de051c 100644\\n--- a/prototype/sky/backends/backend_utils.py\\n+++ b/prototype/sky/backends/backend_utils.py\\n@@ -1,6 +1,8 @@\\n \\\"\\\"\\\"Util constants/functions for the backends.\\\"\\\"\\\"\\n import datetime\\n+import io\\n import os\\n+import selectors\\n import subprocess\\n import tempfile\\n import textwrap\\n@@ -24,6 +26,7 @@\\n # NOTE: keep in sync with the cluster template 'file_mounts'.\\n SKY_REMOTE_WORKDIR = '/tmp/workdir'\\n IP_ADDR_REGEX = r'\\\\d{1,3}\\\\.\\\\d{1,3}\\\\.\\\\d{1,3}\\\\.\\\\d{1,3}'\\n+SKY_LOGS_DIRECTORY = './sky_logs'\\n \\n \\n def _fill_template(template_path: str,\\n@@ -224,3 +227,38 @@ def run_command_on_ip_via_ssh(ip: str,\\n if errs:\\n logger.error(errs)\\n raise subprocess.CalledProcessError(proc.returncode, cmd)\\n+\\n+\\n+def redirect_process_output(proc, log_path, stream_logs, start_streaming_at=''):\\n+ \\\"\\\"\\\"Redirect the process's filtered stdout/stderr to both stream and file\\\"\\\"\\\"\\n+ dirname = os.path.dirname(log_path)\\n+ os.makedirs(dirname, exist_ok=True)\\n+\\n+ out_io = io.TextIOWrapper(proc.stdout, encoding='utf-8', newline='')\\n+ err_io = io.TextIOWrapper(proc.stderr, encoding='utf-8', newline='')\\n+ sel = selectors.DefaultSelector()\\n+ sel.register(out_io, selectors.EVENT_READ)\\n+ sel.register(err_io, selectors.EVENT_READ)\\n+\\n+ stdout = ''\\n+ stderr = ''\\n+\\n+ start_streaming_flag = False\\n+ with open(log_path, 'a') as fout:\\n+ while True:\\n+ for key, _ in sel.select():\\n+ line = key.fileobj.readline()\\n+ if not line:\\n+ return stdout, stderr\\n+ if start_streaming_at in line:\\n+ start_streaming_flag = True\\n+ if key.fileobj is out_io:\\n+ stdout += line\\n+ fout.write(line)\\n+ fout.flush()\\n+ else:\\n+ stderr += line\\n+ fout.write(line)\\n+ fout.flush()\\n+ if stream_logs and start_streaming_flag:\\n+ print(line, end='')\\ndiff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py\\nindex 7a01f0e0192..6306ba0f39c 100644\\n--- a/prototype/sky/backends/cloud_vm_ray_backend.py\\n+++ b/prototype/sky/backends/cloud_vm_ray_backend.py\\n@@ -26,9 +26,57 @@\\n Path = str\\n PostSetupFn = Callable[[str], Any]\\n SKY_REMOTE_WORKDIR = backend_utils.SKY_REMOTE_WORKDIR\\n+SKY_LOGS_DIRECTORY = backend_utils.SKY_LOGS_DIRECTORY\\n \\n logger = logging.init_logger(__name__)\\n \\n+TASK_LAUNCH_CODE_GENERATOR = \\\"\\\"\\\"\\n+ import io\\n+ import os\\n+ import ray\\n+ import selectors\\n+ import subprocess\\n+ ray.init('auto', namespace='__sky__', log_to_driver={stream_logs})\\n+ print('cluster_resources:', ray.cluster_resources())\\n+ print('available_resources:', ray.available_resources())\\n+ print('live nodes:', ray.state.node_ids())\\n+ \\n+ def redirect_process_output(proc, log_path, stream_logs, start_streaming_at=''):\\n+ dirname = os.path.dirname(log_path)\\n+ os.makedirs(dirname, exist_ok=True)\\n+\\n+ out_io = io.TextIOWrapper(proc.stdout, encoding='utf-8', newline='')\\n+ err_io = io.TextIOWrapper(proc.stderr, encoding='utf-8', newline='')\\n+ sel = selectors.DefaultSelector()\\n+ sel.register(out_io, selectors.EVENT_READ)\\n+ sel.register(err_io, selectors.EVENT_READ)\\n+\\n+ stdout = ''\\n+ stderr = ''\\n+\\n+ start_streaming_flag = False\\n+ with open(log_path, 'a') as fout:\\n+ while True:\\n+ for key, _ in sel.select():\\n+ line = key.fileobj.readline()\\n+ if not line:\\n+ return stdout, stderr\\n+ if start_streaming_at in line:\\n+ start_streaming_flag = True\\n+ if key.fileobj is out_io:\\n+ stdout += line\\n+ fout.write(line)\\n+ fout.flush()\\n+ else:\\n+ stderr += line\\n+ fout.write(line)\\n+ fout.flush()\\n+ if stream_logs and start_streaming_flag:\\n+ print(line, end='')\\n+ \\n+ futures = []\\n+ \\\"\\\"\\\"\\n+\\n \\n def _run(cmd, **kwargs):\\n return subprocess.run(cmd, shell=True, check=True, **kwargs)\\n@@ -38,6 +86,21 @@ def _run_no_outputs(cmd, **kwargs):\\n return _run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, **kwargs)\\n \\n \\n+def _run_with_log(cmd,\\n+ log_path,\\n+ stream_logs=False,\\n+ start_streaming_at='',\\n+ **kwargs):\\n+ proc = subprocess.Popen(cmd,\\n+ stdout=subprocess.PIPE,\\n+ stderr=subprocess.PIPE,\\n+ **kwargs)\\n+ stdout, stderr = backend_utils.redirect_process_output(\\n+ proc, log_path, stream_logs, start_streaming_at=start_streaming_at)\\n+ proc.wait()\\n+ return proc, stdout, stderr\\n+\\n+\\n def _get_cluster_config_template(task):\\n _CLOUD_TO_TEMPLATE = {\\n clouds.AWS: 'config/aws-ray.yml.j2',\\n@@ -64,9 +127,10 @@ def _to_accelerator_and_count(resources: Optional[Resources]\\n class RetryingVmProvisioner(object):\\n \\\"\\\"\\\"A provisioner that retries different regions/zones within a cloud.\\\"\\\"\\\"\\n \\n- def __init__(self):\\n+ def __init__(self, log_dir):\\n self._blocked_regions = set()\\n self._blocked_zones = set()\\n+ self.log_dir = log_dir\\n colorama.init()\\n \\n def _in_blocklist(self, cloud, region, zones):\\n@@ -86,7 +150,6 @@ def _update_blocklist_on_gcp_error(self, region, zones, stdout, stderr):\\n Style = colorama.Style\\n assert len(zones) == 1, zones\\n zone = zones[0]\\n- stderr = stderr.decode()\\n splits = stderr.split('\\\\n')\\n exception_str = [s for s in splits if s.startswith('Exception: ')]\\n if len(exception_str) == 1:\\n@@ -116,7 +179,7 @@ def _update_blocklist_on_gcp_error(self, region, zones, stdout, stderr):\\n self._blocked_zones.add(zone.name)\\n else:\\n logger.info('====== stdout ======')\\n- for s in stdout.decode().split('\\\\n'):\\n+ for s in stdout.split('\\\\n'):\\n print(s)\\n logger.info('====== stderr ======')\\n for s in splits:\\n@@ -128,8 +191,8 @@ def _update_blocklist_on_aws_error(self, region, zones, stdout, stderr):\\n # The underlying ray autoscaler / boto3 will try all zones of a region\\n # at once.\\n Style = colorama.Style\\n- stdout_splits = stdout.decode().split('\\\\n')\\n- stderr_splits = stderr.decode().split('\\\\n')\\n+ stdout_splits = stdout.split('\\\\n')\\n+ stderr_splits = stderr.split('\\\\n')\\n errors = [\\n s.strip()\\n for s in stdout_splits + stderr_splits\\n@@ -200,8 +263,12 @@ def _yield_region_zones(self, task: App, cloud: clouds.Cloud):\\n yield (region, zones)\\n \\n def provision_with_retries(self, task: App, to_provision: Resources,\\n- dryrun: bool):\\n+ dryrun: bool, stream_logs: bool):\\n \\\"\\\"\\\"The provision retry loop.\\\"\\\"\\\"\\n+ # Get log_path name\\n+ log_path = os.path.join(self.log_dir, 'provision.log')\\n+ log_abs_path = os.path.abspath(log_path)\\n+\\n self._clear_blocklist()\\n Style = colorama.Style\\n for region, zones in self._yield_region_zones(task, to_provision.cloud):\\n@@ -243,11 +310,17 @@ def provision_with_retries(self, task: App, to_provision: Resources,\\n logger.error(stderr)\\n raise e\\n cluster_config_file = config_dict['ray']\\n- # Captures stdout/err. Otherwise, too many repeated messages.\\n- proc = subprocess.Popen(['ray', 'up', '-y', cluster_config_file],\\n- stdout=subprocess.PIPE,\\n- stderr=subprocess.PIPE)\\n- stdout, stderr = proc.communicate()\\n+\\n+ tail_cmd = f'tail -n100 -f {log_path}'\\n+ logger.info(\\n+ f'To view progress: {Style.BRIGHT}{tail_cmd}{Style.RESET_ALL}')\\n+ # Redirect stdout/err to the file and streaming (if stream_logs).\\n+ proc, stdout, stderr = _run_with_log(\\n+ ['ray', 'up', '-y', cluster_config_file],\\n+ log_abs_path,\\n+ stream_logs,\\n+ start_streaming_at='Shared connection to')\\n+\\n if proc.returncode != 0:\\n self._update_blocklist_on_error(to_provision.cloud, region,\\n zones, stdout, stderr)\\n@@ -290,14 +363,17 @@ class CloudVmRayBackend(backends.Backend):\\n def __init__(self):\\n # TODO: should include this as part of the handle.\\n self._managed_tpu = None\\n+ run_id = backend_utils.get_run_id()\\n+ self.log_dir = os.path.join(SKY_LOGS_DIRECTORY, run_id)\\n+ os.makedirs(self.log_dir, exist_ok=True)\\n \\n- def provision(self, task: App, to_provision: Resources,\\n- dryrun: bool) -> ResourceHandle:\\n+ def provision(self, task: App, to_provision: Resources, dryrun: bool,\\n+ stream_logs: bool) -> ResourceHandle:\\n \\\"\\\"\\\"Provisions using 'ray up'.\\\"\\\"\\\"\\n # ray up: the VMs.\\n- provisioner = RetryingVmProvisioner()\\n+ provisioner = RetryingVmProvisioner(self.log_dir)\\n config_dict = provisioner.provision_with_retries(\\n- task, to_provision, dryrun)\\n+ task, to_provision, dryrun, stream_logs)\\n if dryrun:\\n return\\n cluster_config_file = config_dict['ray']\\n@@ -371,16 +447,11 @@ def _execute_par_task(self, handle: ResourceHandle,\\n # manipulating the futures).\\n #\\n # TODO: possible to open the port in the yaml? Run Ray inside docker?\\n+ log_dir = os.path.join(f'{SKY_REMOTE_WORKDIR}', f'{self.log_dir}',\\n+ 'tasks')\\n codegen = [\\n- textwrap.dedent(f\\\"\\\"\\\"\\\\\\n- import ray\\n- import subprocess\\n- ray.init('auto', namespace='__sky__', log_to_driver={stream_logs})\\n- print('cluster_resources:', ray.cluster_resources())\\n- print('available_resources:', ray.available_resources())\\n- print('live nodes:', ray.state.node_ids())\\n- futures = []\\n- \\\"\\\"\\\")\\n+ textwrap.dedent(\\n+ TASK_LAUNCH_CODE_GENERATOR.format(stream_logs=stream_logs))\\n ]\\n for i, t in enumerate(par_task.tasks):\\n # '. $(conda info --base)/etc/profile.d/conda.sh || true' is used to initialize\\n@@ -404,10 +475,17 @@ def _execute_par_task(self, handle: ResourceHandle,\\n resources_str = ''\\n num_gpus_str = ''\\n name = f'task-{i}' if t.name is None else t.name\\n+ log_path = os.path.join(f'{log_dir}', f'{name}.log')\\n+\\n task_i_codegen = textwrap.dedent(f\\\"\\\"\\\"\\\\\\n- futures.append(ray.remote(lambda: subprocess.run(\\n- {cmd},\\n- shell=True, check=True, executable='/bin/bash')) \\\\\\\\\\n+ def start_task():\\n+ proc = subprocess.Popen({cmd},\\n+ stdout=subprocess.PIPE,\\n+ stderr=subprocess.PIPE,\\n+ shell=True,\\n+ executable='/bin/bash')\\n+ redirect_process_output(proc, '{log_path}', {stream_logs})\\n+ futures.append(ray.remote(start_task) \\\\\\\\\\n .options(name='{name}'{resources_str}{num_gpus_str}) \\\\\\\\\\n .remote())\\n \\\"\\\"\\\")\\n@@ -424,10 +502,17 @@ def _execute_par_task(self, handle: ResourceHandle,\\n if not stream_logs:\\n logger.info(\\n f'{Fore.CYAN}Logs will not be streamed (stream_logs=False).'\\n- f'{Style.RESET_ALL} Hint: in the run command, redirect each'\\n- ' task\\\\'s output to a file, and use `tail -f` to monitor.\\\\n')\\n+ f'{Style.RESET_ALL} Hint: task\\\\'s output will be redirect to'\\n+ f'{Style.BRIGHT} {log_dir} {Style.RESET_ALL}. Please use'\\n+ '`ray attach` and `tail -f` to monitor.\\\\n')\\n \\n self._exec_code_on_head(handle, codegen)\\n+ task_log_dir = os.path.join(f'{self.log_dir}', 'tasks')\\n+ logger.info(\\n+ f'Syncing down the loggings to {Style.BRIGHT}{task_log_dir}{Style.RESET_ALL}.'\\n+ )\\n+ os.makedirs(task_log_dir, exist_ok=True)\\n+ _run(f'ray rsync_down {handle} {log_dir}/* {task_log_dir}')\\n \\n def _exec_code_on_head(self,\\n handle: ResourceHandle,\\n@@ -447,15 +532,14 @@ def _exec_code_on_head(self,\\n executable = 'python3'\\n cd = f'cd {SKY_REMOTE_WORKDIR}'\\n cmd = f'ray exec {handle} \\\\'{cd} && {executable} /tmp/{basename}\\\\''\\n+ log_path = os.path.join(self.log_dir, f'run.log')\\n if not stream_logs:\\n- out = tempfile.NamedTemporaryFile('w', prefix='sky_',\\n- suffix='.out').name\\n- cmd += f' >{out}'\\n colorama.init()\\n Style = colorama.Style\\n logger.info(f'Redirecting stdout, to monitor: '\\n- f'{Style.BRIGHT}tail -f {out}{Style.RESET_ALL}')\\n- _run(cmd)\\n+ f'{Style.BRIGHT}tail -f {log_path}{Style.RESET_ALL}')\\n+\\n+ _run_with_log(cmd, log_path, stream_logs, shell=True)\\n \\n def execute(self, handle: ResourceHandle, task: App,\\n stream_logs: bool) -> None:\\n@@ -485,7 +569,7 @@ def _execute_task_one_node(self, handle: ResourceHandle, task: App,\\n f'Task(run=...) should be a string (found {type(task.run)}).'\\n codegen = textwrap.dedent(f\\\"\\\"\\\"\\\\\\n #!/bin/bash\\n- . $(conda info --base)/etc/profile.d/conda.sh\\n+ . $(conda info --base)/etc/profile.d/conda.sh || true\\n {task.run}\\n \\\"\\\"\\\")\\n self._exec_code_on_head(handle, codegen, stream_logs, executable='bash')\\n@@ -496,16 +580,11 @@ def _execute_task_n_nodes(self, handle: ResourceHandle, task: App,\\n # ray.init(..., log_to_driver=False); otherwise too many logs.\\n # for node:\\n # submit _run_cmd(cmd) with resource {node_i: 1}\\n+ log_dir = os.path.join(f'{SKY_REMOTE_WORKDIR}', f'{self.log_dir}',\\n+ 'tasks')\\n codegen = [\\n- textwrap.dedent(f\\\"\\\"\\\"\\\\\\n- import subprocess\\n- import ray\\n- ray.init('auto', namespace='__sky__', log_to_driver={stream_logs})\\n- print('cluster_resources:', ray.cluster_resources())\\n- print('available_resources:', ray.available_resources())\\n- print('live nodes:', ray.state.node_ids())\\n- futures = []\\n- \\\"\\\"\\\")\\n+ textwrap.dedent(\\n+ TASK_LAUNCH_CODE_GENERATOR.format(stream_logs=stream_logs))\\n ]\\n acc, acc_count = _to_accelerator_and_count(task.best_resources)\\n # Get private ips here as Ray internally uses 'node:private_ip' as\\n@@ -533,13 +612,21 @@ def _execute_task_n_nodes(self, handle: ResourceHandle, task: App,\\n num_gpus_str = f', num_gpus={acc_count}'\\n # Set the executable to /bin/bash, so that the 'source ~/.bashrc'\\n # and 'source activate conda_env' can be used.\\n+ name = f'task-{ip}'\\n+ log_path = os.path.join(f'{log_dir}', f'{name}.log')\\n+\\n codegen.append(\\n textwrap.dedent(f\\\"\\\"\\\"\\\\\\n- futures.append(ray.remote(lambda: subprocess.run(\\n- {cmd},\\n- shell=True, check=True, executable='/bin/bash')) \\\\\\\\\\n- .options(name='task-{ip}'{resources_str}{num_gpus_str}) \\\\\\\\\\n- .remote())\\n+ def start_task():\\n+ proc = subprocess.Popen({cmd},\\n+ stdout=subprocess.PIPE,\\n+ stderr=subprocess.PIPE,\\n+ shell=True,\\n+ executable='/bin/bash')\\n+ redirect_process_output(proc, '{log_path}', {stream_logs})\\n+ futures.append(ray.remote(start_task) \\\\\\\\\\n+ .options(name='{name}'{resources_str}{num_gpus_str}) \\\\\\\\\\n+ .remote())\\n \\\"\\\"\\\"))\\n # Block.\\n codegen.append('ray.get(futures)\\\\n')\\n@@ -552,9 +639,17 @@ def _execute_task_n_nodes(self, handle: ResourceHandle, task: App,\\n if not stream_logs:\\n logger.info(\\n f'{Fore.CYAN}Logs will not be streamed (stream_logs=False).'\\n- f'{Style.RESET_ALL} Hint: in the run command, redirect each'\\n- ' task\\\\'s output to a file, and use `tail -f` to monitor.\\\\n')\\n+ f'{Style.RESET_ALL} Hint: task\\\\'s output will be redirect to'\\n+ f'{Style.BRIGHT} {log_dir} {Style.RESET_ALL}. Please use'\\n+ '`ray attach` and `tail -f` to monitor.\\\\n')\\n+\\n self._exec_code_on_head(handle, codegen)\\n+ task_log_dir = os.path.join(f'{self.log_dir}', 'tasks')\\n+ logger.info(\\n+ f'Syncing down the loggings to {Style.BRIGHT}{task_log_dir}{Style.RESET_ALL}.'\\n+ )\\n+ os.makedirs(task_log_dir, exist_ok=True)\\n+ _run(f'ray rsync_down {handle} {log_dir}/* {task_log_dir}')\\n \\n def post_execute(self, handle: ResourceHandle, teardown: bool) -> None:\\n colorama.init()\\ndiff --git a/prototype/sky/execution.py b/prototype/sky/execution.py\\nindex 12185b93c89..011e7f1c5a9 100644\\n--- a/prototype/sky/execution.py\\n+++ b/prototype/sky/execution.py\\n@@ -341,7 +341,10 @@ def execute_v2(dag: sky.Dag,\\n # Future backends: K8S, SLURM, VM, LOCAL, LOCAL_DOCKER, etc.\\n backend = backends.CloudVmRayBackend()\\n \\n- handle = backend.provision(task, best_resources, dryrun=dryrun)\\n+ handle = backend.provision(task,\\n+ best_resources,\\n+ dryrun=dryrun,\\n+ stream_logs=stream_logs)\\n if dryrun:\\n logger.info('Dry run finished.')\\n return\\ndiff --git a/prototype/sky/logging.py b/prototype/sky/logging.py\\nindex 6e230e02cb7..41aee47208d 100644\\n--- a/prototype/sky/logging.py\\n+++ b/prototype/sky/logging.py\\n@@ -1,12 +1,12 @@\\n-import sys\\n import logging\\n+import sys\\n \\n FORMAT = '%(levelname).1s %(asctime)s %(filename)s:%(lineno)d] %(message)s'\\n DATE_FORMAT = '%m-%d %H:%M:%S'\\n \\n \\n class NewLineFormatter(logging.Formatter):\\n-\\n+ \\\"\\\"\\\"Add logging prefix to the newlines to align multi-line logging messages\\\"\\\"\\\"\\n def __init__(self, fmt, datefmt=None):\\n logging.Formatter.__init__(self, fmt, datefmt)\\n \\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -424,10 +502,17 @@ def _execute_par_task(self, handle: ResourceHandle,\n if not stream_logs:\n logger.info(\n f'{Fore.CYAN}Logs will not be streamed (stream_logs=False).'\n- f'{Style.RESET_ALL} Hint: in the run command, redirect each'\n- ' task\\'s output to a file, and use `tail -f` to monitor.\\n')\n+ f'{Style.RESET_ALL} Hint: task\\'s output will be redirect to'\n+ f'{Style.BRIGHT} {log_dir} {Style.RESET_ALL}. Please use'\n+ '`ray attach` and `tail -f` to monitor.\\n')","line":null,"original_line":507,"original_start_line":505,"path":"prototype/sky/backends/cloud_vm_ray_backend.py","start_line":null,"text":"@user1:\nCan now be explicit as we have control of the logs, something like:\r\n```\r\n f'{Style.RESET_ALL} Hint: task outputs are redirected to'\r\n f'{Style.BRIGHT} {log_dir} {Style.RESET_ALL} on the cluster. To monitor:'\r\n f'ray exec {handle} \"tail -f {log_dir}/*.log\"\\n')\r\n```\n\n@author:\nYes! This would be what we want."},{"diff_hunk":"@@ -26,9 +26,57 @@\n Path = str\n PostSetupFn = Callable[[str], Any]\n SKY_REMOTE_WORKDIR = backend_utils.SKY_REMOTE_WORKDIR\n+SKY_LOGS_DIRECTORY = backend_utils.SKY_LOGS_DIRECTORY\n \n logger = logging.init_logger(__name__)\n \n+TASK_LAUNCH_CODE_GENERATOR = \"\"\"","line":null,"original_line":33,"original_start_line":null,"path":"prototype/sky/backends/cloud_vm_ray_backend.py","start_line":null,"text":"@user1:\nNits: Add a `\\` at the end of this line, so that the codegen'd file doesn't have its first line blank.\r\n\r\nAdd `_` to the beginning of the variable to indicate module-local constants: https://google.github.io/styleguide/pyguide.html#s3.16.2-naming-conventions"}],"string":"[\n {\n \"diff_hunk\": \"@@ -424,10 +502,17 @@ def _execute_par_task(self, handle: ResourceHandle,\\n if not stream_logs:\\n logger.info(\\n f'{Fore.CYAN}Logs will not be streamed (stream_logs=False).'\\n- f'{Style.RESET_ALL} Hint: in the run command, redirect each'\\n- ' task\\\\'s output to a file, and use `tail -f` to monitor.\\\\n')\\n+ f'{Style.RESET_ALL} Hint: task\\\\'s output will be redirect to'\\n+ f'{Style.BRIGHT} {log_dir} {Style.RESET_ALL}. Please use'\\n+ '`ray attach` and `tail -f` to monitor.\\\\n')\",\n \"line\": null,\n \"original_line\": 507,\n \"original_start_line\": 505,\n \"path\": \"prototype/sky/backends/cloud_vm_ray_backend.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nCan now be explicit as we have control of the logs, something like:\\r\\n```\\r\\n f'{Style.RESET_ALL} Hint: task outputs are redirected to'\\r\\n f'{Style.BRIGHT} {log_dir} {Style.RESET_ALL} on the cluster. To monitor:'\\r\\n f'ray exec {handle} \\\"tail -f {log_dir}/*.log\\\"\\\\n')\\r\\n```\\n\\n@author:\\nYes! This would be what we want.\"\n },\n {\n \"diff_hunk\": \"@@ -26,9 +26,57 @@\\n Path = str\\n PostSetupFn = Callable[[str], Any]\\n SKY_REMOTE_WORKDIR = backend_utils.SKY_REMOTE_WORKDIR\\n+SKY_LOGS_DIRECTORY = backend_utils.SKY_LOGS_DIRECTORY\\n \\n logger = logging.init_logger(__name__)\\n \\n+TASK_LAUNCH_CODE_GENERATOR = \\\"\\\"\\\"\",\n \"line\": null,\n \"original_line\": 33,\n \"original_start_line\": null,\n \"path\": \"prototype/sky/backends/cloud_vm_ray_backend.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nNits: Add a `\\\\` at the end of this line, so that the codegen'd file doesn't have its first line blank.\\r\\n\\r\\nAdd `_` to the beginning of the variable to indicate module-local constants: https://google.github.io/styleguide/pyguide.html#s3.16.2-naming-conventions\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"6ea4acb77dab1264a687e47c28e13305173d9cad"},"merged_patch":{"kind":"string","value":"diff --git a/prototype/sky/backends/backend.py b/prototype/sky/backends/backend.py\nindex 4a37b0ec685..0ec810d27dd 100644\n--- a/prototype/sky/backends/backend.py\n+++ b/prototype/sky/backends/backend.py\n@@ -17,8 +17,8 @@ class Backend(object):\n # Examples: 'cluster.yaml'; 'ray://...', 'k8s://...'.\n ResourceHandle = Any\n \n- def provision(self, task: App, to_provision: Resources,\n- dryrun: bool) -> ResourceHandle:\n+ def provision(self, task: App, to_provision: Resources, dryrun: bool,\n+ stream_logs: bool) -> ResourceHandle:\n raise NotImplementedError\n \n def sync_workdir(self, handle: ResourceHandle, workdir: Path) -> None:\ndiff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\nindex 6f9105c0145..7a0e6de051c 100644\n--- a/prototype/sky/backends/backend_utils.py\n+++ b/prototype/sky/backends/backend_utils.py\n@@ -1,6 +1,8 @@\n \"\"\"Util constants/functions for the backends.\"\"\"\n import datetime\n+import io\n import os\n+import selectors\n import subprocess\n import tempfile\n import textwrap\n@@ -24,6 +26,7 @@\n # NOTE: keep in sync with the cluster template 'file_mounts'.\n SKY_REMOTE_WORKDIR = '/tmp/workdir'\n IP_ADDR_REGEX = r'\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}'\n+SKY_LOGS_DIRECTORY = './sky_logs'\n \n \n def _fill_template(template_path: str,\n@@ -224,3 +227,38 @@ def run_command_on_ip_via_ssh(ip: str,\n if errs:\n logger.error(errs)\n raise subprocess.CalledProcessError(proc.returncode, cmd)\n+\n+\n+def redirect_process_output(proc, log_path, stream_logs, start_streaming_at=''):\n+ \"\"\"Redirect the process's filtered stdout/stderr to both stream and file\"\"\"\n+ dirname = os.path.dirname(log_path)\n+ os.makedirs(dirname, exist_ok=True)\n+\n+ out_io = io.TextIOWrapper(proc.stdout, encoding='utf-8', newline='')\n+ err_io = io.TextIOWrapper(proc.stderr, encoding='utf-8', newline='')\n+ sel = selectors.DefaultSelector()\n+ sel.register(out_io, selectors.EVENT_READ)\n+ sel.register(err_io, selectors.EVENT_READ)\n+\n+ stdout = ''\n+ stderr = ''\n+\n+ start_streaming_flag = False\n+ with open(log_path, 'a') as fout:\n+ while True:\n+ for key, _ in sel.select():\n+ line = key.fileobj.readline()\n+ if not line:\n+ return stdout, stderr\n+ if start_streaming_at in line:\n+ start_streaming_flag = True\n+ if key.fileobj is out_io:\n+ stdout += line\n+ fout.write(line)\n+ fout.flush()\n+ else:\n+ stderr += line\n+ fout.write(line)\n+ fout.flush()\n+ if stream_logs and start_streaming_flag:\n+ print(line, end='')\ndiff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py\nindex 411861439fb..ef999eb31c6 100644\n--- a/prototype/sky/backends/cloud_vm_ray_backend.py\n+++ b/prototype/sky/backends/cloud_vm_ray_backend.py\n@@ -26,9 +26,65 @@\n Path = str\n PostSetupFn = Callable[[str], Any]\n SKY_REMOTE_WORKDIR = backend_utils.SKY_REMOTE_WORKDIR\n+SKY_LOGS_DIRECTORY = backend_utils.SKY_LOGS_DIRECTORY\n \n logger = logging.init_logger(__name__)\n \n+_TASK_LAUNCH_CODE_GENERATOR = \"\"\"\\\n+ import io\n+ import os\n+ import ray\n+ import selectors\n+ import subprocess\n+ ray.init('auto', namespace='__sky__', log_to_driver={stream_logs})\n+ print('cluster_resources:', ray.cluster_resources())\n+ print('available_resources:', ray.available_resources())\n+ print('live nodes:', ray.state.node_ids())\n+ \n+ def redirect_process_output(proc, log_path, stream_logs, start_streaming_at=''):\n+ dirname = os.path.dirname(log_path)\n+ os.makedirs(dirname, exist_ok=True)\n+\n+ out_io = io.TextIOWrapper(proc.stdout, encoding='utf-8', newline='')\n+ err_io = io.TextIOWrapper(proc.stderr, encoding='utf-8', newline='')\n+ sel = selectors.DefaultSelector()\n+ sel.register(out_io, selectors.EVENT_READ)\n+ sel.register(err_io, selectors.EVENT_READ)\n+\n+ stdout = ''\n+ stderr = ''\n+\n+ start_streaming_flag = False\n+ with open(log_path, 'a') as fout:\n+ while True:\n+ for key, _ in sel.select():\n+ line = key.fileobj.readline()\n+ if not line:\n+ return stdout, stderr\n+ if start_streaming_at in line:\n+ start_streaming_flag = True\n+ if key.fileobj is out_io:\n+ stdout += line\n+ fout.write(line)\n+ fout.flush()\n+ else:\n+ stderr += line\n+ fout.write(line)\n+ fout.flush()\n+ if stream_logs and start_streaming_flag:\n+ print(line, end='')\n+ \n+ futures = []\n+\n+ def start_task(cmd, log_path, stream_logs):\n+ proc = subprocess.Popen(cmd,\n+ stdout=subprocess.PIPE,\n+ stderr=subprocess.PIPE,\n+ shell=True,\n+ executable='/bin/bash')\n+ redirect_process_output(proc, log_path, stream_logs)\n+\"\"\"\n+\n \n def _run(cmd, **kwargs):\n return subprocess.run(cmd, shell=True, check=True, **kwargs)\n@@ -38,6 +94,21 @@ def _run_no_outputs(cmd, **kwargs):\n return _run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, **kwargs)\n \n \n+def _run_with_log(cmd,\n+ log_path,\n+ stream_logs=False,\n+ start_streaming_at='',\n+ **kwargs):\n+ proc = subprocess.Popen(cmd,\n+ stdout=subprocess.PIPE,\n+ stderr=subprocess.PIPE,\n+ **kwargs)\n+ stdout, stderr = backend_utils.redirect_process_output(\n+ proc, log_path, stream_logs, start_streaming_at=start_streaming_at)\n+ proc.wait()\n+ return proc, stdout, stderr\n+\n+\n def _get_cluster_config_template(task):\n _CLOUD_TO_TEMPLATE = {\n clouds.AWS: 'config/aws-ray.yml.j2',\n@@ -64,9 +135,10 @@ def _to_accelerator_and_count(resources: Optional[Resources]\n class RetryingVmProvisioner(object):\n \"\"\"A provisioner that retries different regions/zones within a cloud.\"\"\"\n \n- def __init__(self):\n+ def __init__(self, log_dir):\n self._blocked_regions = set()\n self._blocked_zones = set()\n+ self.log_dir = log_dir\n colorama.init()\n \n def _in_blocklist(self, cloud, region, zones):\n@@ -86,7 +158,6 @@ def _update_blocklist_on_gcp_error(self, region, zones, stdout, stderr):\n Style = colorama.Style\n assert len(zones) == 1, zones\n zone = zones[0]\n- stderr = stderr.decode()\n splits = stderr.split('\\n')\n exception_str = [s for s in splits if s.startswith('Exception: ')]\n if len(exception_str) == 1:\n@@ -116,7 +187,7 @@ def _update_blocklist_on_gcp_error(self, region, zones, stdout, stderr):\n self._blocked_zones.add(zone.name)\n else:\n logger.info('====== stdout ======')\n- for s in stdout.decode().split('\\n'):\n+ for s in stdout.split('\\n'):\n print(s)\n logger.info('====== stderr ======')\n for s in splits:\n@@ -128,8 +199,8 @@ def _update_blocklist_on_aws_error(self, region, zones, stdout, stderr):\n # The underlying ray autoscaler / boto3 will try all zones of a region\n # at once.\n Style = colorama.Style\n- stdout_splits = stdout.decode().split('\\n')\n- stderr_splits = stderr.decode().split('\\n')\n+ stdout_splits = stdout.split('\\n')\n+ stderr_splits = stderr.split('\\n')\n errors = [\n s.strip()\n for s in stdout_splits + stderr_splits\n@@ -200,8 +271,12 @@ def _yield_region_zones(self, task: App, cloud: clouds.Cloud):\n yield (region, zones)\n \n def provision_with_retries(self, task: App, to_provision: Resources,\n- dryrun: bool):\n+ dryrun: bool, stream_logs: bool):\n \"\"\"The provision retry loop.\"\"\"\n+ # Get log_path name\n+ log_path = os.path.join(self.log_dir, 'provision.log')\n+ log_abs_path = os.path.abspath(log_path)\n+\n self._clear_blocklist()\n Style = colorama.Style\n for region, zones in self._yield_region_zones(task, to_provision.cloud):\n@@ -243,11 +318,17 @@ def provision_with_retries(self, task: App, to_provision: Resources,\n logger.error(stderr)\n raise e\n cluster_config_file = config_dict['ray']\n- # Captures stdout/err. Otherwise, too many repeated messages.\n- proc = subprocess.Popen(['ray', 'up', '-y', cluster_config_file],\n- stdout=subprocess.PIPE,\n- stderr=subprocess.PIPE)\n- stdout, stderr = proc.communicate()\n+\n+ tail_cmd = f'tail -n100 -f {log_path}'\n+ logger.info(\n+ f'To view progress: {Style.BRIGHT}{tail_cmd}{Style.RESET_ALL}')\n+ # Redirect stdout/err to the file and streaming (if stream_logs).\n+ proc, stdout, stderr = _run_with_log(\n+ ['ray', 'up', '-y', cluster_config_file],\n+ log_abs_path,\n+ stream_logs,\n+ start_streaming_at='Shared connection to')\n+\n if proc.returncode != 0:\n self._update_blocklist_on_error(to_provision.cloud, region,\n zones, stdout, stderr)\n@@ -290,14 +371,17 @@ class CloudVmRayBackend(backends.Backend):\n def __init__(self):\n # TODO: should include this as part of the handle.\n self._managed_tpu = None\n+ run_id = backend_utils.get_run_id()\n+ self.log_dir = os.path.join(SKY_LOGS_DIRECTORY, run_id)\n+ os.makedirs(self.log_dir, exist_ok=True)\n \n- def provision(self, task: App, to_provision: Resources,\n- dryrun: bool) -> ResourceHandle:\n+ def provision(self, task: App, to_provision: Resources, dryrun: bool,\n+ stream_logs: bool) -> ResourceHandle:\n \"\"\"Provisions using 'ray up'.\"\"\"\n # ray up: the VMs.\n- provisioner = RetryingVmProvisioner()\n+ provisioner = RetryingVmProvisioner(self.log_dir)\n config_dict = provisioner.provision_with_retries(\n- task, to_provision, dryrun)\n+ task, to_provision, dryrun, stream_logs)\n if dryrun:\n return\n cluster_config_file = config_dict['ray']\n@@ -371,16 +455,11 @@ def _execute_par_task(self, handle: ResourceHandle,\n # manipulating the futures).\n #\n # TODO: possible to open the port in the yaml? Run Ray inside docker?\n+ log_dir = os.path.join(f'{SKY_REMOTE_WORKDIR}', f'{self.log_dir}',\n+ 'tasks')\n codegen = [\n- textwrap.dedent(f\"\"\"\\\n- import ray\n- import subprocess\n- ray.init('auto', namespace='__sky__', log_to_driver={stream_logs})\n- print('cluster_resources:', ray.cluster_resources())\n- print('available_resources:', ray.available_resources())\n- print('live nodes:', ray.state.node_ids())\n- futures = []\n- \"\"\")\n+ textwrap.dedent(\n+ _TASK_LAUNCH_CODE_GENERATOR.format(stream_logs=stream_logs))\n ]\n for i, t in enumerate(par_task.tasks):\n # '. $(conda info --base)/etc/profile.d/conda.sh || true' is used to initialize\n@@ -404,12 +483,12 @@ def _execute_par_task(self, handle: ResourceHandle,\n resources_str = ''\n num_gpus_str = ''\n name = f'task-{i}' if t.name is None else t.name\n+ log_path = os.path.join(f'{log_dir}', f'{name}.log')\n+\n task_i_codegen = textwrap.dedent(f\"\"\"\\\n- futures.append(ray.remote(lambda: subprocess.run(\n- {cmd},\n- shell=True, check=True, executable='/bin/bash')) \\\\\n+ futures.append(ray.remote(start_task) \\\\\n .options(name='{name}'{resources_str}{num_gpus_str}) \\\\\n- .remote())\n+ .remote({cmd}, '{log_path}', {stream_logs}))\n \"\"\")\n codegen.append(task_i_codegen)\n # Block.\n@@ -424,10 +503,18 @@ def _execute_par_task(self, handle: ResourceHandle,\n if not stream_logs:\n logger.info(\n f'{Fore.CYAN}Logs will not be streamed (stream_logs=False).'\n- f'{Style.RESET_ALL} Hint: in the run command, redirect each'\n- ' task\\'s output to a file, and use `tail -f` to monitor.\\n')\n+ f'{Style.RESET_ALL} Hint: task outputs are redirected to '\n+ f'{Style.BRIGHT}{log_dir}{Style.RESET_ALL} on the cluster. To monitor: '\n+ f'ray exec {handle} \"tail -f {log_dir}/*.log\" '\n+ f'(To view the task names: ray exec {handle} \"ls {log_dir}/\")')\n \n self._exec_code_on_head(handle, codegen)\n+ task_log_dir = os.path.join(f'{self.log_dir}', 'tasks')\n+ logger.info(\n+ f'Syncing down the logs to {Style.BRIGHT}{task_log_dir}{Style.RESET_ALL}.'\n+ )\n+ os.makedirs(task_log_dir, exist_ok=True)\n+ _run(f'ray rsync_down {handle} {log_dir}/* {task_log_dir}')\n \n def _exec_code_on_head(self,\n handle: ResourceHandle,\n@@ -447,15 +534,14 @@ def _exec_code_on_head(self,\n executable = 'python3'\n cd = f'cd {SKY_REMOTE_WORKDIR}'\n cmd = f'ray exec {handle} \\'{cd} && {executable} /tmp/{basename}\\''\n+ log_path = os.path.join(self.log_dir, f'run.log')\n if not stream_logs:\n- out = tempfile.NamedTemporaryFile('w', prefix='sky_',\n- suffix='.out').name\n- cmd += f' >{out}'\n colorama.init()\n Style = colorama.Style\n- logger.info(f'Redirecting stdout, to monitor: '\n- f'{Style.BRIGHT}tail -f {out}{Style.RESET_ALL}')\n- _run(cmd)\n+ logger.info(f'Redirecting stdout/stderr, to monitor: '\n+ f'{Style.BRIGHT}tail -f {log_path}{Style.RESET_ALL}')\n+\n+ _run_with_log(cmd, log_path, stream_logs, shell=True)\n \n def execute(self, handle: ResourceHandle, task: App,\n stream_logs: bool) -> None:\n@@ -485,7 +571,7 @@ def _execute_task_one_node(self, handle: ResourceHandle, task: App,\n f'Task(run=...) should be a string (found {type(task.run)}).'\n codegen = textwrap.dedent(f\"\"\"\\\n #!/bin/bash\n- . $(conda info --base)/etc/profile.d/conda.sh\n+ . $(conda info --base)/etc/profile.d/conda.sh || true\n {task.run}\n \"\"\")\n self._exec_code_on_head(handle, codegen, stream_logs, executable='bash')\n@@ -496,16 +582,11 @@ def _execute_task_n_nodes(self, handle: ResourceHandle, task: App,\n # ray.init(..., log_to_driver=False); otherwise too many logs.\n # for node:\n # submit _run_cmd(cmd) with resource {node_i: 1}\n+ log_dir = os.path.join(f'{SKY_REMOTE_WORKDIR}', f'{self.log_dir}',\n+ 'tasks')\n codegen = [\n- textwrap.dedent(f\"\"\"\\\n- import subprocess\n- import ray\n- ray.init('auto', namespace='__sky__', log_to_driver={stream_logs})\n- print('cluster_resources:', ray.cluster_resources())\n- print('available_resources:', ray.available_resources())\n- print('live nodes:', ray.state.node_ids())\n- futures = []\n- \"\"\")\n+ textwrap.dedent(\n+ _TASK_LAUNCH_CODE_GENERATOR.format(stream_logs=stream_logs))\n ]\n acc, acc_count = _to_accelerator_and_count(task.best_resources)\n # Get private ips here as Ray internally uses 'node:private_ip' as\n@@ -533,13 +614,14 @@ def _execute_task_n_nodes(self, handle: ResourceHandle, task: App,\n num_gpus_str = f', num_gpus={acc_count}'\n # Set the executable to /bin/bash, so that the 'source ~/.bashrc'\n # and 'source activate conda_env' can be used.\n+ name = f'task-{ip}'\n+ log_path = os.path.join(f'{log_dir}', f'{name}.log')\n+\n codegen.append(\n textwrap.dedent(f\"\"\"\\\n- futures.append(ray.remote(lambda: subprocess.run(\n- {cmd},\n- shell=True, check=True, executable='/bin/bash')) \\\\\n- .options(name='{ip}'{resources_str}{num_gpus_str}) \\\\\n- .remote())\n+ futures.append(ray.remote(start_task) \\\\\n+ .options(name='{name}'{resources_str}{num_gpus_str}) \\\\\n+ .remote({cmd}, '{log_path}', {stream_logs}))\n \"\"\"))\n # Block.\n codegen.append('ray.get(futures)\\n')\n@@ -552,9 +634,18 @@ def _execute_task_n_nodes(self, handle: ResourceHandle, task: App,\n if not stream_logs:\n logger.info(\n f'{Fore.CYAN}Logs will not be streamed (stream_logs=False).'\n- f'{Style.RESET_ALL} Hint: in the run command, redirect each'\n- ' task\\'s output to a file, and use `tail -f` to monitor.\\n')\n+ f'{Style.RESET_ALL} Hint: task outputs are redirected to'\n+ f'{Style.BRIGHT}{log_dir}{Style.RESET_ALL} on the cluster. To monitor: '\n+ f'ray exec {handle} \"tail -f {log_dir}/*.log\"\\n'\n+ f'(To view the task names: ray exec {handle} \"ls {log_dir}/\")')\n+\n self._exec_code_on_head(handle, codegen)\n+ task_log_dir = os.path.join(f'{self.log_dir}', 'tasks')\n+ logger.info(\n+ f'Syncing down the logs to {Style.BRIGHT}{task_log_dir}{Style.RESET_ALL}.'\n+ )\n+ os.makedirs(task_log_dir, exist_ok=True)\n+ _run(f'ray rsync_down {handle} {log_dir}/* {task_log_dir}')\n \n def post_execute(self, handle: ResourceHandle, teardown: bool) -> None:\n colorama.init()\n@@ -570,7 +661,7 @@ def post_execute(self, handle: ResourceHandle, teardown: bool) -> None:\n )\n \n def teardown(self, handle: ResourceHandle) -> None:\n- _run(f'ray down -y {handle}', shell=True, check=True)\n+ _run(f'ray down -y {handle}')\n if self._managed_tpu is not None:\n _run(f'bash {self._managed_tpu[1]}')\n \ndiff --git a/prototype/sky/execution.py b/prototype/sky/execution.py\nindex f0e2c03287f..1cb502b7034 100644\n--- a/prototype/sky/execution.py\n+++ b/prototype/sky/execution.py\n@@ -343,7 +343,10 @@ def execute_v2(dag: sky.Dag,\n \n backend = backend if backend is not None else backends.CloudVmRayBackend()\n \n- handle = backend.provision(task, best_resources, dryrun=dryrun)\n+ handle = backend.provision(task,\n+ best_resources,\n+ dryrun=dryrun,\n+ stream_logs=stream_logs)\n if dryrun:\n logger.info('Dry run finished.')\n return\ndiff --git a/prototype/sky/logging.py b/prototype/sky/logging.py\nindex 6e230e02cb7..aab02050a72 100644\n--- a/prototype/sky/logging.py\n+++ b/prototype/sky/logging.py\n@@ -1,11 +1,12 @@\n-import sys\n import logging\n+import sys\n \n FORMAT = '%(levelname).1s %(asctime)s %(filename)s:%(lineno)d] %(message)s'\n DATE_FORMAT = '%m-%d %H:%M:%S'\n \n \n class NewLineFormatter(logging.Formatter):\n+ \"\"\"Add logging prefix to the newlines to align multi-line logging messages\"\"\"\n \n def __init__(self, fmt, datefmt=None):\n logging.Formatter.__init__(self, fmt, datefmt)\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 4,\n \"problem_domain\": \"New Feature Additions\"\n}"}}},{"rowIdx":7079,"cells":{"instance_id":{"kind":"string","value":"skypilot-org__skypilot-90@aae9b98"},"repo":{"kind":"string","value":"skypilot-org/skypilot"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":90,"string":"90"},"title":{"kind":"string","value":"[CLI] Add sky ssh and port-forwarding"},"body":{"kind":"string","value":"#87 \r\nEnabled the cli: \r\n1. Attach and port forwarding to cluster: `sky ssh -p <port1> -p <port2> cluster_name` \r\n2. Port forwarding for gpu/cpunode: `sky gpunode -p <port1> -p <port2> ` \r\n3. `sky gpunode -c cluster_name` will carete the cluster with the name of cluster_name (rather than randomly generated one), if the provided cluster does not exist.\r\n"},"created_at":{"kind":"string","value":"2021-12-05T05:02:59Z"},"problem_statement":{"kind":"string","value":"`sky attach [--port-forward] <cluster_name>`\nCan we have the CLI as the title?\r\n\r\nReason: The `sky status` only shows the <cluster_name>. If a user would like to connect to the cluster or do the port forwarding, they need to find the path of the config file by themselves. Directly using the `sky attach <cluster_name>` might be more intuitive."},"hints_text":{"kind":"string","value":"Yes, either `sky attach` or `sky ssh`. Currently no one's working on it.\nThis will also help to expose less and less leaky messages (e.g., we\ncurrently show \"ray attach ...\" and \"sky down ...\" as help messages).\n\nOn Sun, Dec 5, 2021 at 5:20 AM Zhanghao Wu ***@***.***> wrote:\n\n> As the title.\n>\n> Reason: The sky status only shows the <cluster_name>. If a user would\n> like to connect to the cluster or do the port forwarding, they need to find\n> the path of the config file by themselves. Directly using the sky attach\n> <cluster_name> might be more intuitive.\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/concretevitamin/sky-experiments/issues/87>, or\n> unsubscribe\n> <https://github.com/notifications/unsubscribe-auth/AAEQWHTXDVHFNOJWP3MOQPLUPKA3FANCNFSM5JL7OQGQ>\n> .\n> Triage notifications on the go with GitHub Mobile for iOS\n> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>\n> or Android\n> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.\n>\n>"},"resolved_issues":{"kind":"list like","value":[{"body":"Can we have the CLI as the title?\r\n\r\nReason: The `sky status` only shows the <cluster_name>. If a user would like to connect to the cluster or do the port forwarding, they need to find the path of the config file by themselves. Directly using the `sky attach <cluster_name>` might be more intuitive.","number":87,"title":"`sky attach [--port-forward] <cluster_name>`"}],"string":"[\n {\n \"body\": \"Can we have the CLI as the title?\\r\\n\\r\\nReason: The `sky status` only shows the <cluster_name>. If a user would like to connect to the cluster or do the port forwarding, they need to find the path of the config file by themselves. Directly using the `sky attach <cluster_name>` might be more intuitive.\",\n \"number\": 87,\n \"title\": \"`sky attach [--port-forward] <cluster_name>`\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"837dcb8b3a02dc28f935e09c4da90551adcfff92"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"aae9b98c15c1d33328d03fddcdee5fa059464c68\",\n \"head_commit_message\": \"Fix Ctrl-D error\",\n \"patch_to_review\": \"diff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\\nindex c43d93e88f3..7144b014b30 100644\\n--- a/prototype/sky/backends/backend_utils.py\\n+++ b/prototype/sky/backends/backend_utils.py\\n@@ -351,7 +351,9 @@ def redirect_process_output(proc, log_path, stream_logs, start_streaming_at=''):\\n \\n \\n def run(cmd, **kwargs):\\n- return subprocess.run(cmd, shell=True, check=True, **kwargs)\\n+ check = kwargs.pop('check', True)\\n+ shell = kwargs.pop('shell', True)\\n+ return subprocess.run(cmd, shell=shell, check=check, **kwargs)\\n \\n \\n def run_no_outputs(cmd, **kwargs):\\ndiff --git a/prototype/sky/cli.py b/prototype/sky/cli.py\\nindex e0e5730b125..8638d8b760c 100644\\n--- a/prototype/sky/cli.py\\n+++ b/prototype/sky/cli.py\\n@@ -25,6 +25,7 @@\\n \\\"\\\"\\\"\\n import os\\n import time\\n+from typing import List, Optional\\n import yaml\\n \\n import click\\n@@ -65,7 +66,9 @@ def _get_region_zones_from_handle(handle):\\n def _create_interactive_node(name,\\n resources,\\n cluster_handle=None,\\n- backend=cloud_vm_ray_backend.CloudVmRayBackend):\\n+ backend=cloud_vm_ray_backend.CloudVmRayBackend,\\n+ port_forward: Optional[List[int]] = None,\\n+ cluster_name: Optional[str] = None):\\n \\\"\\\"\\\"Creates an interactive session.\\n \\n Args:\\n@@ -90,22 +93,27 @@ def _create_interactive_node(name,\\n backend = backend()\\n backend.register_info(dag=dag, optimize_target=sky.OptimizeTarget.COST)\\n \\n- dag = sky.optimize(dag, minimize=sky.OptimizeTarget.COST)\\n- task = dag.tasks[0]\\n-\\n handle = cluster_handle\\n if handle is None:\\n+ dag = sky.optimize(dag, minimize=sky.OptimizeTarget.COST)\\n+ task = dag.tasks[0]\\n handle = backend.provision(task,\\n task.best_resources,\\n dryrun=False,\\n- stream_logs=True)\\n+ stream_logs=True,\\n+ cluster_name=cluster_name)\\n \\n task_id = global_user_state.add_task(task)\\n \\n # TODO: cd into workdir immediately on the VM\\n # TODO: Delete the temporary cluster config yml (or figure out a way to\\n # re-use it)\\n- backend_utils.run(f'ray attach {handle}')\\n+ extra_cmd = ''\\n+ if port_forward is not None:\\n+ extra_cmd = ' '.join(\\n+ [f'--port-forward {port}' for port in port_forward])\\n+ # Disable check, since the returncode could be non-zero if the user Ctrl-D\\n+ backend_utils.run(f'ray attach {extra_cmd} {handle}', check=False)\\n \\n if cluster_handle is None: # if this is a secondary\\n backend_utils.run(f'ray down -y {handle}')\\n@@ -313,6 +321,49 @@ def down(cluster, all): # pylint: disable=redefined-builtin\\n click.secho(f'Tearing down cluster {name}...done.', fg='green')\\n \\n \\n+@cli.command()\\n+@click.argument('cluster', required=False)\\n+@click.option('--port-forward',\\n+ '-p',\\n+ multiple=True,\\n+ default=[],\\n+ type=int,\\n+ required=False,\\n+ help='Port to be forwarded. To forward multiple ports, '\\n+ 'use this option multiple times.')\\n+def attach(cluster, port_forward): # pylint: disable=redefined-builtin\\n+ \\\"\\\"\\\"Attach to the cluster CLUSTER.\\n+\\n+ CLUSTER is the name of the cluster to attach. If CLUSTER is not supplied,\\n+ the last cluster will be attached.\\n+\\n+ Examples:\\n+\\n+ \\\\b\\n+ # Attach to a specific cluster.\\n+ sky attach cluster_name\\n+\\n+ \\\\b\\n+ # Port forward.\\n+ sky attach -p 8080 -p 4650 cluster_name\\n+ \\\"\\\"\\\"\\n+ # FIXME: make TPU part of handles; so that this kills TPUs too.\\n+ name = cluster\\n+\\n+ to_attach = name\\n+ if to_attach is None:\\n+ to_attach = sorted(global_user_state.get_clusters(),\\n+ key=lambda x: x['launched_at'])[-1]\\n+ handle = global_user_state.get_handle_from_cluster_name(to_attach)\\n+ assert handle is not None, f'Cluster {name} is not found.'\\n+\\n+ # FIXME: Assumes a specific backend.\\n+ _create_interactive_node(name,\\n+ sky.Resources(),\\n+ handle,\\n+ port_forward=port_forward)\\n+\\n+\\n @cli.command()\\n def status():\\n \\\"\\\"\\\"Show the status of all tasks and clusters.\\\"\\\"\\\"\\n@@ -352,20 +403,29 @@ def status():\\n default=None,\\n type=str,\\n help=_CLUSTER_FLAG_HELP)\\n-def gpunode(cluster):\\n+@click.option('--port-forward',\\n+ '-p',\\n+ multiple=True,\\n+ default=[],\\n+ type=int,\\n+ required=False,\\n+ help='Port to be forwarded. To forward multiple ports, '\\n+ 'use this option multiple times.')\\n+def gpunode(cluster, port_forward):\\n \\\"\\\"\\\"Launches an interactive GPU node.\\n \\n Automatically syncs current working directory.\\n \\\"\\\"\\\"\\n # TODO: Sync code files between local and interactive node (watch rsync?)\\n- # TODO: Add port forwarding to allow access to localhost:PORT for jupyter\\n handle = None\\n if cluster is not None:\\n handle = global_user_state.get_handle_from_cluster_name(cluster)\\n \\n _create_interactive_node('gpunode',\\n {sky.Resources(sky.AWS(), accelerators='V100')},\\n- cluster_handle=handle)\\n+ cluster_handle=handle,\\n+ port_forward=port_forward,\\n+ cluster_name=cluster)\\n \\n \\n @cli.command()\\n@@ -374,7 +434,15 @@ def gpunode(cluster):\\n default=None,\\n type=str,\\n help=_CLUSTER_FLAG_HELP)\\n-def cpunode(cluster):\\n+@click.option('--port-forward',\\n+ '-p',\\n+ multiple=True,\\n+ default=[],\\n+ type=int,\\n+ required=False,\\n+ help='Port to be forwarded. To forward multiple ports, '\\n+ 'use this option multiple times.')\\n+def cpunode(cluster, port_forward):\\n \\\"\\\"\\\"Launches an interactive CPU node.\\n \\n Automatically syncs current working directory.\\n@@ -384,7 +452,9 @@ def cpunode(cluster):\\n handle = global_user_state.get_handle_from_cluster_name(cluster)\\n \\n _create_interactive_node('cpunode', {sky.Resources(sky.AWS())},\\n- cluster_handle=handle)\\n+ cluster_handle=handle,\\n+ port_forward=port_forward,\\n+ cluster_name=cluster)\\n \\n \\n def main():\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -90,22 +93,27 @@ def _create_interactive_node(name,\n backend = backend()\n backend.register_info(dag=dag, optimize_target=sky.OptimizeTarget.COST)\n \n- dag = sky.optimize(dag, minimize=sky.OptimizeTarget.COST)\n- task = dag.tasks[0]\n-\n handle = cluster_handle\n if handle is None:\n+ dag = sky.optimize(dag, minimize=sky.OptimizeTarget.COST)\n+ task = dag.tasks[0]\n handle = backend.provision(task,\n task.best_resources,\n dryrun=False,\n- stream_logs=True)\n+ stream_logs=True,\n+ cluster_name=cluster_name)\n \n task_id = global_user_state.add_task(task)\n \n # TODO: cd into workdir immediately on the VM\n # TODO: Delete the temporary cluster config yml (or figure out a way to\n # re-use it)\n- backend_utils.run(f'ray attach {handle}')\n+ extra_cmd = ''\n+ if port_forward is not None:\n+ extra_cmd = ' '.join(\n+ [f'--port-forward {port}' for port in port_forward])\n+ # Disable check, since the returncode could be non-zero if the user Ctrl-D\n+ backend_utils.run(f'ray attach {extra_cmd} {handle}', check=False)","line":null,"original_line":116,"original_start_line":null,"path":"prototype/sky/cli.py","start_line":null,"text":"@user1:\nWas confused for a moment, maybe `attach_options`."},{"diff_hunk":"@@ -313,6 +321,49 @@ def down(cluster, all): # pylint: disable=redefined-builtin\n click.secho(f'Tearing down cluster {name}...done.', fg='green')\n \n \n+@cli.command()\n+@click.argument('cluster', required=False)\n+@click.option('--port-forward',\n+ '-p',\n+ multiple=True,\n+ default=[],\n+ type=int,\n+ required=False,\n+ help='Port to be forwarded. To forward multiple ports, '\n+ 'use this option multiple times.')\n+def attach(cluster, port_forward): # pylint: disable=redefined-builtin\n+ \"\"\"Attach to the cluster CLUSTER.\n+\n+ CLUSTER is the name of the cluster to attach. If CLUSTER is not supplied,\n+ the last cluster will be attached.\n+\n+ Examples:\n+\n+ \\b\n+ # Attach to a specific cluster.\n+ sky attach cluster_name\n+\n+ \\b\n+ # Port forward.\n+ sky attach -p 8080 -p 4650 cluster_name\n+ \"\"\"\n+ # FIXME: make TPU part of handles; so that this kills TPUs too.\n+ name = cluster\n+\n+ to_attach = name\n+ if to_attach is None:\n+ to_attach = sorted(global_user_state.get_clusters(),\n+ key=lambda x: x['launched_at'])[-1]\n+ handle = global_user_state.get_handle_from_cluster_name(to_attach)\n+ assert handle is not None, f'Cluster {name} is not found.'","line":null,"original_line":358,"original_start_line":null,"path":"prototype/sky/cli.py","start_line":null,"text":"@user1:\nProbably want to raise an appropriate click exception like `sky run`; assert is for internal correctness"},{"diff_hunk":"@@ -313,6 +321,49 @@ def down(cluster, all): # pylint: disable=redefined-builtin\n click.secho(f'Tearing down cluster {name}...done.', fg='green')\n \n \n+@cli.command()\n+@click.argument('cluster', required=False)\n+@click.option('--port-forward',\n+ '-p',\n+ multiple=True,\n+ default=[],\n+ type=int,\n+ required=False,\n+ help='Port to be forwarded. To forward multiple ports, '\n+ 'use this option multiple times.')\n+def attach(cluster, port_forward): # pylint: disable=redefined-builtin\n+ \"\"\"Attach to the cluster CLUSTER.\n+\n+ CLUSTER is the name of the cluster to attach. If CLUSTER is not supplied,\n+ the last cluster will be attached.\n+\n+ Examples:\n+\n+ \\b\n+ # Attach to a specific cluster.\n+ sky attach cluster_name\n+\n+ \\b\n+ # Port forward.\n+ sky attach -p 8080 -p 4650 cluster_name\n+ \"\"\"\n+ # FIXME: make TPU part of handles; so that this kills TPUs too.\n+ name = cluster\n+\n+ to_attach = name\n+ if to_attach is None:\n+ to_attach = sorted(global_user_state.get_clusters(),","line":null,"original_line":355,"original_start_line":null,"path":"prototype/sky/cli.py","start_line":null,"text":"@user1:\nPrint an error when there are no clusters."},{"diff_hunk":"@@ -313,6 +321,49 @@ def down(cluster, all): # pylint: disable=redefined-builtin\n click.secho(f'Tearing down cluster {name}...done.', fg='green')\n \n \n+@cli.command()\n+@click.argument('cluster', required=False)\n+@click.option('--port-forward',\n+ '-p',\n+ multiple=True,\n+ default=[],\n+ type=int,\n+ required=False,\n+ help='Port to be forwarded. To forward multiple ports, '\n+ 'use this option multiple times.')\n+def attach(cluster, port_forward): # pylint: disable=redefined-builtin","line":null,"original_line":334,"original_start_line":null,"path":"prototype/sky/cli.py","start_line":null,"text":"@user1:\nCan do away without this pylint disable"}],"string":"[\n {\n \"diff_hunk\": \"@@ -90,22 +93,27 @@ def _create_interactive_node(name,\\n backend = backend()\\n backend.register_info(dag=dag, optimize_target=sky.OptimizeTarget.COST)\\n \\n- dag = sky.optimize(dag, minimize=sky.OptimizeTarget.COST)\\n- task = dag.tasks[0]\\n-\\n handle = cluster_handle\\n if handle is None:\\n+ dag = sky.optimize(dag, minimize=sky.OptimizeTarget.COST)\\n+ task = dag.tasks[0]\\n handle = backend.provision(task,\\n task.best_resources,\\n dryrun=False,\\n- stream_logs=True)\\n+ stream_logs=True,\\n+ cluster_name=cluster_name)\\n \\n task_id = global_user_state.add_task(task)\\n \\n # TODO: cd into workdir immediately on the VM\\n # TODO: Delete the temporary cluster config yml (or figure out a way to\\n # re-use it)\\n- backend_utils.run(f'ray attach {handle}')\\n+ extra_cmd = ''\\n+ if port_forward is not None:\\n+ extra_cmd = ' '.join(\\n+ [f'--port-forward {port}' for port in port_forward])\\n+ # Disable check, since the returncode could be non-zero if the user Ctrl-D\\n+ backend_utils.run(f'ray attach {extra_cmd} {handle}', check=False)\",\n \"line\": null,\n \"original_line\": 116,\n \"original_start_line\": null,\n \"path\": \"prototype/sky/cli.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nWas confused for a moment, maybe `attach_options`.\"\n },\n {\n \"diff_hunk\": \"@@ -313,6 +321,49 @@ def down(cluster, all): # pylint: disable=redefined-builtin\\n click.secho(f'Tearing down cluster {name}...done.', fg='green')\\n \\n \\n+@cli.command()\\n+@click.argument('cluster', required=False)\\n+@click.option('--port-forward',\\n+ '-p',\\n+ multiple=True,\\n+ default=[],\\n+ type=int,\\n+ required=False,\\n+ help='Port to be forwarded. To forward multiple ports, '\\n+ 'use this option multiple times.')\\n+def attach(cluster, port_forward): # pylint: disable=redefined-builtin\\n+ \\\"\\\"\\\"Attach to the cluster CLUSTER.\\n+\\n+ CLUSTER is the name of the cluster to attach. If CLUSTER is not supplied,\\n+ the last cluster will be attached.\\n+\\n+ Examples:\\n+\\n+ \\\\b\\n+ # Attach to a specific cluster.\\n+ sky attach cluster_name\\n+\\n+ \\\\b\\n+ # Port forward.\\n+ sky attach -p 8080 -p 4650 cluster_name\\n+ \\\"\\\"\\\"\\n+ # FIXME: make TPU part of handles; so that this kills TPUs too.\\n+ name = cluster\\n+\\n+ to_attach = name\\n+ if to_attach is None:\\n+ to_attach = sorted(global_user_state.get_clusters(),\\n+ key=lambda x: x['launched_at'])[-1]\\n+ handle = global_user_state.get_handle_from_cluster_name(to_attach)\\n+ assert handle is not None, f'Cluster {name} is not found.'\",\n \"line\": null,\n \"original_line\": 358,\n \"original_start_line\": null,\n \"path\": \"prototype/sky/cli.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nProbably want to raise an appropriate click exception like `sky run`; assert is for internal correctness\"\n },\n {\n \"diff_hunk\": \"@@ -313,6 +321,49 @@ def down(cluster, all): # pylint: disable=redefined-builtin\\n click.secho(f'Tearing down cluster {name}...done.', fg='green')\\n \\n \\n+@cli.command()\\n+@click.argument('cluster', required=False)\\n+@click.option('--port-forward',\\n+ '-p',\\n+ multiple=True,\\n+ default=[],\\n+ type=int,\\n+ required=False,\\n+ help='Port to be forwarded. To forward multiple ports, '\\n+ 'use this option multiple times.')\\n+def attach(cluster, port_forward): # pylint: disable=redefined-builtin\\n+ \\\"\\\"\\\"Attach to the cluster CLUSTER.\\n+\\n+ CLUSTER is the name of the cluster to attach. If CLUSTER is not supplied,\\n+ the last cluster will be attached.\\n+\\n+ Examples:\\n+\\n+ \\\\b\\n+ # Attach to a specific cluster.\\n+ sky attach cluster_name\\n+\\n+ \\\\b\\n+ # Port forward.\\n+ sky attach -p 8080 -p 4650 cluster_name\\n+ \\\"\\\"\\\"\\n+ # FIXME: make TPU part of handles; so that this kills TPUs too.\\n+ name = cluster\\n+\\n+ to_attach = name\\n+ if to_attach is None:\\n+ to_attach = sorted(global_user_state.get_clusters(),\",\n \"line\": null,\n \"original_line\": 355,\n \"original_start_line\": null,\n \"path\": \"prototype/sky/cli.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nPrint an error when there are no clusters.\"\n },\n {\n \"diff_hunk\": \"@@ -313,6 +321,49 @@ def down(cluster, all): # pylint: disable=redefined-builtin\\n click.secho(f'Tearing down cluster {name}...done.', fg='green')\\n \\n \\n+@cli.command()\\n+@click.argument('cluster', required=False)\\n+@click.option('--port-forward',\\n+ '-p',\\n+ multiple=True,\\n+ default=[],\\n+ type=int,\\n+ required=False,\\n+ help='Port to be forwarded. To forward multiple ports, '\\n+ 'use this option multiple times.')\\n+def attach(cluster, port_forward): # pylint: disable=redefined-builtin\",\n \"line\": null,\n \"original_line\": 334,\n \"original_start_line\": null,\n \"path\": \"prototype/sky/cli.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nCan do away without this pylint disable\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"d274f46b64b992d68c0ccb3859d18e32a0c8516c"},"merged_patch":{"kind":"string","value":"diff --git a/prototype/examples/jupyter_app.py b/prototype/examples/jupyter_app.py\nindex 4c6bb71f6d3..0e49b03b7ec 100644\n--- a/prototype/examples/jupyter_app.py\n+++ b/prototype/examples/jupyter_app.py\n@@ -15,8 +15,8 @@ def make_application():\n \n run = f'jupyter notebook --port 8888'\n \n- # Use 'ray attach --port-forward=8888 <config_file>' to forward port to local.\n- # e.g., for AWS, 'ray attach --port-forward=8888 config/aws-ray.yml'\n+ # Use 'sky ssh --port-forward=8888 <cluster_name>' to forward port to local.\n+ # e.g., for AWS, 'sky ssh --port-forward=8888 sky-12345'\n jupyter = sky.Task('jupyter',\n run=run,\n setup=setup,\ndiff --git a/prototype/examples/tensorboard_app.py b/prototype/examples/tensorboard_app.py\nindex b827bb803e3..24327b1e8cd 100644\n--- a/prototype/examples/tensorboard_app.py\n+++ b/prototype/examples/tensorboard_app.py\n@@ -38,8 +38,8 @@\n sky.Resources(accelerators='V100'),\n })\n \n- # Use 'ray attach --port-forward=4650 <config_file>' to forward port to local.\n- # e.g., for AWS, 'ray attach --port-forward=4650 config/user/sky-<cluster_name>.yml'\n+ # Use 'sky ssh --port-forward=4650 <cluster_name>' to forward port to local.\n+ # e.g., for AWS, 'sky ssh --port-forward=4650 sky-12345'\n tensorboard = sky.Task(\n 'tensorboard',\n workdir=workdir,\ndiff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\nindex 700951f4659..f265daf1810 100644\n--- a/prototype/sky/backends/backend_utils.py\n+++ b/prototype/sky/backends/backend_utils.py\n@@ -201,6 +201,7 @@ def write_cluster_config(run_id: RunId,\n # AWS only.\n 'aws_default_ami': aws_default_ami,\n }))\n+ config_dict['cluster_name'] = cluster_name\n config_dict['ray'] = yaml_path\n if dryrun:\n return config_dict\n@@ -362,9 +363,11 @@ def redirect_process_output(proc, log_path, stream_logs, start_streaming_at=''):\n \n \n def run(cmd, **kwargs):\n+ shell = kwargs.pop('shell', True)\n+ check = kwargs.pop('check', True)\n return subprocess.run(cmd,\n- shell=True,\n- check=True,\n+ shell=shell,\n+ check=check,\n executable='/bin/bash',\n **kwargs)\n \ndiff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py\nindex 77eebb0690d..4428b4a5407 100644\n--- a/prototype/sky/backends/cloud_vm_ray_backend.py\n+++ b/prototype/sky/backends/cloud_vm_ray_backend.py\n@@ -408,13 +408,12 @@ def _retry_region_zones(self, task: App, to_provision: Resources,\n backend_utils.run(\n f'ray exec {cluster_config_file} '\n f'\\'echo \"export TPU_NAME={tpu_name}\" >> ~/.bashrc\\'')\n- relpath = backend_utils.get_rel_path(cluster_config_file)\n+ cluster_name = config_dict['cluster_name']\n logger.info(\n f'{style.BRIGHT}Successfully provisioned or found'\n f' existing VM(s). Setup completed.{style.RESET_ALL}')\n- logger.info(\n- f'\\nTo log into the head VM:\\t{style.BRIGHT}ray attach'\n- f' {relpath}{style.RESET_ALL}\\n')\n+ logger.info(f'\\nTo log into the head VM:\\t{style.BRIGHT}sky ssh'\n+ f' {cluster_name}{style.RESET_ALL}\\n')\n return config_dict\n message = ('Failed to acquire resources in all regions/zones'\n f' (requested {to_provision}).'\n@@ -506,7 +505,8 @@ def __init__(self):\n \n def register_info(self, **kwargs) -> None:\n self._dag = kwargs['dag']\n- self._optimize_target = kwargs['optimize_target']\n+ self._optimize_target = kwargs.pop('optimize_target',\n+ OptimizeTarget.COST)\n \n def provision(self,\n task: App,\n@@ -863,13 +863,11 @@ def post_execute(self, handle: ResourceHandle, teardown: bool) -> None:\n colorama.init()\n style = colorama.Style\n if not teardown:\n- relpath = backend_utils.get_rel_path(handle.cluster_yaml)\n name = global_user_state.get_cluster_name_from_handle(handle)\n- logger.info(\n- '\\nTo log into the head VM:\\t'\n- f'{style.BRIGHT}ray attach {relpath} {style.RESET_ALL}\\n'\n- '\\nTo tear down the cluster:'\n- f'\\t{style.BRIGHT}sky down {name}{style.RESET_ALL}\\n')\n+ logger.info('\\nTo log into the head VM:\\t'\n+ f'{style.BRIGHT}sky ssh {name} {style.RESET_ALL}\\n'\n+ '\\nTo tear down the cluster:'\n+ f'\\t{style.BRIGHT}sky down {name}{style.RESET_ALL}\\n')\n if handle.tpu_delete_script is not None:\n logger.info(\n 'Tip: `sky down` will delete launched TPU(s) as well.')\ndiff --git a/prototype/sky/cli.py b/prototype/sky/cli.py\nindex 5f43d5eb61c..68fb24ad5bd 100644\n--- a/prototype/sky/cli.py\n+++ b/prototype/sky/cli.py\n@@ -29,7 +29,7 @@\n \"\"\"\n import os\n import time\n-from typing import Optional\n+from typing import List, Optional\n \n import click\n import pendulum\n@@ -48,6 +48,9 @@\n an autogenerated name.\n \"\"\".strip()\n \n+Path = str\n+Backend = backends.Backend\n+\n \n # TODO: --screen; while uploading ~/.screenrc.\n # TODO: skip installing ray to speed up provisioning.\n@@ -55,14 +58,18 @@ def _create_interactive_node(\n name: str,\n resources: sky.Resources,\n cluster_handle: backend_lib.Backend.ResourceHandle = None,\n- backend: Optional[backend_lib.Backend] = None):\n- \"\"\"Creates and attaches to an interactive node.\n+ backend: Optional[backend_lib.Backend] = None,\n+ port_forward: Optional[List[int]] = None,\n+ cluster_name: Optional[str] = None):\n+ \"\"\"Creates an interactive session.\n \n Args:\n name: Name of the sky.Task to create.\n resources: Resources to attach to VM.\n- cluster_handle: an opaque handle to a launched cluster.\n- backend: the Backend to use (currently only CloudVmRayBackend).\n+ cluster_handle: Cluster YAML file.\n+ backend: Backend to use.\n+ port_forward: List of ports to forward.\n+ cluster_name: Name of the cluster.\n \"\"\"\n \n with sky.Dag() as dag:\n@@ -78,10 +85,10 @@ def _create_interactive_node(\n )\n task.set_resources(resources)\n \n- backend = backend if backend is not None else backends.CloudVmRayBackend()\n- backend.register_info(dag=dag, optimize_target=sky.OptimizeTarget.COST)\n+ backend = backend() if backend is not None else backends.CloudVmRayBackend()\n+ backend.register_info(dag=dag)\n \n- dag = sky.optimize(dag, minimize=sky.OptimizeTarget.COST)\n+ dag = sky.optimize(dag)\n task = dag.tasks[0]\n \n handle = cluster_handle\n@@ -89,14 +96,20 @@ def _create_interactive_node(\n handle = backend.provision(task,\n task.best_resources,\n dryrun=False,\n- stream_logs=True)\n+ stream_logs=True,\n+ cluster_name=cluster_name)\n \n global_user_state.add_task(task)\n \n # TODO: cd into workdir immediately on the VM\n # TODO: Delete the temporary cluster config yml (or figure out a way to\n # re-use it)\n- backend_utils.run(f'ray attach {handle.cluster_yaml}')\n+ attach_options = ''\n+ if port_forward is not None:\n+ attach_options = ' '.join(\n+ [f'--port-forward {port}' for port in port_forward])\n+ # Disable check, since the returncode could be non-zero if the user Ctrl-D\n+ backend_utils.run(f'ray attach {attach_options} {handle}', check=False)\n \n cluster_name = global_user_state.get_cluster_name_from_handle(handle)\n relpath = backend_utils.get_rel_path(handle.cluster_yaml)\n@@ -134,7 +147,7 @@ def cli():\n default=False,\n type=bool,\n help='If True, do not actually run the job.')\n-def run(yaml_path, cluster, dryrun):\n+def run(yaml_path: Path, cluster: str, dryrun: bool):\n \"\"\"Launch a task from a YAML spec (rerun setup if a cluster exists).\"\"\"\n with sky.Dag() as dag:\n sky.Task.from_yaml(yaml_path)\n@@ -150,11 +163,7 @@ def run(yaml_path, cluster, dryrun):\n #\n # To fix all of the above, fix/circumvent the bug that 'ray up' not downing\n # old cloud's cluster with the same name.\n- sky.execute(dag,\n- dryrun=dryrun,\n- stream_logs=True,\n- optimize_target=sky.OptimizeTarget.COST,\n- cluster_name=cluster)\n+ sky.execute(dag, dryrun=dryrun, stream_logs=True, cluster_name=cluster)\n \n \n @cli.command()\n@@ -164,7 +173,7 @@ def run(yaml_path, cluster, dryrun):\n required=True,\n type=str,\n help='Name of the existing cluster to execute a task on.')\n-def exec(yaml_path, cluster): # pylint: disable=redefined-builtin\n+def exec(yaml_path: Path, cluster: str): # pylint: disable=redefined-builtin\n \"\"\"Execute a task from a YAML spec on a cluster (skip setup).\n \n \\b\n@@ -251,7 +260,7 @@ def status():\n default=None,\n is_flag=True,\n help='Tear down all existing clusters.')\n-def down(cluster, all): # pylint: disable=redefined-builtin\n+def down(cluster: str, all: Optional[bool]): # pylint: disable=redefined-builtin\n \"\"\"Tear down cluster(s).\n \n CLUSTER is the name of the cluster to tear down. If both CLUSTER and --all\n@@ -304,13 +313,62 @@ def down(cluster, all): # pylint: disable=redefined-builtin\n \n \n @cli.command()\n+@click.argument('cluster', required=False)\n+@click.option('--port-forward',\n+ '-p',\n+ multiple=True,\n+ default=[],\n+ type=int,\n+ required=False,\n+ help='Port to be forwarded. To forward multiple ports, '\n+ 'use this option multiple times.')\n+def ssh(cluster: str, port_forward: Optional[List[int]]):\n+ \"\"\"ssh to the cluster CLUSTER.\n+\n+ CLUSTER is the name of the cluster to attach. If CLUSTER is not supplied,\n+ the last cluster will be attached.\n+\n+ Examples:\n+\n+ \\b\n+ # ssh to a specific cluster.\n+ sky ssh cluster_name\n+\n+ \\b\n+ # Port forward.\n+ sky ssh --port-forward 8080 --port-forward 4650 cluster_name\n+ sky ssh -p 8080 -p 4650 cluster_name\n+ \"\"\"\n+ # FIXME: make TPU part of handles; so that this kills TPUs too.\n+ name = cluster\n+\n+ to_ssh = name\n+ if to_ssh is None:\n+ launched_clusters = global_user_state.get_clusters()\n+ if len(launched_clusters) == 0:\n+ raise click.UsageError(\n+ 'No launched clusters found (see `sky status`).')\n+ to_ssh = sorted(launched_clusters, key=lambda x: x['launched_at'])[-1]\n+ handle = global_user_state.get_handle_from_cluster_name(to_ssh)\n+\n+ if handle is None:\n+ raise click.UsageError(\n+ f'Cluster {to_ssh} is not found (see `sky status`).')\n+\n+ # FIXME: Assumes a specific backend.\n+ _create_interactive_node(name,\n+ sky.Resources(),\n+ handle,\n+ port_forward=port_forward)\n+\n+\n @click.argument('task_id', required=False, type=str)\n @click.option('--all',\n '-a',\n default=None,\n is_flag=True,\n help='Cancel all tasks.')\n-def cancel(task_id, all): # pylint: disable=redefined-builtin\n+def cancel(task_id: str, all: Optional[bool]): # pylint: disable=redefined-builtin\n \"\"\"Cancel task(s).\n \n TASK_ID is the id of the task to cancel. If both TASK_ID and --all are\n@@ -357,20 +415,43 @@ def cancel(task_id, all): # pylint: disable=redefined-builtin\n default=None,\n type=str,\n help=_CLUSTER_FLAG_HELP)\n-def gpunode(cluster):\n- \"\"\"Launch an interactive GPU node.\n+@click.option('--port-forward',\n+ '-p',\n+ multiple=True,\n+ default=[],\n+ type=int,\n+ required=False,\n+ help='Port to be forwarded. To forward multiple ports, '\n+ 'use this option multiple times.')\n+def gpunode(cluster: str, port_forward: Optional[List[int]]):\n+ \"\"\"Launches an interactive GPU node.\n \n Automatically syncs current working directory.\n+\n+ Examples:\n+\n+ \\b\n+ # start gpunode\n+ sky gpunode\n+\n+ # creating a gpunode with name `cluster` or connecting to existed node.\n+ sky gpunode -c cluster_name\n+\n+ \\b\n+ # Port forward.\n+ sky gpunode --port-forward 8080 --port-forward 4650 cluster_name\n+ sky gpunode -p 8080 -p 4650 cluster_name\n \"\"\"\n # TODO: Sync code files between local and interactive node (watch rsync?)\n- # TODO: Add port forwarding to allow access to localhost:PORT for jupyter\n handle = None\n if cluster is not None:\n handle = global_user_state.get_handle_from_cluster_name(cluster)\n \n _create_interactive_node('gpunode',\n {sky.Resources(sky.AWS(), accelerators='V100')},\n- cluster_handle=handle)\n+ cluster_handle=handle,\n+ port_forward=port_forward,\n+ cluster_name=cluster)\n \n \n @cli.command()\n@@ -379,17 +460,41 @@ def gpunode(cluster):\n default=None,\n type=str,\n help=_CLUSTER_FLAG_HELP)\n-def cpunode(cluster):\n- \"\"\"Launch an interactive CPU node.\n+@click.option('--port-forward',\n+ '-p',\n+ multiple=True,\n+ default=[],\n+ type=int,\n+ required=False,\n+ help='Port to be forwarded. To forward multiple ports, '\n+ 'use this option multiple times.')\n+def cpunode(cluster: str, port_forward: Optional[List[int]]):\n+ \"\"\"Launches an interactive CPU node.\n \n Automatically syncs current working directory.\n+\n+ Examples:\n+\n+ \\b\n+ # start cpunode\n+ sky cpunode\n+\n+ # creating a cpunode with name `cluster` or connecting to existed node.\n+ sky cpunode -c cluster_name\n+\n+ \\b\n+ # Port forward.\n+ sky cpunode --port-forward 8080 --port-forward 4650 cluster_name\n+ sky cpunode -p 8080 -p 4650 cluster_name\n \"\"\"\n handle = None\n if cluster is not None:\n handle = global_user_state.get_handle_from_cluster_name(cluster)\n \n _create_interactive_node('cpunode', {sky.Resources(sky.AWS())},\n- cluster_handle=handle)\n+ cluster_handle=handle,\n+ port_forward=port_forward,\n+ cluster_name=cluster)\n \n \n def main():\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 4,\n \"problem_domain\": \"New Feature Additions\"\n}"}}},{"rowIdx":7080,"cells":{"instance_id":{"kind":"string","value":"skypilot-org__skypilot-68@82e94ab"},"repo":{"kind":"string","value":"skypilot-org/skypilot"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":68,"string":"68"},"title":{"kind":"string","value":"Support file_mounts destination paths that require root access."},"body":{"kind":"string","value":"Fixes #39.\r\n\r\nBoth these should now work:\r\n```\r\n/data/<25GB dir>: /data/<25GB dir>\r\n/data/<25GB dir>: gs://<dir>\r\n```\r\nAdded `examples/using_file_mounts.yaml` as a user guide.\r\n\r\n- [x] test resnet_app file_mounts again"},"created_at":{"kind":"string","value":"2021-11-26T17:25:23Z"},"problem_statement":{"kind":"string","value":"Error when creating directory during filemount\nI specify file_mounts like below\r\n```\r\nfile_mounts = {\r\n '/data/weichiang/dataset/': '/data/weichiang/dataset/',\r\n }\r\n```\r\nthe autoscaler setup failed and I got the permission denied error. \r\n```\r\nmkdir: cannot create directory ‘/data’: Permission denied \r\n```\r\nI had to change all the data paths in my codebase to make it work, which may be too inconvenient for users.\r\nCan we grant root permission during filemount?"},"hints_text":{"kind":"string","value":"file_mounts is synced before setup/init commands in autoscaler design: https://github.com/ray-project/ray/blob/333d0b43fdce13bc46b1f2b43d0b9f4d758ab1e9/python/ray/autoscaler/_private/updater.py#L349-L361\r\nso unfortunately we can't sudo make that dir first before file_mounts are synced. \r\n\r\nHow about\r\n```\r\nfile_mounts = {\r\n '~/data/weichiang/dataset/': '/data/weichiang/dataset/',\r\n}\r\nsetup = 'sudo ln -s ~/data /data && sudo chmod 777 /data && <rest of setup>'\r\n```\r\n\r\n@romilbhardwaj another reason for docker."},"resolved_issues":{"kind":"list like","value":[{"body":"I specify file_mounts like below\r\n```\r\nfile_mounts = {\r\n '/data/weichiang/dataset/': '/data/weichiang/dataset/',\r\n }\r\n```\r\nthe autoscaler setup failed and I got the permission denied error. \r\n```\r\nmkdir: cannot create directory ‘/data’: Permission denied \r\n```\r\nI had to change all the data paths in my codebase to make it work, which may be too inconvenient for users.\r\nCan we grant root permission during filemount?","number":39,"title":"Error when creating directory during filemount"}],"string":"[\n {\n \"body\": \"I specify file_mounts like below\\r\\n```\\r\\nfile_mounts = {\\r\\n '/data/weichiang/dataset/': '/data/weichiang/dataset/',\\r\\n }\\r\\n```\\r\\nthe autoscaler setup failed and I got the permission denied error. \\r\\n```\\r\\nmkdir: cannot create directory ‘/data’: Permission denied \\r\\n```\\r\\nI had to change all the data paths in my codebase to make it work, which may be too inconvenient for users.\\r\\nCan we grant root permission during filemount?\",\n \"number\": 39,\n \"title\": \"Error when creating directory during filemount\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"02fd66069c34693876ce85f7d4a915b4528a0f07"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"82e94ab872e3af3b81d61e0f295024f3665a6903\",\n \"head_commit_message\": \"Support file_mounts destination paths that require root access.\\n\\nFixes #39.\",\n \"patch_to_review\": \"diff --git a/prototype/config/aws-ray.yml.j2 b/prototype/config/aws-ray.yml.j2\\nindex fb81c684e00..42a9b9eb120 100644\\n--- a/prototype/config/aws-ray.yml.j2\\n+++ b/prototype/config/aws-ray.yml.j2\\n@@ -65,6 +65,13 @@ file_mounts: {\\n {%- endfor %}\\n }\\n \\n+{%- if initialization_commands is not none %}\\n+initialization_commands:\\n+{%- for cmd in initialization_commands %}\\n+ - {{cmd}}\\n+{%- endfor %}\\n+{%- endif %}\\n+\\n # Patterns for files to exclude when running rsync up or rsync down\\n # rsync_exclude:\\n # - \\\"**/.git\\\"\\ndiff --git a/prototype/config/gcp-ray.yml.j2 b/prototype/config/gcp-ray.yml.j2\\nindex 694a011dcdd..dc0877c9e6b 100644\\n--- a/prototype/config/gcp-ray.yml.j2\\n+++ b/prototype/config/gcp-ray.yml.j2\\n@@ -87,6 +87,13 @@ file_mounts: {\\n {%- endfor %}\\n }\\n \\n+{%- if initialization_commands is not none %}\\n+initialization_commands:\\n+{%- for cmd in initialization_commands %}\\n+ - {{cmd}}\\n+{%- endfor %}\\n+{%- endif %}\\n+\\n # Patterns for files to exclude when running rsync up or rsync down\\n # rsync_exclude:\\n # - \\\"**/.git\\\"\\ndiff --git a/prototype/examples/root_file_mount.yaml b/prototype/examples/root_file_mount.yaml\\nnew file mode 100644\\nindex 00000000000..4500f90cf46\\n--- /dev/null\\n+++ b/prototype/examples/root_file_mount.yaml\\n@@ -0,0 +1,15 @@\\n+# Example: file_mounts destination paths that require root access\\n+#\\n+# Sky will use sudo to create destination paths and run 'chown' on them, so that\\n+# the 'run' command (logged in as non-root) can still access them.\\n+resources:\\n+ cloud: aws\\n+\\n+# <VM path> : <local path>\\n+file_mounts:\\n+ /setup.py: ./setup.py\\n+ /sky: sky\\n+\\n+run: |\\n+ ls -l /setup.py\\n+ ls -lH /sky\\ndiff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\\nindex 38278b3f067..6b038973dab 100644\\n--- a/prototype/sky/backends/backend_utils.py\\n+++ b/prototype/sky/backends/backend_utils.py\\n@@ -28,6 +28,9 @@\\n IP_ADDR_REGEX = r'\\\\d{1,3}\\\\.\\\\d{1,3}\\\\.\\\\d{1,3}\\\\.\\\\d{1,3}'\\n SKY_LOGS_DIRECTORY = './sky_logs'\\n \\n+# Do not use /tmp because it gets cleared on VM restart.\\n+_SKY_REMOTE_FILE_MOUNTS_DIR = '~/sky_file_mounts/'\\n+\\n \\n def _get_rel_path(path: str) -> str:\\n cwd = os.getcwd()\\n@@ -52,6 +55,20 @@ def _fill_template(template_path: str,\\n return output_path\\n \\n \\n+def _wrap_file_mount(remote: str) -> str:\\n+ \\\"\\\"\\\"Prepends ~/<opaque dir>/ to a path to work around permission issues.\\n+\\n+ Examples:\\n+ /root/hello.txt -> ~/<opaque dir>/root/hello.txt\\n+ local.txt -> ~/<opaque dir>/local.txt\\n+\\n+ In initialization_commands of the ray autoscaler YAML, we can then create a\\n+ symlink to this wrapped path.\\n+ \\\"\\\"\\\"\\n+ return os.path.join(_SKY_REMOTE_FILE_MOUNTS_DIR, remote.lstrip('/'))\\n+\\n+\\n+# TODO: too many things happening here - leaky abstraction. Refactor.\\n def write_cluster_config(run_id: RunId,\\n task: task.Task,\\n cluster_config_template: str,\\n@@ -104,6 +121,25 @@ def write_cluster_config(run_id: RunId,\\n f.write(codegen)\\n setup_sh_path = f.name\\n \\n+ # File mounts handling:\\n+ # (1) in 'file_mounts' sections, add <prefix> to all target paths.\\n+ # (2) then, create symlinks from '/root/file' to '<prefix>/root/file'.\\n+ # We need to do these since as of Ray 1.8, this is not supported natively\\n+ # (Docker works though, of course):\\n+ # https://github.com/ray-project/ray/pull/9332\\n+ # https://github.com/ray-project/ray/issues/9326\\n+ mounts = task.get_local_to_remote_file_mounts()\\n+ wrapped_file_mounts = {}\\n+ initialization_commands = []\\n+ if mounts is not None:\\n+ for remote, local in mounts.items():\\n+ wrapped_remote = _wrap_file_mount(remote)\\n+ wrapped_file_mounts[wrapped_remote] = local\\n+ # NOTE: the use of sudo and the assumption of ubuntu.\\n+ symlink = (f'sudo ln -sf {wrapped_remote} {remote} && '\\n+ f'sudo chown ubuntu {remote}')\\n+ initialization_commands.append(symlink)\\n+\\n yaml_path = _fill_template(\\n cluster_config_template,\\n dict(\\n@@ -115,7 +151,9 @@ def write_cluster_config(run_id: RunId,\\n 'docker_image': task.docker_image,\\n 'container_name': task.container_name,\\n 'num_nodes': task.num_nodes,\\n- 'file_mounts': task.get_local_to_remote_file_mounts() or {},\\n+ # File mounts handling.\\n+ 'file_mounts': wrapped_file_mounts,\\n+ 'initialization_commands': initialization_commands or None,\\n # Region/zones.\\n 'region': region,\\n 'zones': ','.join(zones),\\ndiff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py\\nindex 41afeba9b43..3ca7c330e0f 100644\\n--- a/prototype/sky/backends/cloud_vm_ray_backend.py\\n+++ b/prototype/sky/backends/cloud_vm_ray_backend.py\\n@@ -321,7 +321,7 @@ def provision_with_retries(self, task: App, to_provision: Resources,\\n raise e\\n cluster_config_file = config_dict['ray']\\n \\n- tail_cmd = f'tail -n100 -f {log_path}'\\n+ tail_cmd = f'tail -f {log_path}'\\n logger.info(\\n f'To view progress: {Style.BRIGHT}{tail_cmd}{Style.RESET_ALL}')\\n # Redirect stdout/err to the file and streaming (if stream_logs).\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -104,6 +121,25 @@ def write_cluster_config(run_id: RunId,\n f.write(codegen)\n setup_sh_path = f.name\n \n+ # File mounts handling:\n+ # (1) in 'file_mounts' sections, add <prefix> to all target paths.\n+ # (2) then, create symlinks from '/root/file' to '<prefix>/root/file'.\n+ # We need to do these since as of Ray 1.8, this is not supported natively\n+ # (Docker works though, of course):\n+ # https://github.com/ray-project/ray/pull/9332\n+ # https://github.com/ray-project/ray/issues/9326\n+ mounts = task.get_local_to_remote_file_mounts()\n+ wrapped_file_mounts = {}\n+ initialization_commands = []\n+ if mounts is not None:\n+ for remote, local in mounts.items():\n+ wrapped_remote = _wrap_file_mount(remote)\n+ wrapped_file_mounts[wrapped_remote] = local\n+ # NOTE: the use of sudo and the assumption of ubuntu.\n+ symlink = (f'sudo ln -sf {wrapped_remote} {remote} && '\n+ f'sudo chown ubuntu {remote}')","line":null,"original_line":140,"original_start_line":null,"path":"prototype/sky/backends/backend_utils.py","start_line":null,"text":"@user1:\nI'm not super familiar with ray autoscaler works, but if it uses the same user for running initialization_commands, should we change this to 'sudo chown $USER {remote}'?"},{"diff_hunk":"@@ -28,6 +28,9 @@\n IP_ADDR_REGEX = r'\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}'\n SKY_LOGS_DIRECTORY = './sky_logs'\n \n+# Do not use /tmp because it gets cleared on VM restart.\n+_SKY_REMOTE_FILE_MOUNTS_DIR = '~/sky_file_mounts/'","line":null,"original_line":32,"original_start_line":null,"path":"prototype/sky/backends/backend_utils.py","start_line":null,"text":"@user1:\nConsidering there's state we'll be maintaining on remote VMs, should we start using a `.sky` directory in the home dir? This would then be something like `~/.sky/file_mounts/`\n\n@author:\nGreat point! How about a `~/_sky` or `~/_sky_`? Reasons: (1) we may want to ease debugging, `.sky` won't show on plain `ls`. (2) `~/sky` could work too, but may be \"unprotected\" and collide with user paths. Wdyt?\n\n@user1:\nGood point about `.sky` being hidden. `_sky` sounds good, lets go with that\n\n@author:\nDecided to go with ~/.sky to be consistent with tons of other tools."}],"string":"[\n {\n \"diff_hunk\": \"@@ -104,6 +121,25 @@ def write_cluster_config(run_id: RunId,\\n f.write(codegen)\\n setup_sh_path = f.name\\n \\n+ # File mounts handling:\\n+ # (1) in 'file_mounts' sections, add <prefix> to all target paths.\\n+ # (2) then, create symlinks from '/root/file' to '<prefix>/root/file'.\\n+ # We need to do these since as of Ray 1.8, this is not supported natively\\n+ # (Docker works though, of course):\\n+ # https://github.com/ray-project/ray/pull/9332\\n+ # https://github.com/ray-project/ray/issues/9326\\n+ mounts = task.get_local_to_remote_file_mounts()\\n+ wrapped_file_mounts = {}\\n+ initialization_commands = []\\n+ if mounts is not None:\\n+ for remote, local in mounts.items():\\n+ wrapped_remote = _wrap_file_mount(remote)\\n+ wrapped_file_mounts[wrapped_remote] = local\\n+ # NOTE: the use of sudo and the assumption of ubuntu.\\n+ symlink = (f'sudo ln -sf {wrapped_remote} {remote} && '\\n+ f'sudo chown ubuntu {remote}')\",\n \"line\": null,\n \"original_line\": 140,\n \"original_start_line\": null,\n \"path\": \"prototype/sky/backends/backend_utils.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nI'm not super familiar with ray autoscaler works, but if it uses the same user for running initialization_commands, should we change this to 'sudo chown $USER {remote}'?\"\n },\n {\n \"diff_hunk\": \"@@ -28,6 +28,9 @@\\n IP_ADDR_REGEX = r'\\\\d{1,3}\\\\.\\\\d{1,3}\\\\.\\\\d{1,3}\\\\.\\\\d{1,3}'\\n SKY_LOGS_DIRECTORY = './sky_logs'\\n \\n+# Do not use /tmp because it gets cleared on VM restart.\\n+_SKY_REMOTE_FILE_MOUNTS_DIR = '~/sky_file_mounts/'\",\n \"line\": null,\n \"original_line\": 32,\n \"original_start_line\": null,\n \"path\": \"prototype/sky/backends/backend_utils.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nConsidering there's state we'll be maintaining on remote VMs, should we start using a `.sky` directory in the home dir? This would then be something like `~/.sky/file_mounts/`\\n\\n@author:\\nGreat point! How about a `~/_sky` or `~/_sky_`? Reasons: (1) we may want to ease debugging, `.sky` won't show on plain `ls`. (2) `~/sky` could work too, but may be \\\"unprotected\\\" and collide with user paths. Wdyt?\\n\\n@user1:\\nGood point about `.sky` being hidden. `_sky` sounds good, lets go with that\\n\\n@author:\\nDecided to go with ~/.sky to be consistent with tons of other tools.\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"3c9c54c87dad75d41ed20a7eddc87eccae769480"},"merged_patch":{"kind":"string","value":"diff --git a/prototype/config/aws-ray.yml.j2 b/prototype/config/aws-ray.yml.j2\nindex aae1a8b8bb3..e1052843e76 100644\n--- a/prototype/config/aws-ray.yml.j2\n+++ b/prototype/config/aws-ray.yml.j2\n@@ -65,6 +65,13 @@ file_mounts: {\n {%- endfor %}\n }\n \n+{%- if initialization_commands is not none %}\n+initialization_commands:\n+{%- for cmd in initialization_commands %}\n+ - {{cmd}}\n+{%- endfor %}\n+{%- endif %}\n+\n # Patterns for files to exclude when running rsync up or rsync down\n # rsync_exclude:\n # - \"**/.git\"\ndiff --git a/prototype/config/gcp-ray.yml.j2 b/prototype/config/gcp-ray.yml.j2\nindex ae7429c85cc..67e74531af8 100644\n--- a/prototype/config/gcp-ray.yml.j2\n+++ b/prototype/config/gcp-ray.yml.j2\n@@ -87,6 +87,13 @@ file_mounts: {\n {%- endfor %}\n }\n \n+{%- if initialization_commands is not none %}\n+initialization_commands:\n+{%- for cmd in initialization_commands %}\n+ - {{cmd}}\n+{%- endfor %}\n+{%- endif %}\n+\n # Patterns for files to exclude when running rsync up or rsync down\n # rsync_exclude:\n # - \"**/.git\"\ndiff --git a/prototype/examples/using_file_mounts.yaml b/prototype/examples/using_file_mounts.yaml\nnew file mode 100644\nindex 00000000000..f9c7b2d75b6\n--- /dev/null\n+++ b/prototype/examples/using_file_mounts.yaml\n@@ -0,0 +1,50 @@\n+# Example: using file mounts\n+#\n+# File mounts allow syncing local files (or cloud URLs) to the VM where a Task\n+# will run. Syncing is done before the Task's execution so that its run command\n+# can access these files. After syncing, the mounted paths can be opened, read,\n+# or written as usual.\n+#\n+# Destination paths must be absolute paths, not relative.\n+#\n+# Caveat:\n+#\n+# Destination paths may be created as *symlinks* under the hood. Some\n+# commands may require flags to follow symlinks (e.g., ls -H; du -L).\n+\n+resources:\n+ cloud: gcp\n+\n+# Format:\n+# <destination on VM>: <source, local or cloud>\n+file_mounts:\n+\n+ ###############################################\n+ # Sync from local files/directories (rsync) #\n+ ###############################################\n+ /setup.py: ./setup.py\n+ /sky: .\n+ /more/levels/should/work: .\n+\n+ #############################################\n+ # Sync from Google Cloud Storage (gsutil) #\n+ #############################################\n+\n+ # Syncing a regular object.\n+ /train-00001-of-01024: gs://cloud-tpu-test-datasets/fake_imagenet/train-00001-of-01024\n+\n+ # If a source path points to a \"directory\", its contents will be recursively\n+ # synced (subdirectories included).\n+ /data/fake_imagenet: gs://cloud-tpu-test-datasets/fake_imagenet\n+\n+run: |\n+ ls -l /setup.py\n+\n+ cd /sky\n+ pip3 install -e .\n+\n+ du -schL /train-00001-of-01024\n+ # FIXME: this shows utf-8 decode error for run_with_log().\n+ # head /train-00001-of-01024\n+\n+ ls -lH /data/fake_imagenet | head -n10\ndiff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\nindex 0ab4a0dbd9f..88fe1ead6bf 100644\n--- a/prototype/sky/backends/backend_utils.py\n+++ b/prototype/sky/backends/backend_utils.py\n@@ -31,6 +31,9 @@\n IP_ADDR_REGEX = r'\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}'\n SKY_LOGS_DIRECTORY = './sky_logs'\n \n+# Do not use /tmp because it gets cleared on VM restart.\n+_SKY_REMOTE_FILE_MOUNTS_DIR = '~/.sky/file_mounts/'\n+\n \n def get_rel_path(path: str) -> str:\n cwd = os.getcwd()\n@@ -64,6 +67,21 @@ def _fill_template(template_path: str,\n return output_path\n \n \n+def wrap_file_mount(path: str) -> str:\n+ \"\"\"Prepends ~/<opaque dir>/ to a path to work around permission issues.\n+\n+ Examples:\n+ /root/hello.txt -> ~/<opaque dir>/root/hello.txt\n+ local.txt -> ~/<opaque dir>/local.txt\n+\n+ After the path is synced, we can later create a symlink to this wrapped\n+ path from the original path, e.g., in the initialization_commands of the\n+ ray autoscaler YAML.\n+ \"\"\"\n+ return os.path.join(_SKY_REMOTE_FILE_MOUNTS_DIR, path.lstrip('/'))\n+\n+\n+# TODO: too many things happening here - leaky abstraction. Refactor.\n def write_cluster_config(run_id: RunId,\n task: task_lib.Task,\n cluster_config_template: str,\n@@ -121,6 +139,44 @@ def write_cluster_config(run_id: RunId,\n f.write(codegen)\n setup_sh_path = f.name\n \n+ # File mounts handling:\n+ # (1) in 'file_mounts' sections, add <prefix> to all target paths.\n+ # (2) then, create symlinks from '/.../file' to '<prefix>/.../file'.\n+ # We need to do these since as of Ray 1.8, this is not supported natively\n+ # (Docker works though, of course):\n+ # https://github.com/ray-project/ray/pull/9332\n+ # https://github.com/ray-project/ray/issues/9326\n+ mounts = task.get_local_to_remote_file_mounts()\n+ wrapped_file_mounts = {}\n+ initialization_commands = []\n+ if mounts is not None:\n+ for remote, local in mounts.items():\n+ wrapped_remote = wrap_file_mount(remote)\n+ wrapped_file_mounts[wrapped_remote] = local\n+ # Point 'remote' (may or may not exist) to 'wrapped_remote'\n+ # (guaranteed to exist by ray autoscaler's use of rsync).\n+ #\n+ # 'remote' can have multiple levels:\n+ # - relative paths, a/b/c\n+ # - absolute paths, /a/b/c\n+ symlink_to_make = remote.rstrip('/')\n+ dir_of_symlink = os.path.dirname(remote)\n+ # Below, use sudo in case the symlink needs sudo access to create.\n+ command = ' && '.join([\n+ # Prepare to create the symlink:\n+ # 1. make sure its dir exists.\n+ f'sudo mkdir -p {dir_of_symlink}',\n+ # 2. remove any existing symlink (ln -f may throw 'cannot\n+ # overwrite directory', if the link exists and points to a\n+ # directory).\n+ f'(sudo rm {symlink_to_make} &>/dev/null || true)',\n+ # Link.\n+ f'sudo ln -s {wrapped_remote} {symlink_to_make}',\n+ # chown.\n+ f'sudo chown $USER {symlink_to_make}',\n+ ])\n+ initialization_commands.append(command)\n+\n yaml_path = _fill_template(\n cluster_config_template,\n dict(\n@@ -133,7 +189,9 @@ def write_cluster_config(run_id: RunId,\n 'docker_image': task.docker_image,\n 'container_name': task.container_name,\n 'num_nodes': task.num_nodes,\n- 'file_mounts': task.get_local_to_remote_file_mounts() or {},\n+ # File mounts handling.\n+ 'file_mounts': wrapped_file_mounts,\n+ 'initialization_commands': initialization_commands or None,\n # Region/zones.\n 'region': region,\n 'zones': ','.join(zones),\ndiff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py\nindex 948c51554b1..cfcc524c3b5 100644\n--- a/prototype/sky/backends/cloud_vm_ray_backend.py\n+++ b/prototype/sky/backends/cloud_vm_ray_backend.py\n@@ -51,7 +51,8 @@\n print('available_resources:', ray.available_resources())\n print('live nodes:', ray.state.node_ids())\n \n- def redirect_process_output(proc, log_path, stream_logs, start_streaming_at=''):\n+ def redirect_process_output(\n+ proc, log_path, stream_logs, start_streaming_at=''):\n dirname = os.path.dirname(log_path)\n os.makedirs(dirname, exist_ok=True)\n \n@@ -496,21 +497,56 @@ def sync_file_mounts(\n all_file_mounts: Dict[Path, Path],\n cloud_to_remote_file_mounts: Optional[Dict[Path, Path]],\n ) -> None:\n- # TODO: this only syncs to head.\n+ # TODO: this function currently only syncs to head.\n # 'all_file_mounts' should already have been handled in provision()\n # using the yaml file. Here we handle cloud -> remote file transfers.\n mounts = cloud_to_remote_file_mounts\n- if mounts is not None:\n- for dst, src in mounts.items():\n- storage = cloud_stores.get_storage_from_path(src)\n- # TODO: room for improvement. Here there are many moving parts\n- # (download gsutil on remote, run gsutil on remote). Consider\n- # alternatives (smart_open, each provider's own sdk), a\n- # data-transfer container etc. We also assumed 'src' is a\n- # directory.\n- download_command = storage.make_download_dir_command(\n- source=src, destination=dst)\n- _run(f'ray exec {handle} \\'{download_command}\\'')\n+ if mounts is None:\n+ return\n+ for dst, src in mounts.items():\n+ # TODO: room for improvement. Here there are many moving parts\n+ # (download gsutil on remote, run gsutil on remote). Consider\n+ # alternatives (smart_open, each provider's own sdk), a\n+ # data-transfer container etc.\n+ storage = cloud_stores.get_storage_from_path(src)\n+ # Sync to a safe-to-write \"wrapped\" path.\n+ wrapped_dst = backend_utils.wrap_file_mount(dst)\n+ if storage.is_directory(src):\n+ sync = storage.make_sync_dir_command(source=src,\n+ destination=wrapped_dst)\n+ else:\n+ sync = storage.make_sync_file_command(source=src,\n+ destination=wrapped_dst)\n+ # Symlink to the wrapped path.\n+ symlink_to_make = dst.rstrip('/')\n+ dir_of_symlink = os.path.dirname(symlink_to_make)\n+ # Below, use sudo in case the symlink needs sudo access to create.\n+ command = ' && '.join([\n+ # Prepare to create the symlink:\n+ # 1. make sure its dir exists.\n+ f'sudo mkdir -p {dir_of_symlink}',\n+ # 2. remove any existing symlink (otherwise, gsutil errors).\n+ f'(sudo rm {symlink_to_make} &>/dev/null || true)',\n+ # Make the wrapped dir.\n+ f'mkdir -p {wrapped_dst}',\n+ # Both the wrapped and the symlink dir exist; sync.\n+ sync,\n+ # Link.\n+ f'sudo ln -s {wrapped_dst.rstrip(\"/\")} {symlink_to_make}',\n+ # chown.\n+ f'sudo chown $USER {dst}',\n+ ])\n+ log_path = os.path.join(self.log_dir,\n+ 'file_mounts_cloud_to_remote.log')\n+ proc, unused_stdout, unused_stderr = _run_with_log(\n+ f'ray exec {handle} \\'{command}\\'',\n+ os.path.abspath(log_path),\n+ stream_logs=True,\n+ shell=True)\n+ if proc.returncode:\n+ raise ValueError(\n+ f'File mounts\\n\\t{src} -> {dst}\\nfailed to sync. '\n+ f'See errors above and log: {log_path}')\n \n def run_post_setup(self, handle: ResourceHandle, post_setup_fn: PostSetupFn,\n task: App) -> None:\ndiff --git a/prototype/sky/cloud_stores.py b/prototype/sky/cloud_stores.py\nindex aeb861fa9df..d51e4b6e950 100644\n--- a/prototype/sky/cloud_stores.py\n+++ b/prototype/sky/cloud_stores.py\n@@ -9,41 +9,96 @@\n The full-blown impl should handle authentication so each user's private\n datasets can be accessed.\n \"\"\"\n+import subprocess\n import urllib.parse\n \n \n+def _run(cmd, **kwargs):\n+ return subprocess.run(cmd, shell=True, check=True, **kwargs)\n+\n+\n+def _run_captured_outputs(cmd, **kwargs):\n+ return _run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE, **kwargs)\n+\n+\n class CloudStorage(object):\n \"\"\"Interface for a cloud object store.\"\"\"\n \n- def make_download_dir_command(self, source: str, destination: str) -> str:\n- \"\"\"Makes a runnable bash command to download a 'directory'.\"\"\"\n+ def is_directory(self, url: str) -> bool:\n+ \"\"\"Returns whether 'url' is a directory.\n+\n+ In cloud object stores, a \"directory\" refers to a regular object whose\n+ name is a prefix of other objects.\n+ \"\"\"\n+ raise NotImplementedError\n+\n+ def make_sync_dir_command(self, source: str, destination: str) -> str:\n+ \"\"\"Makes a runnable bash command to sync a 'directory'.\"\"\"\n+ raise NotImplementedError\n+\n+ def make_sync_file_command(self, source: str, destination: str) -> str:\n+ \"\"\"Makes a runnable bash command to sync a file.\"\"\"\n raise NotImplementedError\n \n \n class GcsCloudStorage(CloudStorage):\n \"\"\"Google Cloud Storage.\"\"\"\n \n- def make_download_dir_command(self, source: str, destination: str) -> str:\n- \"\"\"Downloads using gsutil.\n+ # We use gsutil as a basic implementation. One pro is that its -m\n+ # multi-threaded download is nice, which frees us from implementing\n+ # parellel workers on our end.\n+ _GET_GSUTIL = [\n+ 'pushd /tmp &>/dev/null',\n+ # Skip if /tmp/gsutil already exists.\n+ 'ls gsutil &>/dev/null || (wget --quiet '\n+ 'https://storage.googleapis.com/pub/gsutil.tar.gz && '\n+ 'tar xzf gsutil.tar.gz)',\n+ 'popd &>/dev/null',\n+ ]\n+\n+ _GSUTIL = '/tmp/gsutil/gsutil'\n+\n+ def is_directory(self, url: str) -> bool:\n+ \"\"\"Returns whether 'url' is a directory.\n+\n+ In cloud object stores, a \"directory\" refers to a regular object whose\n+ name is a prefix of other objects.\n+ \"\"\"\n+ commands = list(self._GET_GSUTIL)\n+ commands.append(f'{self._GSUTIL} ls -d {url}')\n+ command = ' && '.join(commands)\n+ p = _run_captured_outputs(command)\n+ out = p.stdout.decode().strip()\n+ # gsutil ls -d url\n+ # --> url.rstrip('/') if url is not a directory\n+ # --> url with an ending '/' if url is a directory\n+ if not out.endswith('/'):\n+ assert out == url.rstrip('/'), (out, url)\n+ return False\n+ url = url if url.endswith('/') else (url + '/')\n+ assert out == url, (out, url)\n+ return True\n+\n+ def make_sync_dir_command(self, source: str, destination: str) -> str:\n+ \"\"\"Downloads a directory using gsutil.\n \n Limitation: no authentication support; 'source' is assumed to in a\n publicly accessible bucket.\n \"\"\"\n- # We use gsutil as a basic implementation. One pro is that its -m\n- # multi-threaded download is nice, which frees us from implementing\n- # parellel workers on our end.\n- get_gsutil = [\n- 'pushd /tmp &>/dev/null',\n- # Skip if /tmp/gsutil already exists.\n- 'ls gsutil &>/dev/null || (wget --quiet '\n- 'https://storage.googleapis.com/pub/gsutil.tar.gz && '\n- 'tar xzf gsutil.tar.gz)',\n- 'popd &>/dev/null',\n- ]\n download_via_gsutil = (\n- f'mkdir -p {destination} && '\n- f'/tmp/gsutil/gsutil -m rsync -r {source} {destination}')\n- all_commands = get_gsutil\n+ f'{self._GSUTIL} -m rsync -r {source} {destination}')\n+ all_commands = list(self._GET_GSUTIL)\n+ all_commands.append(download_via_gsutil)\n+ return ' && '.join(all_commands)\n+\n+ def make_sync_file_command(self, source: str, destination: str) -> str:\n+ \"\"\"Downloads a file using gsutil.\n+\n+ Limitation: no authentication support; 'source' is assumed to in a\n+ publicly accessible bucket.\n+ \"\"\"\n+ download_via_gsutil = f'{self._GSUTIL} -m cp {source} {destination}'\n+ all_commands = list(self._GET_GSUTIL)\n all_commands.append(download_via_gsutil)\n return ' && '.join(all_commands)\n \ndiff --git a/prototype/sky/execution.py b/prototype/sky/execution.py\nindex 3410e821e20..c72c4f24910 100644\n--- a/prototype/sky/execution.py\n+++ b/prototype/sky/execution.py\n@@ -12,33 +12,17 @@\n \n - ray exec + each task's commands\n \"\"\"\n-from typing import Any, Callable, Dict, List, Union, Optional\n+from typing import Any, Optional\n \n import sky\n from sky import backends\n from sky import logging\n from sky import optimizer\n-from sky.backends import backend_utils\n \n logger = logging.init_logger(__name__)\n \n-IPAddr = str\n-ShellCommand = str\n-ShellCommandGenerator = Callable[[List[IPAddr]], Dict[IPAddr, ShellCommand]]\n-ShellCommandOrGenerator = Union[ShellCommand, ShellCommandGenerator]\n-\n-SKY_LOGS_DIRECTORY = './logs'\n-STREAM_LOGS_TO_CONSOLE = True\n-\n-App = backend_utils.App\n-RunId = backend_utils.RunId\n-\n-ResourceHandle = str\n-\n OptimizeTarget = optimizer.OptimizeTarget\n \n-SKY_REMOTE_WORKDIR = backend_utils.SKY_REMOTE_WORKDIR\n-\n \n def execute_v2(dag: sky.Dag,\n dryrun: bool = False,\ndiff --git a/prototype/sky/task.py b/prototype/sky/task.py\nindex 97f3635fc20..412c7697630 100644\n--- a/prototype/sky/task.py\n+++ b/prototype/sky/task.py\n@@ -247,6 +247,10 @@ def set_file_mounts(self, file_mounts: Dict[str, str]):\n node from which the task is launched.\n \"\"\"\n self.file_mounts = file_mounts\n+ for remote, unused_source in file_mounts.items():\n+ if not os.path.isabs(remote):\n+ raise ValueError('File mounts: remote paths should be absolute,'\n+ f' not relative or \"~/...\". Found: {remote}')\n return self\n \n def set_blocked_clouds(self, blocked_clouds: Set[clouds.Cloud]):\n@@ -288,7 +292,10 @@ def __rshift__(self, b):\n def __repr__(self):\n if self.name:\n return self.name\n- s = 'Task(run=\\'{}\\')'.format(self.run)\n+ if len(self.run) > 20:\n+ s = 'Task(run=\\'{}...\\')'.format(self.run[:20])\n+ else:\n+ s = 'Task(run=\\'{}\\')'.format(self.run)\n if self.inputs is not None:\n s += '\\n inputs: {}'.format(self.inputs)\n if self.outputs is not None:\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 3,\n \"problem_domain\": \"Bug Fixes\"\n}"}}},{"rowIdx":7081,"cells":{"instance_id":{"kind":"string","value":"espnet__espnet-1840@5e00a63"},"repo":{"kind":"string","value":"espnet/espnet"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":1840,"string":"1,840"},"title":{"kind":"string","value":"Add test for torch>1.1"},"body":{"kind":"string","value":"- Add test for torch>1.1\r\n- Now the tested items are duplicated, so I changed the range\r\n - https://github.com/espnet/espnet/blob/34b21ca720d698de72d20b1d601ab4671d7badac/README.md\r\n - Travis-ci: only builds the documentation and codecov without testing with python=3.8.\r\n - Circleci: Testing of different OS with `conda`, Python=3.6, Pytorch=1.4\r\n - Github-actions: Testing of different PyTorch version with `pip`, ubuntu18, Python=3.7 or 3.8\r\n- I removed the test for nightly. Maybe we don't need it?\r\n- Fix #1832\r\n\r\n@ShigekiKarita Would you check the CI error of `test/test_recog.py`? I couldn't fix this."},"created_at":{"kind":"string","value":"2020-04-15T13:40:58Z"},"problem_statement":{"kind":"string","value":"transformer bug in Pytorch 1.2.0\nespnet/espnet/nets/pytorch_backend/transformer/mask.py \r\n`is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')\r\ndatatype = torch.bool if is_torch_1_2_plus else torch.uint8\r\n\r\n\r\ndef subsequent_mask(size, device=\"cpu\", dtype=datatype):\r\n \"\"\"Create mask for subsequent steps (1, size, size).\r\n :param int size: size of mask\r\n :param str device: \"cpu\" or \"cuda\" or torch.Tensor.device\r\n :param torch.dtype dtype: result dtype\r\n :rtype: torch.Tensor\r\n >>> subsequent_mask(3)\r\n [[1, 0, 0],\r\n [1, 1, 0],\r\n [1, 1, 1]]\r\n \"\"\"\r\n ret = torch.ones(size, size, device=device, dtype=dtype)\r\n return torch.tril(ret, out=ret)\r\n`\r\nRuntimeError: \"tril\" not implemented for 'Bool'\r\n\r\npytorch 1.2.0 with GPU or CPU"},"hints_text":{"kind":"string","value":"I thought that transformer is working on any pytorch versions.\r\nDoes it only happen in pytorch 1.2.0?\r\n\n> I thought that transformer is working on any pytorch versions.\r\n> Does it only happen in pytorch 1.2.0?\r\n\r\nYes，I test with 1.0.0 1.1.0 1.2.0 1.3.0 . It only happen in pytorch 1.2.0. Before 1.2.0 ,pytorch Tensor doesn't have Boolean Type, So it works. But when in 1.2.0, tril not implemented for Bool tensor. > 1.2.0 tril works for bool.\nMany thanks.\r\nHmm. This is very strange...\r\nPlease check PR in #1840 \r\n@kamo-naoyuki, thanks for taking care of it."},"resolved_issues":{"kind":"list like","value":[{"body":"espnet/espnet/nets/pytorch_backend/transformer/mask.py \r\n`is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')\r\ndatatype = torch.bool if is_torch_1_2_plus else torch.uint8\r\n\r\n\r\ndef subsequent_mask(size, device=\"cpu\", dtype=datatype):\r\n \"\"\"Create mask for subsequent steps (1, size, size).\r\n :param int size: size of mask\r\n :param str device: \"cpu\" or \"cuda\" or torch.Tensor.device\r\n :param torch.dtype dtype: result dtype\r\n :rtype: torch.Tensor\r\n >>> subsequent_mask(3)\r\n [[1, 0, 0],\r\n [1, 1, 0],\r\n [1, 1, 1]]\r\n \"\"\"\r\n ret = torch.ones(size, size, device=device, dtype=dtype)\r\n return torch.tril(ret, out=ret)\r\n`\r\nRuntimeError: \"tril\" not implemented for 'Bool'\r\n\r\npytorch 1.2.0 with GPU or CPU ","number":1832,"title":"transformer bug in Pytorch 1.2.0"}],"string":"[\n {\n \"body\": \"espnet/espnet/nets/pytorch_backend/transformer/mask.py \\r\\n`is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')\\r\\ndatatype = torch.bool if is_torch_1_2_plus else torch.uint8\\r\\n\\r\\n\\r\\ndef subsequent_mask(size, device=\\\"cpu\\\", dtype=datatype):\\r\\n \\\"\\\"\\\"Create mask for subsequent steps (1, size, size).\\r\\n :param int size: size of mask\\r\\n :param str device: \\\"cpu\\\" or \\\"cuda\\\" or torch.Tensor.device\\r\\n :param torch.dtype dtype: result dtype\\r\\n :rtype: torch.Tensor\\r\\n >>> subsequent_mask(3)\\r\\n [[1, 0, 0],\\r\\n [1, 1, 0],\\r\\n [1, 1, 1]]\\r\\n \\\"\\\"\\\"\\r\\n ret = torch.ones(size, size, device=device, dtype=dtype)\\r\\n return torch.tril(ret, out=ret)\\r\\n`\\r\\nRuntimeError: \\\"tril\\\" not implemented for 'Bool'\\r\\n\\r\\npytorch 1.2.0 with GPU or CPU \",\n \"number\": 1832,\n \"title\": \"transformer bug in Pytorch 1.2.0\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"8586d22fc15aa09190d86ed1284005e3e6602cd2"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"5e00a638f83682d20764eef1d5c81d798a0ec106\",\n \"head_commit_message\": \"add ci-test for pytorch>=1.2\",\n \"patch_to_review\": \"diff --git a/.circleci/config.yml b/.circleci/config.yml\\nindex 15b9b9e9c6d..9bd3d43194e 100644\\n--- a/.circleci/config.yml\\n+++ b/.circleci/config.yml\\n@@ -18,13 +18,14 @@ jobs:\\n docker:\\n - image: circleci/buildpack-deps:18.04\\n environment:\\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\\n- ESPNET_PYTHON_VERSION: 3.7.3\\n+ ESPNET_PYTHON_VERSION: 3.6\\n TH_VERSION: 1.1.0\\n CHAINER_VERSION: 5.0.0\\n USE_CONDA: true\\n CC: gcc-7\\n CXX: g++-7\\n+ # To avoid UnicodeEncodeError for python<=3.6\\n+ LC_ALL: en_US.UTF-8\\n working_directory: ~/repo\\n \\n steps:\\n@@ -34,6 +35,7 @@ jobs:\\n command: |\\n sudo apt-get update -qq\\n sudo apt-get install -qq -y cmake g++-7 libsndfile1-dev bc\\n+ sudo localedef -f UTF-8 -i en_US en_US\\n - run:\\n name: install espnet\\n command: |\\n@@ -66,13 +68,14 @@ jobs:\\n docker:\\n - image: circleci/buildpack-deps:16.04\\n environment:\\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\\n- ESPNET_PYTHON_VERSION: 3.7.3\\n+ ESPNET_PYTHON_VERSION: 3.6\\n TH_VERSION: 1.1.0\\n CHAINER_VERSION: 5.0.0\\n USE_CONDA: true\\n CC: gcc-7\\n CXX: g++-7\\n+ # To avoid UnicodeEncodeError for python<=3.6\\n+ LC_ALL: en_US.UTF-8\\n working_directory: ~/repo\\n \\n steps:\\n@@ -85,6 +88,7 @@ jobs:\\n sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test\\n sudo apt-get update -qq\\n sudo apt-get install -qq -y cmake g++-7 libsndfile1-dev bc\\n+ sudo localedef -f UTF-8 -i en_US en_US\\n - run:\\n name: install espnet\\n command: |\\n@@ -117,13 +121,14 @@ jobs:\\n docker:\\n - image: centos:7\\n environment:\\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\\n- ESPNET_PYTHON_VERSION: 3.7.3\\n+ ESPNET_PYTHON_VERSION: 3.6\\n TH_VERSION: 1.1.0\\n CHAINER_VERSION: 5.0.0\\n USE_CONDA: true\\n CC: /opt/rh/devtoolset-7/root/usr/bin/gcc\\n CXX: /opt/rh/devtoolset-7/root/usr/bin/g++\\n+ # To avoid UnicodeEncodeError for python<=3.6\\n+ LC_ALL: en_US.UTF-8\\n working_directory: ~/repo\\n \\n steps:\\n@@ -133,6 +138,7 @@ jobs:\\n yum install -y git centos-release-scl cmake libsndfile make bzip2 wget which unzip bc\\n yum-config-manager --enable rhel-server-rhscl-7-rpms\\n yum install -y devtoolset-7-gcc-c++\\n+ localedef -f UTF-8 -i en_US en_US\\n - checkout\\n - run:\\n name: install espnet\\n@@ -173,13 +179,14 @@ jobs:\\n docker:\\n - image: debian:9\\n environment:\\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\\n- ESPNET_PYTHON_VERSION: 3.7.3\\n+ ESPNET_PYTHON_VERSION: 3.6\\n TH_VERSION: 1.1.0\\n CHAINER_VERSION: 5.0.0\\n USE_CONDA: true\\n CC: gcc-6\\n CXX: g++-6\\n+ # To avoid UnicodeEncodeError for python<=3.6\\n+ LC_ALL: en_US.UTF-8\\n working_directory: ~/repo\\n \\n steps:\\n@@ -188,7 +195,8 @@ jobs:\\n name: install dependencies\\n command: |\\n apt-get update -qq\\n- apt-get install -qq -y git cmake g++-6 libsndfile1-dev unzip bzip2 wget curl bc\\n+ apt-get install -qq -y git cmake g++-6 libsndfile1-dev unzip bzip2 wget curl bc locales\\n+ localedef -f UTF-8 -i en_US en_US\\n - run:\\n name: install espnet\\n command: |\\ndiff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml\\nindex 770583b8288..a613b72af6a 100644\\n--- a/.github/workflows/ci.yaml\\n+++ b/.github/workflows/ci.yaml\\n@@ -8,11 +8,22 @@ jobs:\\n strategy:\\n max-parallel: 20\\n matrix:\\n- os: [ubuntu-16.04, ubuntu-18.04]\\n- python-version: [3.7]\\n- pytorch-version: [1.0.1, 1.1]\\n+ # os: [ubuntu-16.04, ubuntu-18.04]\\n+ os: [ubuntu-18.04]\\n+ python-version: [3.7, 3.8]\\n+ pytorch-version: [1.0.1, 1.1.0, 1.2.0, 1.3.1, 1.4.0]\\n chainer-version: [6.0.0]\\n- use-conda: [true, false]\\n+ # NOTE(kamo): Conda is tested by Circle-CI\\n+ use-conda: [false]\\n+ exclude:\\n+ - python-version: 3.8\\n+ pytorch-version: 1.0.1\\n+ - python-version: 3.8\\n+ pytorch-version: 1.1.0\\n+ - python-version: 3.8\\n+ pytorch-version: 1.2.0\\n+ - python-version: 3.8\\n+ pytorch-version: 1.3.1\\n steps:\\n - uses: actions/checkout@master\\n - uses: actions/setup-python@v1\\ndiff --git a/.mergify.yml b/.mergify.yml\\nindex c34ef7bed6a..75ccc4f7e3d 100644\\n--- a/.mergify.yml\\n+++ b/.mergify.yml\\n@@ -2,14 +2,12 @@ pull_request_rules:\\n - name: automatic merge if label=auto-merge\\n conditions:\\n - \\\"label=auto-merge\\\"\\n- - \\\"status-success=linter_and_test (ubuntu-16.04, 3.7, 1.0.1, 6.0.0, true)\\\"\\n- - \\\"status-success=linter_and_test (ubuntu-16.04, 3.7, 1.0.1, 6.0.0, false)\\\"\\n- - \\\"status-success=linter_and_test (ubuntu-16.04, 3.7, 1.1, 6.0.0, true)\\\"\\n- - \\\"status-success=linter_and_test (ubuntu-16.04, 3.7, 1.1, 6.0.0, false)\\\"\\n- - \\\"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.0.1, 6.0.0, true)\\\"\\n - \\\"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.0.1, 6.0.0, false)\\\" \\n- - \\\"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.1, 6.0.0, true)\\\"\\n - \\\"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.1, 6.0.0, false)\\\"\\n+ - \\\"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.2, 6.0.0, false)\\\"\\n+ - \\\"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.3.1, 6.0.0, false)\\\"\\n+ - \\\"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.4.0, 6.0.0, false)\\\"\\n+ - \\\"status-success=linter_and_test (ubuntu-18.04, 3.8, 1.4.0, 6.0.0, false)\\\"\\n - \\\"status-success=ci/circleci: test-centos7\\\"\\n - \\\"status-success=ci/circleci: test-debian9\\\"\\n - \\\"status-success=ci/circleci: test-ubuntu16\\\"\\ndiff --git a/.travis.yml b/.travis.yml\\nindex cecea093152..cde20025949 100644\\n--- a/.travis.yml\\n+++ b/.travis.yml\\n@@ -1,7 +1,7 @@\\n dist: xenial\\n language: python\\n python:\\n- - \\\"3.7\\\"\\n+ - \\\"3.8\\\"\\n \\n cache:\\n - pip\\n@@ -21,24 +21,24 @@ addons:\\n \\n env:\\n # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\\n- - USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=1.0.1 CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\\n- - USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=1.1.0 CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\\n+ - USE_CONDA=false ESPNET_PYTHON_VERSION=3.8 TH_VERSION=1.4.0 CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\\n # torch nightly\\n- - USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=nightly CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\\n+ # - USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=nightly CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\\n \\n matrix:\\n allow_failures:\\n # torch nightly\\n- - env: USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=nightly CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\\n+ # - env: USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=nightly CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\\n \\n install:\\n - travis_retry ./ci/install.sh\\n- - travis_retry ./ci/install_kaldi.sh\\n+ # - travis_retry ./ci/install_kaldi.sh\\n \\n script:\\n- - ./ci/test_shell.sh\\n+ # NOTE(kamo): Codecov and build documentation only\\n+ # - ./ci/test_shell.sh\\n - ./ci/test_python.sh\\n- - ./ci/test_integration.sh\\n+ # - ./ci/test_integration.sh\\n - ./ci/doc.sh\\n \\n sudo: false\\ndiff --git a/README.md b/README.md\\nindex d33ad6a556e..64ccd3ed7fb 100644\\n--- a/README.md\\n+++ b/README.md\\n@@ -2,9 +2,16 @@\\n \\n # ESPnet: end-to-end speech processing toolkit\\n \\n-[](https://github.com/espnet/espnet/actions)\\n-[](https://travis-ci.org/espnet/espnet)\\n-[](https://circleci.com/gh/espnet/espnet)\\n+|system/pytorch ver.|1.0.1|1.1.0|1.2.0|1.3.1|1.4.0|\\n+| :---: | :---: | :---: | :---: | :---: | :---: |\\n+|ubuntu18/python3.8/pip|||||[](https://github.com/espnet/espnet/actions)|\\n+|ubuntu18/python3.7/pip|[](https://github.com/espnet/espnet/actions)|[](https://github.com/espnet/espnet/actions)|[](https://github.com/espnet/espnet/actions)|[](https://github.com/espnet/espnet/actions)|[](https://github.com/espnet/espnet/actions)|\\n+|ubuntu18/python3.6/conda||[](https://circleci.com/gh/espnet/espnet)||||\\n+|ubuntu16/python3.6/conda||[](https://circleci.com/gh/espnet/espnet)||||\\n+|debian9/python3.6/conda||[](https://circleci.com/gh/espnet/espnet)||||\\n+|centos7/python3.6/conda||[](https://circleci.com/gh/espnet/espnet)||||\\n+|[docs/coverage] python3.8|||||[](https://travis-ci.org/espnet/espnet)|\\n+\\n [](https://codecov.io/gh/espnet/espnet)\\n [](https://mergify.io)\\n [](https://gitter.im/espnet-en/community?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)\\ndiff --git a/ci/install.sh b/ci/install.sh\\nindex 84ccb266e42..69cb7e50d17 100755\\n--- a/ci/install.sh\\n+++ b/ci/install.sh\\n@@ -18,7 +18,7 @@ if ${USE_CONDA}; then\\n if [[ ${TH_VERSION} == nightly ]]; then\\n conda install -q -y pytorch-nightly-cpu -c pytorch\\n else\\n- conda install -q -y pytorch-cpu=\\\"${TH_VERSION}\\\" -c pytorch\\n+ conda install -q -y pytorch=\\\"${TH_VERSION}\\\" cpuonly -c pytorch\\n fi\\n conda install -c conda-forge ffmpeg\\n else\\n@@ -29,8 +29,10 @@ else\\n \\n if [[ ${TH_VERSION} == nightly ]]; then\\n pip install torch_nightly -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html\\n- else\\n+ elif [[ ${TH_VERSION} == 1.0.1 ]] || [[ ${TH_VERSION} == 1.1.0 ]]; then\\n pip install --quiet torch==\\\"${TH_VERSION}\\\" -f https://download.pytorch.org/whl/cpu/stable\\n+ else\\n+ pip install --quiet torch==\\\"${TH_VERSION}+cpu\\\" -f https://download.pytorch.org/whl/torch_stable.html\\n fi\\n fi\\n \\ndiff --git a/espnet/nets/pytorch_backend/frontends/dnn_beamformer.py b/espnet/nets/pytorch_backend/frontends/dnn_beamformer.py\\nindex c583d705abd..942675e2051 100644\\n--- a/espnet/nets/pytorch_backend/frontends/dnn_beamformer.py\\n+++ b/espnet/nets/pytorch_backend/frontends/dnn_beamformer.py\\n@@ -13,7 +13,8 @@\\n from espnet.nets.pytorch_backend.frontends.mask_estimator import MaskEstimator\\n from torch_complex.tensor import ComplexTensor\\n \\n-is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2')\\n+is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')\\n+is_torch_1_3_plus = LooseVersion(torch.__version__) >= LooseVersion('1.3.0')\\n \\n \\n class DNN_Beamformer(torch.nn.Module):\\n@@ -146,9 +147,10 @@ def forward(self, psd_in: ComplexTensor, ilens: torch.LongTensor,\\n B, _, C = psd_in.size()[:3]\\n assert psd_in.size(2) == psd_in.size(3), psd_in.size()\\n # psd_in: (B, F, C, C)\\n- datatype = torch.bool if is_torch_1_2_plus else torch.uint8\\n+ datatype = torch.bool if is_torch_1_3_plus else torch.uint8\\n+ datatype2 = torch.bool if is_torch_1_2_plus else torch.uint8\\n psd = psd_in.masked_fill(torch.eye(C, dtype=datatype,\\n- device=psd_in.device), 0)\\n+ device=psd_in.device).type(datatype2), 0)\\n # psd: (B, F, C, C) -> (B, C, F)\\n psd = (psd.sum(dim=-1) / (C - 1)).transpose(-1, -2)\\n \\ndiff --git a/espnet/nets/pytorch_backend/frontends/mask_estimator.py b/espnet/nets/pytorch_backend/frontends/mask_estimator.py\\nindex a087f4b1f32..a4f70518b35 100644\\n--- a/espnet/nets/pytorch_backend/frontends/mask_estimator.py\\n+++ b/espnet/nets/pytorch_backend/frontends/mask_estimator.py\\n@@ -47,7 +47,7 @@ def forward(self, xs: ComplexTensor, ilens: torch.LongTensor) \\\\\\n # Calculate amplitude: (B, C, T, F) -> (B, C, T, F)\\n xs = (xs.real ** 2 + xs.imag ** 2) ** 0.5\\n # xs: (B, C, T, F) -> xs: (B * C, T, F)\\n- xs = xs.view(-1, xs.size(-2), xs.size(-1))\\n+ xs = xs.contiguous().view(-1, xs.size(-2), xs.size(-1))\\n # ilens: (B,) -> ilens_: (B * C)\\n ilens_ = ilens[:, None].expand(-1, C).contiguous().view(-1)\\n \\ndiff --git a/espnet/nets/pytorch_backend/transformer/mask.py b/espnet/nets/pytorch_backend/transformer/mask.py\\nindex f6753f14316..f241211c73d 100644\\n--- a/espnet/nets/pytorch_backend/transformer/mask.py\\n+++ b/espnet/nets/pytorch_backend/transformer/mask.py\\n@@ -10,6 +10,8 @@\\n import torch\\n \\n is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')\\n+# LooseVersion('1.2.0') == LooseVersion(torch.__version__) can't include e.g. 1.2.0+aaa\\n+is_torch_1_2 = LooseVersion('1.3') > LooseVersion(torch.__version__) >= LooseVersion('1.2')\\n datatype = torch.bool if is_torch_1_2_plus else torch.uint8\\n \\n \\n@@ -25,8 +27,13 @@ def subsequent_mask(size, device=\\\"cpu\\\", dtype=datatype):\\n [1, 1, 0],\\n [1, 1, 1]]\\n \\\"\\\"\\\"\\n- ret = torch.ones(size, size, device=device, dtype=dtype)\\n- return torch.tril(ret, out=ret)\\n+ if is_torch_1_2 and dtype == torch.bool:\\n+ # torch=1.2 doesn't support tril for bool tensor\\n+ ret = torch.ones(size, size, device=device, dtype=torch.uint8)\\n+ return torch.tril(ret, out=ret).type(dtype)\\n+ else:\\n+ ret = torch.ones(size, size, device=device, dtype=dtype)\\n+ return torch.tril(ret, out=ret)\\n \\n \\n def target_mask(ys_in_pad, ignore_id):\\ndiff --git a/espnet2/torch_utils/recursive_op.py b/espnet2/torch_utils/recursive_op.py\\nindex 0b6b31713ec..c3b70fb3fa5 100644\\n--- a/espnet2/torch_utils/recursive_op.py\\n+++ b/espnet2/torch_utils/recursive_op.py\\n@@ -2,10 +2,13 @@\\n \\n import torch\\n \\n-if LooseVersion(torch.__version__) > LooseVersion(\\\"1.0.1\\\"):\\n- from torch.distributed import ReduceOp\\n+if torch.distributed.is_available():\\n+ if LooseVersion(torch.__version__) > LooseVersion(\\\"1.0.1\\\"):\\n+ from torch.distributed import ReduceOp\\n+ else:\\n+ from torch.distributed import reduce_op as ReduceOp\\n else:\\n- from torch.distributed import reduce_op as ReduceOp\\n+ ReduceOp = None\\n \\n \\n def recursive_sum(obj, weight: torch.Tensor, distributed: bool = False):\\ndiff --git a/espnet2/train/trainer.py b/espnet2/train/trainer.py\\nindex 3716973f0d9..75a89b271e6 100644\\n--- a/espnet2/train/trainer.py\\n+++ b/espnet2/train/trainer.py\\n@@ -39,10 +39,13 @@\\n from torch.utils.tensorboard import SummaryWriter\\n else:\\n from tensorboardX import SummaryWriter\\n-if LooseVersion(torch.__version__) > LooseVersion(\\\"1.0.1\\\"):\\n- from torch.distributed import ReduceOp\\n+if torch.distributed.is_available():\\n+ if LooseVersion(torch.__version__) > LooseVersion(\\\"1.0.1\\\"):\\n+ from torch.distributed import ReduceOp\\n+ else:\\n+ from torch.distributed import reduce_op as ReduceOp\\n else:\\n- from torch.distributed import reduce_op as ReduceOp\\n+ ReduceOp = None\\n \\n \\n @dataclasses.dataclass\\ndiff --git a/espnet2/utils/fileio.py b/espnet2/utils/fileio.py\\nindex 03916a75576..a2b5de66d1d 100644\\n--- a/espnet2/utils/fileio.py\\n+++ b/espnet2/utils/fileio.py\\n@@ -1,5 +1,3 @@\\n-from __future__ import annotations\\n-\\n import collections.abc\\n from io import StringIO\\n import logging\\n@@ -38,7 +36,7 @@ def __init__(self, p: Union[Path, str]):\\n def __enter__(self):\\n return self\\n \\n- def __getitem__(self, key: str) -> DatadirWriter:\\n+ def __getitem__(self, key: str) -> \\\"DatadirWriter\\\":\\n assert check_argument_types()\\n if self.fd is not None:\\n raise RuntimeError(\\\"This writer points out a file\\\")\\ndiff --git a/test/espnet2/utils/test_sized_dict.py b/test/espnet2/utils/test_sized_dict.py\\nindex 8ec281445bc..634121239a5 100644\\n--- a/test/espnet2/utils/test_sized_dict.py\\n+++ b/test/espnet2/utils/test_sized_dict.py\\n@@ -10,9 +10,9 @@\\n \\n def test_get_size():\\n d = {}\\n- size1 = get_size(d)\\n x = np.random.randn(10)\\n d[\\\"a\\\"] = x\\n+ size1 = sys.getsizeof(d)\\n assert size1 + get_size(x) + get_size(\\\"a\\\") == get_size(d)\\n \\n \\ndiff --git a/test/test_recog.py b/test/test_recog.py\\nindex 759507bf3f8..554a950e16b 100644\\n--- a/test/test_recog.py\\n+++ b/test/test_recog.py\\n@@ -3,18 +3,19 @@\\n # Copyright 2018 Hiroshi Seki\\n # Apache 2.0 (http://www.apache.org/licenses/LICENSE-2.0)\\n \\n-import torch\\n+import argparse\\n+from distutils.version import LooseVersion\\n+import importlib\\n \\n-import espnet.nets.pytorch_backend.lm.default as lm_pytorch\\n+import numpy\\n+import pytest\\n+import torch\\n \\n import espnet.lm.chainer_backend.lm as lm_chainer\\n import espnet.lm.pytorch_backend.extlm as extlm_pytorch\\n+import espnet.nets.pytorch_backend.lm.default as lm_pytorch\\n \\n-import argparse\\n-import importlib\\n-import numpy\\n-\\n-import pytest\\n+is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')\\n \\n \\n def make_arg(**kwargs):\\n@@ -80,6 +81,7 @@ def init_chainer_weight_const(m, val):\\n p.data[:] = val\\n \\n \\n+@pytest.mark.skipif(is_torch_1_2_plus, reason='pytestskip')\\n @pytest.mark.parametrize((\\\"etype\\\", \\\"dtype\\\", \\\"m_str\\\", \\\"text_idx1\\\"), [\\n (\\\"blstmp\\\", \\\"lstm\\\", \\\"espnet.nets.chainer_backend.e2e_asr\\\", 0),\\n (\\\"blstmp\\\", \\\"lstm\\\", \\\"espnet.nets.pytorch_backend.e2e_asr\\\", 1),\\n@@ -130,6 +132,7 @@ def test_recognition_results(etype, dtype, m_str, text_idx1):\\n assert seq_hat_text == seq_true_text\\n \\n \\n+@pytest.mark.skipif(is_torch_1_2_plus, reason='pytestskip')\\n @pytest.mark.parametrize((\\\"etype\\\", \\\"dtype\\\", \\\"m_str\\\", \\\"text_idx1\\\"), [\\n (\\\"blstmp\\\", \\\"lstm\\\", \\\"espnet.nets.chainer_backend.e2e_asr\\\", 0),\\n (\\\"blstmp\\\", \\\"lstm\\\", \\\"espnet.nets.pytorch_backend.e2e_asr\\\", 1),\\ndiff --git a/test_utils/test_addjson_py.bats b/test_utils/test_addjson_py.bats\\nindex d2b0c313915..85fbf19e50a 100755\\n--- a/test_utils/test_addjson_py.bats\\n+++ b/test_utils/test_addjson_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\n@@ -100,5 +100,5 @@ teardown() {\\n cat $tmpdir/out.json\\n jsondiff $tmpdir/out.json $tmpdir/valid\\n }\\n-NG=C.UTF-8\\n+NG=en_US.UTF-8\\n \\ndiff --git a/test_utils/test_apply-cmvn_py.bats b/test_utils/test_apply-cmvn_py.bats\\nindex 4af70c67032..1c6000debdc 100755\\n--- a/test_utils/test_apply-cmvn_py.bats\\n+++ b/test_utils/test_apply-cmvn_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_average_checkpoints_py.bats b/test_utils/test_average_checkpoints_py.bats\\nindex ca75cf99de7..3b4f6b52d90 100644\\n--- a/test_utils/test_average_checkpoints_py.bats\\n+++ b/test_utils/test_average_checkpoints_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_compute-cmvn-stats_py.bats b/test_utils/test_compute-cmvn-stats_py.bats\\nindex cc7478b9c10..86d6fc8309e 100755\\n--- a/test_utils/test_compute-cmvn-stats_py.bats\\n+++ b/test_utils/test_compute-cmvn-stats_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_concatjson_py.bats b/test_utils/test_concatjson_py.bats\\nindex d58e331bab4..7f27354ba10 100755\\n--- a/test_utils/test_concatjson_py.bats\\n+++ b/test_utils/test_concatjson_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_copy-feats_py.bats b/test_utils/test_copy-feats_py.bats\\nindex 8d08e0c8e07..df284dc8366 100755\\n--- a/test_utils/test_copy-feats_py.bats\\n+++ b/test_utils/test_copy-feats_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_data2json_sh.bats b/test_utils/test_data2json_sh.bats\\nindex fa4f9544ca7..50cc340bb14 100755\\n--- a/test_utils/test_data2json_sh.bats\\n+++ b/test_utils/test_data2json_sh.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n cd $BATS_TEST_DIRNAME/../egs/wsj/asr1\\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\ndiff --git a/test_utils/test_dump-pcm_py.bats b/test_utils/test_dump-pcm_py.bats\\nindex 46ce7fcc6be..88e1eafbb89 100755\\n--- a/test_utils/test_dump-pcm_py.bats\\n+++ b/test_utils/test_dump-pcm_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_eval_perm_free_error_py.bats b/test_utils/test_eval_perm_free_error_py.bats\\nindex e3e1c7d81ac..a631303a648 100755\\n--- a/test_utils/test_eval_perm_free_error_py.bats\\n+++ b/test_utils/test_eval_perm_free_error_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_feat-to-shape.bats b/test_utils/test_feat-to-shape.bats\\nindex 6495dccd44c..928d51987cf 100755\\n--- a/test_utils/test_feat-to-shape.bats\\n+++ b/test_utils/test_feat-to-shape.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_get_yaml.bats b/test_utils/test_get_yaml.bats\\nindex f4a2678ce35..26f595be4b1 100755\\n--- a/test_utils/test_get_yaml.bats\\n+++ b/test_utils/test_get_yaml.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_json2trn.py.bats b/test_utils/test_json2trn.py.bats\\nindex b8a4f83d435..6a296b7f09e 100644\\n--- a/test_utils/test_json2trn.py.bats\\n+++ b/test_utils/test_json2trn.py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_merge_scp2json_py.bats b/test_utils/test_merge_scp2json_py.bats\\nindex 74455012940..8692c5197b3 100755\\n--- a/test_utils/test_merge_scp2json_py.bats\\n+++ b/test_utils/test_merge_scp2json_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_mergejson_py.bats b/test_utils/test_mergejson_py.bats\\nindex 1ad0ce40902..2d7ef65adee 100755\\n--- a/test_utils/test_mergejson_py.bats\\n+++ b/test_utils/test_mergejson_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_mix-mono-wav-scp_py.bats b/test_utils/test_mix-mono-wav-scp_py.bats\\nindex b5d010375bb..b37488bce43 100755\\n--- a/test_utils/test_mix-mono-wav-scp_py.bats\\n+++ b/test_utils/test_mix-mono-wav-scp_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_scp2json_py.bats b/test_utils/test_scp2json_py.bats\\nindex 363c7b89ff4..23c05630757 100755\\n--- a/test_utils/test_scp2json_py.bats\\n+++ b/test_utils/test_scp2json_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_splitjson_py.bats b/test_utils/test_splitjson_py.bats\\nindex 4f5fe07fdb6..556f9f9f30d 100755\\n--- a/test_utils/test_splitjson_py.bats\\n+++ b/test_utils/test_splitjson_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_spm.bats b/test_utils/test_spm.bats\\nindex 495b6c4e274..7f5592d21f0 100755\\n--- a/test_utils/test_spm.bats\\n+++ b/test_utils/test_spm.bats\\n@@ -2,6 +2,7 @@\\n # -*- mode:sh -*-\\n \\n setup() {\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n tmpdir=$(mktemp -d test_spm.XXXXXX)\\n echo $tmpdir\\n }\\ndiff --git a/test_utils/test_text2token_py.bats b/test_utils/test_text2token_py.bats\\nindex b2c6c09806e..02c9623312f 100755\\n--- a/test_utils/test_text2token_py.bats\\n+++ b/test_utils/test_text2token_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_text2vocabulary_py.bats b/test_utils/test_text2vocabulary_py.bats\\nindex 434733888f5..c999208ac51 100755\\n--- a/test_utils/test_text2vocabulary_py.bats\\n+++ b/test_utils/test_text2vocabulary_py.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n tmpdir=$(mktemp -d testXXXXXX)\\ndiff --git a/test_utils/test_update_json_sh.bats b/test_utils/test_update_json_sh.bats\\nindex 1b662922839..04c1dc0ff2e 100755\\n--- a/test_utils/test_update_json_sh.bats\\n+++ b/test_utils/test_update_json_sh.bats\\n@@ -1,7 +1,7 @@\\n #!/usr/bin/env bats\\n \\n setup() {\\n- [ ! -z $LC_ALL ] && export LC_ALL=\\\"en_US.UTF-8\\\"\\n+ export LC_ALL=\\\"en_US.UTF-8\\\"\\n \\n cd $BATS_TEST_DIRNAME/../egs/wsj/asr1\\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -66,13 +68,14 @@ jobs:\n docker:\n - image: circleci/buildpack-deps:16.04\n environment:\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\n- ESPNET_PYTHON_VERSION: 3.7.3\n+ ESPNET_PYTHON_VERSION: 3.6\n TH_VERSION: 1.1.0\n CHAINER_VERSION: 5.0.0","line":null,"original_line":73,"original_start_line":null,"path":".circleci/config.yml","start_line":null,"text":"@user1:\nditto\r\n```suggestion\r\n CHAINER_VERSION: 6.0.0\r\n```"},{"diff_hunk":"@@ -173,13 +179,14 @@ jobs:\n docker:\n - image: debian:9\n environment:\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\n- ESPNET_PYTHON_VERSION: 3.7.3\n+ ESPNET_PYTHON_VERSION: 3.6\n TH_VERSION: 1.1.0\n CHAINER_VERSION: 5.0.0","line":null,"original_line":184,"original_start_line":null,"path":".circleci/config.yml","start_line":null,"text":"@user1:\nditto\r\n```suggestion\r\n CHAINER_VERSION: 6.0.0\r\n```"},{"diff_hunk":"@@ -21,24 +21,24 @@ addons:\n \n env:\n # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error","line":null,"original_line":23,"original_start_line":null,"path":".travis.yml","start_line":null,"text":"@user1:\nNot related to this PR but this already fixed so it is better to remove.\r\n```suggestion\r\n```"},{"diff_hunk":"@@ -117,13 +121,14 @@ jobs:\n docker:\n - image: centos:7\n environment:\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\n- ESPNET_PYTHON_VERSION: 3.7.3\n+ ESPNET_PYTHON_VERSION: 3.6\n TH_VERSION: 1.1.0\n CHAINER_VERSION: 5.0.0","line":null,"original_line":126,"original_start_line":null,"path":".circleci/config.yml","start_line":null,"text":"@user1:\nditto\r\n```suggestion\r\n CHAINER_VERSION: 6.0.0\r\n```"},{"diff_hunk":"@@ -18,13 +18,14 @@ jobs:\n docker:\n - image: circleci/buildpack-deps:18.04\n environment:\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\n- ESPNET_PYTHON_VERSION: 3.7.3\n+ ESPNET_PYTHON_VERSION: 3.6\n TH_VERSION: 1.1.0\n CHAINER_VERSION: 5.0.0","line":null,"original_line":23,"original_start_line":null,"path":".circleci/config.yml","start_line":null,"text":"@user1:\nIn `setup.py` we use chainer==6.0.0.\r\nMaybe it is better to follow it.\r\n```suggestion\r\n CHAINER_VERSION: 6.0.0\r\n```"}],"string":"[\n {\n \"diff_hunk\": \"@@ -66,13 +68,14 @@ jobs:\\n docker:\\n - image: circleci/buildpack-deps:16.04\\n environment:\\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\\n- ESPNET_PYTHON_VERSION: 3.7.3\\n+ ESPNET_PYTHON_VERSION: 3.6\\n TH_VERSION: 1.1.0\\n CHAINER_VERSION: 5.0.0\",\n \"line\": null,\n \"original_line\": 73,\n \"original_start_line\": null,\n \"path\": \".circleci/config.yml\",\n \"start_line\": null,\n \"text\": \"@user1:\\nditto\\r\\n```suggestion\\r\\n CHAINER_VERSION: 6.0.0\\r\\n```\"\n },\n {\n \"diff_hunk\": \"@@ -173,13 +179,14 @@ jobs:\\n docker:\\n - image: debian:9\\n environment:\\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\\n- ESPNET_PYTHON_VERSION: 3.7.3\\n+ ESPNET_PYTHON_VERSION: 3.6\\n TH_VERSION: 1.1.0\\n CHAINER_VERSION: 5.0.0\",\n \"line\": null,\n \"original_line\": 184,\n \"original_start_line\": null,\n \"path\": \".circleci/config.yml\",\n \"start_line\": null,\n \"text\": \"@user1:\\nditto\\r\\n```suggestion\\r\\n CHAINER_VERSION: 6.0.0\\r\\n```\"\n },\n {\n \"diff_hunk\": \"@@ -21,24 +21,24 @@ addons:\\n \\n env:\\n # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\",\n \"line\": null,\n \"original_line\": 23,\n \"original_start_line\": null,\n \"path\": \".travis.yml\",\n \"start_line\": null,\n \"text\": \"@user1:\\nNot related to this PR but this already fixed so it is better to remove.\\r\\n```suggestion\\r\\n```\"\n },\n {\n \"diff_hunk\": \"@@ -117,13 +121,14 @@ jobs:\\n docker:\\n - image: centos:7\\n environment:\\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\\n- ESPNET_PYTHON_VERSION: 3.7.3\\n+ ESPNET_PYTHON_VERSION: 3.6\\n TH_VERSION: 1.1.0\\n CHAINER_VERSION: 5.0.0\",\n \"line\": null,\n \"original_line\": 126,\n \"original_start_line\": null,\n \"path\": \".circleci/config.yml\",\n \"start_line\": null,\n \"text\": \"@user1:\\nditto\\r\\n```suggestion\\r\\n CHAINER_VERSION: 6.0.0\\r\\n```\"\n },\n {\n \"diff_hunk\": \"@@ -18,13 +18,14 @@ jobs:\\n docker:\\n - image: circleci/buildpack-deps:18.04\\n environment:\\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\\n- ESPNET_PYTHON_VERSION: 3.7.3\\n+ ESPNET_PYTHON_VERSION: 3.6\\n TH_VERSION: 1.1.0\\n CHAINER_VERSION: 5.0.0\",\n \"line\": null,\n \"original_line\": 23,\n \"original_start_line\": null,\n \"path\": \".circleci/config.yml\",\n \"start_line\": null,\n \"text\": \"@user1:\\nIn `setup.py` we use chainer==6.0.0.\\r\\nMaybe it is better to follow it.\\r\\n```suggestion\\r\\n CHAINER_VERSION: 6.0.0\\r\\n```\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"34b21ca720d698de72d20b1d601ab4671d7badac"},"merged_patch":{"kind":"string","value":"diff --git a/.circleci/config.yml b/.circleci/config.yml\nindex 15b9b9e9c6d..249e2490ae8 100644\n--- a/.circleci/config.yml\n+++ b/.circleci/config.yml\n@@ -18,13 +18,14 @@ jobs:\n docker:\n - image: circleci/buildpack-deps:18.04\n environment:\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\n- ESPNET_PYTHON_VERSION: 3.7.3\n- TH_VERSION: 1.1.0\n- CHAINER_VERSION: 5.0.0\n+ ESPNET_PYTHON_VERSION: 3.6\n+ TH_VERSION: 1.4.0\n+ CHAINER_VERSION: 6.0.0\n USE_CONDA: true\n CC: gcc-7\n CXX: g++-7\n+ # To avoid UnicodeEncodeError for python<=3.6\n+ LC_ALL: en_US.UTF-8\n working_directory: ~/repo\n \n steps:\n@@ -34,6 +35,7 @@ jobs:\n command: |\n sudo apt-get update -qq\n sudo apt-get install -qq -y cmake g++-7 libsndfile1-dev bc\n+ sudo localedef -f UTF-8 -i en_US en_US\n - run:\n name: install espnet\n command: |\n@@ -66,13 +68,14 @@ jobs:\n docker:\n - image: circleci/buildpack-deps:16.04\n environment:\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\n- ESPNET_PYTHON_VERSION: 3.7.3\n- TH_VERSION: 1.1.0\n- CHAINER_VERSION: 5.0.0\n+ ESPNET_PYTHON_VERSION: 3.6\n+ TH_VERSION: 1.4.0\n+ CHAINER_VERSION: 6.0.0\n USE_CONDA: true\n CC: gcc-7\n CXX: g++-7\n+ # To avoid UnicodeEncodeError for python<=3.6\n+ LC_ALL: en_US.UTF-8\n working_directory: ~/repo\n \n steps:\n@@ -85,6 +88,7 @@ jobs:\n sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test\n sudo apt-get update -qq\n sudo apt-get install -qq -y cmake g++-7 libsndfile1-dev bc\n+ sudo localedef -f UTF-8 -i en_US en_US\n - run:\n name: install espnet\n command: |\n@@ -117,13 +121,14 @@ jobs:\n docker:\n - image: centos:7\n environment:\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\n- ESPNET_PYTHON_VERSION: 3.7.3\n- TH_VERSION: 1.1.0\n- CHAINER_VERSION: 5.0.0\n+ ESPNET_PYTHON_VERSION: 3.6\n+ TH_VERSION: 1.4.0\n+ CHAINER_VERSION: 6.0.0\n USE_CONDA: true\n CC: /opt/rh/devtoolset-7/root/usr/bin/gcc\n CXX: /opt/rh/devtoolset-7/root/usr/bin/g++\n+ # To avoid UnicodeEncodeError for python<=3.6\n+ LC_ALL: en_US.UTF-8\n working_directory: ~/repo\n \n steps:\n@@ -133,6 +138,7 @@ jobs:\n yum install -y git centos-release-scl cmake libsndfile make bzip2 wget which unzip bc\n yum-config-manager --enable rhel-server-rhscl-7-rpms\n yum install -y devtoolset-7-gcc-c++\n+ localedef -f UTF-8 -i en_US en_US\n - checkout\n - run:\n name: install espnet\n@@ -173,13 +179,14 @@ jobs:\n docker:\n - image: debian:9\n environment:\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\n- ESPNET_PYTHON_VERSION: 3.7.3\n- TH_VERSION: 1.1.0\n- CHAINER_VERSION: 5.0.0\n+ ESPNET_PYTHON_VERSION: 3.6\n+ TH_VERSION: 1.4.0\n+ CHAINER_VERSION: 6.0.0\n USE_CONDA: true\n CC: gcc-6\n CXX: g++-6\n+ # To avoid UnicodeEncodeError for python<=3.6\n+ LC_ALL: en_US.UTF-8\n working_directory: ~/repo\n \n steps:\n@@ -188,7 +195,8 @@ jobs:\n name: install dependencies\n command: |\n apt-get update -qq\n- apt-get install -qq -y git cmake g++-6 libsndfile1-dev unzip bzip2 wget curl bc\n+ apt-get install -qq -y git cmake g++-6 libsndfile1-dev unzip bzip2 wget curl bc locales\n+ localedef -f UTF-8 -i en_US en_US\n - run:\n name: install espnet\n command: |\ndiff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml\nindex 770583b8288..a613b72af6a 100644\n--- a/.github/workflows/ci.yaml\n+++ b/.github/workflows/ci.yaml\n@@ -8,11 +8,22 @@ jobs:\n strategy:\n max-parallel: 20\n matrix:\n- os: [ubuntu-16.04, ubuntu-18.04]\n- python-version: [3.7]\n- pytorch-version: [1.0.1, 1.1]\n+ # os: [ubuntu-16.04, ubuntu-18.04]\n+ os: [ubuntu-18.04]\n+ python-version: [3.7, 3.8]\n+ pytorch-version: [1.0.1, 1.1.0, 1.2.0, 1.3.1, 1.4.0]\n chainer-version: [6.0.0]\n- use-conda: [true, false]\n+ # NOTE(kamo): Conda is tested by Circle-CI\n+ use-conda: [false]\n+ exclude:\n+ - python-version: 3.8\n+ pytorch-version: 1.0.1\n+ - python-version: 3.8\n+ pytorch-version: 1.1.0\n+ - python-version: 3.8\n+ pytorch-version: 1.2.0\n+ - python-version: 3.8\n+ pytorch-version: 1.3.1\n steps:\n - uses: actions/checkout@master\n - uses: actions/setup-python@v1\ndiff --git a/.mergify.yml b/.mergify.yml\nindex c34ef7bed6a..75ccc4f7e3d 100644\n--- a/.mergify.yml\n+++ b/.mergify.yml\n@@ -2,14 +2,12 @@ pull_request_rules:\n - name: automatic merge if label=auto-merge\n conditions:\n - \"label=auto-merge\"\n- - \"status-success=linter_and_test (ubuntu-16.04, 3.7, 1.0.1, 6.0.0, true)\"\n- - \"status-success=linter_and_test (ubuntu-16.04, 3.7, 1.0.1, 6.0.0, false)\"\n- - \"status-success=linter_and_test (ubuntu-16.04, 3.7, 1.1, 6.0.0, true)\"\n- - \"status-success=linter_and_test (ubuntu-16.04, 3.7, 1.1, 6.0.0, false)\"\n- - \"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.0.1, 6.0.0, true)\"\n - \"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.0.1, 6.0.0, false)\" \n- - \"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.1, 6.0.0, true)\"\n - \"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.1, 6.0.0, false)\"\n+ - \"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.2, 6.0.0, false)\"\n+ - \"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.3.1, 6.0.0, false)\"\n+ - \"status-success=linter_and_test (ubuntu-18.04, 3.7, 1.4.0, 6.0.0, false)\"\n+ - \"status-success=linter_and_test (ubuntu-18.04, 3.8, 1.4.0, 6.0.0, false)\"\n - \"status-success=ci/circleci: test-centos7\"\n - \"status-success=ci/circleci: test-debian9\"\n - \"status-success=ci/circleci: test-ubuntu16\"\ndiff --git a/.travis.yml b/.travis.yml\nindex cecea093152..413203e03a6 100644\n--- a/.travis.yml\n+++ b/.travis.yml\n@@ -1,7 +1,7 @@\n dist: xenial\n language: python\n python:\n- - \"3.7\"\n+ - \"3.8\"\n \n cache:\n - pip\n@@ -20,25 +20,24 @@ addons:\n - bc\n \n env:\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\n- - USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=1.0.1 CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\n- - USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=1.1.0 CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\n+ - USE_CONDA=false ESPNET_PYTHON_VERSION=3.8 TH_VERSION=1.4.0 CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\n # torch nightly\n- - USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=nightly CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\n+ # - USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=nightly CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\n \n matrix:\n allow_failures:\n # torch nightly\n- - env: USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=nightly CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\n+ # - env: USE_CONDA=false ESPNET_PYTHON_VERSION=3.7.3 TH_VERSION=nightly CHAINER_VERSION=6.0.0 CC=gcc-7 CXX=g++-7\n \n install:\n - travis_retry ./ci/install.sh\n- - travis_retry ./ci/install_kaldi.sh\n+ # - travis_retry ./ci/install_kaldi.sh\n \n script:\n- - ./ci/test_shell.sh\n+ # NOTE(kamo): Codecov and build documentation only\n+ # - ./ci/test_shell.sh\n - ./ci/test_python.sh\n- - ./ci/test_integration.sh\n+ # - ./ci/test_integration.sh\n - ./ci/doc.sh\n \n sudo: false\ndiff --git a/README.md b/README.md\nindex d33ad6a556e..23cc3d26c8b 100644\n--- a/README.md\n+++ b/README.md\n@@ -2,9 +2,16 @@\n \n # ESPnet: end-to-end speech processing toolkit\n \n-[](https://github.com/espnet/espnet/actions)\n-[](https://travis-ci.org/espnet/espnet)\n-[](https://circleci.com/gh/espnet/espnet)\n+|system/pytorch ver.|1.0.1|1.1.0|1.2.0|1.3.1|1.4.0|\n+| :---: | :---: | :---: | :---: | :---: | :---: |\n+|ubuntu18/python3.8/pip|||||[](https://github.com/espnet/espnet/actions)|\n+|ubuntu18/python3.7/pip|[](https://github.com/espnet/espnet/actions)|[](https://github.com/espnet/espnet/actions)|[](https://github.com/espnet/espnet/actions)|[](https://github.com/espnet/espnet/actions)|[](https://github.com/espnet/espnet/actions)|\n+|ubuntu18/python3.6/conda|||||[](https://circleci.com/gh/espnet/espnet)|\n+|ubuntu16/python3.6/conda|||||[](https://circleci.com/gh/espnet/espnet)|\n+|debian9/python3.6/conda|||||[](https://circleci.com/gh/espnet/espnet)|\n+|centos7/python3.6/conda|||||[](https://circleci.com/gh/espnet/espnet)|\n+|[docs/coverage] python3.8|||||[](https://travis-ci.org/espnet/espnet)|\n+\n [](https://codecov.io/gh/espnet/espnet)\n [](https://mergify.io)\n [](https://gitter.im/espnet-en/community?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge)\ndiff --git a/ci/install.sh b/ci/install.sh\nindex 84ccb266e42..69cb7e50d17 100755\n--- a/ci/install.sh\n+++ b/ci/install.sh\n@@ -18,7 +18,7 @@ if ${USE_CONDA}; then\n if [[ ${TH_VERSION} == nightly ]]; then\n conda install -q -y pytorch-nightly-cpu -c pytorch\n else\n- conda install -q -y pytorch-cpu=\"${TH_VERSION}\" -c pytorch\n+ conda install -q -y pytorch=\"${TH_VERSION}\" cpuonly -c pytorch\n fi\n conda install -c conda-forge ffmpeg\n else\n@@ -29,8 +29,10 @@ else\n \n if [[ ${TH_VERSION} == nightly ]]; then\n pip install torch_nightly -f https://download.pytorch.org/whl/nightly/cpu/torch_nightly.html\n- else\n+ elif [[ ${TH_VERSION} == 1.0.1 ]] || [[ ${TH_VERSION} == 1.1.0 ]]; then\n pip install --quiet torch==\"${TH_VERSION}\" -f https://download.pytorch.org/whl/cpu/stable\n+ else\n+ pip install --quiet torch==\"${TH_VERSION}+cpu\" -f https://download.pytorch.org/whl/torch_stable.html\n fi\n fi\n \ndiff --git a/espnet/nets/pytorch_backend/frontends/dnn_beamformer.py b/espnet/nets/pytorch_backend/frontends/dnn_beamformer.py\nindex c583d705abd..942675e2051 100644\n--- a/espnet/nets/pytorch_backend/frontends/dnn_beamformer.py\n+++ b/espnet/nets/pytorch_backend/frontends/dnn_beamformer.py\n@@ -13,7 +13,8 @@\n from espnet.nets.pytorch_backend.frontends.mask_estimator import MaskEstimator\n from torch_complex.tensor import ComplexTensor\n \n-is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2')\n+is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')\n+is_torch_1_3_plus = LooseVersion(torch.__version__) >= LooseVersion('1.3.0')\n \n \n class DNN_Beamformer(torch.nn.Module):\n@@ -146,9 +147,10 @@ def forward(self, psd_in: ComplexTensor, ilens: torch.LongTensor,\n B, _, C = psd_in.size()[:3]\n assert psd_in.size(2) == psd_in.size(3), psd_in.size()\n # psd_in: (B, F, C, C)\n- datatype = torch.bool if is_torch_1_2_plus else torch.uint8\n+ datatype = torch.bool if is_torch_1_3_plus else torch.uint8\n+ datatype2 = torch.bool if is_torch_1_2_plus else torch.uint8\n psd = psd_in.masked_fill(torch.eye(C, dtype=datatype,\n- device=psd_in.device), 0)\n+ device=psd_in.device).type(datatype2), 0)\n # psd: (B, F, C, C) -> (B, C, F)\n psd = (psd.sum(dim=-1) / (C - 1)).transpose(-1, -2)\n \ndiff --git a/espnet/nets/pytorch_backend/frontends/mask_estimator.py b/espnet/nets/pytorch_backend/frontends/mask_estimator.py\nindex a087f4b1f32..a4f70518b35 100644\n--- a/espnet/nets/pytorch_backend/frontends/mask_estimator.py\n+++ b/espnet/nets/pytorch_backend/frontends/mask_estimator.py\n@@ -47,7 +47,7 @@ def forward(self, xs: ComplexTensor, ilens: torch.LongTensor) \\\n # Calculate amplitude: (B, C, T, F) -> (B, C, T, F)\n xs = (xs.real ** 2 + xs.imag ** 2) ** 0.5\n # xs: (B, C, T, F) -> xs: (B * C, T, F)\n- xs = xs.view(-1, xs.size(-2), xs.size(-1))\n+ xs = xs.contiguous().view(-1, xs.size(-2), xs.size(-1))\n # ilens: (B,) -> ilens_: (B * C)\n ilens_ = ilens[:, None].expand(-1, C).contiguous().view(-1)\n \ndiff --git a/espnet/nets/pytorch_backend/transformer/mask.py b/espnet/nets/pytorch_backend/transformer/mask.py\nindex f6753f14316..f241211c73d 100644\n--- a/espnet/nets/pytorch_backend/transformer/mask.py\n+++ b/espnet/nets/pytorch_backend/transformer/mask.py\n@@ -10,6 +10,8 @@\n import torch\n \n is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')\n+# LooseVersion('1.2.0') == LooseVersion(torch.__version__) can't include e.g. 1.2.0+aaa\n+is_torch_1_2 = LooseVersion('1.3') > LooseVersion(torch.__version__) >= LooseVersion('1.2')\n datatype = torch.bool if is_torch_1_2_plus else torch.uint8\n \n \n@@ -25,8 +27,13 @@ def subsequent_mask(size, device=\"cpu\", dtype=datatype):\n [1, 1, 0],\n [1, 1, 1]]\n \"\"\"\n- ret = torch.ones(size, size, device=device, dtype=dtype)\n- return torch.tril(ret, out=ret)\n+ if is_torch_1_2 and dtype == torch.bool:\n+ # torch=1.2 doesn't support tril for bool tensor\n+ ret = torch.ones(size, size, device=device, dtype=torch.uint8)\n+ return torch.tril(ret, out=ret).type(dtype)\n+ else:\n+ ret = torch.ones(size, size, device=device, dtype=dtype)\n+ return torch.tril(ret, out=ret)\n \n \n def target_mask(ys_in_pad, ignore_id):\ndiff --git a/espnet2/torch_utils/recursive_op.py b/espnet2/torch_utils/recursive_op.py\nindex 0b6b31713ec..c3b70fb3fa5 100644\n--- a/espnet2/torch_utils/recursive_op.py\n+++ b/espnet2/torch_utils/recursive_op.py\n@@ -2,10 +2,13 @@\n \n import torch\n \n-if LooseVersion(torch.__version__) > LooseVersion(\"1.0.1\"):\n- from torch.distributed import ReduceOp\n+if torch.distributed.is_available():\n+ if LooseVersion(torch.__version__) > LooseVersion(\"1.0.1\"):\n+ from torch.distributed import ReduceOp\n+ else:\n+ from torch.distributed import reduce_op as ReduceOp\n else:\n- from torch.distributed import reduce_op as ReduceOp\n+ ReduceOp = None\n \n \n def recursive_sum(obj, weight: torch.Tensor, distributed: bool = False):\ndiff --git a/espnet2/train/trainer.py b/espnet2/train/trainer.py\nindex 3716973f0d9..75a89b271e6 100644\n--- a/espnet2/train/trainer.py\n+++ b/espnet2/train/trainer.py\n@@ -39,10 +39,13 @@\n from torch.utils.tensorboard import SummaryWriter\n else:\n from tensorboardX import SummaryWriter\n-if LooseVersion(torch.__version__) > LooseVersion(\"1.0.1\"):\n- from torch.distributed import ReduceOp\n+if torch.distributed.is_available():\n+ if LooseVersion(torch.__version__) > LooseVersion(\"1.0.1\"):\n+ from torch.distributed import ReduceOp\n+ else:\n+ from torch.distributed import reduce_op as ReduceOp\n else:\n- from torch.distributed import reduce_op as ReduceOp\n+ ReduceOp = None\n \n \n @dataclasses.dataclass\ndiff --git a/espnet2/utils/fileio.py b/espnet2/utils/fileio.py\nindex 03916a75576..a2b5de66d1d 100644\n--- a/espnet2/utils/fileio.py\n+++ b/espnet2/utils/fileio.py\n@@ -1,5 +1,3 @@\n-from __future__ import annotations\n-\n import collections.abc\n from io import StringIO\n import logging\n@@ -38,7 +36,7 @@ def __init__(self, p: Union[Path, str]):\n def __enter__(self):\n return self\n \n- def __getitem__(self, key: str) -> DatadirWriter:\n+ def __getitem__(self, key: str) -> \"DatadirWriter\":\n assert check_argument_types()\n if self.fd is not None:\n raise RuntimeError(\"This writer points out a file\")\ndiff --git a/test/espnet2/utils/test_sized_dict.py b/test/espnet2/utils/test_sized_dict.py\nindex 8ec281445bc..634121239a5 100644\n--- a/test/espnet2/utils/test_sized_dict.py\n+++ b/test/espnet2/utils/test_sized_dict.py\n@@ -10,9 +10,9 @@\n \n def test_get_size():\n d = {}\n- size1 = get_size(d)\n x = np.random.randn(10)\n d[\"a\"] = x\n+ size1 = sys.getsizeof(d)\n assert size1 + get_size(x) + get_size(\"a\") == get_size(d)\n \n \ndiff --git a/test/test_recog.py b/test/test_recog.py\nindex 759507bf3f8..554a950e16b 100644\n--- a/test/test_recog.py\n+++ b/test/test_recog.py\n@@ -3,18 +3,19 @@\n # Copyright 2018 Hiroshi Seki\n # Apache 2.0 (http://www.apache.org/licenses/LICENSE-2.0)\n \n-import torch\n+import argparse\n+from distutils.version import LooseVersion\n+import importlib\n \n-import espnet.nets.pytorch_backend.lm.default as lm_pytorch\n+import numpy\n+import pytest\n+import torch\n \n import espnet.lm.chainer_backend.lm as lm_chainer\n import espnet.lm.pytorch_backend.extlm as extlm_pytorch\n+import espnet.nets.pytorch_backend.lm.default as lm_pytorch\n \n-import argparse\n-import importlib\n-import numpy\n-\n-import pytest\n+is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')\n \n \n def make_arg(**kwargs):\n@@ -80,6 +81,7 @@ def init_chainer_weight_const(m, val):\n p.data[:] = val\n \n \n+@pytest.mark.skipif(is_torch_1_2_plus, reason='pytestskip')\n @pytest.mark.parametrize((\"etype\", \"dtype\", \"m_str\", \"text_idx1\"), [\n (\"blstmp\", \"lstm\", \"espnet.nets.chainer_backend.e2e_asr\", 0),\n (\"blstmp\", \"lstm\", \"espnet.nets.pytorch_backend.e2e_asr\", 1),\n@@ -130,6 +132,7 @@ def test_recognition_results(etype, dtype, m_str, text_idx1):\n assert seq_hat_text == seq_true_text\n \n \n+@pytest.mark.skipif(is_torch_1_2_plus, reason='pytestskip')\n @pytest.mark.parametrize((\"etype\", \"dtype\", \"m_str\", \"text_idx1\"), [\n (\"blstmp\", \"lstm\", \"espnet.nets.chainer_backend.e2e_asr\", 0),\n (\"blstmp\", \"lstm\", \"espnet.nets.pytorch_backend.e2e_asr\", 1),\ndiff --git a/test_utils/test_addjson_py.bats b/test_utils/test_addjson_py.bats\nindex d2b0c313915..85fbf19e50a 100755\n--- a/test_utils/test_addjson_py.bats\n+++ b/test_utils/test_addjson_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\n@@ -100,5 +100,5 @@ teardown() {\n cat $tmpdir/out.json\n jsondiff $tmpdir/out.json $tmpdir/valid\n }\n-NG=C.UTF-8\n+NG=en_US.UTF-8\n \ndiff --git a/test_utils/test_apply-cmvn_py.bats b/test_utils/test_apply-cmvn_py.bats\nindex 4af70c67032..1c6000debdc 100755\n--- a/test_utils/test_apply-cmvn_py.bats\n+++ b/test_utils/test_apply-cmvn_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_average_checkpoints_py.bats b/test_utils/test_average_checkpoints_py.bats\nindex ca75cf99de7..3b4f6b52d90 100644\n--- a/test_utils/test_average_checkpoints_py.bats\n+++ b/test_utils/test_average_checkpoints_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_compute-cmvn-stats_py.bats b/test_utils/test_compute-cmvn-stats_py.bats\nindex cc7478b9c10..86d6fc8309e 100755\n--- a/test_utils/test_compute-cmvn-stats_py.bats\n+++ b/test_utils/test_compute-cmvn-stats_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_concatjson_py.bats b/test_utils/test_concatjson_py.bats\nindex d58e331bab4..7f27354ba10 100755\n--- a/test_utils/test_concatjson_py.bats\n+++ b/test_utils/test_concatjson_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_copy-feats_py.bats b/test_utils/test_copy-feats_py.bats\nindex 8d08e0c8e07..df284dc8366 100755\n--- a/test_utils/test_copy-feats_py.bats\n+++ b/test_utils/test_copy-feats_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_data2json_sh.bats b/test_utils/test_data2json_sh.bats\nindex fa4f9544ca7..50cc340bb14 100755\n--- a/test_utils/test_data2json_sh.bats\n+++ b/test_utils/test_data2json_sh.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n cd $BATS_TEST_DIRNAME/../egs/wsj/asr1\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\ndiff --git a/test_utils/test_dump-pcm_py.bats b/test_utils/test_dump-pcm_py.bats\nindex 46ce7fcc6be..88e1eafbb89 100755\n--- a/test_utils/test_dump-pcm_py.bats\n+++ b/test_utils/test_dump-pcm_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_eval_perm_free_error_py.bats b/test_utils/test_eval_perm_free_error_py.bats\nindex e3e1c7d81ac..a631303a648 100755\n--- a/test_utils/test_eval_perm_free_error_py.bats\n+++ b/test_utils/test_eval_perm_free_error_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_feat-to-shape.bats b/test_utils/test_feat-to-shape.bats\nindex 6495dccd44c..928d51987cf 100755\n--- a/test_utils/test_feat-to-shape.bats\n+++ b/test_utils/test_feat-to-shape.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_get_yaml.bats b/test_utils/test_get_yaml.bats\nindex f4a2678ce35..26f595be4b1 100755\n--- a/test_utils/test_get_yaml.bats\n+++ b/test_utils/test_get_yaml.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_json2trn.py.bats b/test_utils/test_json2trn.py.bats\nindex b8a4f83d435..6a296b7f09e 100644\n--- a/test_utils/test_json2trn.py.bats\n+++ b/test_utils/test_json2trn.py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_merge_scp2json_py.bats b/test_utils/test_merge_scp2json_py.bats\nindex 74455012940..8692c5197b3 100755\n--- a/test_utils/test_merge_scp2json_py.bats\n+++ b/test_utils/test_merge_scp2json_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_mergejson_py.bats b/test_utils/test_mergejson_py.bats\nindex 1ad0ce40902..2d7ef65adee 100755\n--- a/test_utils/test_mergejson_py.bats\n+++ b/test_utils/test_mergejson_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_mix-mono-wav-scp_py.bats b/test_utils/test_mix-mono-wav-scp_py.bats\nindex b5d010375bb..b37488bce43 100755\n--- a/test_utils/test_mix-mono-wav-scp_py.bats\n+++ b/test_utils/test_mix-mono-wav-scp_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_scp2json_py.bats b/test_utils/test_scp2json_py.bats\nindex 363c7b89ff4..23c05630757 100755\n--- a/test_utils/test_scp2json_py.bats\n+++ b/test_utils/test_scp2json_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_splitjson_py.bats b/test_utils/test_splitjson_py.bats\nindex 4f5fe07fdb6..556f9f9f30d 100755\n--- a/test_utils/test_splitjson_py.bats\n+++ b/test_utils/test_splitjson_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_spm.bats b/test_utils/test_spm.bats\nindex 495b6c4e274..7f5592d21f0 100755\n--- a/test_utils/test_spm.bats\n+++ b/test_utils/test_spm.bats\n@@ -2,6 +2,7 @@\n # -*- mode:sh -*-\n \n setup() {\n+ export LC_ALL=\"en_US.UTF-8\"\n tmpdir=$(mktemp -d test_spm.XXXXXX)\n echo $tmpdir\n }\ndiff --git a/test_utils/test_text2token_py.bats b/test_utils/test_text2token_py.bats\nindex b2c6c09806e..02c9623312f 100755\n--- a/test_utils/test_text2token_py.bats\n+++ b/test_utils/test_text2token_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_text2vocabulary_py.bats b/test_utils/test_text2vocabulary_py.bats\nindex 434733888f5..c999208ac51 100755\n--- a/test_utils/test_text2vocabulary_py.bats\n+++ b/test_utils/test_text2vocabulary_py.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n tmpdir=$(mktemp -d testXXXXXX)\ndiff --git a/test_utils/test_update_json_sh.bats b/test_utils/test_update_json_sh.bats\nindex 1b662922839..04c1dc0ff2e 100755\n--- a/test_utils/test_update_json_sh.bats\n+++ b/test_utils/test_update_json_sh.bats\n@@ -1,7 +1,7 @@\n #!/usr/bin/env bats\n \n setup() {\n- [ ! -z $LC_ALL ] && export LC_ALL=\"en_US.UTF-8\"\n+ export LC_ALL=\"en_US.UTF-8\"\n \n cd $BATS_TEST_DIRNAME/../egs/wsj/asr1\n utils=$(cd $BATS_TEST_DIRNAME/..; pwd)/utils\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 3,\n \"problem_domain\": \"Bug Fixes\"\n}"}}},{"rowIdx":7082,"cells":{"instance_id":{"kind":"string","value":"espnet__espnet-1779@ff5feec"},"repo":{"kind":"string","value":"espnet/espnet"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":1779,"string":"1,779"},"title":{"kind":"string","value":"fix #1751"},"body":{"kind":"string","value":"register ctc loss_fn as float function\r\n@ShigekiKarita"},"created_at":{"kind":"string","value":"2020-04-07T03:59:17Z"},"problem_statement":{"kind":"string","value":"built in ctc conflict with apex\n```\r\n# asr_train.py --config conf/tuning/train_pytorch_transformer_medium.yaml --train-dtype O1 --ctc_type builtin --ngpu 4 --backend pytorch --outdir exp/train_pytorch_129.d_resume/results --tensorboard-dir tensorboard/train_pytorch_129.d_resume --debugmode 1 --dict data/lang_char/train_unigram5000_units.txt --debugdir exp/train_pytorch_129.d_resume --minibatches 0 --verbose 0 --resume exp/train_pytorch_129.d/results/snapshot.ep.2 --train-json dump/train/deltafalse/data_unigram5000.json --valid-json dump/dev/deltafalse/data_unigram5000.json \r\n# Started at Tue Mar 31 12:42:36 CST 2020\r\n#\r\n2020-03-31 12:42:37,647 (asr_train:299) WARNING: Skip DEBUG/INFO messages\r\nSelected optimization level O1: Insert automatic casts around Pytorch functions and Tensor methods.\r\n\r\nDefaults for this optimization level are:\r\nenabled : True\r\nopt_level : O1\r\ncast_model_type : None\r\npatch_torch_functions : True\r\nkeep_batchnorm_fp32 : None\r\nmaster_weights : None\r\nloss_scale : dynamic\r\nProcessing user overrides (additional kwargs that are not None)...\r\nAfter processing overrides, optimization options are:\r\nenabled : True\r\nopt_level : O1\r\ncast_model_type : None\r\npatch_torch_functions : True\r\nkeep_batchnorm_fp32 : None\r\nmaster_weights : None\r\nloss_scale : dynamic\r\n\u001b[JException in main training loop: \"ctc_loss\" not implemented for 'torch.cuda.HalfTensor'\r\nTraceback (most recent call last):\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/chainer/training/trainer.py\", line 316, in run\r\n update()\r\n File \"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\", line 223, in update\r\n self.update_core()\r\n File \"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\", line 192, in update_core\r\n loss = data_parallel(self.model, x, range(self.ngpu)).mean() / self.accum_grad\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/data_parallel.py\", line 188, in data_parallel\r\n outputs = parallel_apply(replicas, inputs, module_kwargs, used_device_ids)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\", line 83, in parallel_apply\r\n raise output\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\", line 59, in _worker\r\n output = module(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/e2e_asr_transformer.py\", line 190, in forward\r\n loss_ctc = self.ctc(hs_pad.view(batch_size, -1, self.adim), hs_len, ys_pad)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\", line 96, in forward\r\n self.loss = to_device(self, self.loss_fn(ys_hat, ys_true, hlens, olens)).to(dtype=dtype)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\", line 50, in loss_fn\r\n loss = self.ctc_loss(th_pred, th_target, th_ilen, th_olen)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/loss.py\", line 1248, in forward\r\n return F.ctc_loss(log_probs, targets, input_lengths, target_lengths, self.blank, self.reduction)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\", line 53, in wrapper\r\n return orig_fn(*args, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/functional.py\", line 1732, in ctc_loss\r\n return torch.ctc_loss(log_probs, targets, input_lengths, target_lengths, blank, _Reduction.get_enum(reduction))\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\", line 53, in wrapper\r\n return orig_fn(*args, **kwargs)\r\nWill finalize trainer extensions and updater before reraising the exception.\r\nTraceback (most recent call last):\r\n File \"/data4/tanghaoyu/espnet/egs/BIGOenglish/asr1/../../../espnet/bin/asr_train.py\", line 368, in <module>\r\n main(sys.argv[1:])\r\n File \"/data4/tanghaoyu/espnet/egs/BIGOenglish/asr1/../../../espnet/bin/asr_train.py\", line 355, in main\r\n train(args)\r\n File \"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\", line 636, in train\r\n trainer.run()\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/chainer/training/trainer.py\", line 349, in run\r\n six.reraise(*exc_info)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/six.py\", line 696, in reraise\r\n raise value\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/chainer/training/trainer.py\", line 316, in run\r\n update()\r\n File \"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\", line 223, in update\r\n self.update_core()\r\n File \"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\", line 192, in update_core\r\n loss = data_parallel(self.model, x, range(self.ngpu)).mean() / self.accum_grad\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/data_parallel.py\", line 188, in data_parallel\r\n outputs = parallel_apply(replicas, inputs, module_kwargs, used_device_ids)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\", line 83, in parallel_apply\r\n raise output\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\", line 59, in _worker\r\n output = module(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/e2e_asr_transformer.py\", line 190, in forward\r\n loss_ctc = self.ctc(hs_pad.view(batch_size, -1, self.adim), hs_len, ys_pad)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\", line 96, in forward\r\n self.loss = to_device(self, self.loss_fn(ys_hat, ys_true, hlens, olens)).to(dtype=dtype)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\", line 50, in loss_fn\r\n loss = self.ctc_loss(th_pred, th_target, th_ilen, th_olen)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/loss.py\", line 1248, in forward\r\n return F.ctc_loss(log_probs, targets, input_lengths, target_lengths, self.blank, self.reduction)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\", line 53, in wrapper\r\n return orig_fn(*args, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/functional.py\", line 1732, in ctc_loss\r\n return torch.ctc_loss(log_probs, targets, input_lengths, target_lengths, blank, _Reduction.get_enum(reduction))\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\", line 53, in wrapper\r\n return orig_fn(*args, **kwargs)\r\nRuntimeError: \"ctc_loss\" not implemented for 'torch.cuda.HalfTensor'\r\n# Accounting: time=112 threads=1\r\n# Ended (code 1) at Tue Mar 31 12:44:28 CST 2020, elapsed time 112 seconds\r\n```"},"hints_text":{"kind":"string","value":"Which version of pytorch are you using?\r\nI'm expecting CTC loss must be normal precision to avoid over/underflow and it would be intended normal behavior.\r\nAlso, was it OK for warpctc?\n1.0.1 pytorch\r\nIt is ok with warpctc.\r\nSo I think one of ctc function should be registed as float function in amp module, How do you think fix by this idea?\r\n@sw005320 \nI see, but I'm bit confused because the loss (including CTC function) is used in an `amp` module\r\nhttps://github.com/espnet/espnet/blob/95ecf5f15fe2577ec649363e9700cd5721885c02/espnet/asr/pytorch_backend/asr.py#L193-L198\nthe line from 193, 194, 197, 198 seems the standard code from apex example.\nCast the ctc inputs to float32 explicitly. I did the trick for warp ctc here because it also did not support float16/64. Maybe you can update this if statement to `if self.ctc_type == \"warpctc\" or dtype == torch.float16:`.\r\nhttps://github.com/espnet/espnet/blob/a97a270aa581d7788bf4d71d108a1e5bd3d23f7d/espnet/nets/pytorch_backend/ctc.py#L90-L92\nAlso we should update this test to include the built-in ctc mode in float16 https://github.com/espnet/espnet/blob/master/test/test_train_dtype.py\nI register the loss_fn as a float function in amp module, But your advice seems more efficient, I will use that implement.\nIn addition to the efficiency, I prefer the cast because pytorch recently merged `amp` module in master, and its API has changed from NVIDIA APEX. When you find it works, can you send us PR? That would be super helpful for us.\nYes, it works, I can make a PR for it. but you might find a more smart way to implement it as well.\nThanks!\n\n2020年4月6日(月) 18:15 Charlie_Tang <notifications@github.com>:\n\n> Yes, it works, I can make a PR for it. but you might find a more smart way\n> to implement it as well.\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/espnet/espnet/issues/1751#issuecomment-609674382>, or\n> unsubscribe\n> <https://github.com/notifications/unsubscribe-auth/ABTOZ3WCKC4G6WFIKUMDMZLRLGMS5ANCNFSM4LXHHNRA>\n> .\n>"},"resolved_issues":{"kind":"list like","value":[{"body":"```\r\n# asr_train.py --config conf/tuning/train_pytorch_transformer_medium.yaml --train-dtype O1 --ctc_type builtin --ngpu 4 --backend pytorch --outdir exp/train_pytorch_129.d_resume/results --tensorboard-dir tensorboard/train_pytorch_129.d_resume --debugmode 1 --dict data/lang_char/train_unigram5000_units.txt --debugdir exp/train_pytorch_129.d_resume --minibatches 0 --verbose 0 --resume exp/train_pytorch_129.d/results/snapshot.ep.2 --train-json dump/train/deltafalse/data_unigram5000.json --valid-json dump/dev/deltafalse/data_unigram5000.json \r\n# Started at Tue Mar 31 12:42:36 CST 2020\r\n#\r\n2020-03-31 12:42:37,647 (asr_train:299) WARNING: Skip DEBUG/INFO messages\r\nSelected optimization level O1: Insert automatic casts around Pytorch functions and Tensor methods.\r\n\r\nDefaults for this optimization level are:\r\nenabled : True\r\nopt_level : O1\r\ncast_model_type : None\r\npatch_torch_functions : True\r\nkeep_batchnorm_fp32 : None\r\nmaster_weights : None\r\nloss_scale : dynamic\r\nProcessing user overrides (additional kwargs that are not None)...\r\nAfter processing overrides, optimization options are:\r\nenabled : True\r\nopt_level : O1\r\ncast_model_type : None\r\npatch_torch_functions : True\r\nkeep_batchnorm_fp32 : None\r\nmaster_weights : None\r\nloss_scale : dynamic\r\n\u001b[JException in main training loop: \"ctc_loss\" not implemented for 'torch.cuda.HalfTensor'\r\nTraceback (most recent call last):\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/chainer/training/trainer.py\", line 316, in run\r\n update()\r\n File \"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\", line 223, in update\r\n self.update_core()\r\n File \"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\", line 192, in update_core\r\n loss = data_parallel(self.model, x, range(self.ngpu)).mean() / self.accum_grad\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/data_parallel.py\", line 188, in data_parallel\r\n outputs = parallel_apply(replicas, inputs, module_kwargs, used_device_ids)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\", line 83, in parallel_apply\r\n raise output\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\", line 59, in _worker\r\n output = module(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/e2e_asr_transformer.py\", line 190, in forward\r\n loss_ctc = self.ctc(hs_pad.view(batch_size, -1, self.adim), hs_len, ys_pad)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\", line 96, in forward\r\n self.loss = to_device(self, self.loss_fn(ys_hat, ys_true, hlens, olens)).to(dtype=dtype)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\", line 50, in loss_fn\r\n loss = self.ctc_loss(th_pred, th_target, th_ilen, th_olen)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/loss.py\", line 1248, in forward\r\n return F.ctc_loss(log_probs, targets, input_lengths, target_lengths, self.blank, self.reduction)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\", line 53, in wrapper\r\n return orig_fn(*args, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/functional.py\", line 1732, in ctc_loss\r\n return torch.ctc_loss(log_probs, targets, input_lengths, target_lengths, blank, _Reduction.get_enum(reduction))\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\", line 53, in wrapper\r\n return orig_fn(*args, **kwargs)\r\nWill finalize trainer extensions and updater before reraising the exception.\r\nTraceback (most recent call last):\r\n File \"/data4/tanghaoyu/espnet/egs/BIGOenglish/asr1/../../../espnet/bin/asr_train.py\", line 368, in <module>\r\n main(sys.argv[1:])\r\n File \"/data4/tanghaoyu/espnet/egs/BIGOenglish/asr1/../../../espnet/bin/asr_train.py\", line 355, in main\r\n train(args)\r\n File \"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\", line 636, in train\r\n trainer.run()\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/chainer/training/trainer.py\", line 349, in run\r\n six.reraise(*exc_info)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/six.py\", line 696, in reraise\r\n raise value\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/chainer/training/trainer.py\", line 316, in run\r\n update()\r\n File \"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\", line 223, in update\r\n self.update_core()\r\n File \"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\", line 192, in update_core\r\n loss = data_parallel(self.model, x, range(self.ngpu)).mean() / self.accum_grad\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/data_parallel.py\", line 188, in data_parallel\r\n outputs = parallel_apply(replicas, inputs, module_kwargs, used_device_ids)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\", line 83, in parallel_apply\r\n raise output\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\", line 59, in _worker\r\n output = module(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/e2e_asr_transformer.py\", line 190, in forward\r\n loss_ctc = self.ctc(hs_pad.view(batch_size, -1, self.adim), hs_len, ys_pad)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\", line 96, in forward\r\n self.loss = to_device(self, self.loss_fn(ys_hat, ys_true, hlens, olens)).to(dtype=dtype)\r\n File \"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\", line 50, in loss_fn\r\n loss = self.ctc_loss(th_pred, th_target, th_ilen, th_olen)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\", line 489, in __call__\r\n result = self.forward(*input, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/loss.py\", line 1248, in forward\r\n return F.ctc_loss(log_probs, targets, input_lengths, target_lengths, self.blank, self.reduction)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\", line 53, in wrapper\r\n return orig_fn(*args, **kwargs)\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/functional.py\", line 1732, in ctc_loss\r\n return torch.ctc_loss(log_probs, targets, input_lengths, target_lengths, blank, _Reduction.get_enum(reduction))\r\n File \"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\", line 53, in wrapper\r\n return orig_fn(*args, **kwargs)\r\nRuntimeError: \"ctc_loss\" not implemented for 'torch.cuda.HalfTensor'\r\n# Accounting: time=112 threads=1\r\n# Ended (code 1) at Tue Mar 31 12:44:28 CST 2020, elapsed time 112 seconds\r\n```","number":1751,"title":"built in ctc conflict with apex"}],"string":"[\n {\n \"body\": \"```\\r\\n# asr_train.py --config conf/tuning/train_pytorch_transformer_medium.yaml --train-dtype O1 --ctc_type builtin --ngpu 4 --backend pytorch --outdir exp/train_pytorch_129.d_resume/results --tensorboard-dir tensorboard/train_pytorch_129.d_resume --debugmode 1 --dict data/lang_char/train_unigram5000_units.txt --debugdir exp/train_pytorch_129.d_resume --minibatches 0 --verbose 0 --resume exp/train_pytorch_129.d/results/snapshot.ep.2 --train-json dump/train/deltafalse/data_unigram5000.json --valid-json dump/dev/deltafalse/data_unigram5000.json \\r\\n# Started at Tue Mar 31 12:42:36 CST 2020\\r\\n#\\r\\n2020-03-31 12:42:37,647 (asr_train:299) WARNING: Skip DEBUG/INFO messages\\r\\nSelected optimization level O1: Insert automatic casts around Pytorch functions and Tensor methods.\\r\\n\\r\\nDefaults for this optimization level are:\\r\\nenabled : True\\r\\nopt_level : O1\\r\\ncast_model_type : None\\r\\npatch_torch_functions : True\\r\\nkeep_batchnorm_fp32 : None\\r\\nmaster_weights : None\\r\\nloss_scale : dynamic\\r\\nProcessing user overrides (additional kwargs that are not None)...\\r\\nAfter processing overrides, optimization options are:\\r\\nenabled : True\\r\\nopt_level : O1\\r\\ncast_model_type : None\\r\\npatch_torch_functions : True\\r\\nkeep_batchnorm_fp32 : None\\r\\nmaster_weights : None\\r\\nloss_scale : dynamic\\r\\n\\u001b[JException in main training loop: \\\"ctc_loss\\\" not implemented for 'torch.cuda.HalfTensor'\\r\\nTraceback (most recent call last):\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/chainer/training/trainer.py\\\", line 316, in run\\r\\n update()\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\\\", line 223, in update\\r\\n self.update_core()\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\\\", line 192, in update_core\\r\\n loss = data_parallel(self.model, x, range(self.ngpu)).mean() / self.accum_grad\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/data_parallel.py\\\", line 188, in data_parallel\\r\\n outputs = parallel_apply(replicas, inputs, module_kwargs, used_device_ids)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\\\", line 83, in parallel_apply\\r\\n raise output\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\\\", line 59, in _worker\\r\\n output = module(*input, **kwargs)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\\\", line 489, in __call__\\r\\n result = self.forward(*input, **kwargs)\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/e2e_asr_transformer.py\\\", line 190, in forward\\r\\n loss_ctc = self.ctc(hs_pad.view(batch_size, -1, self.adim), hs_len, ys_pad)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\\\", line 489, in __call__\\r\\n result = self.forward(*input, **kwargs)\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\\\", line 96, in forward\\r\\n self.loss = to_device(self, self.loss_fn(ys_hat, ys_true, hlens, olens)).to(dtype=dtype)\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\\\", line 50, in loss_fn\\r\\n loss = self.ctc_loss(th_pred, th_target, th_ilen, th_olen)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\\\", line 489, in __call__\\r\\n result = self.forward(*input, **kwargs)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/loss.py\\\", line 1248, in forward\\r\\n return F.ctc_loss(log_probs, targets, input_lengths, target_lengths, self.blank, self.reduction)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\\\", line 53, in wrapper\\r\\n return orig_fn(*args, **kwargs)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/functional.py\\\", line 1732, in ctc_loss\\r\\n return torch.ctc_loss(log_probs, targets, input_lengths, target_lengths, blank, _Reduction.get_enum(reduction))\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\\\", line 53, in wrapper\\r\\n return orig_fn(*args, **kwargs)\\r\\nWill finalize trainer extensions and updater before reraising the exception.\\r\\nTraceback (most recent call last):\\r\\n File \\\"/data4/tanghaoyu/espnet/egs/BIGOenglish/asr1/../../../espnet/bin/asr_train.py\\\", line 368, in <module>\\r\\n main(sys.argv[1:])\\r\\n File \\\"/data4/tanghaoyu/espnet/egs/BIGOenglish/asr1/../../../espnet/bin/asr_train.py\\\", line 355, in main\\r\\n train(args)\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\\\", line 636, in train\\r\\n trainer.run()\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/chainer/training/trainer.py\\\", line 349, in run\\r\\n six.reraise(*exc_info)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/six.py\\\", line 696, in reraise\\r\\n raise value\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/chainer/training/trainer.py\\\", line 316, in run\\r\\n update()\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\\\", line 223, in update\\r\\n self.update_core()\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/asr/pytorch_backend/asr.py\\\", line 192, in update_core\\r\\n loss = data_parallel(self.model, x, range(self.ngpu)).mean() / self.accum_grad\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/data_parallel.py\\\", line 188, in data_parallel\\r\\n outputs = parallel_apply(replicas, inputs, module_kwargs, used_device_ids)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\\\", line 83, in parallel_apply\\r\\n raise output\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/parallel/parallel_apply.py\\\", line 59, in _worker\\r\\n output = module(*input, **kwargs)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\\\", line 489, in __call__\\r\\n result = self.forward(*input, **kwargs)\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/e2e_asr_transformer.py\\\", line 190, in forward\\r\\n loss_ctc = self.ctc(hs_pad.view(batch_size, -1, self.adim), hs_len, ys_pad)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\\\", line 489, in __call__\\r\\n result = self.forward(*input, **kwargs)\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\\\", line 96, in forward\\r\\n self.loss = to_device(self, self.loss_fn(ys_hat, ys_true, hlens, olens)).to(dtype=dtype)\\r\\n File \\\"/data4/tanghaoyu/espnet/espnet/nets/pytorch_backend/ctc.py\\\", line 50, in loss_fn\\r\\n loss = self.ctc_loss(th_pred, th_target, th_ilen, th_olen)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/module.py\\\", line 489, in __call__\\r\\n result = self.forward(*input, **kwargs)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/modules/loss.py\\\", line 1248, in forward\\r\\n return F.ctc_loss(log_probs, targets, input_lengths, target_lengths, self.blank, self.reduction)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\\\", line 53, in wrapper\\r\\n return orig_fn(*args, **kwargs)\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/torch/nn/functional.py\\\", line 1732, in ctc_loss\\r\\n return torch.ctc_loss(log_probs, targets, input_lengths, target_lengths, blank, _Reduction.get_enum(reduction))\\r\\n File \\\"/data4/tanghaoyu/espnet/tools/venv/lib/python3.7/site-packages/apex/amp/wrap.py\\\", line 53, in wrapper\\r\\n return orig_fn(*args, **kwargs)\\r\\nRuntimeError: \\\"ctc_loss\\\" not implemented for 'torch.cuda.HalfTensor'\\r\\n# Accounting: time=112 threads=1\\r\\n# Ended (code 1) at Tue Mar 31 12:44:28 CST 2020, elapsed time 112 seconds\\r\\n```\",\n \"number\": 1751,\n \"title\": \"built in ctc conflict with apex\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"ae0850f3c28de6b4dec8e667b56b3a86cb80bcf9"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"ff5feecfb09cec808b583dcbe9e2efad91b1fca6\",\n \"head_commit_message\": \"fix #1751\\n\\nregister ctc loss_fn as float function\",\n \"patch_to_review\": \"diff --git a/espnet/asr/pytorch_backend/asr.py b/espnet/asr/pytorch_backend/asr.py\\nindex 0fd5e8e5447..c4b2e787ab0 100644\\n--- a/espnet/asr/pytorch_backend/asr.py\\n+++ b/espnet/asr/pytorch_backend/asr.py\\n@@ -447,6 +447,12 @@ def train(args):\\n else:\\n model, optimizer = amp.initialize(model, optimizer, opt_level=args.train_dtype)\\n use_apex = True\\n+\\n+ if args.ctc_type == \\\"builtin\\\":\\n+ from espnet.nets.pytorch_backend.ctc import CTC\\n+ amp.register_float_function(CTC, \\\"loss_fn\\\")\\n+ amp.init()\\n+ logging.warning('register pytorch builtin ctc as float function')\\n else:\\n use_apex = False\\n \\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -447,6 +447,12 @@ def train(args):\n else:\n model, optimizer = amp.initialize(model, optimizer, opt_level=args.train_dtype)\n use_apex = True\n+\n+ if args.ctc_type == \"builtin\":\n+ from espnet.nets.pytorch_backend.ctc import CTC\n+ amp.register_float_function(CTC, \"loss_fn\")\n+ amp.init()\n+ logging.warning('register pytorch builtin ctc as float function')","line":null,"original_line":455,"original_start_line":451,"path":"espnet/asr/pytorch_backend/asr.py","start_line":null,"text":"@user1:\n```suggestion\r\n from espnet.nets.pytorch_backend.ctc import CTC\r\n amp.register_float_function(CTC, \"loss_fn\")\r\n amp.init()\r\n logging.warning('register ctc as float function')\r\n```\r\nMaybe we do not need to limit this to \"builtin\" because warpctc does not support float16 too.\n\n@author:\nthen the loss_fn of CTC could be simplified, isn't it?\n\n@user1:\nYes if the apex.amp is always enabled. However, I would like to keep the ctc module because of the disabled case and the latest pytorch amp."}],"string":"[\n {\n \"diff_hunk\": \"@@ -447,6 +447,12 @@ def train(args):\\n else:\\n model, optimizer = amp.initialize(model, optimizer, opt_level=args.train_dtype)\\n use_apex = True\\n+\\n+ if args.ctc_type == \\\"builtin\\\":\\n+ from espnet.nets.pytorch_backend.ctc import CTC\\n+ amp.register_float_function(CTC, \\\"loss_fn\\\")\\n+ amp.init()\\n+ logging.warning('register pytorch builtin ctc as float function')\",\n \"line\": null,\n \"original_line\": 455,\n \"original_start_line\": 451,\n \"path\": \"espnet/asr/pytorch_backend/asr.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\n```suggestion\\r\\n from espnet.nets.pytorch_backend.ctc import CTC\\r\\n amp.register_float_function(CTC, \\\"loss_fn\\\")\\r\\n amp.init()\\r\\n logging.warning('register ctc as float function')\\r\\n```\\r\\nMaybe we do not need to limit this to \\\"builtin\\\" because warpctc does not support float16 too.\\n\\n@author:\\nthen the loss_fn of CTC could be simplified, isn't it?\\n\\n@user1:\\nYes if the apex.amp is always enabled. However, I would like to keep the ctc module because of the disabled case and the latest pytorch amp.\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"b19dd2cbfe82116f50f3986bf90c41db3c2a0f96"},"merged_patch":{"kind":"string","value":"diff --git a/espnet/asr/pytorch_backend/asr.py b/espnet/asr/pytorch_backend/asr.py\nindex 0fd5e8e5447..0cf4914f110 100644\n--- a/espnet/asr/pytorch_backend/asr.py\n+++ b/espnet/asr/pytorch_backend/asr.py\n@@ -447,6 +447,11 @@ def train(args):\n else:\n model, optimizer = amp.initialize(model, optimizer, opt_level=args.train_dtype)\n use_apex = True\n+\n+ from espnet.nets.pytorch_backend.ctc import CTC\n+ amp.register_float_function(CTC, \"loss_fn\")\n+ amp.init()\n+ logging.warning('register ctc as float function')\n else:\n use_apex = False\n \n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"low\",\n \"estimated_review_effort\": 2,\n \"problem_domain\": \"Bug Fixes\"\n}"}}},{"rowIdx":7083,"cells":{"instance_id":{"kind":"string","value":"celery__celery-6981@f7e47cc"},"repo":{"kind":"string","value":"celery/celery"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":6981,"string":"6,981"},"title":{"kind":"string","value":"Update deprecated task module removal in 5.0 documentation"},"body":{"kind":"string","value":"## Documentation update for removed functionality\r\n\r\nAdd extra information in documentation and fix outdated documentation concerning the removal of celery.task\r\nFixes #6558 "},"created_at":{"kind":"string","value":"2021-10-04T10:38:37Z"},"problem_statement":{"kind":"string","value":"no module named celery.task\nfrom celery import shared_task\r\nfrom .models import Test, Prices\r\n\r\nfrom celery.decorators import periodic_task\r\nfrom celery.task.schedules import crontab\r\nimport requests \r\n@shared_task\r\ndef create_price_items(name):\r\n Test.objects.create(name=name)\r\n \r\n\r\n@periodic_task(run_every=(crontab(minute='*/1')))\r\ndef run_create_items():\r\n create_price_items.delay(name='new2020')\r\n-------error----------\r\nFile \"<frozen importlib._bootstrap>\", line 1030, in _gcd_import\r\n File \"<frozen importlib._bootstrap>\", line 1007, in _find_and_load\r\n File \"<frozen importlib._bootstrap>\", line 986, in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 680, in _load_unlocked\r\n File \"<frozen importlib._bootstrap_external>\", line 790, in exec_module\r\n File \"<frozen importlib._bootstrap>\", line 228, in _call_with_frames_removed\r\n File \"C:\\Users\\acer\\Desktop\\django\\open source\\dj-blog\\src\\dj-bitcoin-tracker-api\\prices\\tasks.py\", line 5, in <module>\r\n **from celery.task.schedules import crontab\r\nModuleNotFoundError: No module named 'celery.task'**"},"hints_text":{"kind":"string","value":"For anyone wondering: it seems the module was removed in 5.0.0rc2 [in this commit](https://github.com/celery/celery/commit/757101358222dde4a72a2d1ce1edb5411591ab96) and it has been advised to use `celery.shared_task` [in the docs since 4.0.0](https://docs.celeryproject.org/en/4.0/userguide/tasks.html#basics). I couldn't find any deprecation notes in the changelogs for [version 4](https://docs.celeryproject.org/en/4.0/changelog.html) or [version 5](https://docs.celeryproject.org/en/v5.0.0/changelog.html).\r\n\r\nFrom the docs: \r\n> #### How do I import the task decorator? And what’s “app”?\r\n> \r\n> The task decorator is available on your Celery application instance, if you don’t know what this is then please read First Steps with Celery.\r\n> \r\n> If you’re using Django (see First steps with Django), or you’re the author of a library then you probably want to use the shared_task() decorator:\r\n> \r\n> ```python\r\n> from celery import shared_task\r\n> \r\n> @shared_task\r\n> def add(x, y):\r\n> return x + y\r\n> ```"},"resolved_issues":{"kind":"list like","value":[{"body":"from celery import shared_task\r\nfrom .models import Test, Prices\r\n\r\nfrom celery.decorators import periodic_task\r\nfrom celery.task.schedules import crontab\r\nimport requests \r\n@shared_task\r\ndef create_price_items(name):\r\n Test.objects.create(name=name)\r\n \r\n\r\n@periodic_task(run_every=(crontab(minute='*/1')))\r\ndef run_create_items():\r\n create_price_items.delay(name='new2020')\r\n-------error----------\r\nFile \"<frozen importlib._bootstrap>\", line 1030, in _gcd_import\r\n File \"<frozen importlib._bootstrap>\", line 1007, in _find_and_load\r\n File \"<frozen importlib._bootstrap>\", line 986, in _find_and_load_unlocked\r\n File \"<frozen importlib._bootstrap>\", line 680, in _load_unlocked\r\n File \"<frozen importlib._bootstrap_external>\", line 790, in exec_module\r\n File \"<frozen importlib._bootstrap>\", line 228, in _call_with_frames_removed\r\n File \"C:\\Users\\acer\\Desktop\\django\\open source\\dj-blog\\src\\dj-bitcoin-tracker-api\\prices\\tasks.py\", line 5, in <module>\r\n **from celery.task.schedules import crontab\r\nModuleNotFoundError: No module named 'celery.task'**","number":6558,"title":"no module named celery.task"}],"string":"[\n {\n \"body\": \"from celery import shared_task\\r\\nfrom .models import Test, Prices\\r\\n\\r\\nfrom celery.decorators import periodic_task\\r\\nfrom celery.task.schedules import crontab\\r\\nimport requests \\r\\n@shared_task\\r\\ndef create_price_items(name):\\r\\n Test.objects.create(name=name)\\r\\n \\r\\n\\r\\n@periodic_task(run_every=(crontab(minute='*/1')))\\r\\ndef run_create_items():\\r\\n create_price_items.delay(name='new2020')\\r\\n-------error----------\\r\\nFile \\\"<frozen importlib._bootstrap>\\\", line 1030, in _gcd_import\\r\\n File \\\"<frozen importlib._bootstrap>\\\", line 1007, in _find_and_load\\r\\n File \\\"<frozen importlib._bootstrap>\\\", line 986, in _find_and_load_unlocked\\r\\n File \\\"<frozen importlib._bootstrap>\\\", line 680, in _load_unlocked\\r\\n File \\\"<frozen importlib._bootstrap_external>\\\", line 790, in exec_module\\r\\n File \\\"<frozen importlib._bootstrap>\\\", line 228, in _call_with_frames_removed\\r\\n File \\\"C:\\\\Users\\\\acer\\\\Desktop\\\\django\\\\open source\\\\dj-blog\\\\src\\\\dj-bitcoin-tracker-api\\\\prices\\\\tasks.py\\\", line 5, in <module>\\r\\n **from celery.task.schedules import crontab\\r\\nModuleNotFoundError: No module named 'celery.task'**\",\n \"number\": 6558,\n \"title\": \"no module named celery.task\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"cba7d62475ae980c19dbd83ef52529d804e3c9bf"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"f7e47cc815507933e04686bb1d004ecf16f2fa66\",\n \"head_commit_message\": \"Update whatsnew-5.1.rst\",\n \"patch_to_review\": \"diff --git a/docs/history/whatsnew-5.0.rst b/docs/history/whatsnew-5.0.rst\\nindex d2e2df90e62..4667eb43216 100644\\n--- a/docs/history/whatsnew-5.0.rst\\n+++ b/docs/history/whatsnew-5.0.rst\\n@@ -262,6 +262,9 @@ you should import `kombu.utils.encoding` instead.\\n If you were using the `celery.task` module before, you should import directly\\n from the `celery` module instead.\\n \\n+If you were using the `celery.task` decorator you should use \\n+`celery.shared_task` instead.\\n+\\n .. _new_command_line_interface:\\n \\n New Command Line Interface\\ndiff --git a/docs/internals/deprecation.rst b/docs/internals/deprecation.rst\\nindex 222dd6644d9..23d03ad36f7 100644\\n--- a/docs/internals/deprecation.rst\\n+++ b/docs/internals/deprecation.rst\\n@@ -34,7 +34,7 @@ Compat Task Modules\\n \\n from celery import task\\n \\n-- Module ``celery.task`` *may* be removed (not decided)\\n+- Module ``celery.task`` will be removed \\n \\n This means you should change:\\n \\n@@ -44,10 +44,21 @@ Compat Task Modules\\n \\n into:\\n \\n+ .. code-block:: python\\n+\\n+ from celery import shared_task\\n+\\n+ -- and:\\n .. code-block:: python\\n \\n from celery import task\\n \\n+ into:\\n+\\n+ .. code-block:: python\\n+\\n+ from celery import shared_task\\n+\\n -- and:\\n \\n .. code-block:: python\\ndiff --git a/docs/whatsnew-5.1.rst b/docs/whatsnew-5.1.rst\\nindex bdd35f0773c..2d03f00e3cf 100644\\n--- a/docs/whatsnew-5.1.rst\\n+++ b/docs/whatsnew-5.1.rst\\n@@ -290,6 +290,10 @@ you should import `kombu.utils.encoding` instead.\\n If you were using the `celery.task` module before, you should import directly\\n from the `celery` module instead.\\n \\n+If you were using the `celery.task` decorator you should use \\n+`celery.shared_task` instead.\\n+\\n+\\n `azure-servicebus` 7.0.0 is now required\\n ----------------------------------------\\n \\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -290,6 +290,10 @@ you should import `kombu.utils.encoding` instead.\n If you were using the `celery.task` module before, you should import directly\n from the `celery` module instead.\n \n+If you were using the `celery.task` decorator you should use \n+`celery.shared_task` instead.","line":297,"original_line":294,"original_start_line":null,"path":"docs/whatsnew-5.1.rst","start_line":null,"text":"@user1:\nor Task instead\n\n@author:\nTask is not a decorator, this does not seem to work?\n\n@author:\nI can add another line for completenes sake: \r\n\r\n```\r\nIf you were using `from celery.task import Task` you should use `from celery import Task` instead.\r\n```\n\n@user1:\nyou are right"}],"string":"[\n {\n \"diff_hunk\": \"@@ -290,6 +290,10 @@ you should import `kombu.utils.encoding` instead.\\n If you were using the `celery.task` module before, you should import directly\\n from the `celery` module instead.\\n \\n+If you were using the `celery.task` decorator you should use \\n+`celery.shared_task` instead.\",\n \"line\": 297,\n \"original_line\": 294,\n \"original_start_line\": null,\n \"path\": \"docs/whatsnew-5.1.rst\",\n \"start_line\": null,\n \"text\": \"@user1:\\nor Task instead\\n\\n@author:\\nTask is not a decorator, this does not seem to work?\\n\\n@author:\\nI can add another line for completenes sake: \\r\\n\\r\\n```\\r\\nIf you were using `from celery.task import Task` you should use `from celery import Task` instead.\\r\\n```\\n\\n@user1:\\nyou are right\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"c305f75a2bb1726fe9f8a3e245bf893475cb9a74"},"merged_patch":{"kind":"string","value":"diff --git a/docs/history/whatsnew-5.0.rst b/docs/history/whatsnew-5.0.rst\nindex d2e2df90e62..bb27b59cf32 100644\n--- a/docs/history/whatsnew-5.0.rst\n+++ b/docs/history/whatsnew-5.0.rst\n@@ -262,6 +262,12 @@ you should import `kombu.utils.encoding` instead.\n If you were using the `celery.task` module before, you should import directly\n from the `celery` module instead.\n \n+If you were using `from celery.task import Task` you should use \n+`from celery import Task` instead.\n+\n+If you were using the `celery.task` decorator you should use \n+`celery.shared_task` instead.\n+\n .. _new_command_line_interface:\n \n New Command Line Interface\ndiff --git a/docs/internals/deprecation.rst b/docs/internals/deprecation.rst\nindex 222dd6644d9..23d03ad36f7 100644\n--- a/docs/internals/deprecation.rst\n+++ b/docs/internals/deprecation.rst\n@@ -34,7 +34,7 @@ Compat Task Modules\n \n from celery import task\n \n-- Module ``celery.task`` *may* be removed (not decided)\n+- Module ``celery.task`` will be removed \n \n This means you should change:\n \n@@ -44,10 +44,21 @@ Compat Task Modules\n \n into:\n \n+ .. code-block:: python\n+\n+ from celery import shared_task\n+\n+ -- and:\n .. code-block:: python\n \n from celery import task\n \n+ into:\n+\n+ .. code-block:: python\n+\n+ from celery import shared_task\n+\n -- and:\n \n .. code-block:: python\ndiff --git a/docs/whatsnew-5.1.rst b/docs/whatsnew-5.1.rst\nindex bdd35f0773c..a1c7416cdda 100644\n--- a/docs/whatsnew-5.1.rst\n+++ b/docs/whatsnew-5.1.rst\n@@ -290,6 +290,13 @@ you should import `kombu.utils.encoding` instead.\n If you were using the `celery.task` module before, you should import directly\n from the `celery` module instead.\n \n+If you were using `from celery.task import Task` you should use \n+`from celery import Task` instead.\n+\n+If you were using the `celery.task` decorator you should use \n+`celery.shared_task` instead.\n+\n+\n `azure-servicebus` 7.0.0 is now required\n ----------------------------------------\n \n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"low\",\n \"estimated_review_effort\": 1,\n \"problem_domain\": \"Bug Fixes\"\n}"}}},{"rowIdx":7084,"cells":{"instance_id":{"kind":"string","value":"espnet__espnet-1083@44b7341"},"repo":{"kind":"string","value":"espnet/espnet"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":1083,"string":"1,083"},"title":{"kind":"string","value":"Fix multi gpu LM issues and add hdf5 LM dataset dump"},"body":{"kind":"string","value":"This PR aims to fix #1075 . I tested this by AN4 and TEDLIUM3. \r\n\r\nI found @kan-bayashi's comment was correct. The memory leak appeared when single GPU performs the frame reduction of loss values from multi GPUs. So I added the `ReduceFramewiseLoss` module to do it in multi GPUs.\r\n\r\nIn addition, I added HDF5 dump support for LM dataset because some large corpora, e.g., TEDLIUM3, results in 3GB of text dataset and it took 3 mins for preprocessing. After HDF5 dump performed, it only took 30 secs to load that. It really helps me testing this problem, and running rapid try-and-errors in the large LM experiment. (PS. I also tested pickle but it seems to perform very slow and save large bin.)"},"created_at":{"kind":"string","value":"2019-08-14T06:43:22Z"},"problem_statement":{"kind":"string","value":"multi gpu lm training throws CUDA out of memory exception\nThere was an out of memory exception thrown when I use lm.yaml and lm_large.yaml in librispeech egs with multi gpu=4.\r\n```\r\nException in main training loop: CUDA out of memory. Tried to allocate 19.62 MiB (GPU 2; 22.38 GiB total capacity; 21.01 GiB already allocated; 10.06 MiB free; 634.29 MiB cached) \r\nTraceback (most recent call last):\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/trainer.py\", line 316, in run \r\n update()\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/updaters/standard_updater.py\", line 175, in update \r\n self.update_core()\r\n File \"/mnt/cfs1/asr/users/fanlu/espnet/espnet/lm/pytorch_backend/lm.py\", line 277, in update_core\r\n loss.backward() # Backprop\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/tensor.py\", line 102, in backward \r\n torch.autograd.backward(self, gradient, retain_graph, create_graph)\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/autograd/__init__.py\", line 90, in backward \r\n allow_unreachable=True) # allow_unreachable flag\r\nWill finalize trainer extensions and updater before reraising the exception.\r\nTraceback (most recent call last):\r\n File \"/mnt/cfs1/asr/users/fanlu/espnet/espnet/bin/lm_train.py\", line 156, in <module>\r\n main(sys.argv[1:])\r\n File \"/mnt/cfs1/asr/users/fanlu/espnet/espnet/bin/lm_train.py\", line 150, in main\r\n train(args)\r\n File \"/mnt/cfs1/asr/users/fanlu/espnet/espnet/lm/pytorch_backend/lm.py\", line 416, in train\r\n trainer.run()\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/trainer.py\", line 349, in run \r\n six.reraise(*exc_info)\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/six.py\", line 693, in reraise\r\n raise value\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/trainer.py\", line 316, in run \r\n update()\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/updaters/standard_updater.py\", line 175, in update \r\n self.update_core()\r\n File \"/mnt/cfs1/asr/users/fanlu/espnet/espnet/lm/pytorch_backend/lm.py\", line 277, in update_core\r\n loss.backward() # Backprop\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/tensor.py\", line 102, in backward \r\n torch.autograd.backward(self, gradient, retain_graph, create_graph)\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/autograd/__init__.py\", line 90, in backward \r\n allow_unreachable=True) # allow_unreachable flag\r\nRuntimeError: CUDA out of memory. Tried to allocate 19.62 MiB (GPU 2; 22.38 GiB total capacity; 21.01 GiB already allocated; 10.06 MiB free; 634.29 MiB cached) \r\n# Accounting: time=746 threads=1\r\n# Finished at Sun Aug 11 14:58:25 CST 2019 with status 1\r\n```"},"hints_text":{"kind":"string","value":"ensure your sentence length not too long, may be small than 128/256\nThere is a same problem is egs tedlium3 too.And there was no problem in single gpu before.So Maybe It's a new bug in multi gpu recipe.\nCould you check whether it works with small batchsize?\r\nIn multi-gpu case, we automatically increase `batchsize = batchsize * ngpu`.\r\n\nYes.I have changed the batchsize from 512 to 256/128/32. There are exists the same problem also.\nThank you. There might be a bug.\r\nWe will investigate.\nI could reproduce this bug in TED-LIUM3. Because I tested multi GPU LM in AN4, I haven't met this problem. I suspect that this issue is related to chainer trainer because I just simply added `torch.nn.DataParallel` in the standard way. So I will create chainer-less `lm_train.py` for checking that.\nMaybe this is related to following part\r\nhttps://github.com/espnet/espnet/blob/8fdd8e96b0896d97a63ab74ceb1cbc01c7652778/espnet/lm/pytorch_backend/lm.py#L265-L270\r\n\r\nThe final loss calculation is conducted on only main gpu.\nHmm, if so, this should be a pytorch bug. Maybe we can create the smallest example to reproduce this memory leak in multi GPUs to submit an issue to pytorch."},"resolved_issues":{"kind":"list like","value":[{"body":"There was an out of memory exception thrown when I use lm.yaml and lm_large.yaml in librispeech egs with multi gpu=4.\r\n```\r\nException in main training loop: CUDA out of memory. Tried to allocate 19.62 MiB (GPU 2; 22.38 GiB total capacity; 21.01 GiB already allocated; 10.06 MiB free; 634.29 MiB cached) \r\nTraceback (most recent call last):\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/trainer.py\", line 316, in run \r\n update()\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/updaters/standard_updater.py\", line 175, in update \r\n self.update_core()\r\n File \"/mnt/cfs1/asr/users/fanlu/espnet/espnet/lm/pytorch_backend/lm.py\", line 277, in update_core\r\n loss.backward() # Backprop\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/tensor.py\", line 102, in backward \r\n torch.autograd.backward(self, gradient, retain_graph, create_graph)\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/autograd/__init__.py\", line 90, in backward \r\n allow_unreachable=True) # allow_unreachable flag\r\nWill finalize trainer extensions and updater before reraising the exception.\r\nTraceback (most recent call last):\r\n File \"/mnt/cfs1/asr/users/fanlu/espnet/espnet/bin/lm_train.py\", line 156, in <module>\r\n main(sys.argv[1:])\r\n File \"/mnt/cfs1/asr/users/fanlu/espnet/espnet/bin/lm_train.py\", line 150, in main\r\n train(args)\r\n File \"/mnt/cfs1/asr/users/fanlu/espnet/espnet/lm/pytorch_backend/lm.py\", line 416, in train\r\n trainer.run()\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/trainer.py\", line 349, in run \r\n six.reraise(*exc_info)\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/six.py\", line 693, in reraise\r\n raise value\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/trainer.py\", line 316, in run \r\n update()\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/updaters/standard_updater.py\", line 175, in update \r\n self.update_core()\r\n File \"/mnt/cfs1/asr/users/fanlu/espnet/espnet/lm/pytorch_backend/lm.py\", line 277, in update_core\r\n loss.backward() # Backprop\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/tensor.py\", line 102, in backward \r\n torch.autograd.backward(self, gradient, retain_graph, create_graph)\r\n File \"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/autograd/__init__.py\", line 90, in backward \r\n allow_unreachable=True) # allow_unreachable flag\r\nRuntimeError: CUDA out of memory. Tried to allocate 19.62 MiB (GPU 2; 22.38 GiB total capacity; 21.01 GiB already allocated; 10.06 MiB free; 634.29 MiB cached) \r\n# Accounting: time=746 threads=1\r\n# Finished at Sun Aug 11 14:58:25 CST 2019 with status 1\r\n```","number":1075,"title":"multi gpu lm training throws CUDA out of memory exception"}],"string":"[\n {\n \"body\": \"There was an out of memory exception thrown when I use lm.yaml and lm_large.yaml in librispeech egs with multi gpu=4.\\r\\n```\\r\\nException in main training loop: CUDA out of memory. Tried to allocate 19.62 MiB (GPU 2; 22.38 GiB total capacity; 21.01 GiB already allocated; 10.06 MiB free; 634.29 MiB cached) \\r\\nTraceback (most recent call last):\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/trainer.py\\\", line 316, in run \\r\\n update()\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/updaters/standard_updater.py\\\", line 175, in update \\r\\n self.update_core()\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/espnet/espnet/lm/pytorch_backend/lm.py\\\", line 277, in update_core\\r\\n loss.backward() # Backprop\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/tensor.py\\\", line 102, in backward \\r\\n torch.autograd.backward(self, gradient, retain_graph, create_graph)\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/autograd/__init__.py\\\", line 90, in backward \\r\\n allow_unreachable=True) # allow_unreachable flag\\r\\nWill finalize trainer extensions and updater before reraising the exception.\\r\\nTraceback (most recent call last):\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/espnet/espnet/bin/lm_train.py\\\", line 156, in <module>\\r\\n main(sys.argv[1:])\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/espnet/espnet/bin/lm_train.py\\\", line 150, in main\\r\\n train(args)\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/espnet/espnet/lm/pytorch_backend/lm.py\\\", line 416, in train\\r\\n trainer.run()\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/trainer.py\\\", line 349, in run \\r\\n six.reraise(*exc_info)\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/six.py\\\", line 693, in reraise\\r\\n raise value\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/trainer.py\\\", line 316, in run \\r\\n update()\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/chainer/training/updaters/standard_updater.py\\\", line 175, in update \\r\\n self.update_core()\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/espnet/espnet/lm/pytorch_backend/lm.py\\\", line 277, in update_core\\r\\n loss.backward() # Backprop\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/tensor.py\\\", line 102, in backward \\r\\n torch.autograd.backward(self, gradient, retain_graph, create_graph)\\r\\n File \\\"/mnt/cfs1/asr/users/fanlu/miniconda3/lib/python3.7/site-packages/torch/autograd/__init__.py\\\", line 90, in backward \\r\\n allow_unreachable=True) # allow_unreachable flag\\r\\nRuntimeError: CUDA out of memory. Tried to allocate 19.62 MiB (GPU 2; 22.38 GiB total capacity; 21.01 GiB already allocated; 10.06 MiB free; 634.29 MiB cached) \\r\\n# Accounting: time=746 threads=1\\r\\n# Finished at Sun Aug 11 14:58:25 CST 2019 with status 1\\r\\n```\",\n \"number\": 1075,\n \"title\": \"multi gpu lm training throws CUDA out of memory exception\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"e663da30a7f4f45c0cea5c6ee5c2c7d7a7ed647a"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"44b7341c0318e0f682376194e842439f9d2799cf\",\n \"head_commit_message\": \"minor update\",\n \"patch_to_review\": \"diff --git a/egs/tedlium3/asr1/run.sh b/egs/tedlium3/asr1/run.sh\\nindex 9a94eb024ed..26174754b4e 100755\\n--- a/egs/tedlium3/asr1/run.sh\\n+++ b/egs/tedlium3/asr1/run.sh\\n@@ -180,7 +180,8 @@ if [ ${stage} -le 3 ] && [ ${stop_stage} -ge 3 ]; then\\n --train-label ${lmdatadir}/train.txt \\\\\\n --valid-label ${lmdatadir}/valid.txt \\\\\\n --resume ${lm_resume} \\\\\\n- --dict ${dict}\\n+ --dict ${dict} \\\\\\n+ --dump-dataset ${lmdatadir}\\n fi\\n \\n if [ -z ${tag} ]; then\\ndiff --git a/espnet/bin/lm_train.py b/espnet/bin/lm_train.py\\nindex bb820ef1e0e..26f880ae8bc 100755\\n--- a/espnet/bin/lm_train.py\\n+++ b/espnet/bin/lm_train.py\\n@@ -85,6 +85,8 @@ def get_parser():\\n help='dropout probability')\\n parser.add_argument('--maxlen', type=int, default=40,\\n help='Batch size is reduced if the input sequence > ML')\\n+ parser.add_argument('--dump-dataset', type=str, default=None,\\n+ help='dump preprocessed dataset as hdf5 if specified')\\n return parser\\n \\n \\ndiff --git a/espnet/lm/lm_utils.py b/espnet/lm/lm_utils.py\\nindex 1c22ebd6f14..7bd83d20992 100644\\n--- a/espnet/lm/lm_utils.py\\n+++ b/espnet/lm/lm_utils.py\\n@@ -6,19 +6,51 @@\\n # This code is ported from the following implementation written in Torch.\\n # https://github.com/chainer/chainer/blob/master/examples/ptb/train_ptb_custom_loop.py\\n \\n-from __future__ import division\\n-from __future__ import print_function\\n-\\n import chainer\\n+import h5py\\n import logging\\n import numpy as np\\n import os\\n import random\\n import six\\n+from tqdm import tqdm\\n \\n from chainer.training import extension\\n \\n \\n+def load_dataset(path, label_dict, outdir=None):\\n+ \\\"\\\"\\\"Load and save HDF5 dataset for LM\\n+\\n+ Args:\\n+ path (str): The path of an input text dataset file\\n+ label_dict (dict[str, int]): dictionary that maps token label string to its ID number\\n+ outdir (str): The path of an output dir\\n+\\n+ Returns:\\n+ list[np.ndarray]: np.int32 IDs of tokens converted by `read_tokens`\\n+ \\\"\\\"\\\"\\n+ if outdir is not None:\\n+ os.makedirs(outdir, exist_ok=True)\\n+ filename = outdir + \\\"/\\\" + os.path.basename(path) + \\\".h5\\\"\\n+ if os.path.exists(filename):\\n+ logging.info(f\\\"loading binary dataset: {filename}\\\")\\n+ f = h5py.File(filename, \\\"r\\\")\\n+ return f[\\\"data\\\"][:], f[\\\"n_tokens\\\"][()], f[\\\"n_oovs\\\"][()]\\n+ else:\\n+ logging.info(\\\"skip dump/load HDF5 because the output dir is not specified\\\")\\n+ logging.info(f\\\"reading text dataset: {path}\\\")\\n+ ret = read_tokens(path, label_dict)\\n+ n_tokens, n_oovs = count_tokens(ret, label_dict['<unk>'])\\n+ if outdir is not None:\\n+ logging.info(f\\\"saving binary dataset: {filename}\\\")\\n+ with h5py.File(filename, \\\"w\\\") as f:\\n+ # http://docs.h5py.org/en/stable/special.html#arbitrary-vlen-data\\n+ f.create_dataset(\\\"data\\\", data=ret, dtype=h5py.special_dtype(vlen=np.int32))\\n+ f[\\\"n_tokens\\\"] = n_tokens\\n+ f[\\\"n_oovs\\\"] = n_oovs\\n+ return ret, n_tokens, n_oovs\\n+\\n+\\n def read_tokens(filename, label_dict):\\n \\\"\\\"\\\"Read tokens as a sequence of sentences\\n \\n@@ -29,10 +61,9 @@ def read_tokens(filename, label_dict):\\n \\\"\\\"\\\"\\n \\n data = []\\n- for ln in open(filename, 'rb').readlines():\\n- data.append(np.array([label_dict[label]\\n- if label in label_dict else label_dict['<unk>']\\n- for label in ln.decode('utf-8').split()], dtype=np.int32))\\n+ unk = label_dict['<unk>']\\n+ for ln in tqdm(open(filename, 'r', encoding='utf-8')):\\n+ data.append(np.array([label_dict.get(label, unk) for label in ln.split()], dtype=np.int32))\\n return data\\n \\n \\ndiff --git a/espnet/lm/pytorch_backend/lm.py b/espnet/lm/pytorch_backend/lm.py\\nindex 2a9bc87f080..aaac7bafb7d 100644\\n--- a/espnet/lm/pytorch_backend/lm.py\\n+++ b/espnet/lm/pytorch_backend/lm.py\\n@@ -27,6 +27,7 @@\\n \\n from espnet.lm.lm_utils import compute_perplexity\\n from espnet.lm.lm_utils import count_tokens\\n+from espnet.lm.lm_utils import load_dataset\\n from espnet.lm.lm_utils import MakeSymlinkToBestModel\\n from espnet.lm.lm_utils import ParallelSentenceIterator\\n from espnet.lm.lm_utils import read_tokens\\n@@ -230,6 +231,52 @@ def concat_examples(batch, device=None, padding=None):\\n return x, t\\n \\n \\n+class ReduceFramewiseLoss(torch.nn.Module):\\n+ \\\"\\\"\\\"Reduce framewise loss values in language modeling\\n+\\n+ Args:\\n+ model (ClassifierWithState): module for computing framewise loss\\n+\\n+ Note:\\n+ PyTorch seems to have memory leak when one GPU compute this after data parallel.\\n+ If parallel GPUs compute this, it seems to be fine.\\n+ See also https://github.com/espnet/espnet/issues/1075\\n+ \\\"\\\"\\\"\\n+\\n+ def __init__(self, model):\\n+ super().__init__()\\n+ self.model = model\\n+ self.reporter = model.reporter\\n+\\n+ def state_dict(self):\\n+ return self.model.state_dict()\\n+\\n+ def load_state_dict(self, d):\\n+ self.model.load_state_dict(d)\\n+\\n+ def forward(self, x, t):\\n+ \\\"\\\"\\\"Reduce framewise loss values\\n+\\n+ Args:\\n+ x (torch.Tensor): input ids. (batch, len)\\n+ t (torch.Tensor): target ids. (batch, len)\\n+\\n+ Returns:\\n+ torch.Tensor: Reduced loss values and valid element counts\\n+ \\\"\\\"\\\"\\n+ loss = 0\\n+ count = torch.tensor(0).long()\\n+ state = None\\n+ batch_size, sequence_length = x.shape\\n+ for i in six.moves.range(sequence_length):\\n+ # Compute the loss at this time step and accumulate it\\n+ state, loss_batch = self.model(state, x[:, i], t[:, i])\\n+ non_zeros = torch.sum(x[:, i] != 0, dtype=torch.float)\\n+ loss += loss_batch * non_zeros\\n+ count += int(non_zeros)\\n+ return loss, count.to(loss.device)\\n+\\n+\\n class BPTTUpdater(training.StandardUpdater):\\n \\\"\\\"\\\"An updater for a pytorch LM\\n \\n@@ -254,24 +301,15 @@ def update_core(self):\\n optimizer = self.get_optimizer('main')\\n # Progress the dataset iterator for sentences at each iteration.\\n batch = train_iter.__next__()\\n- x, t = concat_examples(batch, device=self.device, padding=(0, -100))\\n # Concatenate the token IDs to matrices and send them to the device\\n # self.converter does this job\\n # (it is chainer.dataset.concat_examples by default)\\n- loss = 0\\n- count = 0\\n- state = None\\n- batch_size, sequence_length = x.shape\\n- for i in six.moves.range(sequence_length):\\n- # Compute the loss at this time step and accumulate it\\n- state, loss_batch = self.model(state, x[:, i], t[:, i])\\n- non_zeros = torch.sum(x[:, i] != 0, dtype=torch.float)\\n- loss += loss_batch * non_zeros\\n- count += int(non_zeros)\\n-\\n- loss = loss.mean()\\n- reporter.report({'loss': float(loss.detach())}, optimizer.target)\\n- reporter.report({'count': count}, optimizer.target)\\n+ x, t = concat_examples(batch, device=self.device, padding=(0, -100))\\n+ loss, count = self.model(x, t)\\n+ loss = loss.sum()\\n+ count = count.sum()\\n+ reporter.report({'loss': float(loss.detach() / count)}, optimizer.target)\\n+ reporter.report({'count': int(count)}, optimizer.target)\\n # update\\n self.model.zero_grad() # Clear the parameter gradients\\n loss.backward() # Backprop\\n@@ -303,17 +341,12 @@ def evaluate(self):\\n with torch.no_grad():\\n for batch in copy.copy(val_iter):\\n x, t = concat_examples(batch, device=self.device, padding=(0, -100))\\n- state = None\\n- for i in six.moves.range(len(x[0])):\\n- state, loss_batch = self.model(state, x[:, i], t[:, i])\\n- non_zeros = torch.sum(x[:, i] != 0, dtype=torch.float)\\n- loss += loss_batch * non_zeros\\n- count += int(non_zeros)\\n+ loss, count = self.model(x, t)\\n self.model.train()\\n # report validation loss\\n observation = {}\\n with reporter.report_scope(observation):\\n- reporter.report({'loss': float(loss.mean() / count)}, self.model.reporter)\\n+ reporter.report({'loss': float(loss.sum() / count.sum())}, self.model.reporter)\\n return observation\\n \\n \\n@@ -335,11 +368,8 @@ def train(args):\\n unk = args.char_list_dict['<unk>']\\n eos = args.char_list_dict['<eos>']\\n # read tokens as a sequence of sentences\\n- train = read_tokens(args.train_label, args.char_list_dict)\\n- val = read_tokens(args.valid_label, args.char_list_dict)\\n- # count tokens\\n- n_train_tokens, n_train_oovs = count_tokens(train, unk)\\n- n_val_tokens, n_val_oovs = count_tokens(val, unk)\\n+ val, n_val_tokens, n_val_oovs = load_dataset(args.valid_label, args.char_list_dict, args.dump_dataset)\\n+ train, n_train_tokens, n_train_oovs = load_dataset(args.train_label, args.char_list_dict, args.dump_dataset)\\n logging.info('#vocab = ' + str(args.n_vocab))\\n logging.info('#sentences in the training data = ' + str(len(train)))\\n logging.info('#tokens in the training data = ' + str(n_train_tokens))\\n@@ -361,10 +391,12 @@ def train(args):\\n logging.info('#total iterations = ' + str(args.epoch * len(train_iter.batch_indices)))\\n # Prepare an RNNLM model\\n rnn = RNNLM(args.n_vocab, args.layer, args.unit, args.type, args.dropout_rate)\\n- model = ClassifierWithState(rnn)\\n+ classifier = ClassifierWithState(rnn)\\n+ reporter = classifier.reporter\\n+ model = ReduceFramewiseLoss(classifier)\\n if args.ngpu > 0:\\n model = torch.nn.DataParallel(model, device_ids=list(range(args.ngpu))).cuda()\\n- setattr(model, \\\"reporter\\\", model.module.reporter)\\n+ setattr(model, \\\"reporter\\\", reporter)\\n gpu_id = 0\\n else:\\n gpu_id = -1\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -85,6 +85,8 @@ def get_parser():\n help='dropout probability')\n parser.add_argument('--maxlen', type=int, default=40,\n help='Batch size is reduced if the input sequence > ML')\n+ parser.add_argument('--dump-dataset', type=str, default=None,","line":null,"original_line":88,"original_start_line":null,"path":"espnet/bin/lm_train.py","start_line":null,"text":"@user1:\nI think it is better to rename or change to bool type to make it clear.\n\n@author:\nMaybe `--dump-hdf5-path` is better?\n\n@user1:\nSounds good :)"}],"string":"[\n {\n \"diff_hunk\": \"@@ -85,6 +85,8 @@ def get_parser():\\n help='dropout probability')\\n parser.add_argument('--maxlen', type=int, default=40,\\n help='Batch size is reduced if the input sequence > ML')\\n+ parser.add_argument('--dump-dataset', type=str, default=None,\",\n \"line\": null,\n \"original_line\": 88,\n \"original_start_line\": null,\n \"path\": \"espnet/bin/lm_train.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nI think it is better to rename or change to bool type to make it clear.\\n\\n@author:\\nMaybe `--dump-hdf5-path` is better?\\n\\n@user1:\\nSounds good :)\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"e5b4b239efca811d461c34f92a9818655a4b2acc"},"merged_patch":{"kind":"string","value":"diff --git a/egs/mini_an4/asr1/run.sh b/egs/mini_an4/asr1/run.sh\nindex de162a643f2..b322cc64787 100755\n--- a/egs/mini_an4/asr1/run.sh\n+++ b/egs/mini_an4/asr1/run.sh\n@@ -199,7 +199,8 @@ if [ ${stage} -le 3 ] && [ ${stop_stage} -ge 3 ]; then\n --valid-label ${lmdatadir}/valid.txt \\\n --test-label ${lmdatadir}/test.txt \\\n --resume ${lm_resume} \\\n- --dict ${lmdict}\n+ --dict ${lmdict} \\\n+ --dump-hdf5-path ${lmdatadir}\n fi\n \n if [ -z ${tag} ]; then\ndiff --git a/egs/tedlium3/asr1/run.sh b/egs/tedlium3/asr1/run.sh\nindex 9a94eb024ed..ed76d5bc8b2 100755\n--- a/egs/tedlium3/asr1/run.sh\n+++ b/egs/tedlium3/asr1/run.sh\n@@ -180,7 +180,8 @@ if [ ${stage} -le 3 ] && [ ${stop_stage} -ge 3 ]; then\n --train-label ${lmdatadir}/train.txt \\\n --valid-label ${lmdatadir}/valid.txt \\\n --resume ${lm_resume} \\\n- --dict ${dict}\n+ --dict ${dict} \\\n+ --dump-hdf5-path ${lmdatadir}\n fi\n \n if [ -z ${tag} ]; then\ndiff --git a/espnet/bin/lm_train.py b/espnet/bin/lm_train.py\nindex bb820ef1e0e..90cce80c700 100755\n--- a/espnet/bin/lm_train.py\n+++ b/espnet/bin/lm_train.py\n@@ -85,6 +85,8 @@ def get_parser():\n help='dropout probability')\n parser.add_argument('--maxlen', type=int, default=40,\n help='Batch size is reduced if the input sequence > ML')\n+ parser.add_argument('--dump-hdf5-path', type=str, default=None,\n+ help='Path to dump a preprocessed dataset as hdf5')\n return parser\n \n \ndiff --git a/espnet/lm/lm_utils.py b/espnet/lm/lm_utils.py\nindex 1c22ebd6f14..472d2227dfe 100644\n--- a/espnet/lm/lm_utils.py\n+++ b/espnet/lm/lm_utils.py\n@@ -6,19 +6,55 @@\n # This code is ported from the following implementation written in Torch.\n # https://github.com/chainer/chainer/blob/master/examples/ptb/train_ptb_custom_loop.py\n \n-from __future__ import division\n-from __future__ import print_function\n-\n import chainer\n+import h5py\n import logging\n import numpy as np\n import os\n import random\n import six\n+from tqdm import tqdm\n \n from chainer.training import extension\n \n \n+def load_dataset(path, label_dict, outdir=None):\n+ \"\"\"Load and save HDF5 that contains a dataset and stats for LM\n+\n+ Args:\n+ path (str): The path of an input text dataset file\n+ label_dict (dict[str, int]): dictionary that maps token label string to its ID number\n+ outdir (str): The path of an output dir\n+\n+ Returns:\n+ tuple[list[np.ndarray], int, int]: Tuple of\n+ token IDs in np.int32 converted by `read_tokens`\n+ the number of tokens by `count_tokens`,\n+ and the number of OOVs by `count_tokens`\n+ \"\"\"\n+ if outdir is not None:\n+ os.makedirs(outdir, exist_ok=True)\n+ filename = outdir + \"/\" + os.path.basename(path) + \".h5\"\n+ if os.path.exists(filename):\n+ logging.info(f\"loading binary dataset: {filename}\")\n+ f = h5py.File(filename, \"r\")\n+ return f[\"data\"][:], f[\"n_tokens\"][()], f[\"n_oovs\"][()]\n+ else:\n+ logging.info(\"skip dump/load HDF5 because the output dir is not specified\")\n+ logging.info(f\"reading text dataset: {path}\")\n+ ret = read_tokens(path, label_dict)\n+ n_tokens, n_oovs = count_tokens(ret, label_dict['<unk>'])\n+ if outdir is not None:\n+ logging.info(f\"saving binary dataset: {filename}\")\n+ with h5py.File(filename, \"w\") as f:\n+ # http://docs.h5py.org/en/stable/special.html#arbitrary-vlen-data\n+ data = f.create_dataset(\"data\", (len(ret),), dtype=h5py.special_dtype(vlen=np.int32))\n+ data[:] = ret\n+ f[\"n_tokens\"] = n_tokens\n+ f[\"n_oovs\"] = n_oovs\n+ return ret, n_tokens, n_oovs\n+\n+\n def read_tokens(filename, label_dict):\n \"\"\"Read tokens as a sequence of sentences\n \n@@ -29,10 +65,9 @@ def read_tokens(filename, label_dict):\n \"\"\"\n \n data = []\n- for ln in open(filename, 'rb').readlines():\n- data.append(np.array([label_dict[label]\n- if label in label_dict else label_dict['<unk>']\n- for label in ln.decode('utf-8').split()], dtype=np.int32))\n+ unk = label_dict['<unk>']\n+ for ln in tqdm(open(filename, 'r', encoding='utf-8')):\n+ data.append(np.array([label_dict.get(label, unk) for label in ln.split()], dtype=np.int32))\n return data\n \n \ndiff --git a/espnet/lm/pytorch_backend/lm.py b/espnet/lm/pytorch_backend/lm.py\nindex 2a9bc87f080..6cfbc5bdb55 100644\n--- a/espnet/lm/pytorch_backend/lm.py\n+++ b/espnet/lm/pytorch_backend/lm.py\n@@ -27,6 +27,7 @@\n \n from espnet.lm.lm_utils import compute_perplexity\n from espnet.lm.lm_utils import count_tokens\n+from espnet.lm.lm_utils import load_dataset\n from espnet.lm.lm_utils import MakeSymlinkToBestModel\n from espnet.lm.lm_utils import ParallelSentenceIterator\n from espnet.lm.lm_utils import read_tokens\n@@ -230,6 +231,54 @@ def concat_examples(batch, device=None, padding=None):\n return x, t\n \n \n+class ReduceFramewiseLoss(torch.nn.Module):\n+ \"\"\"Reduce framewise loss values in language modeling\n+\n+ Args:\n+ model (ClassifierWithState): The module for computing framewise loss\n+\n+ Note:\n+ PyTorch seems to have memory leak when one GPU compute this after data parallel.\n+ If parallel GPUs compute this, it seems to be fine.\n+ See also https://github.com/espnet/espnet/issues/1075\n+ \"\"\"\n+\n+ def __init__(self, model):\n+ super().__init__()\n+ self.model = model\n+ self.reporter = model.reporter\n+\n+ def state_dict(self):\n+ return self.model.state_dict()\n+\n+ def load_state_dict(self, d):\n+ self.model.load_state_dict(d)\n+\n+ def forward(self, x, t):\n+ \"\"\"Reduce framewise loss values\n+\n+ Args:\n+ x (torch.Tensor): Input ids. (batch, len)\n+ t (torch.Tensor): Target ids. (batch, len)\n+\n+ Returns:\n+ tuple[torch.Tensor, torch.Tensor]: Tuple of\n+ the reduced loss value along time (scalar)\n+ and the number of valid loss values (scalar)\n+ \"\"\"\n+ loss = 0\n+ count = torch.tensor(0).long()\n+ state = None\n+ batch_size, sequence_length = x.shape\n+ for i in six.moves.range(sequence_length):\n+ # Compute the loss at this time step and accumulate it\n+ state, loss_batch = self.model(state, x[:, i], t[:, i])\n+ non_zeros = torch.sum(x[:, i] != 0, dtype=torch.float)\n+ loss += loss_batch * non_zeros\n+ count += int(non_zeros)\n+ return loss, count.to(loss.device)\n+\n+\n class BPTTUpdater(training.StandardUpdater):\n \"\"\"An updater for a pytorch LM\n \n@@ -254,24 +303,15 @@ def update_core(self):\n optimizer = self.get_optimizer('main')\n # Progress the dataset iterator for sentences at each iteration.\n batch = train_iter.__next__()\n- x, t = concat_examples(batch, device=self.device, padding=(0, -100))\n # Concatenate the token IDs to matrices and send them to the device\n # self.converter does this job\n # (it is chainer.dataset.concat_examples by default)\n- loss = 0\n- count = 0\n- state = None\n- batch_size, sequence_length = x.shape\n- for i in six.moves.range(sequence_length):\n- # Compute the loss at this time step and accumulate it\n- state, loss_batch = self.model(state, x[:, i], t[:, i])\n- non_zeros = torch.sum(x[:, i] != 0, dtype=torch.float)\n- loss += loss_batch * non_zeros\n- count += int(non_zeros)\n-\n- loss = loss.mean()\n- reporter.report({'loss': float(loss.detach())}, optimizer.target)\n- reporter.report({'count': count}, optimizer.target)\n+ x, t = concat_examples(batch, device=self.device, padding=(0, -100))\n+ loss, count = self.model(x, t)\n+ loss = loss.sum()\n+ count = count.sum()\n+ reporter.report({'loss': float(loss.detach() / count)}, optimizer.target)\n+ reporter.report({'count': int(count)}, optimizer.target)\n # update\n self.model.zero_grad() # Clear the parameter gradients\n loss.backward() # Backprop\n@@ -303,17 +343,12 @@ def evaluate(self):\n with torch.no_grad():\n for batch in copy.copy(val_iter):\n x, t = concat_examples(batch, device=self.device, padding=(0, -100))\n- state = None\n- for i in six.moves.range(len(x[0])):\n- state, loss_batch = self.model(state, x[:, i], t[:, i])\n- non_zeros = torch.sum(x[:, i] != 0, dtype=torch.float)\n- loss += loss_batch * non_zeros\n- count += int(non_zeros)\n+ loss, count = self.model(x, t)\n self.model.train()\n # report validation loss\n observation = {}\n with reporter.report_scope(observation):\n- reporter.report({'loss': float(loss.mean() / count)}, self.model.reporter)\n+ reporter.report({'loss': float(loss.sum() / count.sum())}, self.model.reporter)\n return observation\n \n \n@@ -335,11 +370,8 @@ def train(args):\n unk = args.char_list_dict['<unk>']\n eos = args.char_list_dict['<eos>']\n # read tokens as a sequence of sentences\n- train = read_tokens(args.train_label, args.char_list_dict)\n- val = read_tokens(args.valid_label, args.char_list_dict)\n- # count tokens\n- n_train_tokens, n_train_oovs = count_tokens(train, unk)\n- n_val_tokens, n_val_oovs = count_tokens(val, unk)\n+ val, n_val_tokens, n_val_oovs = load_dataset(args.valid_label, args.char_list_dict, args.dump_hdf5_path)\n+ train, n_train_tokens, n_train_oovs = load_dataset(args.train_label, args.char_list_dict, args.dump_hdf5_path)\n logging.info('#vocab = ' + str(args.n_vocab))\n logging.info('#sentences in the training data = ' + str(len(train)))\n logging.info('#tokens in the training data = ' + str(n_train_tokens))\n@@ -361,10 +393,12 @@ def train(args):\n logging.info('#total iterations = ' + str(args.epoch * len(train_iter.batch_indices)))\n # Prepare an RNNLM model\n rnn = RNNLM(args.n_vocab, args.layer, args.unit, args.type, args.dropout_rate)\n- model = ClassifierWithState(rnn)\n+ classifier = ClassifierWithState(rnn)\n+ reporter = classifier.reporter\n+ model = ReduceFramewiseLoss(classifier)\n if args.ngpu > 0:\n model = torch.nn.DataParallel(model, device_ids=list(range(args.ngpu))).cuda()\n- setattr(model, \"reporter\", model.module.reporter)\n+ setattr(model, \"reporter\", reporter)\n gpu_id = 0\n else:\n gpu_id = -1\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 4,\n \"problem_domain\": \"Performance Optimizations\"\n}"}}},{"rowIdx":7085,"cells":{"instance_id":{"kind":"string","value":"celery__celery-6917@a17594a"},"repo":{"kind":"string","value":"celery/celery"},"language":{"kind":"string","value":"Python"},"pull_number":{"kind":"number","value":6917,"string":"6,917"},"title":{"kind":"string","value":"Terminate job implementation for eventlet concurrency backend"},"body":{"kind":"string","value":" # Terminate job implementation for eventlet concurrency backend\r\n\r\n## Description\r\n\r\nCurrent implementation of **TaskPool** which is based on **eventlet** library does not support terminating jobs. \r\nRevoking with `terminate=True` or terminating task raises `NotImplementedError: <class 'celery.concurrency.eventlet.TaskPool'> does not implement kill_job` exception while task continues to run. \r\n\r\nFixes #5209 #3429 \r\nFixes only eventlet backend for this issue #4019 \r\n"},"created_at":{"kind":"string","value":"2021-08-17T19:39:10Z"},"problem_statement":{"kind":"string","value":"I can‘t stop a task by its task_id\n[2018-12-02 23:53:58,955: INFO/MainProcess] Received task: tasks.add[bb1fe102-c1f9-4361-9370-1129900c0d52]\r\n[2018-12-02 23:54:02,479: INFO/MainProcess] Terminating bb1fe102-c1f9-4361-9370-1129900c0d52 (Signals.SIGTERM)\r\n[2018-12-02 23:54:02,490: ERROR/MainProcess] pidbox command error: NotImplementedError(\"<class 'celery.concurrency.eventlet.TaskPool'> does not implement kill_job\",)\r\nTraceback (most recent call last):\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\kombu\\pidbox.py\", line 101, in dispatch\r\n reply = handle(method, arguments)\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\kombu\\pidbox.py\", line 122, in handle_cast\r\n return self.handle(method, arguments)\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\kombu\\pidbox.py\", line 116, in handle\r\n return self.handlers[method](self.state, **arguments)\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\celery\\worker\\control.py\", line 163, in revoke\r\n request.terminate(state.consumer.pool, signal=signum)\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\celery\\worker\\request.py\", line 249, in terminate\r\n pool.terminate_job(self.worker_pid, signal)\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\celery\\concurrency\\base.py\", line 115, in terminate_job\r\n '{0} does not implement kill_job'.format(type(self)))\r\nNotImplementedError: <class 'celery.concurrency.eventlet.TaskPool'> does not implement kill_job\r\n[2018-12-02 23:55:38,956: INFO/MainProcess] Task tasks.add[bb1fe102-c1f9-4361-9370-1129900c0d52] succeeded in 100.0s: 8\r\n\r\n\r\n\r\n\r\nthis is my main code:\r\n\r\nfrom celery.app.control import Control\r\nfrom tasks import add, app\r\n\r\nmyControl=Control(app)\r\nmyControl.revoke(task_id=\"b11729b0-6272-4527-af9d-dc24c0ad492d\", terminate=True)\r\n\r\n\r\n\r\nfinally，if i want to look at the state of the task only by task_id (just like above), how ."},"hints_text":{"kind":"string","value":"Even though I use different concurrency (prefork, using Redis as broker), I've seen the same problem - sometimes worker can't kill some tasks...\nI used the `signal='SIGKILL'` param and got `Task handler raised error: Terminated(9,)`.\r\n\r\nDoes that mean the task termination succeed?\r\n\r\n```python\r\ncelery_app.control.revoke(celery_task_id, terminate=True, signal='SIGKILL')\r\n```\r\n\r\ncelery log:\r\n\r\n```\r\n[2018-12-05 16:07:32,872: DEBUG/MainProcess] pidbox received method revoke(signal='SIGKILL', task_id='970f8054-b4ee-4f70-9814-4899852342bd', terminate=True) [reply_to:None ticket:None]\r\n[2018-12-05 16:07:32,873: INFO/MainProcess] Terminating 970f8054-b4ee-4f70-9814-4899852342bd (Signals.SIGKILL)\r\n[2018-12-05 16:07:33,068: ERROR/MainProcess] Task handler raised error: Terminated(9,)\r\n```\nThe trackback is showing that the taskpool component you used in celery is implement based on eventlet which has not implemented terminate_job function yet. But the default setting is prefork taskpool which and is the only one who has implemented that function.\r\n\nAnd if you want to look at the state of the task only by task_id, you can use : \r\nstatus = AsyncResult( id).status.The query is blocking which sent a request to your backend line database to get the status."},"resolved_issues":{"kind":"list like","value":[{"body":"[2018-12-02 23:53:58,955: INFO/MainProcess] Received task: tasks.add[bb1fe102-c1f9-4361-9370-1129900c0d52]\r\n[2018-12-02 23:54:02,479: INFO/MainProcess] Terminating bb1fe102-c1f9-4361-9370-1129900c0d52 (Signals.SIGTERM)\r\n[2018-12-02 23:54:02,490: ERROR/MainProcess] pidbox command error: NotImplementedError(\"<class 'celery.concurrency.eventlet.TaskPool'> does not implement kill_job\",)\r\nTraceback (most recent call last):\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\kombu\\pidbox.py\", line 101, in dispatch\r\n reply = handle(method, arguments)\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\kombu\\pidbox.py\", line 122, in handle_cast\r\n return self.handle(method, arguments)\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\kombu\\pidbox.py\", line 116, in handle\r\n return self.handlers[method](self.state, **arguments)\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\celery\\worker\\control.py\", line 163, in revoke\r\n request.terminate(state.consumer.pool, signal=signum)\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\celery\\worker\\request.py\", line 249, in terminate\r\n pool.terminate_job(self.worker_pid, signal)\r\n File \"d:\\envs\\aidcs\\lib\\site-packages\\celery\\concurrency\\base.py\", line 115, in terminate_job\r\n '{0} does not implement kill_job'.format(type(self)))\r\nNotImplementedError: <class 'celery.concurrency.eventlet.TaskPool'> does not implement kill_job\r\n[2018-12-02 23:55:38,956: INFO/MainProcess] Task tasks.add[bb1fe102-c1f9-4361-9370-1129900c0d52] succeeded in 100.0s: 8\r\n\r\n\r\n\r\n\r\nthis is my main code:\r\n\r\nfrom celery.app.control import Control\r\nfrom tasks import add, app\r\n\r\nmyControl=Control(app)\r\nmyControl.revoke(task_id=\"b11729b0-6272-4527-af9d-dc24c0ad492d\", terminate=True)\r\n\r\n\r\n\r\nfinally，if i want to look at the state of the task only by task_id (just like above), how .","number":5209,"title":"I can‘t stop a task by its task_id"}],"string":"[\n {\n \"body\": \"[2018-12-02 23:53:58,955: INFO/MainProcess] Received task: tasks.add[bb1fe102-c1f9-4361-9370-1129900c0d52]\\r\\n[2018-12-02 23:54:02,479: INFO/MainProcess] Terminating bb1fe102-c1f9-4361-9370-1129900c0d52 (Signals.SIGTERM)\\r\\n[2018-12-02 23:54:02,490: ERROR/MainProcess] pidbox command error: NotImplementedError(\\\"<class 'celery.concurrency.eventlet.TaskPool'> does not implement kill_job\\\",)\\r\\nTraceback (most recent call last):\\r\\n File \\\"d:\\\\envs\\\\aidcs\\\\lib\\\\site-packages\\\\kombu\\\\pidbox.py\\\", line 101, in dispatch\\r\\n reply = handle(method, arguments)\\r\\n File \\\"d:\\\\envs\\\\aidcs\\\\lib\\\\site-packages\\\\kombu\\\\pidbox.py\\\", line 122, in handle_cast\\r\\n return self.handle(method, arguments)\\r\\n File \\\"d:\\\\envs\\\\aidcs\\\\lib\\\\site-packages\\\\kombu\\\\pidbox.py\\\", line 116, in handle\\r\\n return self.handlers[method](self.state, **arguments)\\r\\n File \\\"d:\\\\envs\\\\aidcs\\\\lib\\\\site-packages\\\\celery\\\\worker\\\\control.py\\\", line 163, in revoke\\r\\n request.terminate(state.consumer.pool, signal=signum)\\r\\n File \\\"d:\\\\envs\\\\aidcs\\\\lib\\\\site-packages\\\\celery\\\\worker\\\\request.py\\\", line 249, in terminate\\r\\n pool.terminate_job(self.worker_pid, signal)\\r\\n File \\\"d:\\\\envs\\\\aidcs\\\\lib\\\\site-packages\\\\celery\\\\concurrency\\\\base.py\\\", line 115, in terminate_job\\r\\n '{0} does not implement kill_job'.format(type(self)))\\r\\nNotImplementedError: <class 'celery.concurrency.eventlet.TaskPool'> does not implement kill_job\\r\\n[2018-12-02 23:55:38,956: INFO/MainProcess] Task tasks.add[bb1fe102-c1f9-4361-9370-1129900c0d52] succeeded in 100.0s: 8\\r\\n\\r\\n\\r\\n\\r\\n\\r\\nthis is my main code:\\r\\n\\r\\nfrom celery.app.control import Control\\r\\nfrom tasks import add, app\\r\\n\\r\\nmyControl=Control(app)\\r\\nmyControl.revoke(task_id=\\\"b11729b0-6272-4527-af9d-dc24c0ad492d\\\", terminate=True)\\r\\n\\r\\n\\r\\n\\r\\nfinally，if i want to look at the state of the task only by task_id (just like above), how .\",\n \"number\": 5209,\n \"title\": \"I can‘t stop a task by its task_id\"\n }\n]","isConversational":false},"base_commit":{"kind":"string","value":"ad994719bafe6747af6cf8251efb0925284a9260"},"commit_to_review":{"kind":"string","value":"{\n \"head_commit\": \"a17594a183f874a5fdfc9449ff544f7ce795540a\",\n \"head_commit_message\": \"[pre-commit.ci] auto fixes from pre-commit.com hooks\\n\\nfor more information, see https://pre-commit.ci\",\n \"patch_to_review\": \"diff --git a/celery/concurrency/eventlet.py b/celery/concurrency/eventlet.py\\nindex c6bb3415f69..90c39e94e2b 100644\\n--- a/celery/concurrency/eventlet.py\\n+++ b/celery/concurrency/eventlet.py\\n@@ -2,6 +2,7 @@\\n import sys\\n from time import monotonic\\n \\n+from greenlet import GreenletExit\\n from kombu.asynchronous import timer as _timer\\n \\n from celery import signals\\n@@ -93,6 +94,7 @@ class TaskPool(base.BasePool):\\n is_green = True\\n task_join_will_block = False\\n _pool = None\\n+ _pool_map = None\\n _quick_put = None\\n \\n def __init__(self, *args, **kwargs):\\n@@ -107,8 +109,9 @@ def __init__(self, *args, **kwargs):\\n \\n def on_start(self):\\n self._pool = self.Pool(self.limit)\\n+ self._pool_map = dict()\\n signals.eventlet_pool_started.send(sender=self)\\n- self._quick_put = self._pool.spawn_n\\n+ self._quick_put = self._pool.spawn\\n self._quick_apply_sig = signals.eventlet_pool_apply.send\\n \\n def on_stop(self):\\n@@ -119,12 +122,17 @@ def on_stop(self):\\n \\n def on_apply(self, target, args=None, kwargs=None, callback=None,\\n accept_callback=None, **_):\\n- self._quick_apply_sig(\\n- sender=self, target=target, args=args, kwargs=kwargs,\\n+ target = TaskPool._make_killable_target(target)\\n+ self._quick_apply_sig(sender=self, target=target, args=args, kwargs=kwargs,)\\n+ gt = self._quick_put(\\n+ apply_target,\\n+ target, args,\\n+ kwargs,\\n+ callback,\\n+ accept_callback,\\n+ self.getpid\\n )\\n- self._quick_put(apply_target, target, args, kwargs,\\n- callback, accept_callback,\\n- self.getpid)\\n+ self._add_to_pool_map(id(gt), gt)\\n \\n def grow(self, n=1):\\n limit = self.limit + n\\n@@ -132,10 +140,16 @@ def grow(self, n=1):\\n self.limit = limit\\n \\n def shrink(self, n=1):\\n- limit = self.limit - n\\n+ limit = self.limit-n\\n self._pool.resize(limit)\\n self.limit = limit\\n \\n+ def terminate_job(self, pid, signal=None):\\n+ if pid in self._pool_map.keys():\\n+ gt = self._pool_map[pid]\\n+ gt.kill()\\n+ gt.wait()\\n+\\n def _get_info(self):\\n info = super()._get_info()\\n info.update({\\n@@ -144,3 +158,26 @@ def _get_info(self):\\n 'running-threads': self._pool.running(),\\n })\\n return info\\n+\\n+ @staticmethod\\n+ def _make_killable_target(target):\\n+ def killable_target(*args, **kwargs):\\n+ try:\\n+ return target(*args, **kwargs)\\n+ except GreenletExit:\\n+ return (False, None, None)\\n+ except Exception:\\n+ raise\\n+ return killable_target\\n+\\n+ def _add_to_pool_map(self, pid, green_thread):\\n+ self._pool_map[pid] = green_thread\\n+ green_thread.link(\\n+ TaskPool._cleanup_after_job_finish,\\n+ self._pool_map,\\n+ pid\\n+ )\\n+\\n+ @staticmethod\\n+ def _cleanup_after_job_finish(gt, pool_map, pid):\\n+ pool_map.pop(pid)\\ndiff --git a/t/unit/concurrency/test_eventlet.py b/t/unit/concurrency/test_eventlet.py\\nindex dcd803e5342..f8ce3ac0c44 100644\\n--- a/t/unit/concurrency/test_eventlet.py\\n+++ b/t/unit/concurrency/test_eventlet.py\\n@@ -2,6 +2,7 @@\\n from unittest.mock import Mock, patch\\n \\n import pytest\\n+from greenlet import GreenletExit\\n \\n import t.skip\\n from celery.concurrency.eventlet import TaskPool, Timer, apply_target\\n@@ -101,6 +102,7 @@ def test_pool(self):\\n x.on_apply(Mock())\\n x._pool = None\\n x.on_stop()\\n+ assert len(x._pool_map.keys()) == 1\\n assert x.getpid()\\n \\n @patch('celery.concurrency.eventlet.base')\\n@@ -130,3 +132,37 @@ def test_get_info(self):\\n 'free-threads': x._pool.free(),\\n 'running-threads': x._pool.running(),\\n }\\n+\\n+ def test_terminate_job(self):\\n+ func = Mock()\\n+ pool = TaskPool(10)\\n+ pool.on_start()\\n+ pool.on_apply(func)\\n+\\n+ assert len(pool._pool_map.keys()) == 1\\n+ pid = list(pool._pool_map.keys())[0]\\n+ task = pool._pool_map[pid]\\n+\\n+ pool.terminate_job(pid)\\n+ task.link.assert_called_once()\\n+ task.kill.assert_called_once()\\n+\\n+ def test_make_killable_target(self):\\n+ def valid_target():\\n+ return \\\"some result...\\\"\\n+\\n+ def terminating_target():\\n+ raise GreenletExit()\\n+\\n+ def failing_target():\\n+ raise RuntimeError(\\\"some error\\\")\\n+\\n+ assert TaskPool._make_killable_target(valid_target)() == \\\"some result...\\\"\\n+ assert TaskPool._make_killable_target(terminating_target)() == (False, None, None)\\n+ with pytest.raises(RuntimeError):\\n+ TaskPool._make_killable_target(failing_target)()\\n+\\n+ def test_cleanup_after_job_finish(self):\\n+ testMap = {'1': None}\\n+ TaskPool._cleanup_after_job_finish(None, testMap, '1')\\n+ assert len(testMap) == 0\\n\"\n}"},"reference_review_comments":{"kind":"list like","value":[{"diff_hunk":"@@ -107,8 +109,9 @@ def __init__(self, *args, **kwargs):\n \n def on_start(self):\n self._pool = self.Pool(self.limit)\n+ self._pool_map = dict()","line":null,"original_line":112,"original_start_line":null,"path":"celery/concurrency/eventlet.py","start_line":null,"text":"@user1:\nplease try to use {} for dicts"}],"string":"[\n {\n \"diff_hunk\": \"@@ -107,8 +109,9 @@ def __init__(self, *args, **kwargs):\\n \\n def on_start(self):\\n self._pool = self.Pool(self.limit)\\n+ self._pool_map = dict()\",\n \"line\": null,\n \"original_line\": 112,\n \"original_start_line\": null,\n \"path\": \"celery/concurrency/eventlet.py\",\n \"start_line\": null,\n \"text\": \"@user1:\\nplease try to use {} for dicts\"\n }\n]","isConversational":false},"merged_commit":{"kind":"string","value":"88c5a2bae5d98ffa24c56f3e4664e99e02a5f2ea"},"merged_patch":{"kind":"string","value":"diff --git a/celery/concurrency/eventlet.py b/celery/concurrency/eventlet.py\nindex c6bb3415f69..f9c9da7f994 100644\n--- a/celery/concurrency/eventlet.py\n+++ b/celery/concurrency/eventlet.py\n@@ -2,6 +2,7 @@\n import sys\n from time import monotonic\n \n+from greenlet import GreenletExit\n from kombu.asynchronous import timer as _timer\n \n from celery import signals\n@@ -93,6 +94,7 @@ class TaskPool(base.BasePool):\n is_green = True\n task_join_will_block = False\n _pool = None\n+ _pool_map = None\n _quick_put = None\n \n def __init__(self, *args, **kwargs):\n@@ -107,8 +109,9 @@ def __init__(self, *args, **kwargs):\n \n def on_start(self):\n self._pool = self.Pool(self.limit)\n+ self._pool_map = {}\n signals.eventlet_pool_started.send(sender=self)\n- self._quick_put = self._pool.spawn_n\n+ self._quick_put = self._pool.spawn\n self._quick_apply_sig = signals.eventlet_pool_apply.send\n \n def on_stop(self):\n@@ -119,12 +122,17 @@ def on_stop(self):\n \n def on_apply(self, target, args=None, kwargs=None, callback=None,\n accept_callback=None, **_):\n- self._quick_apply_sig(\n- sender=self, target=target, args=args, kwargs=kwargs,\n+ target = TaskPool._make_killable_target(target)\n+ self._quick_apply_sig(sender=self, target=target, args=args, kwargs=kwargs,)\n+ greenlet = self._quick_put(\n+ apply_target,\n+ target, args,\n+ kwargs,\n+ callback,\n+ accept_callback,\n+ self.getpid\n )\n- self._quick_put(apply_target, target, args, kwargs,\n- callback, accept_callback,\n- self.getpid)\n+ self._add_to_pool_map(id(greenlet), greenlet)\n \n def grow(self, n=1):\n limit = self.limit + n\n@@ -136,6 +144,12 @@ def shrink(self, n=1):\n self._pool.resize(limit)\n self.limit = limit\n \n+ def terminate_job(self, pid, signal=None):\n+ if pid in self._pool_map.keys():\n+ greenlet = self._pool_map[pid]\n+ greenlet.kill()\n+ greenlet.wait()\n+\n def _get_info(self):\n info = super()._get_info()\n info.update({\n@@ -144,3 +158,24 @@ def _get_info(self):\n 'running-threads': self._pool.running(),\n })\n return info\n+\n+ @staticmethod\n+ def _make_killable_target(target):\n+ def killable_target(*args, **kwargs):\n+ try:\n+ return target(*args, **kwargs)\n+ except GreenletExit:\n+ return (False, None, None)\n+ return killable_target\n+\n+ def _add_to_pool_map(self, pid, greenlet):\n+ self._pool_map[pid] = greenlet\n+ greenlet.link(\n+ TaskPool._cleanup_after_job_finish,\n+ self._pool_map,\n+ pid\n+ )\n+\n+ @staticmethod\n+ def _cleanup_after_job_finish(greenlet, pool_map, pid):\n+ del pool_map[pid]\ndiff --git a/docs/userguide/workers.rst b/docs/userguide/workers.rst\nindex fa3cf468884..74e29490913 100644\n--- a/docs/userguide/workers.rst\n+++ b/docs/userguide/workers.rst\n@@ -324,7 +324,7 @@ Commands\n \n ``revoke``: Revoking tasks\n --------------------------\n-:pool support: all, terminate only supported by prefork\n+:pool support: all, terminate only supported by prefork and eventlet\n :broker support: *amqp, redis*\n :command: :program:`celery -A proj control revoke <task_id>`\n \ndiff --git a/t/unit/concurrency/test_eventlet.py b/t/unit/concurrency/test_eventlet.py\nindex dcd803e5342..9dcdb479b26 100644\n--- a/t/unit/concurrency/test_eventlet.py\n+++ b/t/unit/concurrency/test_eventlet.py\n@@ -2,6 +2,7 @@\n from unittest.mock import Mock, patch\n \n import pytest\n+from greenlet import GreenletExit\n \n import t.skip\n from celery.concurrency.eventlet import TaskPool, Timer, apply_target\n@@ -101,6 +102,7 @@ def test_pool(self):\n x.on_apply(Mock())\n x._pool = None\n x.on_stop()\n+ assert len(x._pool_map.keys()) == 1\n assert x.getpid()\n \n @patch('celery.concurrency.eventlet.base')\n@@ -130,3 +132,32 @@ def test_get_info(self):\n 'free-threads': x._pool.free(),\n 'running-threads': x._pool.running(),\n }\n+\n+ def test_terminate_job(self):\n+ func = Mock()\n+ pool = TaskPool(10)\n+ pool.on_start()\n+ pool.on_apply(func)\n+\n+ assert len(pool._pool_map.keys()) == 1\n+ pid = list(pool._pool_map.keys())[0]\n+ greenlet = pool._pool_map[pid]\n+\n+ pool.terminate_job(pid)\n+ greenlet.link.assert_called_once()\n+ greenlet.kill.assert_called_once()\n+\n+ def test_make_killable_target(self):\n+ def valid_target():\n+ return \"some result...\"\n+\n+ def terminating_target():\n+ raise GreenletExit()\n+\n+ assert TaskPool._make_killable_target(valid_target)() == \"some result...\"\n+ assert TaskPool._make_killable_target(terminating_target)() == (False, None, None)\n+\n+ def test_cleanup_after_job_finish(self):\n+ testMap = {'1': None}\n+ TaskPool._cleanup_after_job_finish(None, testMap, '1')\n+ assert len(testMap) == 0\n"},"metadata":{"kind":"string","value":"{\n \"difficulty\": \"medium\",\n \"estimated_review_effort\": 4,\n \"problem_domain\": \"Bug Fixes\"\n}"}}}],"truncated":false,"partial":false},"paginationData":{"pageIndex":70,"numItemsPerPage":100,"numTotalItems":7086,"offset":7000,"length":100}},"jwt":"eyJhbGciOiJFZERTQSJ9.eyJyZWFkIjp0cnVlLCJwZXJtaXNzaW9ucyI6eyJyZXBvLmNvbnRlbnQucmVhZCI6dHJ1ZX0sImlhdCI6MTc3NzgxMjY3NCwic3ViIjoiL2RhdGFzZXRzL2luY2x1c2lvbkFJL1NXRS1DQVJFIiwiZXhwIjoxNzc3ODE2Mjc0LCJpc3MiOiJodHRwczovL2h1Z2dpbmdmYWNlLmNvIn0._3ZY_XLrYzXb_nSDYFChQpyMMvgFb_sFFJINNXQnOFsK2gAFW3lBYpa57gLZtSh4j8HgMgySmPxeVZX7UJfpDg","displayUrls":true,"splitSizeSummaries":[{"config":"default","split":"dev","numRows":7086,"numBytesParquet":125079708},{"config":"default","split":"test","numRows":671,"numBytesParquet":12126296}]},"discussionsStats":{"closed":0,"open":1,"total":1},"fullWidth":true,"hasGatedAccess":true,"hasFullAccess":true,"isEmbedded":false,"savedQueries":{"community":[{"views":[{"key":"default/test","displayName":"test","viewName":"test"}],"sql":"-- The SQL console is powered by DuckDB WASM and runs entirely in the browser.\n-- Get started by typing a query or selecting a view from the options below.\nSELECT instance_id , base_commit ,problem_statement,commit_to_review FROM test LIMIT 10;","title":"Review Test Instances","createdAt":"2026-01-14T03:09:29.315Z","slug":"JAW4VpX","private":false,"justification":"Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.","viewNames":["test"]}],"user":[]}}">
instance_id stringlengths 21 53 | repo stringclasses 188
values | language stringclasses 1
value | pull_number int64 20 148k | title stringlengths 6 144 | body stringlengths 0 83.4k | created_at stringdate 2015-09-25 03:17:17 2025-07-10 16:50:35 | problem_statement stringlengths 188 240k | hints_text stringlengths 0 145k | resolved_issues listlengths 1 6 | base_commit stringlengths 40 40 | commit_to_review dict | reference_review_comments listlengths 1 62 | merged_commit stringlengths 40 40 | merged_patch stringlengths 297 9.87M | metadata dict |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
skypilot-org__skypilot-1548@b421401 | skypilot-org/skypilot | Python | 1,548 | Add doc for IAM permissions required by SkyPilot | <!-- Describe the changes in this PR -->
Describe the changes in this PR:
To close https://github.com/skypilot-org/skypilot/issues/1443, we'd like to add some documents for required IAM permissions to run SkyPilot.
<!-- Describe tests ran in a "Tested:" section -->
<!-- Unit tests (tests/test_*.py) are part o... | 2022-12-20T06:33:16Z | [Docs] Cloud IAM access requirements for SkyPilot
When assigning people to our shared cloud account, I was wondering what's the minimal IAM access needed for SkyPilot to work instead of granting a full access owner. This can be relevant for people in industry who may not have full access to their shared corp account.
... | After discussing offline, @infwinston and I found the following role list for the user is sufficient to launch the VM on GCP when the `ray-autoscaler` account is already setup.
```
roles/browser
roles/compute.admin
roles/iam.serviceAccountUser
roles/serviceusage.serviceUsageConsumer
roles/storage.admin
```
To s... | [
{
"body": "When assigning people to our shared cloud account, I was wondering what's the minimal IAM access needed for SkyPilot to work instead of granting a full access owner. This can be relevant for people in industry who may not have full access to their shared corp account.\r\nWe probably want to investiga... | fe1b3ab82074b51c9505d0d863f0c1ab9306e7d3 | {
"head_commit": "b4214017abd55102f7ef63227e974cd61a518371",
"head_commit_message": "role",
"patch_to_review": "diff --git a/docs/source/getting-started/installation.rst b/docs/source/getting-started/installation.rst\nindex ecd92246886..996e4f6c96b 100644\n--- a/docs/source/getting-started/installation.rst\n+++ b... | [
{
"diff_hunk": "@@ -76,6 +76,29 @@ If you have edited the ``file_mounts`` section (e.g., by adding some files) and\n To avoid rerunning the ``setup`` commands, pass the ``--no-setup`` flag to ``sky launch``.\n \n \n+What are the required IAM permissons on GCP for SkyPilot?\n+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~... | 2611e034eae6d503c78c2aa2e6123af57687ec31 | diff --git a/docs/source/reference/faq.rst b/docs/source/reference/faq.rst
index 50698008a76..55345e18b07 100644
--- a/docs/source/reference/faq.rst
+++ b/docs/source/reference/faq.rst
@@ -76,6 +76,29 @@ If you have edited the ``file_mounts`` section (e.g., by adding some files) and
To avoid rerunning the ``setup`` co... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
skypilot-org__skypilot-1559@eb8a284 | skypilot-org/skypilot | Python | 1,559 | Logging UX for `sky cancel`. | <!-- Describe the changes in this PR -->
Fixes #1536. Fixes #1537.
<!-- Describe tests ran in a "Tested:" section -->
<!-- Unit tests (tests/test_*.py) are part of Github CI; the below are additional tests. -->
Tested (run the relevant ones):
- [x] Any manual or new tests for this the PR
```
sky cancel... | 2022-12-27T13:37:58Z | UX: `sky cancel` usage hints should be friendlier
Users tended to type `sky cancel <job id>` when they only started playing with one cluster.
This would show
```
click.exceptions.UsageError: sky cancel requires either a job id (see `sky queue 1 -s`) or the --all flag.
```
We should instead show something like
... | [
{
"body": "Users tended to type `sky cancel <job id>` when they only started playing with one cluster.\r\n\r\nThis would show\r\n```\r\nclick.exceptions.UsageError: sky cancel requires either a job id (see `sky queue 1 -s`) or the --all flag.\r\n```\r\n\r\nWe should instead show something like\r\n```\r\n... Use... | ad6296b71f8c6dde35ed47083e920606fb4e1b00 | {
"head_commit": "eb8a284a6f997449e4d55373e25c9f0e379ba672",
"head_commit_message": "Fix test",
"patch_to_review": "diff --git a/sky/cli.py b/sky/cli.py\nindex a8560990372..8dbb0874f3a 100644\n--- a/sky/cli.py\n+++ b/sky/cli.py\n@@ -1607,10 +1607,33 @@ def logs(\n def cancel(cluster: str, all: bool, jobs: List[in... | [
{
"diff_hunk": "@@ -1607,10 +1607,33 @@ def logs(\n def cancel(cluster: str, all: bool, jobs: List[int]): # pylint: disable=redefined-builtin\n # NOTE(dev): Keep the docstring consistent between the Python API and CLI.\n \"\"\"Cancel job(s).\"\"\"\n+ bold = colorama.Style.BRIGHT\n+ reset = colora... | c1eb568dab0cca0a1614d3897f5d7b29274cb37b | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index 548a290f7ac..86022616ef3 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -2403,10 +2403,14 @@ def check_cluster_name_is_valid(cluster_name: str,
def check_cluster_name_not_reserved(
cluster_name:... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-1473@ea40494 | skypilot-org/skypilot | Python | 1,473 | [SPOT/UX] Add color for status | Fixed issue #1413 by adding color for cluster & job statuses:
<img width="577" alt="image" src="https://user-images.githubusercontent.com/8518898/204893332-44788015-1da7-45ed-a093-120d1dd0ddd6.png">
<img width="414" alt="image" src="https://user-images.githubusercontent.com/8518898/204893408-0c1fdfba-2774-4fef-a8... | 2022-11-30T19:44:26Z | [Spot/UX] Color for different job status
From our user:
> Suggestion: show the spot job statuses (or maybe the entire row) in different colors (e.g. green for running; red for failed; yellow for canceled; blue for starting). Right now when there are many jobs it can be a bit inconvenient to quickly locate the running ... | [
{
"body": "From our user:\r\n> Suggestion: show the spot job statuses (or maybe the entire row) in different colors (e.g. green for running; red for failed; yellow for canceled; blue for starting). Right now when there are many jobs it can be a bit inconvenient to quickly locate the running / failed ones.",
... | e1c4121894bed919e2a59eba7096ec75a44ab65b | {
"head_commit": "ea4049496633e697b6c4b92fcaf13f4abe6a405c",
"head_commit_message": "moved method + made stop lighter",
"patch_to_review": "diff --git a/sky/global_user_state.py b/sky/global_user_state.py\nindex b8fe3369e9c..ac969a4b77d 100644\n--- a/sky/global_user_state.py\n+++ b/sky/global_user_state.py\n@@ -1... | [
{
"diff_hunk": "@@ -114,6 +116,21 @@ def is_terminal(self):\n def __lt__(self, other):\n return list(JobStatus).index(self) < list(JobStatus).index(other)\n \n+ def colored_str(self):\n+ color = JOB_STATUS_TO_COLOR[self]\n+ return f'{color}{self.value}{colorama.Style.RESET_ALL}'\n+\... | fec6798524cbbad335db7f4083d98a0661a25312 | diff --git a/sky/global_user_state.py b/sky/global_user_state.py
index b8fe3369e9c..50dd6044442 100644
--- a/sky/global_user_state.py
+++ b/sky/global_user_state.py
@@ -15,6 +15,8 @@
import typing
from typing import Any, Dict, List, Optional
+import colorama
+
from sky import clouds
from sky.utils import db_utils... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-1453@bd09fec | skypilot-org/skypilot | Python | 1,453 | Make `sky start` on the spot controller aware of autostop. | Fixes #1447.
If controller is to be started:
- disallow: -i, --down; disallow being specified with other clusters
Tested:
CLI
```
# Expectedly fail:
sky start sky-cpunode-zongheng sky-spot-controller-8a3968f2
sky start sky-spot-controller-8a3968f2 -i1
sky start sky-spot-controller-8a3968f2 -i1 --down
s... | 2022-11-27T07:22:34Z | [spot] Interaction between `sky start [--force]` and spot controller's autostop
User reported that:
>Is the spot controller autostopping actually working? When checking sky status, the comment says will be autostopped if idle for 10min but the AUTOSTOP column shows nothing.
---
After digging into potential is... | We should probably do the second option, to support cases like: a controller gets auto-stopped -> user wants to run `sky spot logs X`. Relatedly - this will print:
https://github.com/skypilot-org/skypilot/blob/master/sky/core.py#L709-L712
which asks users to manually run `sky start` with an updated `-i` number of... | [
{
"body": "User reported that:\r\n\r\n>Is the spot controller autostopping actually working? When checking sky status, the comment says will be autostopped if idle for 10min but the AUTOSTOP column shows nothing.\r\n\r\n---\r\n\r\nAfter digging into potential issues, we aren't sure why this happened. The below... | 30476aada4d2d6cef06fc8bcd6a49eef34934d91 | {
"head_commit": "bd09fec74d80b049243c1ac984f91b2cb25624e6",
"head_commit_message": "pytest",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex ce053b1a5a3..85a362f880d 100644\n--- a/sky/backends/backend_utils.py\n+++ b/sky/backends/backend_utils.py\n@@ -1956,7 ... | [
{
"diff_hunk": "@@ -89,6 +89,20 @@ def _start(\n f'Starting cluster {cluster_name!r} with backend {backend.NAME} '\n 'is not supported.')\n \n+ if cluster_name == spot.SPOT_CONTROLLER_NAME:\n+ if down:\n+ raise ValueError('Using autodown (rather than autostop) is not... | c37e738caf7c4414b224008de982ea11dc516df1 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index ce053b1a5a3..85a362f880d 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -1956,7 +1956,7 @@ def check_cluster_name_not_reserved(
return None.
"""
if cluster_name in SKY_RESERVED_CLUSTER_NAME... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-1505@e7e933d | skypilot-org/skypilot | Python | 1,505 | [AWS Catalog] Handle the exceptions when the user does not have access to the region | <!-- Describe the changes in this PR -->
Describe the changes in this PR:
Fixes #1459
Our previous `fetch_availability_zone_mappings` does not handle the case where the user does not have access to some of the regions, causing the problem in #1459, where the @iojw fails to fetch his own mapping.
**The prev... | 2022-12-09T06:53:48Z | No usable subnets matching availability zone
For the `us-west-1` region on AWS, my account only has access to the `us-west-1b` and `us-west-1c` zones, but SkyPilot does not take this into account. This causes the following error when running some of the smoke tests:
```
+ sky status --refresh | grep test-autostop-a... | cc @WoosukKwon @infwinston
thanks @iojw I think this issue could be related to https://github.com/skypilot-org/skypilot/issues/1461.
My AZ looks like this:
```
weichiang@mbp tpu-example % aws ec2 describe-availability-zones --region us-west-1
{
"AvailabilityZones": [
{
"State": "availa... | [
{
"body": "For the `us-west-1` region on AWS, my account only has access to the `us-west-1b` and `us-west-1c` zones, but SkyPilot does not take this into account. This causes the following error when running some of the smoke tests:\r\n\r\n```\r\n+ sky status --refresh | grep test-autostop-a64f6128-dd | grep ST... | d7e777fd26a2bcb720705a3946876d68711c0209 | {
"head_commit": "e7e933d66a5be42805117ad07cafa64b46c4cbb1",
"head_commit_message": "fix except",
"patch_to_review": "diff --git a/sky/clouds/service_catalog/data_fetchers/fetch_aws.py b/sky/clouds/service_catalog/data_fetchers/fetch_aws.py\nindex 1b5ba766815..0e291ade9ca 100644\n--- a/sky/clouds/service_catalog/... | [
{
"diff_hunk": "@@ -69,10 +72,14 @@ def _get_instance_types(region: str) -> pd.DataFrame:\n \n \n @ray.remote\n-def _get_availability_zones(region: str) -> pd.DataFrame:\n- client = aws.client('ec2', region_name=region)\n- zones = []\n- response = client.describe_availability_zones()\n+def _get_availab... | 3de66b62c563feb0c50a01ad415059ff31c0c266 | diff --git a/sky/clouds/service_catalog/aws_catalog.py b/sky/clouds/service_catalog/aws_catalog.py
index 58609ba6588..ae2beb22ae1 100644
--- a/sky/clouds/service_catalog/aws_catalog.py
+++ b/sky/clouds/service_catalog/aws_catalog.py
@@ -48,7 +48,7 @@ def _apply_az_mapping(df: 'pd.DataFrame') -> 'pd.DataFrame':
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-1500@fdf1942 | skypilot-org/skypilot | Python | 1,500 | Add safe guard for provisioning/terminating TPU VM and fix spot launch TPU resource leak | Our user reported some errors when getting TPU IPs. This PR adds some safe guard for `_get_tpu_vm_pod_ips` with better error handling to prevent failures like leaked resources with duplicated cluster IDs.
This PR also fixed https://github.com/skypilot-org/skypilot/issues/1514 which tried to remove an `INIT` TPU VM r... | 2022-12-07T23:32:30Z | [TPU VM] Cannot `sky down` a TPU VM when it does not appear on GCP
After running the `tests/run_smoke_tests.sh` the TPU VM test fails, and the following entry remains in the status table.
```
test-tpu-vm-pod-3446f302-b9 57 mins ago 1x GCP(TPU-VM[Spot], {'tpu-v2-32': 1}, accelerator_args={'runtime_v... | Ah thanks. I think the smoke test failed because it couldn't get any TPU v2-32 at the moment (could you confirm?). But I'm not sure why it was left in status table. Could you paste the entire log?
for `sky down -p` issue, this should be fixed in https://github.com/skypilot-org/skypilot/pull/1500 which adds safeguard... | [
{
"body": "After running the `tests/run_smoke_tests.sh` the TPU VM test fails, and the following entry remains in the status table.\r\n```\r\ntest-tpu-vm-pod-3446f302-b9 57 mins ago 1x GCP(TPU-VM[Spot], {'tpu-v2-32': 1}, accelerator_args={'runtime_vers... INIT - sky launch -y -c t... | d5daf1e79f8ac0079cb4d382f234ac787a194039 | {
"head_commit": "fdf1942bdf91d1bb08524c6a1277a9a53157855c",
"head_commit_message": "rename",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex b87b8373592..46f2934ea79 100644\n--- a/sky/backends/backend_utils.py\n+++ b/sky/backends/backend_utils.py\n@@ -1228,34... | [
{
"diff_hunk": "@@ -2684,15 +2685,25 @@ def teardown_no_lock(self,\n f'gcloud compute tpus tpu-vm list --filter='\n f'\\\\(labels.ray-cluster-name={cluster_name}\\\\) '\n f'--zone={zone} --format=value\\\\(name\\\\)')\n- ... | 9fee56983e0b9e1b9c0ad83c4f659ad2821206d0 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index b87b8373592..5e626ca97d5 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -1228,34 +1228,58 @@ def _get_tpu_vm_pod_ips(ray_config: Dict[str, Any],
query_cmd = (f'gcloud compute tpus tpu-vm list --filte... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-1479@8a80f5b | skypilot-org/skypilot | Python | 1,479 | [Spot] Let the controller aware of the failed setup and fail early | Closes #1397
When the spot job fails during setup, the master branch will retry 3 times (or forever if `--retry-until-up` is specified), and set the spot job to `FAILED_NO_RESOURCES`, which is not desired.
This PR makes the controller aware of the failure of the setup early, and set the spot job to `FAILED`.
... | 2022-12-01T04:47:31Z | [Spot] Error in the setup will keep the spot cluster retrying forever
From the user:
> The specific use case was that there was actually some errors in the setup script I had to fix, and I had to use the sky logs to see what’s going on. Otherwise seems like the spot job just keeps restarting itself in a dead loop wit... | [
{
"body": "From the user:\r\n> The specific use case was that there was actually some errors in the setup script I had to fix, and I had to use the sky logs to see what’s going on. Otherwise seems like the spot job just keeps restarting itself in a dead loop with no feedback to the user.\r\n\r\nTODO:\r\n- [ ] ... | e6167b9568fc1937590681fccb7bcae29829cd36 | {
"head_commit": "8a80f5be49d951d1e6334f2cd1e6595f65e4e413",
"head_commit_message": "Add failed setup status for spot",
"patch_to_review": "diff --git a/sky/skylet/job_lib.py b/sky/skylet/job_lib.py\nindex 62909440621..0d16437260e 100644\n--- a/sky/skylet/job_lib.py\n+++ b/sky/skylet/job_lib.py\n@@ -291,7 +291,7 ... | [
{
"diff_hunk": "@@ -223,7 +226,7 @@ def _launch(self, max_retry=3, raise_on_failure=True) -> Optional[float]:\n continue\n \n # Check the job status until it is not in initialized status\n- if status is not None and job_lib.JobStatus.PENDING < status:\n+ ... | c699be1daa865d5e891aabccc7289ee84fe11440 | diff --git a/sky/skylet/job_lib.py b/sky/skylet/job_lib.py
index 2946bcc8aa9..360abab054a 100644
--- a/sky/skylet/job_lib.py
+++ b/sky/skylet/job_lib.py
@@ -79,6 +79,8 @@ class JobStatus(enum.Enum):
# The `job_id` has been generated, but the generated ray program has
# not started yet. skylet can transit the ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-1433@f7b4f8b | skypilot-org/skypilot | Python | 1,433 | [Spot] Let cancel interrupt the spot job (#1414) | Closes #1146
This PR is a resubmission of #1414, fixing the issue in #1431.
Tested:
- [x] `./tests/run_smoke_tests.sh test_spot_cancellation`
- [x] `./tests/run_smoke_tests.sh test_spot`
- [x] `./tests/run_smoke_tests.sh test_spot_gcp`
- [x] `./tests/run_smoke_tests.sh test_spot_recovery`
- [x] `./tests/run_... | 2022-11-19T01:14:05Z | [Spot] `sky spot cancel` does not interrupt PENDING or STARTING job
The current behavior of our code is that we will set the spot job status for PENDING jobs to STARTING first before setting it to CANCLLED, which can be a bit confusing. | Our `sky spot cancel` does not interrupt the provisioning and setup of a spot cluster either:
> It seems that the spot cancel command isn’t propagated immediately.
```
(base) MacBook-Pro-3:~ dementrock$ sky spot cancel 28
Cancelling managed spot jobs with IDs 28. Proceed? [Y/n]: y
I 11-14 05:44:43 spot_utils.py:1... | [
{
"body": "The current behavior of our code is that we will set the spot job status for PENDING jobs to STARTING first before setting it to CANCLLED, which can be a bit confusing.",
"number": 1146,
"title": "[Spot] `sky spot cancel` does not interrupt PENDING or STARTING job"
}
] | 1f843e21aaec2a38b621906b0aad533baf8d3d67 | {
"head_commit": "f7b4f8b10518d1f086ae18ede532c2c3e51ec36c",
"head_commit_message": "Add docstr",
"patch_to_review": "diff --git a/sky/spot/controller.py b/sky/spot/controller.py\nindex c19cee24f4d..dfd027dc58e 100644\n--- a/sky/spot/controller.py\n+++ b/sky/spot/controller.py\n@@ -6,6 +6,7 @@\n \n import coloram... | [
{
"diff_hunk": "@@ -167,40 +166,82 @@ def start(self):\n # The job can be non-terminal if the controller exited abnormally,\n # e.g. failed to launch cluster after reaching the MAX_RETRY.\n if not job_status.is_terminal():\n+ logger.info(f'Previous spot job sta... | 2e3fbe4202fa6e005a215db3eafd26ceacdcb1a2 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index ed91265fe2e..0d20eeb8be6 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -23,7 +23,6 @@
import jinja2
import jsonschema
from packaging import version
-import psutil
import requests
from requests impor... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-1489@1430d74 | skypilot-org/skypilot | Python | 1,489 | [AWS SSO] Use service account to access EC2 and S3 on head and worker nodes | This partially fixes #1488
For aws, we now set the worker nodes to have the same IAM role as the head node, so that they can correctly access s3 buckets without the need to upload the user's credential files (TBD: using the same role will allow the worker to access EC2 as well, which may not be necessary, and we ca... | 2022-12-05T09:35:45Z | [IAM] Utilize ray-autoscaler-v1 IAM role on the remote VM
Instead of using user's credentials on the remote VM, we need to utilize the `ray-autoscaler-v1` to handle the autostop/autodown and make the spot controller able to operate the clusters.
This will benefits:
1. better security for not copying the user's creden... | [
{
"body": "Instead of using user's credentials on the remote VM, we need to utilize the `ray-autoscaler-v1` to handle the autostop/autodown and make the spot controller able to operate the clusters.\r\nThis will benefits:\r\n1. better security for not copying the user's credentials.\r\n2. it will unblock the us... | e1c4121894bed919e2a59eba7096ec75a44ab65b | {
"head_commit": "1430d74694d9f9dea952328b6b74c77586d128b2",
"head_commit_message": "Add comments",
"patch_to_review": "diff --git a/docs/source/getting-started/installation.rst b/docs/source/getting-started/installation.rst\nindex ecd92246886..cbffed8fd51 100644\n--- a/docs/source/getting-started/installation.rs... | [
{
"diff_hunk": "@@ -0,0 +1,1234 @@\n+import copy\n+import itertools\n+import json\n+import logging\n+import os\n+import time\n+from distutils.version import StrictVersion\n+from functools import lru_cache, partial\n+from typing import Any, Dict, List, Optional, Set, Tuple\n+\n+import boto3\n+import botocore\n+\... | 47ac24e66714ba87219555d397930134c68bec4f | diff --git a/docs/source/getting-started/installation.rst b/docs/source/getting-started/installation.rst
index 996e4f6c96b..8e1ef5e2bba 100644
--- a/docs/source/getting-started/installation.rst
+++ b/docs/source/getting-started/installation.rst
@@ -58,6 +58,8 @@ To get the **AWS access key** required by :code:`aws conf... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Security Patches / Vulnerability Fixes"
} | |
skypilot-org__skypilot-1427@b01cb79 | skypilot-org/skypilot | Python | 1,427 | [AWS] Avoid key pair permission issue by using cloud-init for authorized keys | Closes #1425
This PR uses the cloud-init to setup the authorized keys to avoid using `ec2.describe_key_pairs` reducing the permission requirement.
Backward compatibility should be guaranteed by our old yaml content restoring mechanism.
Tested:
`rm ~/.ssh/sky-key*`
- [x] `sky launch --cloud aws` and ssh into... | 2022-11-17T08:10:27Z | [AWS] Permission issues with DescribeKeyPairs
We require `DescribeKeyPairs` permission in `auth. setup_aws_authentication()`, which is not checked in `sky check` and can fail the `sky launch` when not available.
```
botocore.exceptions.ClientError: An error occurred (UnauthorizedOperation) when calling the Describe... | [
{
"body": "We require `DescribeKeyPairs` permission in `auth. setup_aws_authentication()`, which is not checked in `sky check` and can fail the `sky launch` when not available.\r\n\r\n```\r\nbotocore.exceptions.ClientError: An error occurred (UnauthorizedOperation) when calling the DescribeKeyPairs operation: Y... | 79b389dbc8761bf85297bda71c07af2e96df1f9a | {
"head_commit": "b01cb792c9c3f8fb2dddc129ee4ae62d5ea5912f",
"head_commit_message": "address comments",
"patch_to_review": "diff --git a/sky/authentication.py b/sky/authentication.py\nindex 8eff3e482b4..784d8c397d9 100644\n--- a/sky/authentication.py\n+++ b/sky/authentication.py\n@@ -1,14 +1,13 @@\n \"\"\"Module ... | [
{
"diff_hunk": "@@ -65,92 +67,42 @@ def save_key_pair(private_key_path, public_key_path, private_key, public_key):\n f.write(public_key)\n \n \n-def get_public_key_path(private_key_path):\n- if private_key_path.endswith('.pem'):\n- private_key_path, _ = private_key_path.rsplit('.', 1)\n- re... | 14e1934ac8cb9d2d4327174fbd6e04d1e5add2eb | diff --git a/sky/authentication.py b/sky/authentication.py
index 8eff3e482b4..a6d1008bcc4 100644
--- a/sky/authentication.py
+++ b/sky/authentication.py
@@ -1,14 +1,13 @@
"""Module to enable a single SkyPilot key for all VMs in each cloud."""
import copy
import functools
-import hashlib
import os
-import pathlib
i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Security Patches / Vulnerability Fixes"
} | |
skypilot-org__skypilot-1414@25c568c | skypilot-org/skypilot | Python | 1,414 | [Spot] Let cancel interrupt the spot job | Closes #1146
Tested:
- [x] `./tests/run_smoke_tests.sh test_spot_cancellation`
- [x] `./tests/run_smoke_tests.sh test_use_spot`
- [x] `./tests/run_smoke_tests.sh test_spot`
- [x] `./tests/run_smoke_tests.sh test_gcp_spot`
- [x] `./tests/run_smoke_tests.sh test_spot_recovery`
- [x] `./tests/run_smoke_tests.sh ... | 2022-11-14T21:41:19Z | [Spot] `sky spot cancel` does not interrupt PENDING or STARTING job
The current behavior of our code is that we will set the spot job status for PENDING jobs to STARTING first before setting it to CANCLLED, which can be a bit confusing. | Our `sky spot cancel` does not interrupt the provisioning and setup of a spot cluster either:
> It seems that the spot cancel command isn’t propagated immediately.
```
(base) MacBook-Pro-3:~ dementrock$ sky spot cancel 28
Cancelling managed spot jobs with IDs 28. Proceed? [Y/n]: y
I 11-14 05:44:43 spot_utils.py:1... | [
{
"body": "The current behavior of our code is that we will set the spot job status for PENDING jobs to STARTING first before setting it to CANCLLED, which can be a bit confusing.",
"number": 1146,
"title": "[Spot] `sky spot cancel` does not interrupt PENDING or STARTING job"
}
] | dbea5b13346da4523a14962d378e431c2eeee336 | {
"head_commit": "25c568c8887f562e9c9d698ec5e7455f727d066e",
"head_commit_message": "increase waiting time",
"patch_to_review": "diff --git a/sky/spot/controller.py b/sky/spot/controller.py\nindex c19cee24f4d..16a97a9a73e 100644\n--- a/sky/spot/controller.py\n+++ b/sky/spot/controller.py\n@@ -6,6 +6,7 @@\n \n imp... | [
{
"diff_hunk": "@@ -178,8 +178,7 @@ def cancel_jobs_by_id(job_ids: Optional[List[int]]) -> str:\n cancelled_job_ids_str = ', '.join(map(str, cancelled_job_ids))\n identity_str = f'Jobs with IDs {cancelled_job_ids_str} are'\n \n- return (f'{identity_str} scheduled to be cancelled within '\n- ... | 6e9ba0c5eb1cce247ace1f3873d1d509fa96367b | diff --git a/sky/spot/controller.py b/sky/spot/controller.py
index c19cee24f4d..155fc202b5a 100644
--- a/sky/spot/controller.py
+++ b/sky/spot/controller.py
@@ -6,6 +6,7 @@
import colorama
import filelock
+import ray
import sky
from sky import exceptions
@@ -28,9 +29,9 @@ class SpotController:
def __init... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-1411@ce682da | skypilot-org/skypilot | Python | 1,411 | [Spot] Fix spot recovery for multi node | Closes #1410
Tested:
- [x] `tests/run_smoke_tests.sh test_spot_recovery_multi_node` | 2022-11-13T21:05:49Z | [Spot] Controller not recover multi-node spot job when preempted
When the worker node is preempted, the controller will not recover the cluster, if the job does not fail immediately with non-zero returncode after the number of nodes becomes less than expected. | [
{
"body": "When the worker node is preempted, the controller will not recover the cluster, if the job does not fail immediately with non-zero returncode after the number of nodes becomes less than expected.",
"number": 1410,
"title": "[Spot] Controller not recover multi-node spot job when preempted"
}... | 6c004df3725db999dad675294fef922320a0323e | {
"head_commit": "ce682daa0f5b39ad66d3e8571696876a5e059a40",
"head_commit_message": "Add test",
"patch_to_review": "diff --git a/sky/spot/controller.py b/sky/spot/controller.py\nindex 6b7a452fbfc..0487da3a1fd 100644\n--- a/sky/spot/controller.py\n+++ b/sky/spot/controller.py\n@@ -86,8 +86,21 @@ def _run(self):\n ... | [
{
"diff_hunk": "@@ -97,12 +110,9 @@ def _run(self):\n spot_state.set_succeeded(self._job_id, end_time=end_time)\n break\n \n- assert (job_status is None or",
"line": 100,
"original_line": 100,
"original_start_line": null,
"path": "sky/spot/controller.py... | 9bb6eb352ba03d47a586c19f316ab5439fb124c5 | diff --git a/sky/spot/controller.py b/sky/spot/controller.py
index 6b7a452fbfc..c19cee24f4d 100644
--- a/sky/spot/controller.py
+++ b/sky/spot/controller.py
@@ -86,8 +86,23 @@ def _run(self):
self._cluster_name)
if job_status is not None and not job_sta... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-1404@d10bbf1 | skypilot-org/skypilot | Python | 1,404 | [Setup] unset CUDA_VISIBLE_DEVICES for detach setup | Closes #1403.
Tested:
- [x] `tests/run_smoke_tests.sh test_env_check` | 2022-11-12T08:33:42Z | [Setup] `--detach-setup` will have CUDA_VISIBLE_DEVICES set causing inconsistency
From the user:
> Is there a recent change that sets CUDA_VISIBLE_DEVICES to empty string during cluster setup? I have a setup logic that configures the cuda compute capability compile flags based on this, it used to work, but suddenly st... | [
{
"body": "From the user:\r\n> Is there a recent change that sets CUDA_VISIBLE_DEVICES to empty string during cluster setup? I have a setup logic that configures the cuda compute capability compile flags based on this, it used to work, but suddenly stopped working after updating to the latest Sky on master toda... | fb31876161b1a7d01817f74c80330ffb5ac10427 | {
"head_commit": "d10bbf165ac6a07bb5fdc983c391bc37e7955d98",
"head_commit_message": "Add setting CUDA_VISIBLE_DEVICES test",
"patch_to_review": "diff --git a/examples/env_check.yaml b/examples/env_check.yaml\nindex 30adaefb3b0..7d2ed57ab8f 100644\n--- a/examples/env_check.yaml\n+++ b/examples/env_check.yaml\n@@ -... | [
{
"diff_hunk": "@@ -2041,6 +2044,7 @@ def _setup(self, handle: ResourceHandle, task: task_lib.Task,\n f.write(setup_script)\n f.flush()\n setup_sh_path = f.name\n+ print(setup_sh_path)",
"line": null,
"original_line": 2047,
"original_start_line": null,
... | 0d1a15e5bef5cc59bdb25c86a99f99f264eb5ef1 | diff --git a/examples/env_check.yaml b/examples/env_check.yaml
index 30adaefb3b0..7d2ed57ab8f 100644
--- a/examples/env_check.yaml
+++ b/examples/env_check.yaml
@@ -8,6 +8,9 @@ workdir: .
setup: |
echo "here"
echo "export TEST_VAR=test" >> ~/.bashrc
+ [[ -v CUDA_VISIBLE_DEVICES ]] && exit 1 || exit 0
+ export ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-1382@c5206c4 | skypilot-org/skypilot | Python | 1,382 | Fix Logging for `sky launch` on new machine | Fixes #1381.
## Tests
- `sky launch` on a manually provisioned AWS machine (with no credentials).
```
ubuntu@ip-172-31-37-168:~/skypilot/sky$ sky launch
Defaulting to local cloud as there are no enabled public clouds in `sky check`.
Error: Specify -c [local_cluster] to launch on a local cluster.
See `sky s... | 2022-11-07T01:13:02Z | UX: New machine that hasn't run `sky check` raises Local errors on first `sky launch`
To repro:
1. Create a new VM manually in console
2. Run `pip install skypilot`
3. Run `sky launch`
This will show the following:
```
...
I 11-06 15:02:41 optimizer.py:685] Considered resources (1 node):
I 11-06 15:02:41 op... | [
{
"body": "To repro:\r\n\r\n1. Create a new VM manually in console\r\n2. Run `pip install skypilot`\r\n3. Run `sky launch`\r\n\r\nThis will show the following:\r\n```\r\n...\r\nI 11-06 15:02:41 optimizer.py:685] Considered resources (1 node):\r\nI 11-06 15:02:41 optimizer.py:713] -------------------------------... | b2d3555af1f4b5aba53cc0c04c39ccd44fa26bc1 | {
"head_commit": "c5206c4cb7f4e1a58023510e46b943584376ae1c",
"head_commit_message": "ok",
"patch_to_review": "diff --git a/sky/backends/onprem_utils.py b/sky/backends/onprem_utils.py\nindex 7cb28c624b2..b112fc845ef 100644\n--- a/sky/backends/onprem_utils.py\n+++ b/sky/backends/onprem_utils.py\n@@ -11,6 +11,8 @@\n... | [
{
"diff_hunk": "@@ -467,6 +469,13 @@ def save_distributable_yaml(cluster_config: Dict[str, Dict[str, Any]]) -> None:\n common_utils.dump_yaml(abs_yaml_path, cluster_config)\n \n \n+# Checks if there is public cloud enabled.\n+def _is_public_cloud_disabled():\n+ enabled_clouds = global_user_state.get_enab... | 77d63a377196bb9caa1974233b3c367cda8c58e8 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index a1506a2c34a..4bd0a45bb2e 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -2055,3 +2055,10 @@ def validate_schema(obj, schema, err_msg_prefix=''):
if err_msg:
with ux_utils.print_exception_no_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-1384@392cc39 | skypilot-org/skypilot | Python | 1,384 | [Image] Support passing AMIs for different regions | Closes #1345
Main changes:
1. Support a dict for `image_id`
2. Added 3 smoke tests for the image_id dict.
Notes:
1. The failover will only go through the regions listed in the `image_id`.
3. If a region or zone is specified and not in the `image_ids`, it will throw an error.
4. If a task to be run on a exis... | 2022-11-08T19:37:23Z | Support passing multiple `image_id`, one per region
From user, whose app requires a specific Ubuntu 18.04 version, and does not support the latest 20.04 we use:
> An alternative could be to allow specifying image_id as a mapping from region to AMI so that at least the user won’t be limited to specifying a fixed regi... | The API for having a dict for `image_id` leaks the things each field can control. Previously, the region controls the regions to retry on, and the `image_id` specifies the image only. However, with the current specification, there are now two ways to limit the regions to failover through:
```
resources:
region: us... | [
{
"body": "From user, whose app requires a specific Ubuntu 18.04 version, and does not support the latest 20.04 we use:\r\n\r\n> An alternative could be to allow specifying image_id as a mapping from region to AMI so that at least the user won’t be limited to specifying a fixed region. This would be more flexib... | fb31876161b1a7d01817f74c80330ffb5ac10427 | {
"head_commit": "392cc39eaa6b5fb6317daf5e2f432f0a3694bfa7",
"head_commit_message": "add tests",
"patch_to_review": "diff --git a/docs/source/reference/yaml-spec.rst b/docs/source/reference/yaml-spec.rst\nindex fa1e29a8b33..586e0366cbc 100644\n--- a/docs/source/reference/yaml-spec.rst\n+++ b/docs/source/reference... | [
{
"diff_hunk": "@@ -66,7 +66,13 @@ def get_resources_schema():\n }\n },\n 'image_id': {\n- 'type': 'string',\n+ 'anyOf': [{\n+ 'type': 'string',\n+ }, {\n+ 'type': 'object',\n+ ... | db13172a5da44f8afa0e2a554270b1559be4aa64 | diff --git a/docs/source/reference/yaml-spec.rst b/docs/source/reference/yaml-spec.rst
index fa1e29a8b33..586e0366cbc 100644
--- a/docs/source/reference/yaml-spec.rst
+++ b/docs/source/reference/yaml-spec.rst
@@ -96,6 +96,11 @@ Available fields:
# image_id: skypilot:k80-ubuntu-2004
# image_id: skypilo... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-1400@1651922 | skypilot-org/skypilot | Python | 1,400 | [Spot] Keep SKYPILOT_JOB_ID the same for the same spot job | Fixes #1399
Also, fixes the testing for the `SKYPILOT_JOB_ID`.
~~This PR also adds the `SKYPILOT_JOB_ID` to the `sky spot queue -a` to make it easier for the user to find.~~
```
(sky-dev) ➜ sky-experiment-dev (fix-sky-job-id) sky spot queue -a ... | 2022-11-12T04:27:59Z | [Spot] The SKYPILOT_JOB_ID changes across restarts
From our user:
> It seems that the SKYPILOT_JOB_ID isn’t being preserved across restarts. Any idea what could be happening?
During the initial run it was 2022-11-12-00-17-08-581710_test-managed-spot-6_id-1
After I killed the cluster and the spot controller restarted... | [
{
"body": "From our user:\r\n> It seems that the SKYPILOT_JOB_ID isn’t being preserved across restarts. Any idea what could be happening?\r\nDuring the initial run it was 2022-11-12-00-17-08-581710_test-managed-spot-6_id-1\r\nAfter I killed the cluster and the spot controller restarted, it became sky-2022-11-12... | 6fec1473596a40c1794ccbaf6281c723c6a22ea0 | {
"head_commit": "165192267169a3bfc77584a5fc87eeaca9947bdc",
"head_commit_message": "don't set job_id_env_var for spot controller task",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex 8082dbd7cad..367b24ce5ee 100644\n--- a/sky/backends/cloud_vm_... | [
{
"diff_hunk": "@@ -1787,6 +1787,14 @@ def autostop(\n required=False,\n help=('Retry provisioning infinitely until the cluster is up, '\n 'if we fail to start the cluster due to unavailability errors.'))\n+@click.option(\n+ '--force',\n+ '-f',\n+ default=False,\n+ is_flag=True,\n+... | 1ffa161e75137843e13c3889e4342d21921e909c | diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py
index 8082dbd7cad..1acb0ec71d2 100644
--- a/sky/backends/cloud_vm_ray_backend.py
+++ b/sky/backends/cloud_vm_ray_backend.py
@@ -311,7 +311,6 @@ def add_gang_scheduling_placement_group(
file=sys.stderr,
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-1329@14e5d3b | skypilot-org/skypilot | Python | 1,329 | [Spot] Fix race condition for spot logs | This PR attempts to fix #1328.
The problem could happen due to a race condition, where the cluster is removed due to the preemption, but the `spot_status` has not been set to the correct state yet. In that case, the `handle` will be `None` and fails the log tailing.
i.e., after the following lines the cluster can... | 2022-10-29T19:13:12Z | [Spot] `NoneType` for handle when tailing the logs for the spot job
@pounde reported an issue with the main branch, where the following issue occurs:
```
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/home/ubuntu/.local/lib/python3.9/site-packages/sky/spot/spot_utils.py", line 24... | [
{
"body": "@pounde reported an issue with the main branch, where the following issue occurs:\r\n```\r\nTraceback (most recent call last):\r\n File \"<string>\", line 1, in <module>\r\n File \"/home/ubuntu/.local/lib/python3.9/site-packages/sky/spot/spot_utils.py\", line 242, in stream_logs_by_id\r\n return... | f49ed5aed4d180c18d7feddcb2733c61d9170441 | {
"head_commit": "14e5d3b08cc9a4acf19c42ab52a66101623da02e",
"head_commit_message": "address comments",
"patch_to_review": "diff --git a/sky/spot/spot_utils.py b/sky/spot/spot_utils.py\nindex 5dc402e1ba1..a3ffbfc7b0f 100644\n--- a/sky/spot/spot_utils.py\n+++ b/sky/spot/spot_utils.py\n@@ -230,15 +230,21 @@ def str... | [
{
"diff_hunk": "@@ -230,15 +230,21 @@ def stream_logs_by_id(job_id: int, follow: bool = True) -> str:\n cluster_name = generate_spot_cluster_name(task_name, job_id)\n backend = backends.CloudVmRayBackend()\n spot_status = spot_state.get_status(job_id)\n- while not spot_status.is_terminal():\n- ... | 855ae907d1929896d9176ac1bbdf439db20cff0e | diff --git a/sky/spot/spot_utils.py b/sky/spot/spot_utils.py
index 5dc402e1ba1..0700c1da751 100644
--- a/sky/spot/spot_utils.py
+++ b/sky/spot/spot_utils.py
@@ -230,15 +230,24 @@ def stream_logs_by_id(job_id: int, follow: bool = True) -> str:
cluster_name = generate_spot_cluster_name(task_name, job_id)
backen... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-1379@a791739 | skypilot-org/skypilot | Python | 1,379 | [Core] Add support for detach setup | Closes #730.
This PR adds the following option to `sky.launch` and `sky launch`: `--async-setup`
Note:
1. The setup will be run on all the nodes in the clusters no matter how many nodes are required by the task so that all the nodes will be in the same state to avoid inconsistent behavior on different nodes afte... | 2022-11-05T22:12:06Z | Support asynchronous setup and file_mounts
Our current setup and file_mounts require the user's laptop to have an `ssh` connection with the cluster, which means the setup or file_mounts will be stopped if the user stop the laptop. When the setup takes a long time, it is easy for the user to fail the setup.
Workaroun... | This falls into the asynchronous story, right?
For the setup, I think it may be a little bit different. For the asynchronous story, we assume there is a process running in the background on the laptop connecting with the cluster and handling the setup/file_mounts.
However, the `setup` can be run on the cluster indepen... | [
{
"body": "Our current setup and file_mounts require the user's laptop to have an `ssh` connection with the cluster, which means the setup or file_mounts will be stopped if the user stop the laptop. When the setup takes a long time, it is easy for the user to fail the setup.\r\n\r\nWorkaround: place setup in th... | e8c0772ee0e5dbe059cf7e73bc4441071026994f | {
"head_commit": "a791739e190b8e2bcb32c294b949dca1ce8a7295",
"head_commit_message": "Add test for async setup",
"patch_to_review": "diff --git a/examples/job_queue/job_multinode.yaml b/examples/job_queue/job_multinode.yaml\nindex ad016154e1d..ff291589001 100644\n--- a/examples/job_queue/job_multinode.yaml\n+++ b/... | [
{
"diff_hunk": "@@ -66,20 +66,24 @@ def sync_file_mounts(\n \n @timeline.event\n @usage_lib.messages.usage.update_runtime('setup')\n- def setup(self, handle: ResourceHandle, task: 'task_lib.Task') -> None:\n- return self._setup(handle, task)\n+ def setup(self, handle: ResourceHandle, task: ... | 9896f8061d34301cda7dd2b1df4cc986884eccb9 | diff --git a/examples/job_queue/job_multinode.yaml b/examples/job_queue/job_multinode.yaml
index ad016154e1d..4e8c05b79f0 100644
--- a/examples/job_queue/job_multinode.yaml
+++ b/examples/job_queue/job_multinode.yaml
@@ -16,11 +16,12 @@ num_nodes: 2
setup: |
echo "running setup"
+ sleep 80
run: |
timestamp... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-1330@d513c70 | skypilot-org/skypilot | Python | 1,330 | [Test/Azure] Fix the torch version in examples for smoke test and change the credential for Azure | Closes #1327
PyTorch bumps up the version to `1.13.0` yesterday, which causes the cuda version mismatch problem, when directly installing the latest `PyTorch==1.13.0` `pip install torch`.
The backward compatibility should be guaranteed by our `_RAY_YAML_KEYS_TO_RESTORE_FOR_BACK_COMPATIBILITY` in `backend_utils.p... | 2022-10-29T23:21:49Z | [Smoke tests] Cuda error for training
Our smoke tests with `Pytorch` fails (`test_cancel_pytorch` and `test_huggingface`, due to the following cuda issue:
```
(node-1 pid=31582) Traceback (most recent call last):
(node-1 pid=31582) File "/opt/conda/lib/python3.7/runpy.py", line 183, in _run_module_as_main
(node-1... | Just identified the issue, I was launching the azure cluster from an AWS ec2 VM, where there are some empty Azure credential services set up by default. We can limit the credential used by the `node_provider` to be only `AzureCliCredential` instead of a chain of different kind of credentials (fixed in #1330)
Update:... | [
{
"body": "Our smoke tests with `Pytorch` fails (`test_cancel_pytorch` and `test_huggingface`, due to the following cuda issue:\r\n```\r\n(node-1 pid=31582) Traceback (most recent call last):\r\n(node-1 pid=31582) File \"/opt/conda/lib/python3.7/runpy.py\", line 183, in _run_module_as_main\r\n(node-1 pid=3158... | fca1824ac41c558401c473f3f6f3383b25e08b5a | {
"head_commit": "d513c703bc378e74aa8337772d3a583a1c81563e",
"head_commit_message": "increase the multi-node timeout",
"patch_to_review": "diff --git a/examples/huggingface_glue_imdb_app.yaml b/examples/huggingface_glue_imdb_app.yaml\nindex ba114fcd0b8..8eb45dda016 100644\n--- a/examples/huggingface_glue_imdb_app... | [
{
"diff_hunk": "@@ -110,15 +110,14 @@ def get_default_ami(cls, region_name: str, instance_type: str) -> str:\n }\n assert region_name in amis, region_name\n return amis[region_name]\n- # Deep Learning AMI GPU PyTorch 1.10.0 (Ubuntu 20.04) 20220308\n+ ... | f539c0e1e9770bf0d98760055fd82f4cc8d5d82e | diff --git a/docs/source/examples/distributed-jobs.rst b/docs/source/examples/distributed-jobs.rst
index 404be137844..8bf9d48e26c 100644
--- a/docs/source/examples/distributed-jobs.rst
+++ b/docs/source/examples/distributed-jobs.rst
@@ -20,8 +20,9 @@ For example, here is a simple PyTorch Distributed training example:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
skypilot-org__skypilot-1297@fd5782f | skypilot-org/skypilot | Python | 1,297 | Add `--retry-until-up`, `--region`, `--zone`, and `--idle-minutes-to-autostop` for interactive nodes (v2) | This pull request builds on https://github.com/skypilot-org/skypilot/pull/1207 by setting `user_requested_resources` appropriately and handling the autostop edge case.
Tested:
`sky {cpunode, gpunode}` on GCP:
- [x] With and without -`-idle-minutes-to-autostop`
- [x] With varying regions and zones (`--region`,... | 2022-10-24T06:30:42Z | Support autostop option for interactive node CLIs
I found myself wanting to use autostopping when launching `sky gpunode`. We can add the following option from `sky launch` to the interactive node CLIs:
```
-i, --idle-minutes-to-autostop INTEGER
Automatically stop the cluster aft... | Reopening, we can close this when https://github.com/skypilot-org/skypilot/pull/1207 is resubmitted.
Thanks for the report @parasj. This is indeed very useful.
A workaround (as I'm sure you know; posting for others) is `sky launch --gpus A100 --retry-until-up --region <region>`.
Working on it :) | [
{
"body": "I found myself wanting to use autostopping when launching `sky gpunode`. We can add the following option from `sky launch` to the interactive node CLIs:\r\n```\r\n -i, --idle-minutes-to-autostop INTEGER\r\n Automatically stop the cluster after this\r\n ... | e536f7edaadad9d55f0a7c057ae6fe6d9834dffa | {
"head_commit": "fd5782fb0e63c4f27d4aba132eaf06c792a39b11",
"head_commit_message": "Update user_requested_resources",
"patch_to_review": "diff --git a/sky/cli.py b/sky/cli.py\nindex 705e2500a7a..45702514b06 100644\n--- a/sky/cli.py\n+++ b/sky/cli.py\n@@ -208,15 +208,53 @@ def _interactive_node_cli_command(cli_fu... | [
{
"diff_hunk": "@@ -657,6 +695,13 @@ def _launch_with_confirm(\n elif not confirm_shown:\n click.secho(f'Running task on cluster {cluster}...', fg='yellow')\n \n+ if node_type is not None and idle_minutes_to_autostop is not None \\\n+ and maybe_status == global_user_state.ClusterStatus... | 2adab1b68e831e8a4318603a90f5686eae7d0cde | diff --git a/sky/cli.py b/sky/cli.py
index 705e2500a7a..502423981fc 100644
--- a/sky/cli.py
+++ b/sky/cli.py
@@ -208,15 +208,67 @@ def _interactive_node_cli_command(cli_func):
default=False,
required=False,
help='Skip confirmat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-1324@883e9cf | skypilot-org/skypilot | Python | 1,324 | [UX] remove stacktrace for pipe and ssh info | Closes #1169
This PR removes the long stack trace due to the broken pipe. (The `--no-follow` is a better way to get rid of the broken pipe issue.)
Tested:
```
sky logs test-log | grep il
Tailing logs of the last job on cluster 'test-log'...
INFO: Tip: use Ctrl-C to exit log streaming... | 2022-10-29T09:27:30Z | Make `sky logs` with piping handle interrupts gracefully
If using `sky logs .. | grep ...` in a pipe, then ctrl-c would print out a long stacktrace:
```
$ sky logs sky-spot-controller-abb92b6d 34 | grep 'preempted from'
(zh-14-26 pid=97928) I 09-13 04:21:03 recovery_strategy.py:355] Cluster is preempted from zone us... | [
{
"body": "If using `sky logs .. | grep ...` in a pipe, then ctrl-c would print out a long stacktrace:\r\n```\r\n$ sky logs sky-spot-controller-abb92b6d 34 | grep 'preempted from'\r\n(zh-14-26 pid=97928) I 09-13 04:21:03 recovery_strategy.py:355] Cluster is preempted from zone us-west1-a.\r\n(zh-14-26 pid=97928... | f49ed5aed4d180c18d7feddcb2733c61d9170441 | {
"head_commit": "883e9cf10f7dea9025b11549feb89827463f56d0",
"head_commit_message": "format",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex 541d3bf96ef..1dc132ce221 100644\n--- a/sky/backends/backend_utils.py\n+++ b/sky/backends/backend_utils.py\n@@ -1996,9 ... | [
{
"diff_hunk": "@@ -68,6 +68,8 @@ def ssh_options_list(ssh_private_key: Optional[str],\n 'ConnectTimeout': f'{timeout}s',\n # Agent forwarding for git.\n 'ForwardAgent': 'yes',\n+ # Disable loggings for ssh.\n+ 'LogLevel': 'QUIET',",
"line": null,
"original_line": 7... | cb7641a4b8fa7631207e7e10f62ef3ed615db682 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index 541d3bf96ef..1dc132ce221 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -1996,9 +1996,11 @@ def kill_children_processes():
# Handle ctrl-c
def interrupt_handler(signum, frame):
del signum, frame
- ... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-1294@b24bec8 | skypilot-org/skypilot | Python | 1,294 | [Spot] Rename spot queue and fix help str | Fixes #1277 and #1195.
Main changes:
1. Rename `sky spot status` to `sky spot queue`, and deprecate `sky spot status`.
```
> sky spot --help
Usage: sky spot [OPTIONS] COMMAND [ARGS]...
Managed spot instances related commands.
Options:
-h, --help Show... | 2022-10-23T07:14:57Z | [Spot] Correct hint after ctrl-c from `sky spot launch` during streaming logs
Currently, when we ctrl-c from `sky spot launch` the hint for canceling jobs should be `sky spot cancel`, but the current output is as following:
```
I 10-04 15:56:40 cloud_vm_ray_backend.py:2080] Job ID: 17
I 10-04 15:56:40 cloud_vm_ray_b... | What is the final decision regarding this? I saw that `sky spot queue` and `sky queue` is the best option.
Yes, according to the vote we should rename `spot status` to `spot queue`
everywhere.
On Sat, Oct 22, 2022 at 7:58 PM Michael Luo ***@***.***>
wrote:
> What is the final decision regarding this? I saw that sky s... | [
{
"body": "Currently, when we ctrl-c from `sky spot launch` the hint for canceling jobs should be `sky spot cancel`, but the current output is as following:\r\n```\r\nI 10-04 15:56:40 cloud_vm_ray_backend.py:2080] Job ID: 17\r\nI 10-04 15:56:40 cloud_vm_ray_backend.py:2080] To cancel the job: sky cancel s... | 427081e52e8a7c6a758a7c2af7eb114d0d4cb17e | {
"head_commit": "b24bec844deb23716e13406ae2d3cf70e3cfc6fe",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/docs/source/examples/spot-jobs.rst b/docs/source/examples/spot-jobs.rst\nindex 04c0b270ab0..d091a46b070 100644\n--- a/docs/source/examples/spot-jobs.rst\n+++ b/docs/source/examples/spot-jobs... | [
{
"diff_hunk": "@@ -2190,31 +2206,32 @@ def _execute(\n # Case: task_lib.Task(run, num_nodes=1)\n self._execute_task_one_node(handle, task, job_id, detach_run)\n \n- def _post_execute(self, handle: ResourceHandle, teardown: bool) -> None:\n+ def _post_execute(self, handle: Resource... | e9ff439a170ba4dc6573447f26b8f37365a2dca1 | diff --git a/docs/source/examples/spot-jobs.rst b/docs/source/examples/spot-jobs.rst
index 04c0b270ab0..8c1c4fad855 100644
--- a/docs/source/examples/spot-jobs.rst
+++ b/docs/source/examples/spot-jobs.rst
@@ -188,8 +188,8 @@ Here are some commands for managed spot jobs. Check :code:`sky spot --help` for
.. code-block:... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-1311@94ab93b | skypilot-org/skypilot | Python | 1,311 | [Storage] Support multiple files in Storage | Closes #1070 and unblocks #1266.
Adds support for specifying multiple paths for upload to a Storage object using a list as a source:
```
/dataset/:
name: sky-multisource-storage\
source: [~/mydir/myfile.txt, ~/datasets]
```
Tested:
- [x] `pytest test_smoke.py::TestStorageWithCredentials`
- [x] ... | 2022-10-27T13:17:44Z | [Storage] Upload multiple files to the same bucket with different directories
It would be great if sky storage can support uploading multiple files into the same bucket but different folder in the bucket. Currently, a workaround is to write another program to upload the files first, before running the sky yaml.
```p... | Is it possible for the user to organize their files into a local hierarchy however they want, then simply specify the root of the hierarchy in the source?
```bash
mkdir ~/mydir/run-1/
mv {run1_files_path} ~/mydir/run-1/
...
```
In YAML:
```yaml
file_mounts:
remote_path:
source: ~/mydir/
```
> Is ... | [
{
"body": "It would be great if sky storage can support uploading multiple files into the same bucket but different folder in the bucket. Currently, a workaround is to write another program to upload the files first, before running the sky yaml.\r\n\r\n```python\r\nfor l_path in local_paths:\r\n subprocess.run... | 3c925be900cc62bce1ea01c95574da125fcf700e | {
"head_commit": "94ab93b669514c29bdfcd7c0497a55ccd4f293a2",
"head_commit_message": "add validation",
"patch_to_review": "diff --git a/docs/source/reference/storage.rst b/docs/source/reference/storage.rst\nindex 8ec6992f7fa..fda3083466f 100644\n--- a/docs/source/reference/storage.rst\n+++ b/docs/source/reference/... | [
{
"diff_hunk": "@@ -1074,13 +1138,22 @@ def upload(self):\n StorageUploadError: if upload fails.\n \"\"\"\n try:\n- if self.source is not None:\n+ if isinstance(self.source, list):\n+ for source_path in self.source:\n+ # We uplo... | db422ccfb05615cf92898a247cdec5e4ab5936bd | diff --git a/docs/source/reference/storage.rst b/docs/source/reference/storage.rst
index f599bf57a3a..683a9df36ad 100644
--- a/docs/source/reference/storage.rst
+++ b/docs/source/reference/storage.rst
@@ -155,6 +155,23 @@ and storage mounting:
name: romil-output-bucket
mode: MOUNT
+ # *** Uploa... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-1264@84d929a | skypilot-org/skypilot | Python | 1,264 | [Spot] Update docs for auto-translation | This PR updates the docs for managed spot jobs with auto-translation added in #1081. Also, fixes #1269
Tested:
- renderred locally. | 2022-10-17T20:32:26Z | [Docs] Spot controller missing from docs
The docs lack information on how to manage the spot controller, especially on how to terminate the controller. We need to answer questions like:
1. Is the spot controller shared among tasks?
2. How long does the spot controller keep running?
3. I am uninstalling SkyPilot or... | [
{
"body": "The docs lack information on how to manage the spot controller, especially on how to terminate the controller. We need to answer questions like:\r\n\r\n1. Is the spot controller shared among tasks?\r\n2. How long does the spot controller keep running?\r\n3. I am uninstalling SkyPilot or I do not want... | 9d705a77617a98bba18da1d7e2ee4414758453d0 | {
"head_commit": "84d929a7688d496a9895940a0d1535ea241b757f",
"head_commit_message": "update",
"patch_to_review": "diff --git a/docs/source/examples/spot-jobs.rst b/docs/source/examples/spot-jobs.rst\nindex 836439ca89b..5b282af1224 100644\n--- a/docs/source/examples/spot-jobs.rst\n+++ b/docs/source/examples/spot-j... | [
{
"diff_hunk": "@@ -6,57 +6,89 @@ Managed Spot Jobs\n SkyPilot supports managed spot jobs that can **automatically recover from preemptions**.\n This feature **saves significant cost** (e.g., up to 70\\% for GPU VMs) by making preemptible spot instances practical for long-running jobs.\n \n-To maximize availabi... | e26c5b3e773ac839d223b54d0fb48d2a2134a982 | diff --git a/docs/source/examples/spot-jobs.rst b/docs/source/examples/spot-jobs.rst
index 836439ca89b..17656f924e0 100644
--- a/docs/source/examples/spot-jobs.rst
+++ b/docs/source/examples/spot-jobs.rst
@@ -6,57 +6,88 @@ Managed Spot Jobs
SkyPilot supports managed spot jobs that can **automatically recover from pree... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
skypilot-org__skypilot-1259@ced2878 | skypilot-org/skypilot | Python | 1,259 | [Core] Fix resource validation for existing cluster and refactor | Fixes #1258
This PR makes validation of the resources based on the offering for each region/zone, only when the resources is `launchable` and is being launched by the optimizer. This is because if the cluster already exists, the user can specify some combination of the accelerator / accelerator count that does not ... | 2022-10-16T23:31:35Z | [Core] Fail to launch task on existing cluster with odd GPU numbers when region/zone specified
Reproducible code:
```
sky gpunode --gpus K80:4 --region us-central1 --cloud gcp -c test-gpu
sky exec --gpus K80:3 --region us-central1 test-gpu 'echo hi'
```
It raises:
```
Task from command: echo hi
ValueError: Acce... | This issue is stale because it has been open 120 days with no activity. Remove stale label or comment or this will be closed in 10 days.
This issue was closed because it has been stalled for 10 days with no activity. | [
{
"body": "Reproducible code:\r\n```\r\nsky gpunode --gpus K80:4 --region us-central1 --cloud gcp -c test-gpu\r\nsky exec --gpus K80:3 --region us-central1 test-gpu 'echo hi'\r\n```\r\nIt raises:\r\n```\r\nTask from command: echo hi\r\nValueError: Accelerator \"K80\" is not available in \"us-central1\" region/z... | f2033eabbd58e84a9e47f8339868d0ff3a9840e9 | {
"head_commit": "ced28783d1925d59ab4f2298c94de8579bc16940",
"head_commit_message": "add unitest for excution on existing cluster\n\nfix instance type\n\nfix the test without aws credential\n\nrefactor test\n\nadd job tests\n\nremove remnant\n\nadd invalid accelerator regions\n\nformat\n\nfix test\n\nfix test\n\nfi... | [
{
"diff_hunk": "@@ -4,6 +4,8 @@\n from click import testing as cli_testing\n \n import sky\n+from sky import exceptions\n+from sky import clouds",
"line": null,
"original_line": 8,
"original_start_line": null,
"path": "tests/test_cli.py",
"start_line": null,
"text": "@user1:\n```suggesti... | 520558825d733b7ea736bbea84848b59ad4c4f0c | diff --git a/.github/workflows/pytest.yml b/.github/workflows/pytest.yml
index 2b36d95dde9..81a43cb49bb 100644
--- a/.github/workflows/pytest.yml
+++ b/.github/workflows/pytest.yml
@@ -19,6 +19,7 @@ jobs:
- tests/test_cli.py
- tests/test_config.py
- tests/test_global_user_state.py
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-1207@af56cf3 | skypilot-org/skypilot | Python | 1,207 | Add `--retry-until-up`, `--region`, `--zone`, and `--idle-minutes-to-autostop` for interactive nodes | Add `--retry-until-up`, `--region`, and `--idle-minutes-to-autostop` for interactive nodes. This fixes #1131 and #1205.
Tested: `sky {cpunode, gpunode}` on Azure:
- [x] With and without `--idle-minutes-to-autostop`
- [x] With varying regions (`--region`)
I also used print statements to verify `_launch_with_conf... | 2022-10-06T23:47:56Z | Support autostop option for interactive node CLIs
I found myself wanting to use autostopping when launching `sky gpunode`. We can add the following option from `sky launch` to the interactive node CLIs:
```
-i, --idle-minutes-to-autostop INTEGER
Automatically stop the cluster aft... | [
{
"body": "I found myself wanting to use autostopping when launching `sky gpunode`. We can add the following option from `sky launch` to the interactive node CLIs:\r\n```\r\n -i, --idle-minutes-to-autostop INTEGER\r\n Automatically stop the cluster after this\r\n ... | f9b530038f2c607b0062f2d203d95e5da878dad9 | {
"head_commit": "af56cf33f98f3f35418ffdc6a5cd7b700fb866b5",
"head_commit_message": "Add --idle-minutes-to-autostop flag for interactive nodes",
"patch_to_review": "diff --git a/sky/cli.py b/sky/cli.py\nindex 0f36ad71cf2..307d427d012 100644\n--- a/sky/cli.py\n+++ b/sky/cli.py\n@@ -207,15 +207,36 @@ def _interacti... | [
{
"diff_hunk": "@@ -207,15 +207,36 @@ def _interactive_node_cli_command(cli_func):\n default=False,\n required=False,\n help='Skip confirmation prompt.')\n+ retry_until_up = click.option('--retry-until-up',\n+ ... | 1a4bdaaf96747b46424cb22cc069374b30b3285b | diff --git a/sky/cli.py b/sky/cli.py
index 0f36ad71cf2..791bc670530 100644
--- a/sky/cli.py
+++ b/sky/cli.py
@@ -207,15 +207,53 @@ def _interactive_node_cli_command(cli_func):
default=False,
required=False,
help='Skip confirmat... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-1183@f031c9d | skypilot-org/skypilot | Python | 1,183 | Fail early when spot cluster name too long occurs on GCP | Fixes #1178
Tested:
- [x] `sky spot launch -n i-am-a-very-long-name-too-make-it-fail --cloud gcp 'sleep 10'`
- [x] `sky spot launch -n i-am-a-very-long-name-too-make-it-fail --cloud gcp 'sleep 10' --retry-until-up` | 2022-09-30T21:33:33Z | spot vm provision keep retry when name is too long
Hi Sky team,
I specified a long name (which I should prevent in future) for spot VM, and the provision keeps retry. Obviously, this is not necessary as the criteria will keep failing.
Thanks!
```
(worker-220929-motif-enrichment-test-0 pid=3925) I 09-29 23:06:... | [
{
"body": "Hi Sky team,\r\n\r\nI specified a long name (which I should prevent in future) for spot VM, and the provision keeps retry. Obviously, this is not necessary as the criteria will keep failing.\r\n\r\nThanks!\r\n\r\n```\r\n(worker-220929-motif-enrichment-test-0 pid=3925) I 09-29 23:06:25 storage.py:536]... | 0a98c4dc98c8230a21f883696fe93ec61ea3cb72 | {
"head_commit": "f031c9db1fd8e520c6e368e33af3c4fbedb74102",
"head_commit_message": "format",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex 902d1f0f5d3..5eaf9edc9d7 100644\n--- a/sky/backends/backend_utils.py\n+++ b/sky/backends/backend_utils.py\n@@ -1831,9 ... | [
{
"diff_hunk": "@@ -1831,9 +1831,9 @@ def check_cluster_name_is_valid(cluster_name: str,\n if len(cluster_name) > _MAX_CLUSTER_NAME_LEN_FOR_GCP:\n with ux_utils.print_exception_no_traceback():\n raise ValueError(\n- f'Cluster name {cluster_name!r} has {len(... | a05f2ba09321e8ac237be4961499dbd3e9e7bbe2 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index 902d1f0f5d3..181cfa1bf35 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -1822,7 +1822,7 @@ def check_cluster_name_is_valid(cluster_name: str,
valid_regex = '[a-z]([-a-z0-9]{0,61}[a-z0-9])?'
if r... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-1217@f057f3d | skypilot-org/skypilot | Python | 1,217 | [Autodown] Support for autodown | Closes #954.
Please refer to the following tests for the design of the CLI.
Main changes:
1. Add an option `--terminate` for`sky launch` and `sky start`
2. Add an option `--terminate` for `sky autostop`
3. `sky.launch` replaces the `teardown` option with `terminate`.
Tested:
- [x] `sky launch -c test-autod... | 2022-10-10T03:51:22Z | Design auto-down, similar to auto-stop
This came up during a user conversation. The user has been using auto-stopping, and he'd also like an auto-down equivalent.
To design this, we need to think about
- Do we provide both CLIs, e.g., `sky autostop` and `sky autodown` co-exist. In code as well.
- Alternatively, ... | [
{
"body": "This came up during a user conversation. The user has been using auto-stopping, and he'd also like an auto-down equivalent. \r\n\r\nTo design this, we need to think about\r\n- Do we provide both CLIs, e.g., `sky autostop` and `sky autodown` co-exist. In code as well.\r\n- Alternatively, we can keep ... | a44daa221b9d3e2d3af3c65f0789e7f0364497f3 | {
"head_commit": "f057f3d4723df74c742c20d892b55a59f82af794",
"head_commit_message": "fix comment",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex 4043051196c..2c3caaf0765 100644\n--- a/sky/backends/cloud_vm_ray_backend.py\n+++ b/sky/backends/clo... | [
{
"diff_hunk": "@@ -2608,10 +2608,11 @@ def post_teardown_cleanup(self,\n def set_autostop(self,\n handle: ResourceHandle,\n idle_minutes_to_autostop: Optional[int],\n+ terminate: bool = True,",
"line": null,
"original_line": 2611,
"o... | 83dbdff6af10e35a3fb2c337fb3957dbd8c2b457 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index 8735b012d36..a8bd87da0c9 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -1650,7 +1650,9 @@ def _update_cluster_status_no_lock(
backend.set_autostop(handle, -1, stream_logs=False)
exc... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-1144@36893af | skypilot-org/skypilot | Python | 1,144 | Makes the local wheel dir the same hierarchy as the remote | Previously, if a user log into the remote cluster and run `sky launch`, the hash based wheel dir (introduced by #1139) will be destroyed.
This PR aligns the local wheel directory hierarchy with the remote wheel directory.
Tested:
- [x] `sky launch -c min ./examples/minimal.yaml; ssh min; sky launch -c test-build '... | 2022-08-31T06:07:44Z | Fail to launch spot job due to wheels not found
Hi Sky team,
I try to launch a spot job on a new controller with the latest sky from `git pull` The job keeps failing, and the log error is
```
(warmup pid=534) I 09-01 01:04:42 recovery_strategy.py:144] Failed to launch the spot cluster with error: Could not find ... | [
{
"body": "Hi Sky team,\r\n\r\nI try to launch a spot job on a new controller with the latest sky from `git pull` The job keeps failing, and the log error is\r\n\r\n```\r\n(warmup pid=534) I 09-01 01:04:42 recovery_strategy.py:144] Failed to launch the spot cluster with error: Could not find built SkyPilot whee... | 3c8b5e28487d8857d58c8d4fe6e3368f543c3fa4 | {
"head_commit": "36893afab87ad40b51bd5a6130712901e309ce3b",
"head_commit_message": "pin the azure cli for faster installation",
"patch_to_review": "diff --git a/sky/backends/wheel_utils.py b/sky/backends/wheel_utils.py\nindex 3eee3fb9d05..752bdf3ad92 100644\n--- a/sky/backends/wheel_utils.py\n+++ b/sky/backends/... | [
{
"diff_hunk": "@@ -5,82 +5,104 @@\n import shutil\n import subprocess\n import tempfile\n-from typing import Optional, Tuple\n+from typing import Tuple\n \n import filelock\n from packaging import version\n \n import sky\n+from sky import sky_logging\n from sky.backends import backend_utils\n \n+logger = sky_l... | aa004fe0ff0bd8abd318b3f1d18d2ed1e46c7ba1 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index 842e946ccd9..72939263273 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -64,7 +64,7 @@
SKY_REMOTE_APP_DIR = '~/.sky/sky_app'
SKY_RAY_YAML_REMOTE_PATH = '~/.sky/sky_ray.yml'
IP_ADDR_REGEX = r'\d{1,3}\.\... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-1143@c7d85b2 | skypilot-org/skypilot | Python | 1,143 | [Spot] Show FAILED_CONTROLLER when controller exit abnormally | Fixes #1141
Previously, if the controller failed abnormally, the spot status of the job will only be updated if the user run `sky spot cancel <job_id>`.
Now we move the status update to the skylet, so that the spot status will be updated automatically.
Tested:
- [x] `sky spot launch -n test-status 'echo hi; sleep 1... | 2022-08-31T04:08:01Z | [Spot] Populate the FAILED job status to the spot job table
When the spot controller failed due to some unexpected error, though the job status in `jobs.db` will be set to FAILED by skylet, but the status is not populated to the spot job table. | [
{
"body": "When the spot controller failed due to some unexpected error, though the job status in `jobs.db` will be set to FAILED by skylet, but the status is not populated to the spot job table. ",
"number": 1141,
"title": "[Spot] Populate the FAILED job status to the spot job table"
}
] | f97f0afa4f38d8bd319ebb3857523c1e56b577f0 | {
"head_commit": "c7d85b2410577a017f8fac706d5fdaa6bbf13fde",
"head_commit_message": "add spot status update to skylet",
"patch_to_review": "diff --git a/sky/skylet/events.py b/sky/skylet/events.py\nindex 5d4cd79643c..7f5fbaba17a 100644\n--- a/sky/skylet/events.py\n+++ b/sky/skylet/events.py\n@@ -13,6 +13,7 @@\n f... | [
{
"diff_hunk": "@@ -68,6 +68,41 @@ def get_job_status(backend: 'backends.CloudVmRayBackend',\n return status\n \n \n+def update_spot_job_status(job_id: Optional[int] = None):\n+ \"\"\"Update spot job status if the controller failed abnormally.\n+\n+ Check the status of the controller. If it is not run... | 91f25b652bdf4e95051c7bf8b22fccbe664655e2 | diff --git a/sky/skylet/events.py b/sky/skylet/events.py
index 5d4cd79643c..7f5fbaba17a 100644
--- a/sky/skylet/events.py
+++ b/sky/skylet/events.py
@@ -13,6 +13,7 @@
from sky import sky_logging
from sky.backends import backend_utils, cloud_vm_ray_backend
from sky.skylet import autostop_lib, job_lib
+from sky.spot i... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-973@7add39d | skypilot-org/skypilot | Python | 973 | Sky storage microbenchmark YAML | Closes #965. Refer to `examples/benchmarks/results.md` for details.
Example output (`sky launch storage_rawperf.yaml`):
```
(storage-demo pid=29477) ===== Benchmark Results =====
(storage-demo pid=29477) All results are reported as (bandwidth, IOPS)
(storage-demo pid=29477)
(storage-demo pid=29477) ##### Sequen... | 2022-07-14T17:26:04Z | YAMLs for profiling storage performance
We should add YAMLs which use fio/other benchmarking tools to measure Sky Storage (COPY and MOUNT) mode performance against EBS. And we should preferably do this for different workload types (sequential rw, random rw, real application performance (e.g., training)) | [
{
"body": "We should add YAMLs which use fio/other benchmarking tools to measure Sky Storage (COPY and MOUNT) mode performance against EBS. And we should preferably do this for different workload types (sequential rw, random rw, real application performance (e.g., training))",
"number": 965,
"title": "Y... | 04b94b9004a7188b742b181cf6d87a648cfbff78 | {
"head_commit": "7add39d10061cbd7efe81ec25ecb58fba34e1246",
"head_commit_message": "update results",
"patch_to_review": "diff --git a/examples/benchmarks/results.md b/examples/benchmarks/results.md\nnew file mode 100644\nindex 00000000000..2fb234916ef\n--- /dev/null\n+++ b/examples/benchmarks/results.md\n@@ -0,0... | [
{
"diff_hunk": "@@ -0,0 +1,48 @@\n+# Sky Benchmarks",
"line": null,
"original_line": 1,
"original_start_line": null,
"path": "examples/benchmarks/results.md",
"start_line": null,
"text": "@user1:\nCan we change\r\n- directory name to `examples/perf/`?\r\n- this line to \"Performance benc... | 9dce0e60340c20a650112c531a15729cdbde8a8c | diff --git a/examples/perf/results.md b/examples/perf/results.md
new file mode 100644
index 00000000000..b8f592e9be1
--- /dev/null
+++ b/examples/perf/results.md
@@ -0,0 +1,48 @@
+# Performance benchmarks for Sky
+
+This directory is a collection of YAMLs used to benchmark Sky's performance.
+
+## Sky Storage Benchmar... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-956@b9db118 | skypilot-org/skypilot | Python | 956 | Fix spot recovery caused by the exception raising | Closes #955.
After discussing with @infwinston, we found out that the problem is caused by #928, as all of our exception catching in the spot controller use `SystemExit`, which does not correctly catch the exception raised.
Tested:
- [x] `sky spot launch -n test-spot 'pip install tqdm; python -u -c "from tqdm im... | 2022-07-06T23:39:36Z | Potential bug of spot recovery
I tried to run our spot training example by
```
sky spot launch examples/spot/bert_qa.yaml
```
and manually killed the VM after the training started to test our spot recovery.
But it was not successful and I got the `FAILED_CONTROLLER` error:
```
(sky-b7d3-weichiang pid=120832) ... | Any useful message in `sky logs sky-spot-controller 17`?
Here is the log. There seems to be some command error for unknown reason.
```
(sky-b7d3-weichiang pid=120832) I 07-06 19:17:52 spot_utils.py:54] === Checking the job status... ===
(sky-b7d3-weichiang pid=120832) I 07-06 19:17:54 spot_utils.py:56] Job status: J... | [
{
"body": "I tried to run our spot training example by\r\n```\r\nsky spot launch examples/spot/bert_qa.yaml\r\n```\r\nand manually killed the VM after the training started to test our spot recovery.\r\n\r\nBut it was not successful and I got the `FAILED_CONTROLLER` error:\r\n```\r\n(sky-b7d3-weichiang pid=12083... | 69ed3d8d36cc9ed2341564e59bf2ab202e461aa1 | {
"head_commit": "b9db1182cb3799f80dadf79634b79bb476ead99c",
"head_commit_message": "Fix",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex 2d1e9311de0..f128875ecaf 100644\n--- a/sky/backends/cloud_vm_ray_backend.py\n+++ b/sky/backends/cloud_vm_ra... | [
{
"diff_hunk": "@@ -77,7 +77,7 @@ def launch(self,\n cluster_name=self.cluster_name,\n detach_run=True)\n logger.info('Spot cluster launched.')\n- except SystemExit:\n+ except Exception: # pylint: disable=broad-except\n... | 8ce739c57a55285662fc347da84799eab9652517 | diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py
index 2d1e9311de0..f128875ecaf 100644
--- a/sky/backends/cloud_vm_ray_backend.py
+++ b/sky/backends/cloud_vm_ray_backend.py
@@ -2001,8 +2001,8 @@ def tail_logs(self,
# Refer to: https://github.com/ray-project/ray/b... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-1081@af92b92 | skypilot-org/skypilot | Python | 1,081 | [Spot] Auto file_mounts translation for spot | Fixes #1073.
This PR makes sure that a normal task YAML can be run with `sky spot launch` without any modification.
~~It is currently blocked by #1069.~~
Tested:
- [x] `sky spot launch -n test-storage exampels/managed_spot_with_storage.yaml`
TODO:
- [x] Add test | 2022-08-15T19:16:30Z | [Spot] Automatically translate the local file mounts and workdir to sky Storage
The friction of changing an original available sky yaml with `workdir` and local file mounts set to the managed spot yaml has been observed multiple times. We may want to have SkyPilot translate those for the users automatically, i.e. trans... | [
{
"body": "The friction of changing an original available sky yaml with `workdir` and local file mounts set to the managed spot yaml has been observed multiple times. We may want to have SkyPilot translate those for the users automatically, i.e. translate those into SkyPilot Storage with `persistent: false` and... | ef90904e4b012d8ff1e65985aaf20491c90f2774 | {
"head_commit": "af92b92c63ccbcd959a42962dd1d4428a63fd492",
"head_commit_message": "Add a TODO",
"patch_to_review": "diff --git a/examples/managed_spot_with_storage.yaml b/examples/managed_spot_with_storage.yaml\nindex d82aff7db4b..c9fe823b19d 100644\n--- a/examples/managed_spot_with_storage.yaml\n+++ b/examples... | [
{
"diff_hunk": "@@ -282,7 +282,7 @@ def test_job_queue():\n test = Test(\n 'job_queue',\n [\n- f'sky launch -y -c {name} examples/job_queue/cluster.yaml',\n+ f'sky launch --cloud gcp -y -c {name} examples/job_queue/cluster.yaml',",
"line": null,
"original_line":... | 2d8153daef9dfa24a1a815a79f5439813a34a2c5 | diff --git a/examples/managed_spot_with_storage.yaml b/examples/managed_spot_with_storage.yaml
index d82aff7db4b..c9fe823b19d 100644
--- a/examples/managed_spot_with_storage.yaml
+++ b/examples/managed_spot_with_storage.yaml
@@ -11,8 +11,10 @@ resources:
use_spot: true
spot_recovery: failover
+workdir: ./exampl... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-917@05b5593 | skypilot-org/skypilot | Python | 917 | Enhance the logging info for pending task | Closes #892. | 2022-06-10T22:38:47Z | [Job] Pending Jobs Hanging
Suppose the user launches a cluster of 4 V100 and submits two jobs with 2 V100s. The cluster is now full.
Submitting a 3rd job with 2 V100s will be placed as PENDING for the Ray autoscaler. However, `sky launch -c asdf job.yaml` will hang, since the job is waiting for other two jobs to fi... | This is expected? User can pass -d to detach.
On Thu, Jun 2, 2022 at 13:04 Michael Luo ***@***.***> wrote:
> Suppose the user launches a cluster of 4 V100 and submits two jobs with 2
> V100s. The cluster is now full.
>
> Submitting a 3rd job with 2 V100s will be placed as PENDING for the Ray
> autoscaler. However, s... | [
{
"body": "Suppose the user launches a cluster of 4 V100 and submits two jobs with 2 V100s. The cluster is now full.\r\n\r\nSubmitting a 3rd job with 2 V100s will be placed as PENDING for the Ray autoscaler. However, `sky launch -c asdf job.yaml` will hang, since the job is waiting for other two jobs to finish... | 2cc0ebcfd17a91d510b4b5bc0ca69fbaaaeb9643 | {
"head_commit": "05b559340704c43fc34ea6f32d3a24be7300021d",
"head_commit_message": "Merge branch 'master' of github.com:concretevitamin/sky-experiments into enhance-log-info",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex afa4313932c..39e64122... | [
{
"diff_hunk": "@@ -251,7 +251,9 @@ def add_gang_scheduling_placement_group(\n pg = ray_util.placement_group({json.dumps(bundles)}, {pack_mode!r})\n plural = 's' if {num_nodes} > 1 else ''\n node_str = f'{num_nodes} node' + plural + '.'\n- print('SK... | fe44de6bb4975577d50a763063170f9ca43aedfd | diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py
index afa4313932c..8bc9e2fec31 100644
--- a/sky/backends/cloud_vm_ray_backend.py
+++ b/sky/backends/cloud_vm_ray_backend.py
@@ -251,14 +251,16 @@ def add_gang_scheduling_placement_group(
pg = ray_util.placement_gro... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-926@f14c993 | skypilot-org/skypilot | Python | 926 | Enhance YAML schema validation | Fixes #674.
Currently, the YAML schema validation only throws errors for unknown fields. It does not have support for required / optional fields, enum checks and type checks.
I propose using the [JSON Schema](https://json-schema.org/) format to define and validate schemas for the YAML configuration file. Althou... | 2022-06-16T09:55:11Z | Enforce strict YAML schema compliance
Sometimes I accidentally type `num_workers: 2` instead of `num_nodes: 2` in a sky YAML. `num_workers: 2` silently succeeds, and the user is left wondering why only 1 node was spun up.
We should enforce strict checking against the YAML schema, and raise errors if any extra keys a... | This should be partially fixed by #759, as we will error out for any unknown field.
Reopening this because in order to achieve full schema compliance, we also need to check values of YAML fields. For example, I accidentally typed `cloud: gcp` instead of `gcs`, and it silently succeeds and the optimizer picked AWS for m... | [
{
"body": "Sometimes I accidentally type `num_workers: 2` instead of `num_nodes: 2` in a sky YAML. `num_workers: 2` silently succeeds, and the user is left wondering why only 1 node was spun up.\r\n\r\nWe should enforce strict checking against the YAML schema, and raise errors if any extra keys are supplied in ... | d0dc9af6225e2e32c869b9649d767432ccfdcfe9 | {
"head_commit": "f14c993c3373dad3e3d289af431e6a4a1a4475f9",
"head_commit_message": "Use older JSON schema\n\nThe version of jsonschema that supports Python 3.6 does not contain a validator for the 202012 schema, so we have to use an older schema to support Python 3.6",
"patch_to_review": "diff --git a/sky/backen... | [
{
"diff_hunk": "@@ -0,0 +1,18 @@\n+\"\"\"This module contains a custom validator for the JSON Schema specification.\n+\n+The main motivation behind extending the existing JSON Schema validator is to\n+allow for case-insensitive enum matching since this is currently not supported\n+by the latest JSON Schema spec... | 50078321cf123b546c7670421d54a780ff006a09 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index ef4a5439518..85d06f2e2a8 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -24,6 +24,7 @@
import colorama
import filelock
import jinja2
+import jsonschema
import psutil
import requests
from requests im... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-978@b52130c | skypilot-org/skypilot | Python | 978 | Add core programmatic API align with CLI | Closes #871 and #980. Also, makes #972 easier.
Our current implementation has many functionalities in the `cli.py`, which makes python API users have to use subprocess to do the cluster, jobs, and storage management, and cannot handle easily handle the return values (needs to be done with string process).
This PR... | 2022-07-15T18:57:50Z | Move the functionality of cli to sdk
We need to move the functionality of the current CLI to SDK so that we can align the CLI and programmatic APIs. One example of the benefit is we can replace the `subprocess` call of the CLI commands with SDK, e.g. `subprocess.run('sky status')` in the cloud_vm_ray_backend.
[API] `s... | We can have an `execution.launch_impl`(or a better name) method with the same API as the current `sky.launch`, and let all internal call use that method. `sky.launch` and `execution.launch` can be a wrapper of that method without the `is_spot_controller_task` in the param list. | [
{
"body": "We need to move the functionality of the current CLI to SDK so that we can align the CLI and programmatic APIs. One example of the benefit is we can replace the `subprocess` call of the CLI commands with SDK, e.g. `subprocess.run('sky status')` in the cloud_vm_ray_backend.",
"number": 871,
"t... | 4c4061e7c3b21819b85b35ac64a807b0d540b898 | {
"head_commit": "b52130c56ae581c5f8b2a45b9df150a33d678f48",
"head_commit_message": "Fix test",
"patch_to_review": "diff --git a/sky/__init__.py b/sky/__init__.py\nindex 64db590a23f..cd9f05482bc 100644\n--- a/sky/__init__.py\n+++ b/sky/__init__.py\n@@ -7,11 +7,15 @@\n from sky import clouds\n from sky.clouds.serv... | [
{
"diff_hunk": "@@ -252,6 +247,29 @@ def _parse_env_var(env_var: str) -> Tuple[str, str]:\n type=str,\n help=('The region to use. If specified, overrides the '\n '\"resources.region\" config. Passing \"none\" resets the config.')),\n+ click.option(\n+ '--gpus',\n+ ... | 4d68f332cbb89a125c9d495295ec240fdfbdd716 | diff --git a/sky/__init__.py b/sky/__init__.py
index b80edae876f..f78b8333477 100644
--- a/sky/__init__.py
+++ b/sky/__init__.py
@@ -7,11 +7,16 @@
from sky import clouds
from sky.clouds.service_catalog import list_accelerators
from sky.dag import Dag
-from sky.execution import launch, exec # pylint: disable=redefin... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-882@43e8ca0 | skypilot-org/skypilot | Python | 882 | Fix recursive symlinks when uploading to sky storage | Closes #814 by using `--no-follow-symlinks` flag for `aws s3 sync`. Sky Storage now ignores all symlinks (like regular file_mounts, I believe).
Tested:
- [x] `./tests/run_smoke_tests.sh test_file_mounts`
- [x] `pytest test_smoke.py::TestStorageWithCredentials`
| 2022-06-02T11:24:18Z | [Storage] COPY mode storage bug: infinite loop if source has a `mylink -> .` symlink
My Sky root dir has a symlink
```
» ll mylink
lrwxr-xr-x@ 1 zongheng staff 1 Mar 6 09:01 mylink@ -> .
```
When running
```
bash tests/run_smoke_tests.sh test_spot_storage
```
It seems to get confused and recursively uploa... | Good catch - seems to be inherited from [aws-cli #3709](https://github.com/aws/aws-cli/issues/3709). We could either:
1. Use `--no-follow-symlinks` [flag](https://docs.aws.amazon.com/cli/latest/reference/s3/sync.html) for `aws s3 sync`. This would ignore all symlinks and not upload even broken links (like we do for ... | [
{
"body": "My Sky root dir has a symlink\r\n```\r\n » ll mylink\r\nlrwxr-xr-x@ 1 zongheng staff 1 Mar 6 09:01 mylink@ -> .\r\n```\r\nWhen running\r\n```\r\nbash tests/run_smoke_tests.sh test_spot_storage\r\n```\r\nIt seems to get confused and recursively uploads my dir, causing the test to timeout:\r\n```\r... | 83dcc4b1764120a5754683c2d4d708e8ebc3eb19 | {
"head_commit": "43e8ca018e7e68805a1fbb3b48a2b070d54da0ae",
"head_commit_message": "fix symlink",
"patch_to_review": "diff --git a/docs/source/reference/storage.rst b/docs/source/reference/storage.rst\nindex 1c8eda722ba..d68e528aa0b 100644\n--- a/docs/source/reference/storage.rst\n+++ b/docs/source/reference/sto... | [
{
"diff_hunk": "@@ -625,6 +628,14 @@ def test_upload_to_existing_bucket(self, tmp_awscli_bucket, tmp_mount):\n 'File not found in bucket - output was : {}'.format(out.decode\n ('utf-8'))\n \n+ # Check symlinks - symlinks don't ge... | f92d70737a1ef64ac4664c2a9ac2d38d0ff1d640 | diff --git a/docs/source/reference/storage.rst b/docs/source/reference/storage.rst
index 1c8eda722ba..d68e528aa0b 100644
--- a/docs/source/reference/storage.rst
+++ b/docs/source/reference/storage.rst
@@ -171,9 +171,9 @@ and storage mounting:
.. note::
Symbolic links are handled differently in :code:`file_mount... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-911@732c6ad | skypilot-org/skypilot | Python | 911 | Refresh the cluster status with the cloud CLI | Partially fixes #904.
This PR is the first step for using cloud CLI tools to fetch the cluster status. Although I implemented the status fetching for all the nodes in clusters, I am trying to be conservative in this PR, without letting the cluster status always up-to-date. Here are several reasons:
1. We do not want ... | 2022-06-08T08:12:35Z | UX: make `sky status` refresh correctly and by default
From Ritwik's onborading: "it’s counter-intuitive to me `sky status` doesn’t refresh by default."
We can make it refresh correctly by talking with the cloud provider. Currently refresh simply pings - if a cluster is unreachable, it's considered STOPPED but it co... | Another user previously gave this feedback:
> - one thing that was unclear to me (brought this up on a call with wei-lin) is whether the sky-status reflects just the local database or it reflects the status from the cloud provider. for example, if i make some action like stopping an instance via the web interface, doe... | [
{
"body": "From Ritwik's onborading: \"it’s counter-intuitive to me `sky status` doesn’t refresh by default.\"\r\n\r\nWe can make it refresh correctly by talking with the cloud provider. Currently refresh simply pings - if a cluster is unreachable, it's considered STOPPED but it could have been terminated manua... | 582ca05f1379b8c27ae286acceea771128d2e0f4 | {
"head_commit": "732c6ad7576774e47a189f4ad789d97955e53cb7",
"head_commit_message": "Update figures",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex e8624943968..2622b74e178 100644\n--- a/sky/backends/backend_utils.py\n+++ b/sky/backends/backend_utils.py\n@@ ... | [
{
"diff_hunk": "@@ -1322,21 +1544,20 @@ def get_clusters(include_reserved: bool, refresh: bool) -> List[Dict[str, Any]]:\n f'[bold cyan]Refreshing status for {len(records)} cluster{plural}[/]',\n total=len(records))\n \n- def _refresh_cluster(record):\n- handle = record['handle']\n+ ... | 8ff87dfa77f1443666c7fa9b4390106e21583116 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index 5058959ca8b..2d4153e5d04 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -22,6 +22,7 @@
import uuid
import colorama
+import filelock
import jinja2
import psutil
import requests
@@ -91,6 +92,10 @@
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-881@6270e56 | skypilot-org/skypilot | Python | 881 | Fix copy mounting when storage already exists | Closes #856.
Tested:
- [x] `pytest test_smoke.py::TestStorageWithCredentials`
- [x] Manually created a `MOUNT` storage in minimal.yaml and wrote to it, then used the storage in `COPY` mode in a copy of minimal.yaml to read the file earlier written. | 2022-06-02T11:06:57Z | [Storage] `COPY` mode mounting fails for existing Storage objects
From @concretevitamin:
I’m trying to test this out:
```
file_mounts:
/checkpoints:
name: my-sky-ckpts
mode: MOUNT
```
this works.
Then I want to add a variant of COPY, so I intuitively change mode
```
file_mounts:
/checkpoints... | +1 I was surprised by this a couple days ago.
+1 I experienced the exactly same thing as well. | [
{
"body": "From @concretevitamin:\r\n\r\nI’m trying to test this out:\r\n```\r\nfile_mounts:\r\n /checkpoints:\r\n name: my-sky-ckpts\r\n mode: MOUNT\r\n```\r\nthis works.\r\n\r\nThen I want to add a variant of COPY, so I intuitively change mode\r\n```\r\nfile_mounts:\r\n /checkpoints:\r\n name: my-s... | 82f24a4a59527e301881d4cc205ef73670cd4816 | {
"head_commit": "6270e569368c695a5a6b1dbcbb86ed88538ab840",
"head_commit_message": "address comments",
"patch_to_review": "diff --git a/sky/data/storage.py b/sky/data/storage.py\nindex da44484db45..5ffe4a083a1 100644\n--- a/sky/data/storage.py\n+++ b/sky/data/storage.py\n@@ -441,14 +441,20 @@ def _validate_stora... | [
{
"diff_hunk": "@@ -475,7 +475,8 @@ def add_storage_mounts(self) -> None:\n store_type = storage_plans[storage]\n if store_type is storage_lib.StoreType.S3:\n # TODO: allow for Storage mounting of different clouds\n- if storage.source.starts... | 0f29de6c15ff501f302088591fa649774c939221 | diff --git a/sky/data/storage.py b/sky/data/storage.py
index da44484db45..ac0a68def90 100644
--- a/sky/data/storage.py
+++ b/sky/data/storage.py
@@ -441,14 +441,20 @@ def _validate_storage_spec(self) -> None:
if self.source is None:
# If the mode is COPY, the source must be specified
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-974@bbf188d | skypilot-org/skypilot | Python | 974 | Fix storage deletion for spot | Closes #959.
The previous storage class cannot delete the non-sky-managed store, which is required for managed spot.
Main changes:
1. Add an internal option `force_delete` to the storage class.
2. Make controller delete the bucket after finishing.
3. Modify `./tests/run_smoke_tests.sh test_spot_storage` for te... | 2022-07-15T04:25:30Z | Spot storage leakage
Although `examples/managed_spot_with_storage.yaml` set the persistent to false, our following smoke test will still have leakage in the `sky storage ls`.
```
def test_spot_storage():
"""Test storage with managed spot"""
name = _get_cluster_name()
yaml_str = pathlib.Path(
'... | [
{
"body": "Although `examples/managed_spot_with_storage.yaml` set the persistent to false, our following smoke test will still have leakage in the `sky storage ls`.\r\n```\r\ndef test_spot_storage():\r\n \"\"\"Test storage with managed spot\"\"\"\r\n name = _get_cluster_name()\r\n yaml_str = pathlib.Pa... | 35068e65362d42fa8aacb79d4fc381ff417fb78c | {
"head_commit": "bbf188db5f6aded5aa0b0454285e6f487b1d7570",
"head_commit_message": "format",
"patch_to_review": "diff --git a/examples/managed_spot_with_storage.yaml b/examples/managed_spot_with_storage.yaml\nindex 627efa7f0ec..53c3b402df3 100644\n--- a/examples/managed_spot_with_storage.yaml\n+++ b/examples/man... | [
{
"diff_hunk": "@@ -784,12 +796,18 @@ def sync_local_dir(self) -> None:\n with backend_utils.safe_console_status(\n f'[bold cyan]Syncing '\n f'[green]{self.source} to s3://{self.name}/'):\n- with subprocess.Popen(sync_command.split(' '),\n- ... | 4536a8ac8a14e7c69cc197baecf46d08e29c26c7 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index 1bc524acf86..beabe87f2f0 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -1099,7 +1099,7 @@ def _process_cli_query(
@contextlib.contextmanager
-def subpress_output():
+def suppress_output():
"""S... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-863@f89ce10 | skypilot-org/skypilot | Python | 863 | Add retry-until-up feature for launch and start | Closes #857.
Main changes:
1. Added retry until up for both `sky launch` and `sky start`.
2. Exponential backoff for retry in `--retry-until-up` and spot recovery.
Tested:
- [x] `sky launch -c test-gpu --gpus V100 ''`
- [x] `sky launch -c test-gpu --gpus V100 -r ''`
- [x] `sky launch -c retry-test --gpus=A10... | 2022-05-23T05:43:56Z | UX: add "wait until launched" option to `sky launch`
Currently, both @Michaelvll and Daniel have used/discussed using wrapping `sky launch` in a bash loop in case launching fails. They used something like
```
until sky launch ...; do; done
```
to manually make this work. We should consider adding a `--wait-until... | [
{
"body": "Currently, both @Michaelvll and Daniel have used/discussed using wrapping `sky launch` in a bash loop in case launching fails. They used something like\r\n```\r\n until sky launch ...; do; done\r\n```\r\nto manually make this work. We should consider adding a `--wait-until-up / -w` or `--retry-unt... | 47735f442b1dcb5707662aa069fe2b37b0369fca | {
"head_commit": "f89ce10ecab95393779d601fc4ce2348b9a1744c",
"head_commit_message": "Add backoff for spot recovery",
"patch_to_review": "diff --git a/sky/backends/backend.py b/sky/backends/backend.py\nindex d0274d19345..0d109b1e48e 100644\n--- a/sky/backends/backend.py\n+++ b/sky/backends/backend.py\n@@ -28,7 +28... | [
{
"diff_hunk": "@@ -159,12 +161,13 @@ def recover(self) -> float:\n self.terminate_cluster()\n \n # Step 3\n- launched_time = self.launch(max_retry=self._MAX_RETRY_CNT,\n- retry_gap_seconds=self._RETRY_GAP_SECONDS,\n- r... | 5e04053f175a2016a705d2b3e07b4c3511ce1174 | diff --git a/sky/backends/backend.py b/sky/backends/backend.py
index d0274d19345..0d109b1e48e 100644
--- a/sky/backends/backend.py
+++ b/sky/backends/backend.py
@@ -28,7 +28,8 @@ def provision(self,
to_provision: Optional['resources.Resources'],
dryrun: bool,
str... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-775@302a6eb | skypilot-org/skypilot | Python | 775 | Fix sky cancel for on-prem mode | ~~`sky cancel` fails to kill the user processes when on-prem mode is used as `ps --forest` does not list processes with different users.~~
~~Replace it with `pstree` to find all descendent processes.~~
~~Also, replace `kill -s 0` with `ps -p` to check the liveness of process as `kill -s 0` can [return 1](https://... | 2022-04-29T20:51:03Z | potential performance issue with sky spot controller
There seems to be a performance issue of sky spot controller.
I've been using it for 3 days and submitted 20+ jobs. In the beginning it was pretty smooth but now it becomes super slow.
Now it's stuck for 5mins+ when I tried `sky spot status` or `sky spot logs`.
``... | Looks like the performance issue is critical. now the recovery mechanism is not functioning well.
What process takes most of the CPUs? Could you have a screenshot of the process list sorted by the CPU utilization? | [
{
"body": "There seems to be a performance issue of sky spot controller.\r\nI've been using it for 3 days and submitted 20+ jobs. In the beginning it was pretty smooth but now it becomes super slow.\r\nNow it's stuck for 5mins+ when I tried `sky spot status` or `sky spot logs`.\r\n```\r\n(sky) weichiang@blaze:~... | 3710ce5096d2bd1e0945450bb6b45a0ca6e9ad1f | {
"head_commit": "302a6eb54249400c70e3cb945daff7edebaac66a",
"head_commit_message": "Fix sky spot issue",
"patch_to_review": "diff --git a/examples/resnet_app.yaml b/examples/resnet_app.yaml\nindex b21e17791f8..88e8a153992 100644\n--- a/examples/resnet_app.yaml\n+++ b/examples/resnet_app.yaml\n@@ -2,9 +2,7 @@ nam... | [
{
"diff_hunk": "@@ -45,6 +45,7 @@\n # polling strategies`\n 'grpcio<=1.43.0',\n 'pulp',\n+ 'psutil',",
"line": 47,
"original_line": 48,
"original_start_line": null,
"path": "sky/setup_files/setup.py",
"start_line": null,
"text": "@user1:\nnit: order before pulp"
}
] | 3bab8466a5e3c07d7a643adf40d29dcc1025ef89 | diff --git a/examples/resnet_app.yaml b/examples/resnet_app.yaml
index b21e17791f8..88e8a153992 100644
--- a/examples/resnet_app.yaml
+++ b/examples/resnet_app.yaml
@@ -2,9 +2,7 @@ name: resnet-app
resources:
cloud: aws
- instance_type: p3.2xlarge
- # cloud: azure
- # accelerators: V100
+ accelerators: V100
... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
skypilot-org__skypilot-747@60ea502 | skypilot-org/skypilot | Python | 747 | Fix race condition for skylet daemon | Closes #745. Changed the behavior of the status update in skylet daemon: only update the status of the jobs that are submitted more than 2 seconds ago (need to be tuned based on heuristics), to make sure `ray job` has been correctly updated.
The problem is hard to reproduce, so I chose a reasonable gap (2 seconds) f... | 2022-04-15T08:04:24Z | Possible race condition of job status update in sky daemon
This is observed by @concretevitamin. When a job is just submitted, the `sky logs` called by `sky launch` may return status FAILED immediately. This can be caused by a race condition, where status update in skylet daemon set the job to FAILED, as the `ray job ... | [
{
"body": "This is observed by @concretevitamin. When a job is just submitted, the `sky logs` called by `sky launch` may return status FAILED immediately. This can be caused by a race condition, where status update in skylet daemon set the job to FAILED, as the `ray job status` has not been updated yet and retu... | 641205d2d52cdfaf3044331b4031b3558e3b63d3 | {
"head_commit": "60ea50264d95d13a317a92e318f7dabaf5dc85e1",
"head_commit_message": "update comment",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex 751cfc489ef..92ad527ebae 100644\n--- a/sky/backends/cloud_vm_ray_backend.py\n+++ b/sky/backends/... | [
{
"diff_hunk": "@@ -160,17 +160,18 @@ def _get_jobs(\n f\"\"\"\\\n SELECT * FROM jobs\n WHERE status IN ({','.join(['?'] * len(status_list))})\n+ AND submitted_at >= (?)",
"line": null,
"original_line": 163,
"original_start_line": null,
"path": "sky... | efff1c6cf8be1b576a579c01a6e494a42e1ccb73 | diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py
index 751cfc489ef..8d57cc82a3d 100644
--- a/sky/backends/cloud_vm_ray_backend.py
+++ b/sky/backends/cloud_vm_ray_backend.py
@@ -1885,8 +1885,6 @@ def _exec_code_on_head(
try:
if not detach_run:
- ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-727@4fca3da | skypilot-org/skypilot | Python | 727 | Make sky exec submit jobs for inline commands; guard Azure disabled subscription error. | Tested
- rendered html
- `sky exec balsa -d --workdir=. <my command>`
- `sky gpunode` previously failed due to the unhandled Azure error; now it fails over to AWS.
Fixes #677. | 2022-04-08T19:57:00Z | UX: Change the default behavior of `sky exec -- inline cmd` to submit job
The current default behavior of inline cmd without specifying the GPU requirements is the same as `ssh -c cmd`, and will not submit the task to the job queue. It is different from any other behaviors of `sky exec` and `sky launch`. It may cause c... | The pros are very appealing! A few thoughts:
1. Can we ask Daniel which behavior would he expect/prefer?
2. This means interactive commands like `sky exec clus htop` will occupy the `sky queue` table. Which may be ok, if we update docs to discourage this behavior (and use `ssh clus htop`, with some flags, etc.).
L... | [
{
"body": "The current default behavior of inline cmd without specifying the GPU requirements is the same as `ssh -c cmd`, and will not submit the task to the job queue. It is different from any other behaviors of `sky exec` and `sky launch`. It may cause confusion for the users, e.g. Daniel used the inline com... | 564f70b3d24a4747204296255cc42642e76aa4c7 | {
"head_commit": "4fca3da8be6444ff04455d808e776e4a25cba571",
"head_commit_message": "YAPF",
"patch_to_review": "diff --git a/docs/source/examples/iterative-dev-project.rst b/docs/source/examples/iterative-dev-project.rst\nindex 9d2722c9df4..62fde411847 100644\n--- a/docs/source/examples/iterative-dev-project.rst\... | [
{
"diff_hunk": "@@ -103,9 +103,9 @@ Bash commands are also supported, such as:\n \n .. code-block:: console\n \n- $ sky exec mycluster -- gpustat -i\n- $ sky exec mycluster -- ls -l\n- $ sky exec mycluster htop\n+ $ sky exec mycluster python train.py",
"line": null,
"original_line": 106,
"origin... | 37ca82cc46baf8cb5ae1001f34520c8381ad634d | diff --git a/docs/source/examples/iterative-dev-project.rst b/docs/source/examples/iterative-dev-project.rst
index 9d2722c9df4..ba428e4cf35 100644
--- a/docs/source/examples/iterative-dev-project.rst
+++ b/docs/source/examples/iterative-dev-project.rst
@@ -30,10 +30,8 @@ To run a command or a script on the cluster, use... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-711@baf1204 | skypilot-org/skypilot | Python | 711 | Fix optimizer messages | This PR closes #700
The fixed optimizer will
* skip the head message (`Optimizer - plan minimizing cost`) if the search space is trivial, and
* print hourly cost when the DAG consists of a task that does not have a time estimator and does not involve any data egress.
NOTE: `sky gpunode` still prints the header... | 2022-04-05T02:11:41Z | User is confused by optimizer messages for single-task/single-resource
```
$ sky gpunode --spot
I 04-04 12:31:57 optimizer.py:594] Optimizer - plan minimizing cost
I 04-04 12:31:57 optimizer.py:597] Estimated total run time: ~1.0 hr, total cost: ~$0.3
I 04-04 12:31:57 optimizer.py:609]
I 04-04 12:31:57 optimizer.p... | > For the second line, perhaps replace it with "Estimated hourly cost: ~$0.3".
Sounds good. Will fix this.
> The first line is definitely confusing.
Agreed. Will fix to skip the line whenever appropriate.
> Also curious what’s the default instance type selection logic; e.g. why wasn’t g4dn.xlarge chosen as ... | [
{
"body": "```\r\n$ sky gpunode --spot\r\nI 04-04 12:31:57 optimizer.py:594] Optimizer - plan minimizing cost\r\nI 04-04 12:31:57 optimizer.py:597] Estimated total run time: ~1.0 hr, total cost: ~$0.3\r\nI 04-04 12:31:57 optimizer.py:609]\r\nI 04-04 12:31:57 optimizer.py:609] TASK BEST_RESOURCE\r\nI 04-04 1... | f337f64aec2825065c97d68b54ca58ff2025feff | {
"head_commit": "baf1204cdc2b489666255ad2036db9aa04d743b8",
"head_commit_message": "Fix optimizer msg",
"patch_to_review": "diff --git a/sky/optimizer.py b/sky/optimizer.py\nindex a882eb9ac28..5d3f37e5980 100644\n--- a/sky/optimizer.py\n+++ b/sky/optimizer.py\n@@ -590,12 +590,31 @@ def print_optimized_plan(\n ... | [
{
"diff_hunk": "@@ -590,12 +590,31 @@ def print_optimized_plan(\n node_to_cost_map: _TaskToCostMap,\n minimize_cost: bool,\n ):\n- if minimize_cost:\n- logger.info('Optimizer - plan minimizing cost')\n+ node_to_cost_map = {\n+ k: v\n+ for k, v i... | b949af40c966e26d50b68042b1898c0fc38876df | diff --git a/sky/optimizer.py b/sky/optimizer.py
index a882eb9ac28..c9899c3c0d8 100644
--- a/sky/optimizer.py
+++ b/sky/optimizer.py
@@ -590,12 +590,31 @@ def print_optimized_plan(
node_to_cost_map: _TaskToCostMap,
minimize_cost: bool,
):
- if minimize_cost:
- logger.info('Optim... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
skypilot-org__skypilot-721@b7ad6a1 | skypilot-org/skypilot | Python | 721 | Reformat `sky status` codepath and minor fixes | This solves #716 as well moving `REGION` next to `RESOURCE` as suggested by @concretevitamin
Examples:
<img width="853" alt="image" src="https://user-images.githubusercontent.com/8518898/161877067-4d4947f9-f7e2-4356-862d-53b2b2839c96.png">
<img width="1038" alt="image" src="https://user-images.githubuserconte... | 2022-04-06T01:29:40Z | UX: `sky status` should hint about --refresh if there are clusters with autostop scheduled
Users may see an UP cluster with AUTOSTOP column set, and are confused by it "why is it still showing as UP even though the instance has stopped"?
Proposal:
- Detect if `sky status` shows any UP cluster with AUTOSTOP schedule... | [
{
"body": "Users may see an UP cluster with AUTOSTOP column set, and are confused by it \"why is it still showing as UP even though the instance has stopped\"?\r\n\r\nProposal:\r\n- Detect if `sky status` shows any UP cluster with AUTOSTOP scheduled \r\n- If so, output a hint line at the bottom, along the lines... | 2a825356b702d7c653a38c247b8bcc0c6956ce7a | {
"head_commit": "b7ad6a1690377fc088c00943d210f2bc034e4f52",
"head_commit_message": "refactor sky status codepath and minor fixes",
"patch_to_review": "diff --git a/format.sh b/format.sh\nindex 8954d68ebf2..79d2b805ee8 100755\n--- a/format.sh\n+++ b/format.sh\n@@ -89,7 +89,10 @@ else\n fi\n \n # Run Pylint\n+echo... | [
{
"diff_hunk": "@@ -0,0 +1,118 @@\n+\"\"\"Utilities for sky status.\"\"\"\n+import click\n+\n+from sky import backends\n+from sky.backends import backend_utils\n+from sky.utils.cli_utils import cli_utils\n+from sky.skylet import util_lib\n+\n+\n+class StatusColumn:\n+ \"\"\"One column of the displayed cluste... | caedbe0f5b4778625ff4119624b1e07a23a409a3 | diff --git a/format.sh b/format.sh
index 8954d68ebf2..79d2b805ee8 100755
--- a/format.sh
+++ b/format.sh
@@ -89,7 +89,10 @@ else
fi
# Run Pylint
+echo 'Sky Pylint:'
pylint --load-plugins pylint_quotes sky
+echo 'Sky Utils Pylint:'
+pylint --load-plugins pylint_quotes sky/utils
if ! git diff --quiet &>/dev/null;... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-692@f90f55d | skypilot-org/skypilot | Python | 692 | Fix the hardcoded gcp project id | Closes #317. This PR fixes the hardcoded GCP project id in our template file, using the same method in cloud storage for fetching the project id.
Tested:
- [x] `sky launch -c fm-gcp-test --cloud gcp examples/using_file_mounts.yaml` with the `sudo apt update; sudo apt install tree` commented out (due to #629). | 2022-04-03T22:46:24Z | Consider allowing users to configure cloud templates / changing GCP's project_id
(To discuss) Motivations for configurability of cloud templates
- (GCP) users may want to change GCP's project id
- (Azure) similarly, subscriptions etc.
- Users may want to add disks
Downsides of exposing the templates
- Too much c... | IIUC, this is now solved by `sky check`. Closing for now.
gcp-ray.yml.j2 currently hardcodes the `project_id` field - I think this issue is still open.
> gcp-ray.yml.j2 currently hardcodes the `project_id` field - I think this issue is still open.
Ahh, good catch. Our cloud storage got the project_id from the GCP cr... | [
{
"body": "(To discuss) Motivations for configurability of cloud templates\r\n- (GCP) users may want to change GCP's project id\r\n- (Azure) similarly, subscriptions etc.\r\n- Users may want to add disks\r\n\r\nDownsides of exposing the templates\r\n- Too much control; e.g.,\r\n - users can mess with the setup... | 78a39866e381df94ec9ed61f5ec543aab637d51c | {
"head_commit": "f90f55dac653b8591e05af3a95bbaf8f3f0f912b",
"head_commit_message": "Move azure subscription id to auth",
"patch_to_review": "diff --git a/sky/authentication.py b/sky/authentication.py\nindex 838854b8daf..0894b2c6419 100644\n--- a/sky/authentication.py\n+++ b/sky/authentication.py\n@@ -12,6 +12,7 ... | [
{
"diff_hunk": "@@ -14,10 +14,11 @@ provider:\n module: sky.skylet.providers.gcp.GCPNodeProvider\n region: {{region}}\n availability_zone: {{zones}}\n- project_id: intercloud-320520 # Globally unique project id\n # Keep (otherwise cannot reuse when re-provisioning).\n # teardown(terminate=True) will... | f3e1135b81432b083ddb61af3e688533274e5c07 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index be72b11408c..ec6c123f06b 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -30,7 +30,6 @@
from sky import global_user_state
from sky import exceptions
from sky import sky_logging
-from sky.adaptors import... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-680@9b011bf | skypilot-org/skypilot | Python | 680 | Add YAML schema check | Fixes #674.
### Tests
- [x] Full YAML from documentation
```
num_node: 1
# returns error
==========
resource:
cloud: aws
disk_space: 256
# returns error
```
Also tested `file_mounts`:
```
# returns useful error with suggestion:
file_mounts:
~/resnet_ddp:
name: tmp-resnet-test
... | 2022-04-01T22:34:01Z | Enforce strict YAML schema compliance
Sometimes I accidentally type `num_workers: 2` instead of `num_nodes: 2` in a sky YAML. `num_workers: 2` silently succeeds, and the user is left wondering why only 1 node was spun up.
We should enforce strict checking against the YAML schema, and raise errors if any extra keys a... | This should be partially fixed by #759, as we will error out for any unknown field. | [
{
"body": "Sometimes I accidentally type `num_workers: 2` instead of `num_nodes: 2` in a sky YAML. `num_workers: 2` silently succeeds, and the user is left wondering why only 1 node was spun up.\r\n\r\nWe should enforce strict checking against the YAML schema, and raise errors if any extra keys are supplied in ... | d18eb7c8ba1be3f99458d582a8a60095bba58f10 | {
"head_commit": "9b011bfef0a0c919b202f844c86e3b571d798f93",
"head_commit_message": "remove bad yaml",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex c45ca820b07..33ed35f85d3 100644\n--- a/sky/backends/backend_utils.py\n+++ b/sky/backends/backend_utils.py\n@@... | [
{
"diff_hunk": "@@ -236,6 +236,9 @@ class Storage(object):\n storage.delete()\n \"\"\"\n \n+ # Update the key list when a new field is added.\n+ yaml_keys = ['name', 'source', 'store', 'mode', 'persistent']",
"line": null,
"original_line": 240,
"original_start_line": null,
"pat... | 38c98e97745bb21e4bef14d542ea338d5f64bccd | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index c45ca820b07..33ed35f85d3 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -1,6 +1,7 @@
"""Util constants/functions for the backends."""
import colorama
import datetime
+import difflib
import enum
impor... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-685@495e3e9 | skypilot-org/skypilot | Python | 685 | Support glob patterns for jobs for `sky logs -s` | Closes #625 by supporting globbing on `sky logs -s`
Example output:
<img width="1132" alt="image" src="https://user-images.githubusercontent.com/8518898/161404721-6963ba25-6ea3-4295-95e6-e25a54b2c1ba.png"> | 2022-04-02T23:25:29Z | Make `sky logs -s` support glob pattern on the job IDs
Feature request from Daniel:
> I have 32 jobs and I want to search all of them for certain keywords (to match script outputs with wandb runs based on the wandb run name). Right now I'm running
for j in `seq 56 87`; do sky logs -s myclus $j; done
and then I'm p... | [
{
"body": "Feature request from Daniel:\r\n\r\n> I have 32 jobs and I want to search all of them for certain keywords (to match script outputs with wandb runs based on the wandb run name). Right now I'm running\r\nfor j in `seq 56 87`; do sky logs -s myclus $j; done\r\nand then I'm planning to grep the logs loc... | 4517202978195792890db20e2cce36d44ea3abc1 | {
"head_commit": "495e3e9fb46ba142597a127386177fd4c79f4491",
"head_commit_message": "removed whitespace",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex cd1cbe306b9..011aaa45290 100644\n--- a/sky/backends/cloud_vm_ray_backend.py\n+++ b/sky/backe... | [
{
"diff_hunk": "@@ -407,6 +425,14 @@ def get_log_path(cls, job_id: int) -> str:\n ]\n return cls._build(code)\n \n+ @classmethod\n+ def get_log_path_with_globbing(cls, job_id: int) -> str:",
"line": null,
"original_line": 429,
"original_start_line": null,
"path": "sky/skyle... | 2cca303c7d406be0f6cba55f24ce30765f4df6cd | diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py
index cd1cbe306b9..a3dea4751c0 100644
--- a/sky/backends/cloud_vm_ray_backend.py
+++ b/sky/backends/cloud_vm_ray_backend.py
@@ -1679,29 +1679,42 @@ def get_job_status(self, handle: ResourceHandle,
return None
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-659@4b202eb | skypilot-org/skypilot | Python | 659 | Parallel sky down | Closes #641. This PR makes `sky down` run in parallel. It also mitigates the problem with #656 to tear down the 100 clusters faster.
Main changes:
1. Make the database and rich console compatible with multi-thread.
Tested:
- [x] `for i in {1..4}; do sky launch -c min-$i ./examples/minimal.yaml -y 2>&1 | tee $i-... | 2022-03-28T07:55:45Z | Can sky down be parallelized?
I created 20 clusters on Azure for testing purpose.
After testing, I'd like to `sky down -a` but terminating each Azure cluster is taking >5mins.
In total 100mins is needed to clean up all clusters.
Is it possible to send all the termination signals in parallel? | Note: I just tried it with `backend_utils.run_in_parallel`, it seems that the `sqlite3` cannot be run in multiple threads. We may need to try multiple processes or ray actors.
we could also just use `conn = sqlite3.connect('your.db', check_same_thread=False)` to allow sqlite3 on multiple threads then create our own loc... | [
{
"body": "I created 20 clusters on Azure for testing purpose.\r\nAfter testing, I'd like to `sky down -a` but terminating each Azure cluster is taking >5mins.\r\nIn total 100mins is needed to clean up all clusters.\r\nIs it possible to send all the termination signals in parallel?",
"number": 641,
"tit... | 5189b50973030f52c9d8e38f95db87e17bfe190f | {
"head_commit": "4b202eba3963f47e22e3617f2b86b6824d59e8bf",
"head_commit_message": "format",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex 76ed4441b6c..615f80adc37 100644\n--- a/sky/backends/backend_utils.py\n+++ b/sky/backends/backend_utils.py\n@@ -11,6 +1... | [
{
"diff_hunk": "@@ -27,31 +28,42 @@\n _DB_PATH = os.path.expanduser('~/.sky/state.db')\n os.makedirs(pathlib.Path(_DB_PATH).parents[0], exist_ok=True)\n \n-_CONN = sqlite3.connect(_DB_PATH)\n-_CURSOR = _CONN.cursor()\n-\n-# Table for Clusters\n-_CURSOR.execute(\"\"\"\\\n- CREATE TABLE IF NOT EXISTS clusters ... | 07dd9500d1a40df71d400d4d118ebb8ad538b572 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index f1cd49f6212..5f3d70c9c67 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -11,6 +11,7 @@
import subprocess
import sys
import textwrap
+import threading
import time
import typing
from typing import Any... | {
"difficulty": "high",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-635@237c152 | skypilot-org/skypilot | Python | 635 | Added sky down --purge | Added `sky down --purge` which allows a user to remove a cluster from Sky ignoring any errors that the cloud provider throws (i.e ResourceNotFound). Useful for when the user manually plays around with resources or sky launch is called but terminated before any resources are created. | 2022-03-24T01:14:51Z | UX: fail to `sky down` a cluster that was manually terminated in console
Daniel reported:
I accidentally terminated an instance in the EC2 web console that corresponded to a STOPPED cluster (I thought it was one of the rogue instances). Now I can't remove the cluster from the sky interface:
```
$ sky down vasp
Te... | [
{
"body": "Daniel reported:\r\n\r\nI accidentally terminated an instance in the EC2 web console that corresponded to a STOPPED cluster (I thought it was one of the rogue instances). Now I can't remove the cluster from the sky interface:\r\n```\r\n$ sky down vasp\r\nTerminating 1 cluster: vasp. Proceed? [Y/n]: y... | 3451dd23f087b0b8522516722a4e2e37840c1fcb | {
"head_commit": "237c1529337ce5d6919152add8f67819b5898449",
"head_commit_message": "added sky down --purge",
"patch_to_review": "diff --git a/.pylintrc b/.pylintrc\nindex 5ae679e73ff..24472ae6f58 100644\n--- a/.pylintrc\n+++ b/.pylintrc\n@@ -210,7 +210,7 @@ const-rgx=^(_?[A-Z][A-Z0-9_]*|__[a-z0-9_]+__|_?[a-z][a-... | [
{
"diff_hunk": "@@ -2052,9 +2054,11 @@ def _teardown(self, handle: ResourceHandle, terminate: bool) -> bool:\n f'{tpu_stderr}{colorama.Style.RESET_ALL}')\n return False\n \n- if returncode != 0:\n+ if not purge and returncode != 0:\n ... | ec42159434fc238cad12a7dc51a0dfb286100dbb | diff --git a/sky/backends/backend.py b/sky/backends/backend.py
index 6576e8a670f..939227a2ee9 100644
--- a/sky/backends/backend.py
+++ b/sky/backends/backend.py
@@ -58,7 +58,10 @@ def post_execute(self, handle: ResourceHandle, teardown: bool) -> None:
def teardown_ephemeral_storage(self, task: 'task_lib.Task') -> ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-616@7071f72 | skypilot-org/skypilot | Python | 616 | Optimize the `sky job queue` when large amount of jobs running | Closes #612. This PR optimizes the `sky job queue` time from 24 seconds to 1.4 seconds when there are 30 jobs running. (To have 30 jobs running together, we need to change the original placement_group setting of CPUs to smaller than 1 to allow more jobs than CPU cores.)
```
# With 30 jobs running
# Old sky queue
... | 2022-03-19T01:35:44Z | `sky queue` takes a long time when there is many jobs running
Quotes from Daniel:
> with 32 jobs running, sky queue takes 40 seconds to print out the job list (87 total jobs, including cancelled/failed/succeeded)
> just logged in to check and CPU is pretty undersubscribed (I thought it might be oversubscribed anyway,... | [
{
"body": "Quotes from Daniel:\r\n> with 32 jobs running, sky queue takes 40 seconds to print out the job list (87 total jobs, including cancelled/failed/succeeded)\r\n> just logged in to check and CPU is pretty undersubscribed (I thought it might be oversubscribed anyway, but turns out my code has both poor CP... | 4bc859818a13787aa3b9e69f0f215d7d98812749 | {
"head_commit": "7071f7280500ee662df3dab304c84aaedea201a7",
"head_commit_message": "format",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex e3172683146..f1dd6c9da7e 100644\n--- a/sky/backends/backend_utils.py\n+++ b/sky/backends/backend_utils.py\n@@ -1130,6 ... | [
{
"diff_hunk": "@@ -1277,12 +1278,23 @@ def provision(self,\n # TPU.\n tpu_create_script=config_dict.get('tpu-create-script'),\n tpu_delete_script=config_dict.get('tpu-delete-script'))\n+\n+ # Update job queue to avoid stale jobs (when restarted), befor... | 0af3344c99d27bdb5046ddb37c337d94b48b2290 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index ab81b0a224b..82184d49847 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -785,7 +785,7 @@ def ssh_options_list(ssh_private_key: Optional[str],
# sky.launch().
'ControlMaster': 'au... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} | |
skypilot-org__skypilot-628@34fce9e | skypilot-org/skypilot | Python | 628 | Refactor DAG optimizer | Closes #545.
This PR refactors the Sky DAG optimizer. This PR includes:
* breaking up the `_optimize_cost` function, which was quite long (~170 lines) and a bit hard to follow. Now the optimization process is split into multiple smaller stages/functions.
* simplifying the DP algorithm by restricting the input grap... | 2022-03-22T09:38:39Z | Optimizer's message should be clarified
Kevin's question: what does $0.9 mean?
```
(sky) weichiang@blaze:~/repos/sky$ sky gpunode --cloud aws
I 03-11 13:58:37 optimizer.py:355] Optimizer - plan minimizing cost (~$0.9):
I 03-11 13:58:37 optimizer.py:370]
I 03-11 13:58:37 optimizer.py:370] TASK BEST_RESOURCE
I... | I assume this is because our default time estimator is set to 1 hour... since we don't really seem to use those we might as well update to $0.9/hour
Yes, we should clarify. Currently, that number is `sum(estimated cost of node n) for n in DAG`. The estimated cost of each node is based on its estimated run time, which... | [
{
"body": "Kevin's question: what does $0.9 mean?\r\n```\r\n(sky) weichiang@blaze:~/repos/sky$ sky gpunode --cloud aws\r\nI 03-11 13:58:37 optimizer.py:355] Optimizer - plan minimizing cost (~$0.9):\r\nI 03-11 13:58:37 optimizer.py:370] \r\nI 03-11 13:58:37 optimizer.py:370] TASK BEST_RESOURCE\r\nI 03-11 13... | 459bf95a47118aad05635fc8353dcacb56c790bc | {
"head_commit": "34fce9eb3afdaf7314fbfd1dde742623203c1280",
"head_commit_message": "yapf",
"patch_to_review": "diff --git a/examples/example_app.py b/examples/example_app.py\nindex add2891f0e5..d09b2c9c7aa 100644\n--- a/examples/example_app.py\n+++ b/examples/example_app.py\n@@ -76,4 +76,4 @@ def make_applicatio... | [
{
"diff_hunk": "@@ -332,51 +443,52 @@ def _optimize_cost(\n if is_multi_instances:\n logger.info(\n f'To list more details, run \\'sky show-gpus {acc_name}\\'.')\n- return dag, best_plan\n \n @staticmethod\n- def read_optimized_plan(dp_best_cost, top... | ce0975f0c042e360b63f61ff61ea1372762fffc0 | diff --git a/examples/example_app.py b/examples/example_app.py
index add2891f0e5..d09b2c9c7aa 100644
--- a/examples/example_app.py
+++ b/examples/example_app.py
@@ -76,4 +76,4 @@ def make_application():
dag = make_application()
sky.optimize(dag, minimize=sky.OptimizeTarget.COST)
-# sky.optimize(dag, minimize=Optimi... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-588@7d16f0b | skypilot-org/skypilot | Python | 588 | Add instructions in document for quota increase | To close https://github.com/sky-proj/sky/issues/524, https://github.com/sky-proj/sky/issues/513. We might also explore CLI interface to query quotas for convenience as mentioned in https://github.com/sky-proj/sky/issues/447. Curious what people think. | 2022-03-15T21:43:06Z | Docs: Add instructions for quota requests on all clouds
By default, accounts on all three clouds are not granted quotas for high end GPU instances such as V100. Let's write a clean guideline for users on how to submit quota requests. | [
{
"body": "By default, accounts on all three clouds are not granted quotas for high end GPU instances such as V100. Let's write a clean guideline for users on how to submit quota requests.",
"number": 524,
"title": "Docs: Add instructions for quota requests on all clouds"
}
] | 53fdaa55c72336ad1c30e2460e88bd997b62791a | {
"head_commit": "7d16f0b48cb34badb531baef7b49701535ee3277",
"head_commit_message": "Add hint for azure subscriptions",
"patch_to_review": "diff --git a/docs/source/getting-started/installation.rst b/docs/source/getting-started/installation.rst\nindex 96f8e17be41..2050d080b9a 100644\n--- a/docs/source/getting-sta... | [
{
"diff_hunk": "@@ -0,0 +1,46 @@\n+.. _quota:\n+Quota Increase\n+==================\n+\n+\n+Most cloud providers enforce a quota policy to limit the number of VM instances that can exist in a given region.\n+Users may encourter `QuotaExceeded` or `VcpuLimitExceeded` errors during resources provisioning, especia... | ba6c551785ea74a0ffb0b8a71cf2a68354dc737d | diff --git a/docs/source/getting-started/installation.rst b/docs/source/getting-started/installation.rst
index 96f8e17be41..2050d080b9a 100644
--- a/docs/source/getting-started/installation.rst
+++ b/docs/source/getting-started/installation.rst
@@ -63,6 +63,8 @@ If running :code:`conda install -c conda-forge google-clo... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} | |
skypilot-org__skypilot-614@ac824f0 | skypilot-org/skypilot | Python | 614 | Update GCP image for OS consistency and fix GCP's spot CPU | Close https://github.com/sky-proj/sky/issues/607.
Before:
```
ubuntu@ray-k80-gcp-old-head-4b2251cf-compute:~$ lsb_release -d
Description: Debian GNU/Linux 10 (buster)
ubuntu@ray-k80-gcp-old-head-4b2251cf-compute:~$ nvidia-smi
Fri Mar 18 23:51:52 2022
+------------------------------------------------------... | 2022-03-19T00:17:56Z | Inconsistent system version for different cloud
For different clouds, we are using inconsistent systems. I think it would be fine to be on different small versions of `ubuntu 20`, but GCP's `Debian` would be a bit surprising.
AWS:
```
ubuntu@ip-172-31-1-185:~$ lsb_release -d
Description: Ubuntu 20.04.4 LTS
``... | [
{
"body": "For different clouds, we are using inconsistent systems. I think it would be fine to be on different small versions of `ubuntu 20`, but GCP's `Debian` would be a bit surprising.\r\n\r\nAWS:\r\n```\r\nubuntu@ip-172-31-1-185:~$ lsb_release -d\r\nDescription: Ubuntu 20.04.4 LTS\r\n```\r\n\r\nGCP:\r\n... | b0438c4c2410967fc4516bce572f519650bfa4d7 | {
"head_commit": "ac824f0f0d384a5a08ed7e0c7574a855d28b637f",
"head_commit_message": "Fix worker",
"patch_to_review": "diff --git a/sky/clouds/gcp.py b/sky/clouds/gcp.py\nindex 4e820d5067f..4252b4c620d 100644\n--- a/sky/clouds/gcp.py\n+++ b/sky/clouds/gcp.py\n@@ -186,6 +186,7 @@ def make_deploy_resources_variables... | [
{
"diff_hunk": "@@ -186,6 +186,7 @@ def make_deploy_resources_variables(self, resources):\n 'tpu': None,\n 'custom_resources': None,\n 'use_spot': r.use_spot,\n+ 'image_name': 'common-cpu',",
"line": null,
"original_line": 189,
"original_start_line": nu... | 48e5150ea3d1f9319a87588ba0b46a5a8e779444 | diff --git a/sky/clouds/gcp.py b/sky/clouds/gcp.py
index 4e820d5067f..91f09efa9e7 100644
--- a/sky/clouds/gcp.py
+++ b/sky/clouds/gcp.py
@@ -186,6 +186,7 @@ def make_deploy_resources_variables(self, resources):
'tpu': None,
'custom_resources': None,
'use_spot': r.use_spot,
+ ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} | |
skypilot-org__skypilot-581@28d4583 | skypilot-org/skypilot | Python | 581 | Created and handled teardown success bool | Added a success variable to teardown (`sky down`) which has the following benefits:
1. Makes it more clear when `sky down` has failed from a user perspective by surfacing it as a red result
```
(sky-full) mraheja@latte:~/Sky/sky$ sky down sky-cpunode-mraheja
Terminating 1 cluster: sky-cpunode-mraheja. Proceed? ... | 2022-03-15T09:21:03Z | Do not delete the ray yaml file if `sky down` fails
When I tried to `sky down` a GCP cluster, I was on a wrong conda environment that does not have `googleapiclient` installed. Though it print out the error messages, after I switched back to the correct environment and `sky down` again, it told me the ray yaml file doe... | +1, encountered this too. Best to remove the yaml only after the actual down/stop returns success (exit code == 0). cc @mraheja | [
{
"body": "When I tried to `sky down` a GCP cluster, I was on a wrong conda environment that does not have `googleapiclient` installed. Though it print out the error messages, after I switched back to the correct environment and `sky down` again, it told me the ray yaml file does not exist. We may not remove th... | 0e2933605949f83a1759df75236bc27f80a80001 | {
"head_commit": "28d458327807458ef3583ab7b4c69aadd46af511",
"head_commit_message": "Created and handled teardown success bool",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex 193016ecfaf..a521e8720ed 100644\n--- a/sky/backends/cloud_vm_ray_back... | [
{
"diff_hunk": "@@ -1203,9 +1203,12 @@ def _terminate_or_stop_clusters(names: Tuple[str], apply_to_all: Optional[bool],\n click.echo(' To terminate the cluster, run: ', nl=False)\n click.secho(f'sky down {name}', bold=True)\n continue\n- backend.teardown(handle, termi... | 319a0a256284cb9163cc8b36656cf208140d6655 | diff --git a/sky/backends/backend.py b/sky/backends/backend.py
index d7f1efa1376..e873a9b28b8 100644
--- a/sky/backends/backend.py
+++ b/sky/backends/backend.py
@@ -58,7 +58,7 @@ def post_execute(self, handle: ResourceHandle, teardown: bool) -> None:
def teardown_ephemeral_storage(self, task: Task) -> None:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-569@1c4deb7 | skypilot-org/skypilot | Python | 569 | Sky Installation for Mac <1.15 Warnings + Doc | ## Features
- [x] Added warnings for Mac installation if user runs `pip install -v .` in Sky repo.
<img width="1032" alt="Screen Shot 2022-03-14 at 5 21 28 PM" src="https://user-images.githubusercontent.com/20640975/158284108-35690c86-b68d-459a-b6b2-91b5ad45ebc6.png">
- [x] Added Mac warning in the installation... | 2022-03-15T00:35:01Z | Cannot install on Apple Silicon due to grpcio issue
Our package as is won't install on Apple Silicon due to grpcio (imported by Ray) compatibility issues. The current workaround I've been using is: `pip uninstall grpcio; conda install grpcio`, but I'm hoping either grpcio/ray finds a way to fix this soon.
Until then... | I had that problem back in Jan. Had to clear up space and upgrade to Catalina.
Don't think we can do much here...
Discussed offline - we should
- require ray >= 1.9.2 in setup.py
- try to detect <= MacOS 10.14 and print a useful message saying MacOS >= 1.15 is needed to satisfy the ray requirement | [
{
"body": "Our package as is won't install on Apple Silicon due to grpcio (imported by Ray) compatibility issues. The current workaround I've been using is: `pip uninstall grpcio; conda install grpcio`, but I'm hoping either grpcio/ray finds a way to fix this soon.\r\n\r\nUntil then should we add a section to o... | c6955a4828987252052459726c06586f2d8ab15a | {
"head_commit": "1c4deb7e81c087b36e6005f625098f7dd68bc588",
"head_commit_message": "Fix",
"patch_to_review": "diff --git a/docs/source/getting-started/installation.rst b/docs/source/getting-started/installation.rst\nindex 70ca4015b97..2fdc70af9f7 100644\n--- a/docs/source/getting-started/installation.rst\n+++ b/... | [
{
"diff_hunk": "@@ -5,10 +5,42 @@\n Google Cloud Platform or Microsoft Azure.\"\"\"\n \n import os\n+import platform\n import setuptools\n+import warnings\n \n ROOT_DIR = os.path.dirname(__file__)\n \n+\n+def version_comparator(v1, v2):\n+ v1_num = [int(i) for i in v1.split(\".\")]\n+ v2_num = [int(i) for... | 89b18dec08b8b450e3818b0360823d219f4d02bc | diff --git a/docs/source/getting-started/installation.rst b/docs/source/getting-started/installation.rst
index 70ca4015b97..96f8e17be41 100644
--- a/docs/source/getting-started/installation.rst
+++ b/docs/source/getting-started/installation.rst
@@ -17,6 +17,10 @@ only have access to certain clouds, use any combination ... | {
"difficulty": "medium",
"estimated_review_effort": 2,
"problem_domain": "Documentation Updates"
} |
skypilot-org__skypilot-504@baa3924 | skypilot-org/skypilot | Python | 504 | Timeout for multi-node launching | This is to resolve #502. We will timeout the gang scheduling if we fail to launch at least 1 node in 30 seconds when there is any node that should be launched (launch means: provision without any setup). The fail case relates to quota limit or resources availability limit. We can further reduce the `timeout` to simulat... | 2022-03-08T05:35:22Z | [Azure] `sky launch azure-start-stop.yaml` fails due to dependency
I failed to launch two azure nodes with the following error during launching the head node.
```
ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following d... | +1, having the same issue. Here's the complete log, if that's any help:
```
(base) romilb@romilbx1yoga:/mnt/d/Romil/Berkeley/Research/sky-experiments$ sky launch -c azure-start-stop ./examples/azure_start_stop.yaml
Task from YAML spec: ./examples/azure_start_stop.yaml
Running task on cluster azure-start-stop...
... | [
{
"body": "I failed to launch two azure nodes with the following error during launching the head node.\r\n```\r\nERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.\r\nfbprophet 0.7.1 requi... | b99ae426fcdaef545872ae3bf6f50ef87e898ffc | {
"head_commit": "baa392446f90bfd048aa4eebe67e396f445d73e3",
"head_commit_message": "Add retry for head ip fetching at the first time",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex bcb26d916d5..cda5a261389 100644\n--- a/sky/backends/backend_utils.py\n+++ b/... | [
{
"diff_hunk": "@@ -773,6 +840,68 @@ def generate_cluster_name():\n return f'sky-{uuid.uuid4().hex[:4]}-{getpass.getuser()}'\n \n \n+def get_node_ips(cluster_yaml: str,\n+ expected_num_nodes: int,\n+ return_private_ips: bool = False) -> List[str]:\n+ \"\"\"Returns the IPs ... | ae1b2a17f905bb069b6f1969599344b17c980bf2 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index bcb26d916d5..98f4006d7cb 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -6,6 +6,7 @@
from multiprocessing import pool
import os
import pathlib
+import re
import shlex
import subprocess
import sys
@@... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
skypilot-org__skypilot-501@b9ab7f2 | skypilot-org/skypilot | Python | 501 | Fix Azure resource leak | Unfortunately I cannot reproduce the bug with my laptop. But it looks like the valid fix. @infwinston Could you try this simple fix?
BTW, we are still leaking other resources for all clouds (because of design of Ray autoscaler), e.g., credentials and security configurations. Not sure if there are limits of these res... | 2022-03-07T23:48:06Z | [Azure] Is our Azure resouce clean up correct?
I've started running into this error on Azure EastUS:
```
W 02-23 09:15:54 cloud_vm_ray_backend.py:505] Exception Details: (ResourceCountExceedsLimitDueToTemplate) Subscription aa86df77-e703-453e-b2f4-955c3b33e534 has a quota of 100 for resources of type P
ublic... | The code appears to delete NIC, IP, storage on a best effort basis: https://github.com/sky-proj/sky/blob/master/sky/skylet/providers/azure/node_provider.py#L271. cc @suquark
We use azure cli to delete the stopped azure machines, where we only use `az vm delete`. Maybe we also need to clean up the IP resources as well... | [
{
"body": "I've started running into this error on Azure EastUS:\r\n```\r\nW 02-23 09:15:54 cloud_vm_ray_backend.py:505] Exception Details: (ResourceCountExceedsLimitDueToTemplate) Subscription aa86df77-e703-453e-b2f4-955c3b33e534 has a quota of 100 for resources of type P\r\nublicIpAddress with sku Basi... | bfe0f4d9808d77f1f9db52321aa3fee872ee2071 | {
"head_commit": "b9ab7f271e7496d32b931d0b6023ac43a43591c2",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex e5aa99aeac8..0b9f474e97e 100644\n--- a/sky/backends/cloud_vm_ray_backend.py\n+++ b/sky/backends/cloud_vm_ra... | [
{
"diff_hunk": "@@ -56,6 +56,9 @@ class AzureNodeProvider(NodeProvider):\n \n def __init__(self, provider_config, cluster_name):\n NodeProvider.__init__(self, provider_config, cluster_name)\n+ # TODO(suquark): This is a temporary patch for creating the non-existing resource group.\n+ f... | 7821e2c747dc66eae18fa8360ec1dc4ad19f99fc | diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py
index e5aa99aeac8..7a6d4c9935f 100644
--- a/sky/backends/cloud_vm_ray_backend.py
+++ b/sky/backends/cloud_vm_ray_backend.py
@@ -1693,8 +1693,21 @@ def teardown(self, handle: ResourceHandle, terminate: bool) -> None:
prev_s... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-496@177cacc | skypilot-org/skypilot | Python | 496 | Fix rsync_exclude for gcp credential file_mounts | Closes #494. The `rsync_exclude` will treat the absolute path as the relative path, so the previous symlink problem observed in #483 still exists. I changed the `rsync_exclude` for the symlink in the credential to be a relative path. The solution is a bit hacky right now, but it may be good to fix it first and then ref... | 2022-03-07T06:12:50Z | Multinode Sky Launch Bug
On most recent master, run multinode setup, e.g. `sky launch -c hello examples/env_check.yaml`.
Head node launches, but worker nodes failed to launch:
```
I 03-06 00:24:52 backend_utils.py:503] No cluster status.
I 03-06 00:24:52 backend_utils.py:503] The autoscaler failed with the follow... | @Michaelvll Do you have a direction on what is causing this issue?
Tried latest f5f228368 on my laptop, didn't see this issue. It sounds like the autoscaler cannot access / doesn't have read permissions to `/home/ubuntu/.config/gcloud/virtenv/bin/python`. Check `ls -l`?
`cat ~/.sky/generated/hello.yml`:
```
...
... | [
{
"body": "On most recent master, run multinode setup, e.g. `sky launch -c hello examples/env_check.yaml`.\r\nHead node launches, but worker nodes failed to launch:\r\n\r\n```\r\nI 03-06 00:24:52 backend_utils.py:503] No cluster status.\r\nI 03-06 00:24:52 backend_utils.py:503] The autoscaler failed with the fo... | 1604bf139472ed9ad9c254ad56e13127a096a624 | {
"head_commit": "177caccdf8c76812d057b2fe5c6549bc39618959",
"head_commit_message": "format",
"patch_to_review": "diff --git a/sky/clouds/gcp.py b/sky/clouds/gcp.py\nindex 5aae7314d07..04b77abf5b7 100644\n--- a/sky/clouds/gcp.py\n+++ b/sky/clouds/gcp.py\n@@ -256,6 +256,10 @@ def check_credentials(self) -> Tuple[b... | [
{
"diff_hunk": "@@ -256,6 +256,10 @@ def check_credentials(self) -> Tuple[bool, Optional[str]]:\n return True, None\n \n def get_credential_file_mounts(self) -> Tuple[Dict[str, str], List[str]]:\n+ # Excluding the symlink to the python executable created by the gcp\n+ # credential, whi... | d8e4ba5a4e8f26a0a663cd326e92166ebea4b84c | diff --git a/sky/clouds/gcp.py b/sky/clouds/gcp.py
index 5aae7314d07..a649e9fb4c8 100644
--- a/sky/clouds/gcp.py
+++ b/sky/clouds/gcp.py
@@ -256,6 +256,10 @@ def check_credentials(self) -> Tuple[bool, Optional[str]]:
return True, None
def get_credential_file_mounts(self) -> Tuple[Dict[str, str], List[st... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-441@6d95f92 | skypilot-org/skypilot | Python | 441 | Remove tracebacks for exceptions to improve UX | Previously, the raised exceptions will print a large amount of unnecessary traceback information of the internal sky code as well `ssh` error, so that the user's file_mounts / setup / run error will be more close to the end and easier to find. This PR suppresses the errors that occurred in the following yaml. Closes #3... | 2022-02-24T08:47:13Z | [Logging/Sky Launch] Highlight Error Message from User Setup/Run Commands
When Sky is provisioning machine and running the user's `setup/run` commands in the yaml file, it is difficult for initial users to find the error message in their setup or run script amidst all the logs. Hence, it is a good idea to highlight the... | [
{
"body": "When Sky is provisioning machine and running the user's `setup/run` commands in the yaml file, it is difficult for initial users to find the error message in their setup or run script amidst all the logs. Hence, it is a good idea to highlight the errors.",
"number": 384,
"title": "[Logging/Sk... | bfd93f9c9d1c5b32fecc2e03e57e258ebebb6c7e | {
"head_commit": "6d95f9226f053034127eb4a4d22c806970d60f09",
"head_commit_message": "Fix #442",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex 1d914a1c800..27e67dc9b2a 100644\n--- a/sky/backends/backend_utils.py\n+++ b/sky/backends/backend_utils.py\n@@ -593,9... | [
{
"diff_hunk": "@@ -1116,7 +1123,7 @@ def sync_workdir(self, handle: ResourceHandle, workdir: Path) -> None:\n f'Symlink contents are not uploaded.{style.RESET_ALL}')\n self._rsync_up(handle,\n ip=ip,\n- source=f'{workdir}',\n+... | 2dbc50f7ca73f658c0f30c16671955e97c23c6de | diff --git a/examples/using_file_mounts.yaml b/examples/using_file_mounts.yaml
index f0c1170e02c..f33e0491ce0 100644
--- a/examples/using_file_mounts.yaml
+++ b/examples/using_file_mounts.yaml
@@ -44,11 +44,11 @@ file_mounts:
#
# After syncing the target will be:
#
- # /tmp/data/
+ # /tmp/workdir/
# a/
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-460@49aee38 | skypilot-org/skypilot | Python | 460 | [Azure] Downgrade the image version for K80 instances | Fixes #449 and probably closes #133
I found that the MS-DSVM image v21.08.30 uses NVIDIA driver 470, which does not incur the GPU loading error on Ubuntu machines. Let's use this version of image until Azure releases a new fixed image for K80.
| 2022-02-26T23:44:26Z | Azure K80 provision fails
Azure will raise the following error when launching an instance with K80. We may need to update the `azure-ray.yml.j2` to avoid this error.
```bash
Exception Details: (BadRequest) {
"error": {
"code": "BadRequest",
"message": "The selected VM size 'Standard_NC6_Promo' cannot ... | +1, have noticed this as well.
Found some related discussion
https://docs.microsoft.com/en-us/answers/questions/658624/nc6-dsvm-ubuntu-1804-gen-1-nvidia-smi-has-failed-b.html
looks like DSVM image is broken on K80.
One possible quick workaround is downgrading the Nvidia driver by executing:
```bash
sudo apt purge l... | [
{
"body": "Azure will raise the following error when launching an instance with K80. We may need to update the `azure-ray.yml.j2` to avoid this error.\r\n```bash\r\nException Details:\t(BadRequest) {\r\n\t \"error\": {\r\n\t \"code\": \"BadRequest\",\r\n\t \"message\": \"The selected VM size 'Standard_NC... | 03ef9fa7b00e07e20925eba3a0cd0af6407d4ad4 | {
"head_commit": "49aee38cfbc7dab4889e12a42205e6e3cf17db54",
"head_commit_message": "Remove a reference link",
"patch_to_review": "diff --git a/sky/clouds/azure.py b/sky/clouds/azure.py\nindex f66460bccf4..68f87fa3641 100644\n--- a/sky/clouds/azure.py\n+++ b/sky/clouds/azure.py\n@@ -79,8 +79,21 @@ def _get_image_... | [
{
"diff_hunk": "@@ -79,8 +79,21 @@ def _get_image_config(cls, gen_version, instance_type):\n 'image_version': '21.11.04'\n }\n \n- # ubuntu-2004 does not work on A100\n+ # ubuntu-2004 v21.10.21 and v21.11.04 do not work on K80\n+ # due to an NVIDIA driver issue.\n ... | 82ff236fee01795d90d0eacd7d70e7d5642079cf | diff --git a/sky/clouds/azure.py b/sky/clouds/azure.py
index f66460bccf4..a461ecbbc88 100644
--- a/sky/clouds/azure.py
+++ b/sky/clouds/azure.py
@@ -70,8 +70,7 @@ def get_default_instance_type(cls):
# 8 vCpus, 32 GB RAM. Prev-gen (as of 2021) general purpose.
return 'Standard_D8_v4'
- @classmeth... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
skypilot-org__skypilot-440@bb79b61 | skypilot-org/skypilot | Python | 440 | [Storage/File Mount] Check `workdir` and Filemount `src` Size | Solves Issue #391. Checks the size of `workdir` (without recursive tracking) and warns the user if the work directory is too big
<img width="1269" alt="Screen Shot 2022-02-24 at 12 20 09 AM" src="https://user-images.githubusercontent.com/20640975/155485642-e0eab110-a628-4d2d-8eff-8d4f3ad66d1c.png">
. | 2022-02-24T08:20:21Z | [Storage] Large Dataset inside `workdir`
In some cases, users will have the entire dataset e.g. `/tmp/imagenet` in their work directory! This is extremely bad since syncing the work directory will hanging if the dataset is big.
Potential Fix: Some mechanism to determine the size of the workdir and throw warning if ... | The first suggested fix seems reasonable for now (we should also explicitly mention in documentation the limitations of the `workdir` in terms of size and to never put large datasets there).
The second suggestion (Sky automatically managing big folders and moving to S3/GCS) is interesting! I can imagine that this wi... | [
{
"body": "In some cases, users will have the entire dataset e.g. `/tmp/imagenet` in their work directory! This is extremely bad since syncing the work directory will hanging if the dataset is big. \r\n\r\nPotential Fix: Some mechanism to determine the size of the workdir and throw warning if workdir is too big... | bfd93f9c9d1c5b32fecc2e03e57e258ebebb6c7e | {
"head_commit": "bb79b61dec2deeea45c1c3afd9a24e4bc957fb6d",
"head_commit_message": "Done",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex fb512b20bd5..e0c284f19cc 100644\n--- a/sky/backends/cloud_vm_ray_backend.py\n+++ b/sky/backends/cloud_vm_r... | [
{
"diff_hunk": "@@ -1104,18 +1110,28 @@ def sync_workdir(self, handle: ResourceHandle, workdir: Path) -> None:\n style = colorama.Style\n ip_list = self._get_node_ips(handle.cluster_yaml, handle.launched_nodes)\n full_workdir = os.path.abspath(os.path.expanduser(workdir))\n+\n+ # ... | 6abbf9d6287cd9fa960a2d26beaca18025f5d777 | diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py
index fb512b20bd5..71fd0a6b770 100644
--- a/sky/backends/cloud_vm_ray_backend.py
+++ b/sky/backends/cloud_vm_ray_backend.py
@@ -39,6 +39,7 @@
Path = str
PostSetupFn = Callable[[str], Any]
+SKY_DIRSIZE_WARN_THRESHOLD = 100
SKY_... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-454@33a81ca | skypilot-org/skypilot | Python | 454 | Fix delayed logs of `sky logs` locally vs `tail -f` remotely | Closes #451
The previous delay can be as large as 5 minutes. I did the following changes to optimize the situation.
1. ~~Using the `ray job logs` instead of our self-implemented busy for loop for tailing the log file. (`ray job` API has a shorter calling path)~~ I have to bring back our own log tailing function, s... | 2022-02-25T07:58:42Z | `sky logs` has large delay compares to the real logs
This is an observation from @dhroth where the `sky logs` has a large delay of the actual log written in the `sky_logs/` folder. By experiments with the `resnet_app.yaml` with the `train_steps=25000`. It has up to 5-minute delay of the logs between `sky logs ` and the... | [
{
"body": "This is an observation from @dhroth where the `sky logs` has a large delay of the actual log written in the `sky_logs/` folder. By experiments with the `resnet_app.yaml` with the `train_steps=25000`. It has up to 5-minute delay of the logs between `sky logs ` and the real logs. It seems like the prob... | 0d86924848849d6043625de5d5469b8ba243b8f8 | {
"head_commit": "33a81cae3c1b7b2954feecd4b88ecbf807f275df",
"head_commit_message": "Move back to run_with_log",
"patch_to_review": "diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py\nindex c37e9ad2327..8a92bc045c2 100644\n--- a/sky/backends/backend_utils.py\n+++ b/sky/backends/backend_ut... | [
{
"diff_hunk": "@@ -89,18 +88,21 @@ def run_with_log(\n check: bool = False,\n shell: bool = False,\n with_ray: bool = False,\n+ output_only: bool = False,\n **kwargs,\n ) -> Union[None, Tuple[subprocess.Popen, str, str]]:\n \"\"\"Runs a command and logs its output to a file.\n \n Ret... | fac312bf8be1fda95fe2444093db3bf8a5fc0793 | diff --git a/sky/backends/backend_utils.py b/sky/backends/backend_utils.py
index 14eb8fade6f..117209b6001 100644
--- a/sky/backends/backend_utils.py
+++ b/sky/backends/backend_utils.py
@@ -602,6 +602,8 @@ def run_command_on_ip_via_ssh(
# Advanced options.
require_outputs: bool = False,
log_path: str = '/... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-559@d9fc612 | skypilot-org/skypilot | Python | 559 | Fix prompt, add fallback retry for INIT cluster | Closes #514.
Main changes:
1. Remove the prompt of creating new cluster confirmation, when the previous cluster is in INIT mode.
2. Launching cluster in INIT mode will first retry the previous region/zone and launched_resources. If that fails, sky will try to launch the cluster of the current resources requirement... | 2022-03-13T22:46:48Z | Fix sky check showing AWS:enabled even when `aws configure` is not run
`sky check` incorrectly showed that AWS was available to use but an extra `aws configure` was required for Sky to actually view that AWS is available and include it in optimizer/provisioner. | Additionally, we should be more obvious in documentation that Sky checks credentials _automatically_
Investigation below -- I'm not sure why this bug was encountered in Kevin's session.
Around 24min into the video:
- We see `AWS: enabled`, which [means](https://github.com/s... | [
{
"body": "`sky check` incorrectly showed that AWS was available to use but an extra `aws configure` was required for Sky to actually view that AWS is available and include it in optimizer/provisioner.",
"number": 514,
"title": "Fix sky check showing AWS:enabled even when `aws configure` is not run"
}... | 005a6b21457c3e25f927adc4bc75640f6fdd3694 | {
"head_commit": "d9fc6127c6d5cfbff7796053d23544e12bc49f84",
"head_commit_message": "remove assert",
"patch_to_review": "diff --git a/sky/backends/cloud_vm_ray_backend.py b/sky/backends/cloud_vm_ray_backend.py\nindex d0f4c2442f3..6d163d51660 100644\n--- a/sky/backends/cloud_vm_ray_backend.py\n+++ b/sky/backends/c... | [
{
"diff_hunk": "@@ -612,6 +629,12 @@ def _yield_region_zones(self, to_provision: Resources, cluster_name: str):\n \n raise exceptions.ResourcesUnavailableError(message,\n no_retry=True)\n+ assert cluster_status == global_user_... | d68435c0ba3eb3398752366a128182dad77daefd | diff --git a/examples/run_smoke_tests.sh b/examples/run_smoke_tests.sh
index b5a59c63599..b236925ab43 100755
--- a/examples/run_smoke_tests.sh
+++ b/examples/run_smoke_tests.sh
@@ -17,7 +17,7 @@ sky down -y min &
time sky launch -y -c env "$DIR"/env_check.yaml
sky down -y env &
-touch ~/tempfile
+touch ~/tmpfile
m... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-432@3434de3 | skypilot-org/skypilot | Python | 432 | Centralize sky_logs, polish logging, and update `sky start` documentation | Closes #406. | 2022-02-24T00:13:05Z | `sky_logs/` should be put at a central place, not under current working directory
Central place can be, for example, `~/sky_logs/<unique across user/run>` or `/tmp/sky_logs/<unique across user/run>`. This avoids polluting many directories.
+1: @romilbhardwaj, me
systems that use this strategy: Ray, Spark, ... | Another example where this is a blocker is when I run sky cpunode/gpunode in a path where I don't have permissions (e.g. `/`) - sky fails because it's unable to create `sky_logs` dir.
+1. We could put this under `~/.sky/logs` or `~/sky_logs` (like Slurm) and make `sky logs` the main entry point for accessing all sky-re... | [
{
"body": "Central place can be, for example, `~/sky_logs/<unique across user/run>` or `/tmp/sky_logs/<unique across user/run>`. This avoids polluting many directories.\r\n\r\n+1: @romilbhardwaj, me\r\n\r\nsystems that use this strategy: Ray, Spark, ...",
"number": 406,
"title": "`sky_logs/` should be ... | 9609d4310174f454cc7ec8b077a2730fbf36f04d | {
"head_commit": "3434de37ed7c5325bcdd046a29a67cc1d50d1907",
"head_commit_message": "fix verb",
"patch_to_review": "diff --git a/docs/source/reference/interactive-nodes.rst b/docs/source/reference/interactive-nodes.rst\nindex 78d7ca130ee..3d80856c412 100644\n--- a/docs/source/reference/interactive-nodes.rst\n+++ ... | [
{
"diff_hunk": "@@ -812,11 +814,20 @@ def ray_up(start_streaming_at):\n public_key_path = config['auth']['ssh_public_key']\n file_mounts[public_key_path] = public_key_path\n \n- with console.status('[bold cyan]Starting cluster...'):\n+ region_name = logging_info['region_nam... | 9acb36e7f09ed73ae2884ef3508f236aeb4dd663 | diff --git a/docs/source/reference/interactive-nodes.rst b/docs/source/reference/interactive-nodes.rst
index 78d7ca130ee..3d80856c412 100644
--- a/docs/source/reference/interactive-nodes.rst
+++ b/docs/source/reference/interactive-nodes.rst
@@ -58,6 +58,12 @@ Interactive nodes can be started and stopped like any other ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
skypilot-org__skypilot-415@c245e23 | skypilot-org/skypilot | Python | 415 | Update documentation with provisioning quickstart | Adds new subsection to quickstart with provisioning introduction and addresses issues found during first user onboarding. | 2022-02-22T23:52:50Z | [Storage] User tends to use the default file_mounts
Though we support cloud storage for large files, the user tends to use the default one. The reasons might be the following:
1. The default file_mounts is more intuitive.
2. We do not have a good doc to guide the user using cloud storage.
A quick fix could be find... | Note, however, object stores are not a panacea and may surface other issues:
1. It costs money & the cleanups may not be automatic
2. It can run into bucket name conflicts, which will fail the setup.
3. Cloud storage is much more complex than rsync - there must be many error messages we're not handling (ACL, bucket ... | [
{
"body": "Though we support cloud storage for large files, the user tends to use the default one. The reasons might be the following:\r\n1. The default file_mounts is more intuitive.\r\n2. We do not have a good doc to guide the user using cloud storage.\r\n\r\nA quick fix could be finding a better place (maybe... | 8d17229395f2d9e2e45d9062403c0e0078c9f7a0 | {
"head_commit": "c245e236625bdce018150e28eea539c0931feaf6",
"head_commit_message": "transfer artifacts",
"patch_to_review": "diff --git a/README.md b/README.md\nindex 2952926e930..d4a1bc55e79 100644\n--- a/README.md\n+++ b/README.md\n@@ -40,7 +40,7 @@ Please refer to our [documentation](https://sky-proj-sky.read... | [
{
"diff_hunk": "@@ -19,19 +19,46 @@ Key Features\n - **No cloud lock-in** - transparently run your code across AWS, Google Cloud, and Azure\n \n \n+Provisioning your first cluster\n+--------------------------------\n+We'll start by launching our first cluster on Sky using an interactive node.\n+Interactive node... | 1add56a5ff11eddfc1aba2a77f874d8b25b68147 | diff --git a/README.md b/README.md
index 2952926e930..d4a1bc55e79 100644
--- a/README.md
+++ b/README.md
@@ -40,7 +40,7 @@ Please refer to our [documentation](https://sky-proj-sky.readthedocs-hosted.com/
# Clone the sky codebase
git clone ssh://git@github.com/sky-proj/sky.git
cd sky
-# Sky requires python >= 3.6.
+#... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Documentation Updates"
} |
skypilot-org__skypilot-333@fdf2402 | skypilot-org/skypilot | Python | 333 | Terminate stopped gcp instances | Fixed #318.
Tested:
- [x] `sky launch -c min --cloud gcp examples/env_check.yaml; sky stop min; sky down min` | 2022-02-15T19:55:01Z | Sky down not working for stopped GCP
Ray is buggy for deleting stopped clusters of all clouds. We call the `awscli` for AWS to solve the problem. For now we just skip the stopped GCP clusters during terminating, we need to support deleting them as well.
To repro
```bash
sky launch --cloud GCP -c debug examples/min... | [
{
"body": "Ray is buggy for deleting stopped clusters of all clouds. We call the `awscli` for AWS to solve the problem. For now we just skip the stopped GCP clusters during terminating, we need to support deleting them as well.\r\n\r\nTo repro\r\n```bash\r\nsky launch --cloud GCP -c debug examples/minimal.yaml ... | addcaac47696eab82aae0694d7471ad3a6623e50 | {
"head_commit": "fdf24022315ea0798083f57e769a7f0d404b69d4",
"head_commit_message": "lint",
"patch_to_review": "diff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py\nindex ff0b66967de..325b9153d97 100644\n--- a/prototype/sky/backends/cloud_vm_ray_backend.py\... | [
{
"diff_hunk": "@@ -1591,7 +1601,7 @@ def teardown(self, handle: ResourceHandle, terminate: bool) -> None:\n # TODO(suquark,zongheng): Support deleting stopped GCP clusters.\n # Tracked in issue #318.\n logger.info(\n- f'Cannot terminate GCP clu... | a0cfa5a36d3b44756afd8116158bebd5f79cb084 | diff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py
index ff0b66967de..619b561eb3a 100644
--- a/prototype/sky/backends/cloud_vm_ray_backend.py
+++ b/prototype/sky/backends/cloud_vm_ray_backend.py
@@ -1580,6 +1580,16 @@ def teardown(self, handle: ResourceHandle, t... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} | |
skypilot-org__skypilot-308@c998f04 | skypilot-org/skypilot | Python | 308 | Optimize sky cli | **10x** the sky cli loading speed: ~3.6s -> ~0.36s
The most time consuming pkgs:
```
pandas
ray
networkx
docker
oauth2client
```
Closes #204 | 2022-02-12T08:27:52Z | Hide imports in Sky cli to improve loading speed
Top level imports in Sky cli slows down loading speed. ~Fixing it is not of high priority.~ I do feel it is a bit slow to respond when `sky --help`. However, we need to make sure the slow down is caused by importing modules. | +1, this would be nice
```bash
» time sky status
NAME LAUNCHED RESOURCES COMMAND STATUS
debug 2 days ago 1x AWS(m4.2xlarge) sky launch -c debug examples/minimal.yaml UP
status() 0.0012319087982177734
sky status 1.62s user 0.28s system 121% cpu 1.566 total
```... | [
{
"body": "Top level imports in Sky cli slows down loading speed. ~Fixing it is not of high priority.~ I do feel it is a bit slow to respond when `sky --help`. However, we need to make sure the slow down is caused by importing modules.",
"number": 204,
"title": "Hide imports in Sky cli to improve loadin... | c63a71bf24453d1c76d2a575e4bae88bfe66a61a | {
"head_commit": "c998f04bbc9c6ae97ec29d0ab6d52a52d7fdb43e",
"head_commit_message": "fix",
"patch_to_review": "diff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py\nindex 160bf737822..36b48aff88c 100644\n--- a/prototype/sky/backends/cloud_vm_ray_backend.py\n... | [
{
"diff_hunk": "@@ -0,0 +1,23 @@\n+\"\"\"Docker adaptors\"\"\"\n+\n+# pylint: disable=import-outside-toplevel\n+\n+\n+def from_env():\n+ import docker",
"line": null,
"original_line": 7,
"original_start_line": null,
"path": "prototype/sky/docker_adaptor.py",
"start_line": null,
"text"... | 82165bcad0348e81eefe6da48157dc69f25cc543 | diff --git a/prototype/sky/backends/cloud_vm_ray_backend.py b/prototype/sky/backends/cloud_vm_ray_backend.py
index 160bf737822..c18f2737433 100644
--- a/prototype/sky/backends/cloud_vm_ray_backend.py
+++ b/prototype/sky/backends/cloud_vm_ray_backend.py
@@ -15,7 +15,6 @@
from typing import Any, Callable, Dict, List, Op... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Performance Optimizations"
} |
skypilot-org__skypilot-326@238f07b | skypilot-org/skypilot | Python | 326 | Keep wheels build up-to-date | Actual testing is by manually launching and ssh into the cluster to see if the installed sky get updated.
A simplified testing procedure:
1. Under the directory containing `setup.py`, run `pip wheel --no-deps . --wheel-dir /tmp`. This generates the wheel `/tmp/sky-*.whl`
2. Use `unzip` command to see the content... | 2022-02-14T22:31:33Z | `sky launch` on existing cluster will not update the `ray_patches`
I am editing the files in skylet/ray_patches, but it seems we will not update the `ray_patches`. Do you have any idea of how to solve this @suquark ?
Ensure `sky launch` update skylet code on an existing cluster
@Michaelvll @suquark @infwinston | related to #260 | [
{
"body": "I am editing the files in skylet/ray_patches, but it seems we will not update the `ray_patches`. Do you have any idea of how to solve this @suquark ?",
"number": 260,
"title": "`sky launch` on existing cluster will not update the `ray_patches`"
},
{
"body": "@Michaelvll @suquark @infw... | ae85360d055cb930cc60bdddbe7ec428f294ca66 | {
"head_commit": "238f07b470eb6462e4027f91cda66ac78b0b5f7c",
"head_commit_message": "keep wheels build up-to-date",
"patch_to_review": "diff --git a/prototype/config/aws-ray.yml.j2 b/prototype/config/aws-ray.yml.j2\nindex 23e10f8b61f..4c6f4b1a989 100644\n--- a/prototype/config/aws-ray.yml.j2\n+++ b/prototype/conf... | [
{
"diff_hunk": "@@ -95,7 +95,7 @@ setup_commands:\n # This AMI's system Python is version 2+.\n # _gang_schedule_ray_up() requires first two lines; do not modify.\n - pip3 install -U ray[default]=={{ray_version}} && mkdir -p ~/sky_workdir && mkdir -p ~/.sky/sky_app && touch ~/.sudo_as_admin_successful\n- ... | 61a919192f79445ca5c0962961d6c4d00029a6c9 | diff --git a/prototype/config/aws-ray.yml.j2 b/prototype/config/aws-ray.yml.j2
index 23e10f8b61f..4c6f4b1a989 100644
--- a/prototype/config/aws-ray.yml.j2
+++ b/prototype/config/aws-ray.yml.j2
@@ -89,7 +89,7 @@ setup_commands:
# This AMI's system Python is version 2+.
# _gang_schedule_ray_up() requires first two ... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-301@da36821 | skypilot-org/skypilot | Python | 301 | Clean up generated config and scripts on cluster termination | Closes #264
## Tested
```
sky tpunode
sky down sky-tpunode-gautam # cleanup
sky cpunode
sky stop sky-cpunode-gautam
sky start sky-cpunode-gautam
sky down sky-cpunode-gautam # clean up
``` | 2022-02-11T07:35:36Z | Placement and cleanup of generated cluster configs (`config/user/`)
Issue: A generated cluster config should be removed on `sky down` / `backend.teardown(terminate=True)`
To discuss: `<sky package dir>/config/user/` is currently used; but should probably (?) be changed to, say, `~/.sky/...`.
- Pro: it seems wei... | I think it makes sense to move to `~/.sky/...` since all our other user state lives there. We also don't really want users interacting with the `state.db` and `jobs.db` stored there (even though they could), so not sure if putting things in `.sky` necessarily encourages user interaction.
I would encourage the move t... | [
{
"body": "Issue: A generated cluster config should be removed on `sky down` / `backend.teardown(terminate=True)`\r\n\r\nTo discuss: `<sky package dir>/config/user/` is currently used; but should probably (?) be changed to, say, `~/.sky/...`. \r\n - Pro: it seems weird to have a pip package dir growing in siz... | 27ef21ad98cafad875e97ae9eae22479cb77c505 | {
"head_commit": "da368211aef8ee9b43b63c490b7362bf316e0ecf",
"head_commit_message": "clean up on terminate",
"patch_to_review": "diff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\nindex fd798cd4114..10e389d5b5b 100644\n--- a/prototype/sky/backends/backend_utils.py\n+++... | [
{
"diff_hunk": "@@ -1547,6 +1552,19 @@ def teardown(self, handle: ResourceHandle, terminate: bool) -> None:\n auth_config = backend_utils.read_yaml(handle.cluster_yaml)['auth']\n _remove_cluster_from_ssh_config(handle.head_ip, auth_config)\n name = global_user_state.get_cluster_name_from... | 959d38b34b121d4eb1ccce99f49edd93ccaee4e5 | diff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py
index fd798cd4114..10e389d5b5b 100644
--- a/prototype/sky/backends/backend_utils.py
+++ b/prototype/sky/backends/backend_utils.py
@@ -47,12 +47,6 @@
run_with_log = log_lib.run_with_log
-def get_rel_path(path: str) -> str... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-285@ec83ebe | skypilot-org/skypilot | Python | 285 | Fix the scale down problem with sky launch | This PR aims to fix #270, where `sky launch` with a task with smaller `num_nodes` on a cluster will scale down the cluster. It also, fix the problem of `sky logs --sync-down`, where previously the log_path gotten from the remote machine has an additional `\n`.
Tested:
- [x] `sky launch -c sc examples/source_check.y... | 2022-02-09T01:00:14Z | `sky launch` task with fewer num_nodes on existing cluster scales down the cluster
`sky launch -c test launch.yaml` creates 4 nodes, but if we do `sky launch -c test task.yaml`, the cluster will be scaled down to 1 node. That may not be the expected behavior, since the user may only want to run the setup on the 4-node ... | [
{
"body": "`sky launch -c test launch.yaml` creates 4 nodes, but if we do `sky launch -c test task.yaml`, the cluster will be scaled down to 1 node. That may not be the expected behavior, since the user may only want to run the setup on the 4-node cluster. \r\n\r\nProposed behavior: when launching a task with f... | 1856caee9c4c19a16b76c993da670af3278ba95f | {
"head_commit": "ec83ebe1d732c74c072f05de07de13decd4595eb",
"head_commit_message": "Format",
"patch_to_review": "diff --git a/prototype/sky/backends/backend.py b/prototype/sky/backends/backend.py\nindex d2d4a52517e..305d0ba3572 100644\n--- a/prototype/sky/backends/backend.py\n+++ b/prototype/sky/backends/backend... | [
{
"diff_hunk": "@@ -946,7 +947,8 @@ def _filter(name, all_clusters):\n dummy_task.num_nodes = handle.launched_nodes\n click.secho(f'Starting cluster {name}...', bold=True)\n backend.provision(dummy_task,\n- to_provision=None,\n+ to_pr... | a5fdaf74a6da9055ae0f9b543960c6aaabbe740a | diff --git a/prototype/sky/backends/backend.py b/prototype/sky/backends/backend.py
index d2d4a52517e..7d3160589b6 100644
--- a/prototype/sky/backends/backend.py
+++ b/prototype/sky/backends/backend.py
@@ -45,8 +45,8 @@ def sync_file_mounts(
def add_storage_objects(self, task: Task) -> None:
raise NotImple... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} | |
skypilot-org__skypilot-278@f18e46c | skypilot-org/skypilot | Python | 278 | Move user files to ~/.sky | Keeps all sky related files in `~/.sky` (like `.aws`). Closes #10
### Tested
- Launching a new cpunode and logging in | 2022-02-08T06:54:52Z | Move local Sky keys/files/metadata to ~/.sky
Makes uninstallation easier and keeps things organized. Maybe not a huge deal, but as a user I feel a bit weird having a Sky app create and save a new SSH key under `~/.ssh/sky-key` without me knowing.
Placement and cleanup of generated cluster configs (`config/user/`)
Issu... | Seconded
Ray autoscaler makes keys for the user too, just that the key is different across clouds. A temporary fix for this is just to add a log saying that Sky will create `sky-key` for them if the key is not specified.
Didn't know Ray did this as well. I'm wondering if there's a key design choice (no pun intended) he... | [
{
"body": "Makes uninstallation easier and keeps things organized. Maybe not a huge deal, but as a user I feel a bit weird having a Sky app create and save a new SSH key under `~/.ssh/sky-key` without me knowing.",
"number": 10,
"title": "Move local Sky keys/files/metadata to ~/.sky"
},
{
"body"... | 394afd93c85f42151e13bdee8dab1c45c35671f7 | {
"head_commit": "f18e46cf1c7553047d4c7e80936f92d2e1b1057d",
"head_commit_message": "fix long line",
"patch_to_review": "diff --git a/prototype/sky/authentication.py b/prototype/sky/authentication.py\nindex 48750ee5afa..442bda67ad5 100644\n--- a/prototype/sky/authentication.py\n+++ b/prototype/sky/authentication.... | [
{
"diff_hunk": "@@ -487,10 +488,11 @@ def write_cluster_config(task: task_lib.Task,\n 'tpu_name': tpu_name,\n }),\n # Use new names for TPU scripts so that different runs can use\n- # different TPUs. Put in config/user/ to be consistent with\n-... | 85e5932e8a71a095c30096e8abd5b30a4468d8d8 | diff --git a/prototype/sky/authentication.py b/prototype/sky/authentication.py
index 48750ee5afa..442bda67ad5 100644
--- a/prototype/sky/authentication.py
+++ b/prototype/sky/authentication.py
@@ -20,6 +20,7 @@
# development.
MAX_TRIALS = 64
+PRIVATE_SSH_KEY_PATH = '~/.ssh/sky-key'
def generate_rsa_key_pair():... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Code Refactoring / Architectural Improvement"
} |
skypilot-org__skypilot-368@558522e | skypilot-org/skypilot | Python | 368 | Fix assertion on Azure's A100/V100 and fuzzy resource search | Fixes https://github.com/sky-proj/sky/issues/367. @gmittal | 2022-02-18T09:31:27Z | Fuzzy resource search
I type something like this: `sky gpunode --cloud azure --gpus A100`, but sky throws an exception (as expected, since this not a valid configuration). It would be really nice to show some kind of "nearest neighbor" resource that is valid and still accomplishes my goal of launching an A100 instance ... | Fixing it now. | [
{
"body": "I type something like this: `sky gpunode --cloud azure --gpus A100`, but sky throws an exception (as expected, since this not a valid configuration). It would be really nice to show some kind of \"nearest neighbor\" resource that is valid and still accomplishes my goal of launching an A100 instance o... | f212f1e4598f4f187ab7bf711d0585a8b5af358e | {
"head_commit": "558522ebac14d9bc104cf7a7a85ad1e5e70d895e",
"head_commit_message": "Fix assertion on Azure's A100/V100",
"patch_to_review": "diff --git a/sky/clouds/service_catalog/common.py b/sky/clouds/service_catalog/common.py\nindex 4ab38819633..e4684c7d96e 100644\n--- a/sky/clouds/service_catalog/common.py\... | [
{
"diff_hunk": "@@ -95,11 +95,17 @@ def get_instance_type_for_accelerator_impl(\n # and count. Throw so we can manually investigate. The current\n # whitelist consists of:\n if len(instance_types) == 2:\n+ # FIXME: refactor below implementation\n # - M60, offered b... | a450a1e4edfc964c3cc9ee577e53162341441a0d | diff --git a/sky/cli.py b/sky/cli.py
index c58985bc593..d85d5545533 100644
--- a/sky/cli.py
+++ b/sky/cli.py
@@ -106,6 +106,15 @@ def _parse_accelerator_options(accelerator_options: str) -> Dict[str, float]:
return accelerators
+def _get_cloud(cloud: str) -> Optional[clouds.Cloud]:
+ """Check if cloud is re... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-235@0bb5938 | skypilot-org/skypilot | Python | 235 | Fix defunct job after cancelling | We are currently using `subprocess` to run the command line. The child process may be defunct when the python program is killed. Fixed by creating a subprocess to kill the defuncted child process with `try ... finally`. Fixed #233
Tested:
1. Launch a cluster with `sky launch -c test ./examples/job_queue/cluster.ya... | 2022-01-22T23:04:46Z | Failed to kill a sky job with sky cancel
I failed to cancel my job with `sky cancel`. I had to manually ssh in and kill it.
@Michaelvll have you met this issue before?
```
(sky) weichiang@blaze:~/repos/bert-sign/sky-experiments/prototype/examples$ sky cancel -c sky-2920-weichiang 9
Cancelling jobs (9) on cluster sk... | Yeah, that happens to me sometimes. Is it possible to create a small reproduction code? I suspect it is caused by the ray's stale actors. | [
{
"body": "I failed to cancel my job with `sky cancel`. I had to manually ssh in and kill it.\r\n@Michaelvll have you met this issue before?\r\n```\r\n(sky) weichiang@blaze:~/repos/bert-sign/sky-experiments/prototype/examples$ sky cancel -c sky-2920-weichiang 9\r\nCancelling jobs (9) on cluster sky-2920-weichia... | 95a90955f9c8bf6deae1520e208a350caa1f2b0f | {
"head_commit": "0bb5938b22cfcfee6cbe904519ccf1aa8f1a6a07",
"head_commit_message": "Change comment",
"patch_to_review": "diff --git a/prototype/examples/job_queue/job_gpu.yaml b/prototype/examples/job_queue/job_gpu.yaml\nnew file mode 100644\nindex 00000000000..985847b68cd\n--- /dev/null\n+++ b/prototype/example... | [
{
"diff_hunk": "@@ -76,18 +76,35 @@ def run_with_log(\n Retruns the process, stdout and stderr of the command.\n Note that the stdout and stderr is already decoded.\n \"\"\"\n- with subprocess.Popen(cmd,\n- stdout=subprocess.PIPE,\n- stderr=subp... | 754b78fffde75ee59e97ddfb46e937256579c20b | diff --git a/prototype/examples/job_queue/job_gpu.yaml b/prototype/examples/job_queue/job_gpu.yaml
new file mode 100644
index 00000000000..985847b68cd
--- /dev/null
+++ b/prototype/examples/job_queue/job_gpu.yaml
@@ -0,0 +1,28 @@
+# A task submitted to an existing cluster.
+#
+# Runs a task on a existing cluster.
+#
+#... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-211@8413579 | skypilot-org/skypilot | Python | 211 | Fix git SSH agent forwarding issues | Polishing SSH and git functionality.
### Tests
```
class c1:
name = 'cluster1'
ip = '127.0.0.1'
auth_config = {'ssh_user': 'ubuntu', 'ssh_private_key': '~/.ssh/id_rsa'}
class c2:
name = 'cluster2'
ip = '127.0.0.2'
auth_config = {'ssh_user': 'ubuntu', 'ssh_private_key': '~/.ssh/id_rsa'}
clas... | 2022-01-18T09:15:05Z | git credential forwarding doesn't work for https auth
Many users use `gh auth login` to authenticate with github and cache their git credentials locally. This uses https instead of ssh for git authentication.
Current git credential forwarding in sky supports forwarding only ssh credentials. Is there some way we can... | HTTPS host forwarding doesn't seem to be documented anywhere by GitHub, so for now we'll have to require that if users want git to magically work on their remote VMs they're going to need to have an SSH key set up locally. `gh auth login` supports SSH setup quite easily in their login flow, including creating a new key... | [
{
"body": "Many users use `gh auth login` to authenticate with github and cache their git credentials locally. This uses https instead of ssh for git authentication. \r\n\r\nCurrent git credential forwarding in sky supports forwarding only ssh credentials. Is there some way we can add support for forwarding htt... | df228f88146aef3aff343f306501b1304a20794b | {
"head_commit": "8413579bbfe539a3b6170f32e3f2c277c2cd037f",
"head_commit_message": "Fix remove lines",
"patch_to_review": "diff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\nindex 3be7672af58..eba2634e082 100644\n--- a/prototype/sky/backends/backend_utils.py\n+++ b/pr... | [
{
"diff_hunk": "@@ -293,9 +300,52 @@ def remove_cluster(cls, ip: str, auth_config: Dict[str, str]):\n cursor += 1\n \n # Remove sky-generated config and update the file.\n- config[start_line_idx:end_line_idx] = []\n+ config[prev_end_line_idx:end_line_idx] = [\n+ '\\n... | 86e1dbbe2c0e1f48b6ce1ca2a67f3d989d010252 | diff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py
index 3be7672af58..bcf7bd3971c 100644
--- a/prototype/sky/backends/backend_utils.py
+++ b/prototype/sky/backends/backend_utils.py
@@ -178,8 +178,9 @@ def _get_generated_config(cls, autogen_comment: str, host_name: str,
... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
skypilot-org__skypilot-163@b791373 | skypilot-org/skypilot | Python | 163 | Catch resource demands (accelerators) inconsistent with instance type. | Fixes #154.
Tested
- new unit tests
- `sky gpunode -t p3.2xlarge --gpus=K80 --cloud aws` correctly fails with the new error
- `sky gpunode -t p3.2xlarge --gpus=V100 --cloud aws` works
- `sky gpunode -t p3dn.24xlarge --cloud aws` works | 2022-01-11T02:31:56Z | accelerators_to_hourly_cost prevents gpunode with user-specified instance type
```
❯ sky gpunode -t p3dn.24xlarge --cloud aws
I 01-08 14:18:15 optimizer.py:206] Defaulting estimated time to 1 hr. Call Task.set_time_estimator() to override.
Traceback (most recent call last):
File "/Users/gautam/miniconda3/envs/sky... | [
{
"body": "```\r\n❯ sky gpunode -t p3dn.24xlarge --cloud aws\r\nI 01-08 14:18:15 optimizer.py:206] Defaulting estimated time to 1 hr. Call Task.set_time_estimator() to override.\r\nTraceback (most recent call last):\r\n File \"/Users/gautam/miniconda3/envs/sky/bin/sky\", line 33, in <module>\r\n sys.exit(lo... | d9cbd6c2dbe447cf6f865449170ef9096c8cdf50 | {
"head_commit": "b791373260c1ff5562c533565d57a40086216060",
"head_commit_message": "Fine tune a few things",
"patch_to_review": "diff --git a/prototype/examples/huggingface_glue_imdb_app.yaml b/prototype/examples/huggingface_glue_imdb_app.yaml\nindex 1e1ff257e9e..1d32d77c4d9 100644\n--- a/prototype/examples/hugg... | [
{
"diff_hunk": "@@ -77,6 +79,29 @@ def __repr__(self) -> str:\n def is_launchable(self) -> bool:\n return self.cloud is not None and self.instance_type is not None\n \n+ def _clear_redundant_accelerators_field(self) -> None:\n+ \"\"\"Try-clears any specified accelerators field for non-GCP.... | dcd6dca0b1d96b37118cd32608c629c901ca0898 | diff --git a/prototype/examples/huggingface_glue_imdb_app.yaml b/prototype/examples/huggingface_glue_imdb_app.yaml
index 1e1ff257e9e..1d32d77c4d9 100644
--- a/prototype/examples/huggingface_glue_imdb_app.yaml
+++ b/prototype/examples/huggingface_glue_imdb_app.yaml
@@ -25,5 +25,5 @@ run: |
--per_device_train_batch_... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} | |
espnet__espnet-2509@1a08dc0 | espnet/espnet | Python | 2,509 | Docker Updates | Updates on docker to fit the installation of ESpnet.
This will also fix PR #2508. | 2020-09-24T01:54:00Z | Docker build error
# error content
I got the error while building docker image
I run these commands.
- command
```
cd docker
./build.sh fully_local cpu
```
but the error was occared.
- the error sentence
```
Step 14/16 : RUN if [ -z "$( nvcc -V )" ]; then echo "Build without CUDA" && MY_OPTS... | @muramasa2 THe problem is that the docker was not updated for the new environment of ESPnet.
It has been new changes in the installation.
I will upload the fixes for all docker containers.
@Fhrozen I appreciate your support, thanks. | [
{
"body": "# error content\r\n I got the error while building docker image\r\nI run these commands.\r\n- command\r\n```\r\ncd docker\r\n./build.sh fully_local cpu\r\n```\r\nbut the error was occared.\r\n- the error sentence\r\n```\r\nStep 14/16 : RUN if [ -z \"$( nvcc -V )\" ]; then echo \"Build without... | 180af1103997d4eb42ece85cdb92b049db5570c7 | {
"head_commit": "1a08dc0415ea255b6614119628a8aff1b8830469",
"head_commit_message": "Update docker/prebuilt/devel/Dockerfile",
"patch_to_review": "diff --git a/docker/prebuilt/devel/Dockerfile b/docker/prebuilt/devel/Dockerfile\nindex 14d396ccd9b..55ddfdcdf90 100644\n--- a/docker/prebuilt/devel/Dockerfile\n+++ b/... | [
{
"diff_hunk": "@@ -22,24 +22,27 @@ RUN cd espnet && \\\n # Install espnet\n WORKDIR /espnet/tools\n \n-# Disable cupy test\n-# Docker build does not load libcuda.so.1\n # Replace nvidia-smi for nvcc because docker does not load nvidia-smi\n-RUN if [ -z \"$( nvcc -V )\" ]; then \\\n+RUN if [ -z \"$( which nvcc ... | 9b4da4b8fe6ed95e5c07a55b9e69eb75dc953f5e | diff --git a/docker/prebuilt/devel/Dockerfile b/docker/prebuilt/devel/Dockerfile
index 14d396ccd9b..55ddfdcdf90 100644
--- a/docker/prebuilt/devel/Dockerfile
+++ b/docker/prebuilt/devel/Dockerfile
@@ -18,21 +18,25 @@ WORKDIR /espnet/tools
# Disable cupy test
# Docker build does not load libcuda.so.1
# Replace nvidia... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Dependency Updates & Env Compatibility"
} |
skypilot-org__skypilot-49@1fa7fec | skypilot-org/skypilot | Python | 49 | Add logging for execution_v2 | Added the logging for the execution_v2 (as in #25 ). The behavior would be as follows:
1. All the provision information/task output will be written to files so that users can tail the files for the output.
2. If the `stream_logs` is set to true, the output provision logs will be streamed to the console if the `Shared... | 2021-11-20T09:46:02Z | Stream logs to files during VM provisioning and setup
Is it expected behavior that there is no output for VM setup during provisioning? I think it might be hard for the user to debug for the setup commends. Also, I failed to find the output anywhere as a file.
I am running `python ./examples/resnet_app.py`, and the ... | Yes, expected to not show, although we can change. The rationale is if you print ray up's stdout/stderr, and if you have retries, that will be very crowded. Give it a try by setting a p3.16x requirement.
We could try to write the stdout/stderr (captured in variables) to files. This is similar to V1's logging.
We ... | [
{
"body": "Is it expected behavior that there is no output for VM setup during provisioning? I think it might be hard for the user to debug for the setup commends. Also, I failed to find the output anywhere as a file.\r\n\r\nI am running `python ./examples/resnet_app.py`, and the output is as below.\r\n```\r\nI... | e6af21aa3a5a338a08a1eb6c0c199675ada014e2 | {
"head_commit": "1fa7fec10fe18aeee823e959fa2a58ca3b3423f5",
"head_commit_message": "Fix tail -f information for provision",
"patch_to_review": "diff --git a/prototype/sky/backends/backend.py b/prototype/sky/backends/backend.py\nindex 4a37b0ec685..0ec810d27dd 100644\n--- a/prototype/sky/backends/backend.py\n+++ b... | [
{
"diff_hunk": "@@ -424,10 +502,17 @@ def _execute_par_task(self, handle: ResourceHandle,\n if not stream_logs:\n logger.info(\n f'{Fore.CYAN}Logs will not be streamed (stream_logs=False).'\n- f'{Style.RESET_ALL} Hint: in the run command, redirect each'\n- ... | 6ea4acb77dab1264a687e47c28e13305173d9cad | diff --git a/prototype/sky/backends/backend.py b/prototype/sky/backends/backend.py
index 4a37b0ec685..0ec810d27dd 100644
--- a/prototype/sky/backends/backend.py
+++ b/prototype/sky/backends/backend.py
@@ -17,8 +17,8 @@ class Backend(object):
# Examples: 'cluster.yaml'; 'ray://...', 'k8s://...'.
ResourceHandle... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-90@aae9b98 | skypilot-org/skypilot | Python | 90 | [CLI] Add sky ssh and port-forwarding | #87
Enabled the cli:
1. Attach and port forwarding to cluster: `sky ssh -p <port1> -p <port2> cluster_name`
2. Port forwarding for gpu/cpunode: `sky gpunode -p <port1> -p <port2> `
3. `sky gpunode -c cluster_name` will carete the cluster with the name of cluster_name (rather than randomly generated one), if the... | 2021-12-05T05:02:59Z | `sky attach [--port-forward] <cluster_name>`
Can we have the CLI as the title?
Reason: The `sky status` only shows the <cluster_name>. If a user would like to connect to the cluster or do the port forwarding, they need to find the path of the config file by themselves. Directly using the `sky attach <cluster_name>` ... | Yes, either `sky attach` or `sky ssh`. Currently no one's working on it.
This will also help to expose less and less leaky messages (e.g., we
currently show "ray attach ..." and "sky down ..." as help messages).
On Sun, Dec 5, 2021 at 5:20 AM Zhanghao Wu ***@***.***> wrote:
> As the title.
>
> Reason: The sky status... | [
{
"body": "Can we have the CLI as the title?\r\n\r\nReason: The `sky status` only shows the <cluster_name>. If a user would like to connect to the cluster or do the port forwarding, they need to find the path of the config file by themselves. Directly using the `sky attach <cluster_name>` might be more intuitiv... | 837dcb8b3a02dc28f935e09c4da90551adcfff92 | {
"head_commit": "aae9b98c15c1d33328d03fddcdee5fa059464c68",
"head_commit_message": "Fix Ctrl-D error",
"patch_to_review": "diff --git a/prototype/sky/backends/backend_utils.py b/prototype/sky/backends/backend_utils.py\nindex c43d93e88f3..7144b014b30 100644\n--- a/prototype/sky/backends/backend_utils.py\n+++ b/pr... | [
{
"diff_hunk": "@@ -90,22 +93,27 @@ def _create_interactive_node(name,\n backend = backend()\n backend.register_info(dag=dag, optimize_target=sky.OptimizeTarget.COST)\n \n- dag = sky.optimize(dag, minimize=sky.OptimizeTarget.COST)\n- task = dag.tasks[0]\n-\n handle = cluster_handle\n if ha... | d274f46b64b992d68c0ccb3859d18e32a0c8516c | diff --git a/prototype/examples/jupyter_app.py b/prototype/examples/jupyter_app.py
index 4c6bb71f6d3..0e49b03b7ec 100644
--- a/prototype/examples/jupyter_app.py
+++ b/prototype/examples/jupyter_app.py
@@ -15,8 +15,8 @@ def make_application():
run = f'jupyter notebook --port 8888'
- # Use 'ray attach... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "New Feature Additions"
} |
skypilot-org__skypilot-68@82e94ab | skypilot-org/skypilot | Python | 68 | Support file_mounts destination paths that require root access. | Fixes #39.
Both these should now work:
```
/data/<25GB dir>: /data/<25GB dir>
/data/<25GB dir>: gs://<dir>
```
Added `examples/using_file_mounts.yaml` as a user guide.
- [x] test resnet_app file_mounts again | 2021-11-26T17:25:23Z | Error when creating directory during filemount
I specify file_mounts like below
```
file_mounts = {
'/data/weichiang/dataset/': '/data/weichiang/dataset/',
}
```
the autoscaler setup failed and I got the permission denied error.
```
mkdir: cannot create directory ‘/data’: Permission denied ... | file_mounts is synced before setup/init commands in autoscaler design: https://github.com/ray-project/ray/blob/333d0b43fdce13bc46b1f2b43d0b9f4d758ab1e9/python/ray/autoscaler/_private/updater.py#L349-L361
so unfortunately we can't sudo make that dir first before file_mounts are synced.
How about
```
file_mounts =... | [
{
"body": "I specify file_mounts like below\r\n```\r\nfile_mounts = {\r\n '/data/weichiang/dataset/': '/data/weichiang/dataset/',\r\n }\r\n```\r\nthe autoscaler setup failed and I got the permission denied error. \r\n```\r\nmkdir: cannot create directory ‘/data’: Permission denied \r\n```\r\... | 02fd66069c34693876ce85f7d4a915b4528a0f07 | {
"head_commit": "82e94ab872e3af3b81d61e0f295024f3665a6903",
"head_commit_message": "Support file_mounts destination paths that require root access.\n\nFixes #39.",
"patch_to_review": "diff --git a/prototype/config/aws-ray.yml.j2 b/prototype/config/aws-ray.yml.j2\nindex fb81c684e00..42a9b9eb120 100644\n--- a/prot... | [
{
"diff_hunk": "@@ -104,6 +121,25 @@ def write_cluster_config(run_id: RunId,\n f.write(codegen)\n setup_sh_path = f.name\n \n+ # File mounts handling:\n+ # (1) in 'file_mounts' sections, add <prefix> to all target paths.\n+ # (2) then, create symlinks from '/root/file' to '<prefix... | 3c9c54c87dad75d41ed20a7eddc87eccae769480 | diff --git a/prototype/config/aws-ray.yml.j2 b/prototype/config/aws-ray.yml.j2
index aae1a8b8bb3..e1052843e76 100644
--- a/prototype/config/aws-ray.yml.j2
+++ b/prototype/config/aws-ray.yml.j2
@@ -65,6 +65,13 @@ file_mounts: {
{%- endfor %}
}
+{%- if initialization_commands is not none %}
+initialization_commands:
... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
espnet__espnet-1840@5e00a63 | espnet/espnet | Python | 1,840 | Add test for torch>1.1 | - Add test for torch>1.1
- Now the tested items are duplicated, so I changed the range
- https://github.com/espnet/espnet/blob/34b21ca720d698de72d20b1d601ab4671d7badac/README.md
- Travis-ci: only builds the documentation and codecov without testing with python=3.8.
- Circleci: Testing of different OS wi... | 2020-04-15T13:40:58Z | transformer bug in Pytorch 1.2.0
espnet/espnet/nets/pytorch_backend/transformer/mask.py
`is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')
datatype = torch.bool if is_torch_1_2_plus else torch.uint8
def subsequent_mask(size, device="cpu", dtype=datatype):
"""Create mask for subse... | I thought that transformer is working on any pytorch versions.
Does it only happen in pytorch 1.2.0?
> I thought that transformer is working on any pytorch versions.
> Does it only happen in pytorch 1.2.0?
Yes，I test with 1.0.0 1.1.0 1.2.0 1.3.0 . It only happen in pytorch 1.2.0. Before 1.2.0 ,pytorch Tensor doe... | [
{
"body": "espnet/espnet/nets/pytorch_backend/transformer/mask.py \r\n`is_torch_1_2_plus = LooseVersion(torch.__version__) >= LooseVersion('1.2.0')\r\ndatatype = torch.bool if is_torch_1_2_plus else torch.uint8\r\n\r\n\r\ndef subsequent_mask(size, device=\"cpu\", dtype=datatype):\r\n \"\"\"Create mask for su... | 8586d22fc15aa09190d86ed1284005e3e6602cd2 | {
"head_commit": "5e00a638f83682d20764eef1d5c81d798a0ec106",
"head_commit_message": "add ci-test for pytorch>=1.2",
"patch_to_review": "diff --git a/.circleci/config.yml b/.circleci/config.yml\nindex 15b9b9e9c6d..9bd3d43194e 100644\n--- a/.circleci/config.yml\n+++ b/.circleci/config.yml\n@@ -18,13 +18,14 @@ jobs:... | [
{
"diff_hunk": "@@ -66,13 +68,14 @@ jobs:\n docker:\n - image: circleci/buildpack-deps:16.04\n environment:\n- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece installation error\n- ESPNET_PYTHON_VERSION: 3.7.3\n+ ESPNET_PYTHON_VERSION: 3.6\n TH_VERSIO... | 34b21ca720d698de72d20b1d601ab4671d7badac | diff --git a/.circleci/config.yml b/.circleci/config.yml
index 15b9b9e9c6d..249e2490ae8 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -18,13 +18,14 @@ jobs:
docker:
- image: circleci/buildpack-deps:18.04
environment:
- # NOTE(kan-bayashi): Use 3.7.3 to avoid sentencepiece... | {
"difficulty": "medium",
"estimated_review_effort": 3,
"problem_domain": "Bug Fixes"
} |
espnet__espnet-1779@ff5feec | espnet/espnet | Python | 1,779 | fix #1751 | register ctc loss_fn as float function
@ShigekiKarita | 2020-04-07T03:59:17Z | built in ctc conflict with apex
```
# asr_train.py --config conf/tuning/train_pytorch_transformer_medium.yaml --train-dtype O1 --ctc_type builtin --ngpu 4 --backend pytorch --outdir exp/train_pytorch_129.d_resume/results --tensorboard-dir tensorboard/train_pytorch_129.d_resume --debugmode 1 --dict data/lang_char/train... | Which version of pytorch are you using?
I'm expecting CTC loss must be normal precision to avoid over/underflow and it would be intended normal behavior.
Also, was it OK for warpctc?
1.0.1 pytorch
It is ok with warpctc.
So I think one of ctc function should be registed as float function in amp module, How do you th... | [
{
"body": "```\r\n# asr_train.py --config conf/tuning/train_pytorch_transformer_medium.yaml --train-dtype O1 --ctc_type builtin --ngpu 4 --backend pytorch --outdir exp/train_pytorch_129.d_resume/results --tensorboard-dir tensorboard/train_pytorch_129.d_resume --debugmode 1 --dict data/lang_char/train_unigram500... | ae0850f3c28de6b4dec8e667b56b3a86cb80bcf9 | {
"head_commit": "ff5feecfb09cec808b583dcbe9e2efad91b1fca6",
"head_commit_message": "fix #1751\n\nregister ctc loss_fn as float function",
"patch_to_review": "diff --git a/espnet/asr/pytorch_backend/asr.py b/espnet/asr/pytorch_backend/asr.py\nindex 0fd5e8e5447..c4b2e787ab0 100644\n--- a/espnet/asr/pytorch_backend... | [
{
"diff_hunk": "@@ -447,6 +447,12 @@ def train(args):\n else:\n model, optimizer = amp.initialize(model, optimizer, opt_level=args.train_dtype)\n use_apex = True\n+\n+ if args.ctc_type == \"builtin\":\n+ from espnet.nets.pytorch_backend.ctc import CTC\n+ ... | b19dd2cbfe82116f50f3986bf90c41db3c2a0f96 | diff --git a/espnet/asr/pytorch_backend/asr.py b/espnet/asr/pytorch_backend/asr.py
index 0fd5e8e5447..0cf4914f110 100644
--- a/espnet/asr/pytorch_backend/asr.py
+++ b/espnet/asr/pytorch_backend/asr.py
@@ -447,6 +447,11 @@ def train(args):
else:
model, optimizer = amp.initialize(model, optimizer, o... | {
"difficulty": "low",
"estimated_review_effort": 2,
"problem_domain": "Bug Fixes"
} |
celery__celery-6981@f7e47cc | celery/celery | Python | 6,981 | Update deprecated task module removal in 5.0 documentation | ## Documentation update for removed functionality
Add extra information in documentation and fix outdated documentation concerning the removal of celery.task
Fixes #6558 | 2021-10-04T10:38:37Z | no module named celery.task
from celery import shared_task
from .models import Test, Prices
from celery.decorators import periodic_task
from celery.task.schedules import crontab
import requests
@shared_task
def create_price_items(name):
Test.objects.create(name=name)
@periodic_task(run_every=(cro... | For anyone wondering: it seems the module was removed in 5.0.0rc2 [in this commit](https://github.com/celery/celery/commit/757101358222dde4a72a2d1ce1edb5411591ab96) and it has been advised to use `celery.shared_task` [in the docs since 4.0.0](https://docs.celeryproject.org/en/4.0/userguide/tasks.html#basics). I couldn... | [
{
"body": "from celery import shared_task\r\nfrom .models import Test, Prices\r\n\r\nfrom celery.decorators import periodic_task\r\nfrom celery.task.schedules import crontab\r\nimport requests \r\n@shared_task\r\ndef create_price_items(name):\r\n Test.objects.create(name=name)\r\n \r\n\r\n@periodic_task(r... | cba7d62475ae980c19dbd83ef52529d804e3c9bf | {
"head_commit": "f7e47cc815507933e04686bb1d004ecf16f2fa66",
"head_commit_message": "Update whatsnew-5.1.rst",
"patch_to_review": "diff --git a/docs/history/whatsnew-5.0.rst b/docs/history/whatsnew-5.0.rst\nindex d2e2df90e62..4667eb43216 100644\n--- a/docs/history/whatsnew-5.0.rst\n+++ b/docs/history/whatsnew-5.0... | [
{
"diff_hunk": "@@ -290,6 +290,10 @@ you should import `kombu.utils.encoding` instead.\n If you were using the `celery.task` module before, you should import directly\n from the `celery` module instead.\n \n+If you were using the `celery.task` decorator you should use \n+`celery.shared_task` instead.",
"lin... | c305f75a2bb1726fe9f8a3e245bf893475cb9a74 | diff --git a/docs/history/whatsnew-5.0.rst b/docs/history/whatsnew-5.0.rst
index d2e2df90e62..bb27b59cf32 100644
--- a/docs/history/whatsnew-5.0.rst
+++ b/docs/history/whatsnew-5.0.rst
@@ -262,6 +262,12 @@ you should import `kombu.utils.encoding` instead.
If you were using the `celery.task` module before, you should i... | {
"difficulty": "low",
"estimated_review_effort": 1,
"problem_domain": "Bug Fixes"
} |
espnet__espnet-1083@44b7341 | espnet/espnet | Python | 1,083 | Fix multi gpu LM issues and add hdf5 LM dataset dump | This PR aims to fix #1075 . I tested this by AN4 and TEDLIUM3.
I found @kan-bayashi's comment was correct. The memory leak appeared when single GPU performs the frame reduction of loss values from multi GPUs. So I added the `ReduceFramewiseLoss` module to do it in multi GPUs.
In addition, I added HDF5 dump suppo... | 2019-08-14T06:43:22Z | multi gpu lm training throws CUDA out of memory exception
There was an out of memory exception thrown when I use lm.yaml and lm_large.yaml in librispeech egs with multi gpu=4.
```
Exception in main training loop: CUDA out of memory. Tried to allocate 19.62 MiB (GPU 2; 22.38 GiB total capacity; 21.01 GiB already alloc... | ensure your sentence length not too long, may be small than 128/256
There is a same problem is egs tedlium3 too.And there was no problem in single gpu before.So Maybe It's a new bug in multi gpu recipe.
Could you check whether it works with small batchsize?
In multi-gpu case, we automatically increase `batchsize = bat... | [
{
"body": "There was an out of memory exception thrown when I use lm.yaml and lm_large.yaml in librispeech egs with multi gpu=4.\r\n```\r\nException in main training loop: CUDA out of memory. Tried to allocate 19.62 MiB (GPU 2; 22.38 GiB total capacity; 21.01 GiB already allocated; 10.06 MiB free; 634.29 MiB ca... | e663da30a7f4f45c0cea5c6ee5c2c7d7a7ed647a | {
"head_commit": "44b7341c0318e0f682376194e842439f9d2799cf",
"head_commit_message": "minor update",
"patch_to_review": "diff --git a/egs/tedlium3/asr1/run.sh b/egs/tedlium3/asr1/run.sh\nindex 9a94eb024ed..26174754b4e 100755\n--- a/egs/tedlium3/asr1/run.sh\n+++ b/egs/tedlium3/asr1/run.sh\n@@ -180,7 +180,8 @@ if [ ... | [
{
"diff_hunk": "@@ -85,6 +85,8 @@ def get_parser():\n help='dropout probability')\n parser.add_argument('--maxlen', type=int, default=40,\n help='Batch size is reduced if the input sequence > ML')\n+ parser.add_argument('--dump-dataset', type=str, default=N... | e5b4b239efca811d461c34f92a9818655a4b2acc | diff --git a/egs/mini_an4/asr1/run.sh b/egs/mini_an4/asr1/run.sh
index de162a643f2..b322cc64787 100755
--- a/egs/mini_an4/asr1/run.sh
+++ b/egs/mini_an4/asr1/run.sh
@@ -199,7 +199,8 @@ if [ ${stage} -le 3 ] && [ ${stop_stage} -ge 3 ]; then
--valid-label ${lmdatadir}/valid.txt \
--test-label ${lmdatadi... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Performance Optimizations"
} |
celery__celery-6917@a17594a | celery/celery | Python | 6,917 | Terminate job implementation for eventlet concurrency backend | # Terminate job implementation for eventlet concurrency backend
## Description
Current implementation of **TaskPool** which is based on **eventlet** library does not support terminating jobs.
Revoking with `terminate=True` or terminating task raises `NotImplementedError: <class 'celery.concurrency.eventlet.Tas... | 2021-08-17T19:39:10Z | I can‘t stop a task by its task_id
[2018-12-02 23:53:58,955: INFO/MainProcess] Received task: tasks.add[bb1fe102-c1f9-4361-9370-1129900c0d52]
[2018-12-02 23:54:02,479: INFO/MainProcess] Terminating bb1fe102-c1f9-4361-9370-1129900c0d52 (Signals.SIGTERM)
[2018-12-02 23:54:02,490: ERROR/MainProcess] pidbox command error... | Even though I use different concurrency (prefork, using Redis as broker), I've seen the same problem - sometimes worker can't kill some tasks...
I used the `signal='SIGKILL'` param and got `Task handler raised error: Terminated(9,)`.
Does that mean the task termination succeed?
```python
celery_app.control.revo... | [
{
"body": "[2018-12-02 23:53:58,955: INFO/MainProcess] Received task: tasks.add[bb1fe102-c1f9-4361-9370-1129900c0d52]\r\n[2018-12-02 23:54:02,479: INFO/MainProcess] Terminating bb1fe102-c1f9-4361-9370-1129900c0d52 (Signals.SIGTERM)\r\n[2018-12-02 23:54:02,490: ERROR/MainProcess] pidbox command error: NotImpleme... | ad994719bafe6747af6cf8251efb0925284a9260 | {
"head_commit": "a17594a183f874a5fdfc9449ff544f7ce795540a",
"head_commit_message": "[pre-commit.ci] auto fixes from pre-commit.com hooks\n\nfor more information, see https://pre-commit.ci",
"patch_to_review": "diff --git a/celery/concurrency/eventlet.py b/celery/concurrency/eventlet.py\nindex c6bb3415f69..90c39e... | [
{
"diff_hunk": "@@ -107,8 +109,9 @@ def __init__(self, *args, **kwargs):\n \n def on_start(self):\n self._pool = self.Pool(self.limit)\n+ self._pool_map = dict()",
"line": null,
"original_line": 112,
"original_start_line": null,
"path": "celery/concurrency/eventlet.py",
"s... | 88c5a2bae5d98ffa24c56f3e4664e99e02a5f2ea | diff --git a/celery/concurrency/eventlet.py b/celery/concurrency/eventlet.py
index c6bb3415f69..f9c9da7f994 100644
--- a/celery/concurrency/eventlet.py
+++ b/celery/concurrency/eventlet.py
@@ -2,6 +2,7 @@
import sys
from time import monotonic
+from greenlet import GreenletExit
from kombu.asynchronous import timer ... | {
"difficulty": "medium",
"estimated_review_effort": 4,
"problem_domain": "Bug Fixes"
} |
Subsets and Splits
Review Test Instances
Retrieves basic metadata about code review instances but doesn't provide any analytical insights or patterns beyond raw data access.